aboutsummaryrefslogtreecommitdiffstats
path: root/actionview/CHANGELOG.md
Commit message (Collapse)AuthorAgeFilesLines
...
* Merge pull request #20046 from yoongkang/ladidaRafael Mendonça França2016-01-161-0/+6
|\ | | | | | | Use ActiveSupport::SafeBuffer when flushing content_for
| * Use ActiveSupport::SafeBuffer when flushing content_forYoong Kang Lim2015-05-251-0/+6
| | | | | | | | | | | | | | | | | | | | | | Previously, when content_for is flushed, the content was replaced directly by a new value in ActionView::OutputFlow#set. The problem is this new value passed to the method may not be an instance of ActiveSupport::SafeBuffer. This change forces the value to be set to a new instance of ActiveSupport::SafeBuffer.
* | docs, formatting pass over changelogs. [ci skip]Yves Senn2016-01-131-1/+1
| |
* | Fix collection_radio_buttons' hidden_field name and make it appear before ↵Santiago Pastorino2015-12-311-0/+8
| | | | | | | | | | | | the radios Fixes #22773
* | TestController#parameters returns AC::ParametersJustin Coyne2015-12-291-0/+5
| | | | | | | | | | | | | | Fixes #22827 ActionView::TestCase::TestController#parameters should return an instance of ActionController::Parameters rather than a hash. This enables helper methods to use the correct interface.
* | Merge pull request #22778 from y-yagi/fix_submit_tag_with_symbol_valueYves Senn2015-12-241-0/+5
| | | | | | | | fix TypeError when using submit_tag with Symbol value
* | release notes, extract notable changes from Action View CHANGELOG.Yves Senn2015-12-221-4/+4
| | | | | | | | [ci skip]
* | No more no changes entries in the CHANGELOGsGenadi Samokovarov2015-12-211-3/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | During the `5.0.0.beta1` release, the CHANGELOGs got an entry like the following: ``` * No changes. ``` It is kinda confusing as there are indeed changes after it. Not a biggie, just a small pass over the CHANGELOGs. [ci skip]
* | fix typo in config value [ci skip]yuuji.yaginuma2015-12-191-1/+1
| |
* | Add CHANGELOG headers for Rails 5.0.0.beta1eileencodes2015-12-181-0/+5
| |
* | debug_missing_translation configuration added to action_viewSameer Rahmani2015-12-181-0/+9
| | | | | | | | | | | | | | | | | | `I18n.translate` helper will wrap the missing translation keys in a <span> tag only if `debug_missing_translation` configuration has a truthy value. Default value is `true`. For example in `application.rb`: # in order to turn off missing key wrapping config.action_view.debug_missing_translation = false
* | Merge pull request #21914 from zachalewel/zachalewel-patch-1Matthew Draper2015-12-181-8/+8
|\ \ | | | | | | | | | Update CHANGELOG.md for readability
| * | Update CHANGELOG.mdZach Alewel2015-10-081-1/+1
| | |
| * | Update CHANGELOG.md for readabilityZach Alewel2015-10-081-1/+1
| | |
* | | Merge pull request #22280 from yui-knk/fix_chagnelog_actionviewRichard Schneeman2015-11-121-1/+1
|\ \ \ | | | | | | | | [ci skip] Fix CHANGELOG.md format from list to italic.
| * | | [ci skip] Fix CHANGELOG.md format from list to italic.yui-knk2015-11-131-1/+1
| | | |
* | | | Respect value of `:object` if `:object` is false when renderingyui-knk2015-11-131-0/+6
|/ / / | | | | | | | | | | | | This commit fixes the bug convering `false` to `locals[as]` when `options[:object]` is `false` (close #22260).
* | | Fix week_field returning invalid valueChristoph2015-11-101-0/+5
| | | | | | | | | | | | | | | | | | | | | According to the W3 spec[1] the value should use a 1-based index and not a 0-based index for the week number. [1]: http://www.w3.org/TR/html-markup/datatypes.html#form.data.week
* | | fix method name typo [ci skip]yuuji.yaginuma2015-11-091-1/+1
| | |
* | | Allow `host` option in javscript and css helpersGrzegorz Witek2015-11-081-0/+4
| | | | | | | | | | | | | | | Now both `javascript_include_tag` and `stylesheet_tag` can accept `host` option to provide custom host for the asset
* | | Don’t allow arbitrary data in back urlsDamien Burke2015-11-031-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `link_to :back` creates a link to whatever was passed in via the referer header. If an attacker can alter the referer header, that would create a cross-site scripting vulnerability on every page that uses `link_to :back` This commit restricts the back URL to valid non-javascript URLs. https://github.com/rails/rails/issues/14444
* | | Fix style issues with #16252Sean Griffin2015-10-291-4/+4
| | |
* | | making selected value to accept Hash like the default option. E.g. selected: ↵Lecky Lao2015-10-291-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | {day: params[:day].to_i, month: params[:month].to_id} Adds in test test_date_select_with_selected_in_hash and change log fixes typo in CHANGELOG
* | | Collection check boxes propagates input's id to the label's for attribute.Vasiliy Ermolovich2015-10-201-0/+5
|/ /
* | Fix ActionView changelog documentation [ci skip]Abhishek Jain2015-10-061-1/+1
| |
* | Add a hidden field on the collection_radio_buttonsMauro George2015-09-241-0/+5
| | | | | | | | | | This will avoid a error be raised when the only input on the form is the `collection_radio_buttons`.
* | `url_for` does not modify polymorphic optionsBernerd Schaefer2015-09-041-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The `url_for` methods in `actionpack` and `actionview` now make a copy of the provided options before generating polymorphic paths or URLs. The bug in the previous behavior is most noticeable in a case like: url_options = [:new, :post, param: 'value'] if current_page?(url_options) css_class = "active" end link_to "New Post", url_options, class: css_class
* | - Extracted `DELIMITED_REGEX` to `delimited_regex` method and made use of ↵Vipul A M2015-08-281-0/+10
| | | | | | | | | | | | | | | | | | | | user passed `options[:delimited_regex]` if available. Changed `DELIMITED_REGEX` to `DEFAULT)DELIMITED_REGEX` to signify what it means. - Added tests for number to delimited and number to currency in both actionview and activesupport. Changes Changes
* | Make disable_with default in submit_tagJustin Schiff2015-08-111-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Prevents double submission by making disable_with the default. Default disable_with option will only be applied if user has not specified her/his own disable_with option, whether that is in the `data-disable-with` string form or the `:data => { :disable_with => "Saving..." }` hash form. disable_with will default to the value attribute. A configuration option was added to opt out of this functionality if the user so desires. `config.action_view.automatically_disable_submit_tag = false`
* | Sometimes you need a specific break sequence while using word wrap and as ↵Mauricio Gomez Aguinaga2015-08-111-0/+4
| | | | | | | | | | | | | | | | | | | | today the only option we have is "\n" and is hardcoded. With this change you will be able to specify any break sequence ("\r\n" for example) as an option. adding proper documentation for break_sequence in ActionView::Helpers::TextHelper.word_wrap adding some more documentation for word_wrap custom break sequence and making sure we use new hash syntax
* | Add wildcard template dependencies.Kasper Timm Hansen2015-07-261-0/+18
| |
* | Support explicit defintion of resouce name for collection caching.Dov Murik2015-07-071-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | If a template includes `# Template Collection: ...` anywhere in its source, that name will be used as the cache name for the partial that is rendered for the collection. This allows users to enable collection caching even if the template doesn't start with `<% cache ... do %>`. Moreover, the `# Template Collection: ...` notation is recognized in all template types (and template types other than ERB can define a resource_cache_call_pattern method to allow the `cache ... do` pattern to be recognized too).
* | Merge pull request #20669 from akolomiychuk/image-pathYves Senn2015-06-291-0/+4
|\ \ | | | | | | | | | Passing nil to image_tag
* | | Fix cache issue when different partials use the same collectionRoque Pinel2015-06-281-0/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | Adds the `virtual_path` option to `cache_fragment_name` so it can be provided when needed. That allows `cache_collection_render` to get the appropriate cache key with the digest generated based on the template and prevent collision with other templates that cache the same collection.
* | | Improve detection of partial templates eligible for collection caching.Dov Murik2015-06-221-0/+5
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | The regular expression which was used to detect partial templates that begin with a `<% cache ... do %>` call missed some cases. This commits attempts to improve the detection for some cases such as multi-line comments at the beginning of the template. The different templates are listed in two new unit test methods. Note that specially crafted Ruby code can still evade such `cache`-call detection: for example, a user might have its own method which itself calls the Rails `cache` helper. In such a case, the template's code doesn't start with a literal `cache` string and therefore will not be eligible for collection caching.
* / Raise an ArgumentError when `include_blank` is false for a required field inGrey Baker2015-06-081-0/+5
|/ | | | | | | | | | `Tags::Base#select_content_tag`. Previously, passing a falsey value to `include_blank` would be ignored if the field was required, and a blank line would still be inserted. The following will now raise instead of quietly failing: `select("post", "category", %w(a required field), { include_blank: false }, required: 'required')`
* Pass over CHANGELOGS [ci skip]Prathamesh Sonpatki2015-05-161-2/+3
|
* Do not put partial name to local_assigns when rendering without an objectHenrik Nygren2015-05-141-0/+4
| | | | | | | | When one rendered a partial template without specifying an object or a collection (e.g. <%= render partial: 'partial_name' %>), Rails would make an object called :partial_name available in local_assigns. I don't think this was the intended behavior, since no local variable called 'partial_name' gets defined in the view.
* Remove :rescue_format option for translate helper since it's no longer ↵Bernard Potocki2015-05-041-0/+5
| | | | supported by I18n.
* Handle raise flag in translate when both main and default translation is ↵Bernard Potocki2015-05-041-0/+7
| | | | missing. Fixes #19967
* Revert "Merge pull request #19844 from ↵Yves Senn2015-05-011-4/+0
| | | | | | | | | | | | | | | | | | | | | stevenspiel/link_to_if_block_helper_addition" This reverts commit d459b001b43d25053e7982e96eb8383538a6e358, reversing changes made to 4d4950fae9e2a6970b5f1793aadc56a0b44e28a3. :sweat: The block is not supposed to be passed to `link_to`. It's used for a customized behavior of the `condtion = false` case. The docs illustrate that like so: ``` <%= link_to_if(@current_user.nil?, "Login", { controller: "sessions", action: "new" }) do link_to(@current_user.login, { controller: "accounts", action: "show", id: @current_user }) end %> ```
* Merge pull request #19844 from stevenspiel/link_to_if_block_helper_additionYves Senn2015-05-011-0/+4
|\ | | | | | | Update url_helper.rb
* | pass over CHANGELOGs. [ci skip]Yves Senn2015-04-221-2/+1
|/
* Override default form builder for a controllerKevin McPhillips2015-04-131-0/+5
|
* Accept lambda as child_index option in #fields_for methodKarol Galanciak2015-04-051-0/+4
|
* Merge pull request #19649 from aprescott/allow-array-defaultsMatthew Draper2015-04-051-0/+6
|\ | | | | | | Allow an array to be a default translation value.
| * Allow an array to be a default translation value.Adam Prescott2015-04-041-0/+8
|/ | | | | | | | | | | 4.2.1 introduced a change to the way `translate`/`t` works with an option of `default: [[]]`. In 4.2.0, this would give a default value of `[]`, but in 4.2.1, it leads to a missing translation. `default: [[]]` is again allowed for cases where a default of `[]` is needed. This addresses GitHub issue 19640.
* Merge pull request #19421 from jcoyne/translate_defaults_with_nilRafael Mendonça França2015-03-201-0/+8
| | | | Strip nils out of default translations. Fixes #19419
* put the changelog entry in the right file :sweat: [ci skip]Yves Senn2015-03-061-0/+7
|
* Fix regression when passing a value different of String.Ulisses Almeida2015-02-261-0/+5
| | | | | | | | | | | | | | | | | The previous version of rails(4.2.0) you can pass objects to the default option of translation helper. For example: ```ruby t('foo', default: 1) ``` But on rails 4.2.1 version this kind of use stopped to work, because started only to accept String types. Now with this fix we can use orther value types on this helper again.