aboutsummaryrefslogtreecommitdiffstats
path: root/actiontext
Commit message (Collapse)AuthorAgeFilesLines
* Output junit format test reportFumiaki MATSUSHIMA2019-04-041-0/+2
|
* Avoid creating ActionText::RichText records unnecessarilyGeorge Claghorn2019-03-232-1/+9
| | | | Assigning a has_one association for a persisted record saves the change immediately, so attempting to read a rich-text attribute on a persisted record without a corresponding ActionText::RichText would eagerly create one. Avoid assigning the rich text association to fix.
* Fix updating rich text via nested attributesGeorge Claghorn2019-03-176-7/+40
| | | Closes #35159.
* Merge tag 'v6.0.0.beta3'eileencodes2019-03-133-2/+7
|\ | | | | | | v6.0.0.beta3 release
| * Prep releaseeileencodes2019-03-113-2/+7
| | | | | | | | | | | | | | * Update RAILS_VERSION * Bundle * rake update_versions * rake changelog:header
* | Merge pull request #35485 from excid3/default-attachable-trix-partialJavan Makhmali2019-03-115-2/+31
|\ \ | | | | | | Adds default trix content attachmment partial path
| * | Adds default trix partialChris Oliver2019-03-055-2/+31
| |/
* | Merge pull request #35529 from ↵Ryuta Kamizono2019-03-092-2/+2
|\ \ | | | | | | | | | | | | abhaynikam/35492-follow-up-to-updates-links-to-https Updated links from http to https in guides, docs, etc
| * | Updated links from http to https in guides, docs, etcAbhay Nikam2019-03-092-2/+2
| | |
* | | Upgrade webpack-dev-server version in test appsSharang Dashputre2019-03-092-435/+229
| | |
* | | Use the latest stable release of webpackerSharang Dashputre2019-03-092-2000/+3727
|/ /
* / Explicitly require rails-html-sanitizer gem in ActionText helpersChris LaRose2019-03-061-0/+2
|/ | | | | | | | | | | If the [`action_text.helper` initializer][0] runs after `ActionController::Base` has been loaded, but before the `rails-html-sanitizer` gem has been `require`d, then the reference to the constant `Rails::Html` in the body of the `ActionText::ContentHelper` module raises an `uninitialized constant` exception. [0]: https://github.com/rails/rails/blob/21703382393c87212c27c988420ee5c133c1aa9f/actiontext/lib/action_text/engine.rb#L31-L35
* Preparing for 6.0.0.beta2 releaseRafael Mendonça França2019-02-253-2/+7
|
* Disable available locale checks in Action Test testyuuji.yaginuma2019-02-241-0/+3
| | | | | | | | | Without this change, `store_translations` silently fails when available locales already initialized. Ref: https://travis-ci.org/rails/rails/jobs/497615616#L6846 https://travis-ci.org/rails/rails/jobs/497605027#L6856
* Allows rich_text_area_tag to add I18n translated placeholder text if ↵Abhay Nikam2019-02-222-2/+52
| | | | placeholder option set to true
* SQLite3: Implement `add_foreign_key` and `remove_foreign_key`Ryuta Kamizono2019-02-111-0/+1
| | | | | | | | | | | | I implemented Foreign key create in `create_table` for SQLite3 at #24743. This follows #24743 to implement `add_foreign_key` and `remove_foreign_key`. Unfortunately SQLite3 has one limitation that `PRAGMA foreign_key_list(table-name)` doesn't have constraint name. So we couldn't implement find/remove foreign key by name for now. Fixes #35207. Closes #31343.
* Merge pull request #35071 from kamipo/text_without_limitRyuta Kamizono2019-01-293-5/+4
|\ | | | | MySQL: Support `:size` option to change text and blob size
| * Allow changing text and blob size without giving the `limit` optionRyuta Kamizono2019-01-293-5/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | In MySQL, the text column size is 65,535 bytes by default (1 GiB in PostgreSQL). It is sometimes too short when people want to use a text column, so they sometimes change the text size to mediumtext (16 MiB) or longtext (4 GiB) by giving the `limit` option. Unlike MySQL, PostgreSQL doesn't allow the `limit` option for a text column (raises ERROR: type modifier is not allowed for type "text"). So `limit: 4294967295` (longtext) couldn't be used in Action Text. I've allowed changing text and blob size without giving the `limit` option, it prevents that migration failure on PostgreSQL.
| * Revert "Apply `t.timestamps` changes in Action Text and Action Mailbox"Ryuta Kamizono2019-01-292-1/+2
| | | | | | | | This reverts commit 30f666f87ab873258b797b39f29cf852f7621bea.
| * Apply `t.timestamps` changes in Action Text and Action MailboxRyuta Kamizono2019-01-292-2/+1
| | | | | | | | Follow up #34956.
* | Add line break to Action Text installation outputsVinicius Brasil2019-01-271-1/+1
|/ | | | | | | | | | | | | | The Action Text installations appends `require("trix")` to the application.js file. The problem is that there isn't a line break in the beginning of the installation output, leading to syntax errors, e.g.: ``` import './application.scss'require("trix") ``` This commit moves the line break from the end to the beginning of the output, fixing it to: ``` import './application.scss' require("trix") ```
* Merge pull request #34970 from kamipo/timestamps_with_precision_by_defaultRyuta Kamizono2019-01-262-8/+7
|\ | | | | Make `t.timestamps` with precision by default.
| * Make `t.timestamps` with precision by defaultRyuta Kamizono2019-01-262-8/+7
| |
* | Fix error saving Action Text content containing non-blob attachablesJavan Makhmali2019-01-252-1/+10
|/ | | | | | | | | | Failing test before the ActionText::RichText change: ``` Error: ActionText::ModelTest#test_embed_extraction_only_extracts_file_attachments: ArgumentError: Could not find or build blob: expected attachable, got #<ActionText::Attachables::RemoteImage:0x00007fb0259fef70 @url="http://example.com/cat.jpg", @content_type="image", @width=nil, @height=nil> ```
* Prefer ImageProcessing's resize_to_limit macro over resize_to_fitGeorge Claghorn2019-01-241-1/+1
| | | | Don't upsize images smaller than the specified dimensions.
* Fix document formatting on Action Text docs [ci skip]colorbox2019-01-242-4/+4
| | | | Use `+` instead of backquote.
* Changed webserver to web server.alkesh262019-01-221-1/+1
|
* Preparing for 6.0.0.beta1 releaseRafael Mendonça França2019-01-183-2/+4
|
* Merge pull request #34956 from kamipo/actionmailbox_datetime_precisionRyuta Kamizono2019-01-181-5/+5
|\ | | | | Allow using Action Mailbox on MySQL 5.5
| * Allow using Action Mailbox on MySQL 5.5Ryuta Kamizono2019-01-181-5/+5
| | | | | | | | | | | | | | | | | | | | Active Record still support MySQL 5.5 which doesn't support datetime with precision. https://github.com/rails/rails/blob/9e34df00039d63b5672315419e76f06f80ef3dc4/activerecord/lib/active_record/connection_adapters/abstract_mysql_adapter.rb#L99-L101 So we should check `supports_datetime_with_precision?` on the connection.
* | Action Text: bundle package.json in built gem.Kasper Timm Hansen2019-01-181-1/+1
|/ | | | | | | | | | | | | | | | | | After 866da19fd9fc12d001ab99ac87890ea1cebb2cd9 we now use package.json to install Action Text's JS dependencies (see JS_PACKAGE_PATH). But when the gem pacakge for Action Text is built, package.json was not included so running `rails action_text:install` in a Rails app would fail with: ``` rails action_text:install rails aborted! Errno::ENOENT: No such file or directory @ rb_sysopen - xxx/gems/actiontext-6.0.0.alpha/lib/templates/../../package.json ./bin/rails:4:in `<main>' Tasks: TOP => app:template (See full trace by running task with --trace) ```
* Tidy up action_text:install taskJavan Makhmali2019-01-171-9/+20
| | | | Automate installing the appropriate packages with yarn and appending them to the default application.js pack.
* Make trix a peer dependency of actiontext since it’s not used directlyJavan Makhmali2019-01-172-2/+3
|
* Move all npm packages to @rails scopeJavan Makhmali2019-01-105-20/+8
| | | | Fixes #33083
* Enable `Lint/DeprecatedClassMethods` cop to avoid using deprecated methodsyuuji.yaginuma2019-01-091-1/+1
|
* Merge pull request #34898 from ksolo/update-raketasks-for-new-frameworksAaron Patterson2019-01-081-0/+2
|\ | | | | Add new frameworks to `tasks/release.rb`
| * add new frameworks to tasks/release.rbKevin Solorio2019-01-081-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | The Frameworks collection was missing actiontext and actionmailbox, this would mean they are skipped when running any tasks that iterated through this collection changes include Breaking up frameworks declaration into multiple lines and put them in order. This should make adding to the list easier and if you need to scan it, they will be in order you would expect Add `package` task to both actiontext and actionmailbox
* | Add load hook for ActionText::RichTextGeorge Claghorn2019-01-071-0/+2
|/
* Reset ActionText::Content.renderer before and after each requestGeorge Claghorn2019-01-051-3/+6
|
* Merge pull request #34878 from bogdanvlviv/action_text-guides-docsGeorge Claghorn2019-01-051-60/+2
|\ | | | | Add Action Text to guides [ci skip]
| * Add Action Text to guides [ci skip]bogdanvlviv2019-01-051-60/+2
| | | | | | | | | | | | | | | | - Move some actiontext/README.md content to Action Text Overview guide - I added WIP label to that guide since we definitely want to complement it. - Add Action Text to Major Features of Rails 6.0 Similar approach was used in #34812
* | Merge pull request #34875 from bogdanvlviv/test-actiontext-on-rails-6.0George Claghorn2019-01-055-7/+4
|\ \ | | | | | | Test actiontext on Rails 6.0
| * | Test actiontext on Rails 6.0bogdanvlviv2019-01-055-7/+4
| |/ | | | | | | | | | | | | | | | | | | | | | | - config.load_defaults 6.0 in the dummy app and fix the test since by default rails 6.0 configured does not generate "utf8" hidden input, see #32125 - Use `ActiveRecord::Migration[6.0]` in the dummy app since actiontext will be since Rails 6.0 - Fix `CreateActiveStorageTables` migration in the dummy app. Add `t.foreign_key :active_storage_blobs, column: :blob_id` It was added in 2ae3a29508e. - `rails/actiontext$ yarn install`
* | Merge pull request #34876 from ↵George Claghorn2019-01-051-1/+0
|\ \ | | | | | | | | | | | | bogdanvlviv/remove-needless-comment-actiontext.gemspec Remove comment from `actiontext/actiontext.gemspec`
| * | Remove comment from `actiontext/actiontext.gemspec`bogdanvlviv2019-01-051-1/+0
| |/ | | | | | | | | | | | | | | This comment was autogenerated, see `railties/lib/rails/generators/rails/plugin/templates/%name%.gemspec.tt` Since actiontext is well described in this file, I think we shouldn't keep this comment. Note that this commit is more like cosmetic change, so it is OK if we don't merge this.
* / Fix API docs of `ActionText::RichText` [ci skip]bogdanvlviv2019-01-051-4/+4
|/ | | | | | | This text should appear on the page https://api.rubyonrails.org/v6.0/classes/ActionText/RichText.html Related to 86517942e469193e8624d5078d718785552c1270
* Generate Action Text's API docsGeorge Claghorn2019-01-041-13/+15
|
* Import Action TextGeorge Claghorn2019-01-04137-0/+9430
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-09 04:38:55 +0000