| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
In most cases it works now without explicit require because it's accidentally required through
active_support/core_ext/date_and_time/calculations.rb where we still call `try`,
but that would stop working if we changed the Calculations implementation and remove the require call there.
|
|
|
|
|
|
|
|
|
| |
Adds an attachment button to the Trix toolbar that improves overall file upload usability, especially on mobile devices where files can't be dragged / dropped.
References:
- https://github.com/basecamp/trix/releases/tag/1.2.0
- https://github.com/basecamp/trix/pull/619
- https://github.com/basecamp/trix/issues/582
|
| |
|
| |
|
|
|
|
|
|
| |
Fixes that file attachments without captions would not be represented in plain text generated from rich-text content, causing ActionText::RichText#present? to return false.
Closes #36607.
|
|
|
|
|
| |
Especially, somehow `CHANGELOG.md` in actiontext and activestorage in
master branch had used 3 spaces indentation.
|
| |
|
| |
|
| |
|
|
|
|
| |
Fix that an ActiveRecord::RecordNotUnique error would be raised when saving rich-text content with the same file attached multiple times.
|
| |
|
| |
|
| |
|
|
|
|
|
| |
- Allow configuring the sanitizer and its options
- Split attachment rendering and sanitizing helpers so each can be overridden by applications
|
| |
|
| |
|
|
|
|
| |
Assigning a has_one association for a persisted record saves the change immediately, so attempting to read a rich-text attribute on a persisted record without a corresponding ActionText::RichText would eagerly create one. Avoid assigning the rich text association to fix.
|
|
|
| |
Closes #35159.
|
|\
| |
| |
| | |
v6.0.0.beta3 release
|
| |
| |
| |
| |
| |
| |
| | |
* Update RAILS_VERSION
* Bundle
* rake update_versions
* rake changelog:header
|
|\ \
| | |
| | | |
Adds default trix content attachmment partial path
|
| |/ |
|
|\ \
| | |
| | |
| | |
| | | |
abhaynikam/35492-follow-up-to-updates-links-to-https
Updated links from http to https in guides, docs, etc
|
| | | |
|
| | | |
|
|/ / |
|
|/
|
|
|
|
|
|
|
|
|
| |
If the [`action_text.helper` initializer][0] runs after
`ActionController::Base` has been loaded, but before the
`rails-html-sanitizer` gem has been `require`d, then the reference to
the constant `Rails::Html` in the body of the
`ActionText::ContentHelper` module raises an `uninitialized constant`
exception.
[0]: https://github.com/rails/rails/blob/21703382393c87212c27c988420ee5c133c1aa9f/actiontext/lib/action_text/engine.rb#L31-L35
|
| |
|
|
|
|
|
|
|
|
|
| |
Without this change, `store_translations` silently fails when available
locales already initialized.
Ref:
https://travis-ci.org/rails/rails/jobs/497615616#L6846
https://travis-ci.org/rails/rails/jobs/497605027#L6856
|
|
|
|
| |
placeholder option set to true
|
|
|
|
|
|
|
|
|
|
|
|
| |
I implemented Foreign key create in `create_table` for SQLite3 at
#24743. This follows #24743 to implement `add_foreign_key` and
`remove_foreign_key`.
Unfortunately SQLite3 has one limitation that
`PRAGMA foreign_key_list(table-name)` doesn't have constraint name.
So we couldn't implement find/remove foreign key by name for now.
Fixes #35207.
Closes #31343.
|
|\
| |
| | |
MySQL: Support `:size` option to change text and blob size
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
In MySQL, the text column size is 65,535 bytes by default (1 GiB in
PostgreSQL). It is sometimes too short when people want to use a text
column, so they sometimes change the text size to mediumtext (16 MiB) or
longtext (4 GiB) by giving the `limit` option.
Unlike MySQL, PostgreSQL doesn't allow the `limit` option for a text
column (raises ERROR: type modifier is not allowed for type "text").
So `limit: 4294967295` (longtext) couldn't be used in Action Text.
I've allowed changing text and blob size without giving the `limit`
option, it prevents that migration failure on PostgreSQL.
|
| |
| |
| |
| | |
This reverts commit 30f666f87ab873258b797b39f29cf852f7621bea.
|
| |
| |
| |
| | |
Follow up #34956.
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Action Text installations appends `require("trix")` to the application.js file. The problem is that there isn't a line break in the beginning of the installation output, leading to syntax errors, e.g.:
```
import './application.scss'require("trix")
```
This commit moves the line break from the end to the beginning of the output, fixing it to:
```
import './application.scss'
require("trix")
```
|
|\
| |
| | |
Make `t.timestamps` with precision by default.
|
| | |
|
|/
|
|
|
|
|
|
|
|
| |
Failing test before the ActionText::RichText change:
```
Error:
ActionText::ModelTest#test_embed_extraction_only_extracts_file_attachments:
ArgumentError: Could not find or build blob: expected attachable, got #<ActionText::Attachables::RemoteImage:0x00007fb0259fef70 @url="http://example.com/cat.jpg", @content_type="image", @width=nil, @height=nil>
```
|
|
|
|
| |
Don't upsize images smaller than the specified dimensions.
|
|
|
|
| |
Use `+` instead of backquote.
|
| |
|
| |
|
|\
| |
| | |
Allow using Action Mailbox on MySQL 5.5
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Active Record still support MySQL 5.5 which doesn't support datetime
with precision.
https://github.com/rails/rails/blob/9e34df00039d63b5672315419e76f06f80ef3dc4/activerecord/lib/active_record/connection_adapters/abstract_mysql_adapter.rb#L99-L101
So we should check `supports_datetime_with_precision?` on the
connection.
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
After 866da19fd9fc12d001ab99ac87890ea1cebb2cd9 we now use package.json
to install Action Text's JS dependencies (see JS_PACKAGE_PATH).
But when the gem pacakge for Action Text is built, package.json was not
included so running `rails action_text:install` in a Rails app would
fail with:
```
rails action_text:install
rails aborted!
Errno::ENOENT: No such file or directory @ rb_sysopen - xxx/gems/actiontext-6.0.0.alpha/lib/templates/../../package.json
./bin/rails:4:in `<main>'
Tasks: TOP => app:template
(See full trace by running task with --trace)
```
|
|
|
|
| |
Automate installing the appropriate packages with yarn and appending them to the default application.js pack.
|
| |
|
|
|
|
| |
Fixes #33083
|
| |
|