index
:
rails.git
3-2-stable-for-hmno
master
Mirror of official rails repo with custom fixes.
Harald Eilertsen
about
summary
refs
log
tree
commit
diff
stats
log msg
author
committer
range
path:
root
/
actionpack
Commit message (
Expand
)
Author
Age
Files
Lines
...
*
|
|
|
|
|
"controllers" should be a valid path name
Aaron Patterson
2014-05-29
2
-1
/
+11
*
|
|
|
|
|
controllers with slash names are also not supported, so we can reuse the message
Aaron Patterson
2014-05-28
1
-6
/
+2
*
|
|
|
|
|
only validate controllers
Aaron Patterson
2014-05-28
1
-15
/
+17
*
|
|
|
|
|
golf down a bit
Aaron Patterson
2014-05-28
1
-8
/
+4
*
|
|
|
|
|
only error handling between controller and action is the same
Aaron Patterson
2014-05-28
1
-18
/
+16
*
|
|
|
|
|
add a test for controllers without colons
Aaron Patterson
2014-05-28
1
-0
/
+10
*
|
|
|
|
|
move nil check to a method that yields to a block if the value is not nil
Aaron Patterson
2014-05-28
1
-17
/
+16
*
|
|
|
|
|
translate action / controller to the desired object
Aaron Patterson
2014-05-28
1
-12
/
+11
*
|
|
|
|
|
only one nil check on the action variable
Aaron Patterson
2014-05-28
1
-10
/
+8
*
|
|
|
|
|
change to case / when on types
Aaron Patterson
2014-05-28
1
-8
/
+7
*
|
|
|
|
|
only do one nil check against the controller
Aaron Patterson
2014-05-28
1
-9
/
+9
*
|
|
|
|
|
extract controller and action parsing to a method
Aaron Patterson
2014-05-28
1
-19
/
+26
*
|
|
|
|
|
we don't need the call to presence. that is my present, to you!
Aaron Patterson
2014-05-28
1
-1
/
+1
*
|
|
|
|
|
swtich to returning early if to responds to call
Aaron Patterson
2014-05-28
1
-35
/
+32
*
|
|
|
|
|
return early if we have a valid controller name
Aaron Patterson
2014-05-28
1
-5
/
+5
*
|
|
|
|
|
trade 2 is_a? checks for a nil check
Aaron Patterson
2014-05-28
1
-2
/
+4
*
|
|
|
|
|
invert logic to remove nil? and exclude? checks (use ruby rather than AS when...
Aaron Patterson
2014-05-28
1
-6
/
+6
*
|
|
|
|
|
fewer blank? calls
Aaron Patterson
2014-05-28
1
-4
/
+4
*
|
|
|
|
|
reduce action.blank? calls
Aaron Patterson
2014-05-28
1
-4
/
+6
*
|
|
|
|
|
reduce blank? checks
Aaron Patterson
2014-05-28
1
-4
/
+9
*
|
|
|
|
|
extract controller checks to methods
Aaron Patterson
2014-05-28
1
-19
/
+26
*
|
|
|
|
|
set defaults at the top so we can avoid the ||= test
Aaron Patterson
2014-05-28
1
-6
/
+9
*
|
|
|
|
|
add a test for existing mapper functionality
Aaron Patterson
2014-05-28
1
-0
/
+12
|
/
/
/
/
/
*
|
|
|
|
add tests for argument error cases
Aaron Patterson
2014-05-28
1
-0
/
+27
*
|
|
|
|
Merge pull request #15386 from zuhao/refactor_actionpack_request_forgery_prot...
Santiago Pastorino
2014-05-28
1
-3
/
+6
|
\
\
\
\
\
|
*
|
|
|
|
Avoid hardcoded value in teardown.
Zuhao Wan
2014-05-28
1
-3
/
+6
*
|
|
|
|
|
Merge pull request #15388 from zuhao/refactor_actionpack_send_file_test
Santiago Pastorino
2014-05-28
1
-2
/
+6
|
\
\
\
\
\
\
|
*
|
|
|
|
|
Unregister Mime::Type in teardown.
Zuhao Wan
2014-05-28
1
-2
/
+6
|
|
/
/
/
/
/
*
|
|
|
|
|
Merge pull request #15385 from zuhao/refactor_actionpack_render_other_test
Santiago Pastorino
2014-05-28
1
-4
/
+7
|
\
\
\
\
\
\
|
|
/
/
/
/
/
|
/
|
|
|
|
|
|
*
|
|
|
|
Add and remove renderer inside the test to prevent leak.
Zuhao Wan
2014-05-28
1
-4
/
+7
|
|
/
/
/
/
*
|
|
|
|
Merge pull request #15383 from zuhao/refactor_actionpack_localized_templates_...
Yves Senn
2014-05-28
1
-10
/
+8
|
\
\
\
\
\
|
|
/
/
/
/
|
/
|
|
|
|
|
*
|
|
|
Move I18n.locale setting into setup and teardown.
Zuhao Wan
2014-05-28
1
-10
/
+8
|
|
/
/
/
*
/
/
/
Add with_default_charset helper.
Zuhao Wan
2014-05-28
1
-12
/
+20
|
/
/
/
*
|
|
Deprecate all *_filter callbacks in favor of *_action callbacks
Rafael Mendonça França
2014-05-27
5
-214
/
+224
*
|
|
rm dead code
Aaron Patterson
2014-05-27
1
-5
/
+0
*
|
|
PARAMETERS_KEY is only used in the request, so move the constant there
Aaron Patterson
2014-05-27
3
-9
/
+9
*
|
|
Merge branch 'constraints'
Aaron Patterson
2014-05-27
11
-75
/
+85
|
\
\
\
|
*
|
|
rm reset_parameters because we automatically do it from 9ca4839a
Aaron Patterson
2014-05-27
3
-9
/
+0
|
*
|
|
move path_parameter encoding check to the request object
Aaron Patterson
2014-05-27
3
-18
/
+13
|
*
|
|
dispatcher doesn't need `call` anymore
Aaron Patterson
2014-05-27
1
-4
/
+0
|
*
|
|
call `serve` with the request on dispatchers
Aaron Patterson
2014-05-27
1
-9
/
+10
|
*
|
|
constraints class does not need the request class anymore
Aaron Patterson
2014-05-27
1
-4
/
+4
|
*
|
|
give all endpoints a superclass
Aaron Patterson
2014-05-27
4
-22
/
+40
|
*
|
|
skip the build business if the stack is empty
Aaron Patterson
2014-05-26
1
-2
/
+6
|
*
|
|
stop hardcoding path_parameters and get it from the request
Aaron Patterson
2014-05-26
1
-1
/
+2
|
*
|
|
we do not need to cache rack_app
Aaron Patterson
2014-05-26
1
-9
/
+3
|
*
|
|
a redirect is not a dispatcher by definition, so eliminate test
Aaron Patterson
2014-05-26
1
-1
/
+1
|
*
|
|
push is_a check up to where the Constraints object is allocated
Aaron Patterson
2014-05-26
2
-6
/
+11
|
*
|
|
pass the request object to the application
Aaron Patterson
2014-05-25
3
-6
/
+8
|
*
|
|
pass a request to `matches?` so we can avoid creating excess requests
Aaron Patterson
2014-05-25
2
-7
/
+6
[prev]
[next]