aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack
Commit message (Collapse)AuthorAgeFilesLines
* Adds #key and #to_param to the AMo interfacesnusnu2010-02-193-1/+39
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit introduces two new methods that every AMo compliant object must implement. Below are the default implementations along with the implied interface contract. # Returns an Enumerable of all (primary) key # attributes or nil if new_record? is true def key new_record? ? nil : [1] end # Returns a string representing the object's key # suitable for use in URLs, or nil if new_record? # is true def to_param key ? key.first.to_s : nil end 1) The #key method Previously rails' record_identifier code, which is used in the #dom_id helper, relied on calling #id on the record to provide a reasonable DOM id. Now with rails3 being all ORM agnostic, it's not safe anymore to assume that every record ever will have an #id as its primary key attribute. Having a #key method available on every AMo object means that #dom_id can be implemented using record.to_model.key # instead of record.id Using this we're able to take composite primary keys into account (e.g. available in datamapper) by implementing #dom_id using a newly added record_key_for_dom_id(record) method. The user can overwrite this method to provide customized versions of the object's key used in #dom_id. Also, dealing with more complex keys that can contain arbitrary strings, means that we need to make sure that we only provide DOM ids that are valid according to the spec. For this reason, this patch sends the key provided through a newly added sanitize_dom_id(candidate_id) method, that makes sure we only produce valid HTML The reason to not just add #dom_id to the AMo interface was that it feels like providing a DOM id should not be a model concern. Adding #dom_id to the AMo interface would force these concern on the model, while it's better left to be implemented in a helper. Now one could say the same is true for #to_param, and actually I think that it doesn't really fit into the model either, but it's used in AR and it's a main part of integrating into the rails router. This is different from #dom_id which is only used in view helpers and can be implemented on top of a semantically more meaningful method like #key. 2) The #to_param method Since the rails router relies on #to_param to be present, AR::Base implements it and returns the id by default, allowing the user to overwrite the method if desired. Now with different ORMs integrating into rails, every ORM railtie needs to implement it's own #to_param implementation while already providing code to be AMo compliant. Since the whole point of AMo compliance seems to be to integrate any ORM seamlessly into rails, it seems fair that all we really need to do as another ORM, is to be AMo compliant. By including #to_param into the official interface, we can make sure that this code can be centralized in the various AMo compliance layers, and not be added separately by every ORM railtie. 3) All specs pass
* Fix a bunch of pending tests by providing an introspection mode for the ↵Carlhuda2010-02-194-21/+42
| | | | Response object that does up-front parsing of the headers to populate things like @etag
* Revert "i18n translate with arrays issue solved"Yehuda Katz2010-02-191-5/+0
| | | | This reverts commit e7055e5b084f5e29e9cf8dab8d56943da65ccb43.
* i18n translate with arrays issue solvedSantiago Pastorino2010-02-191-0/+5
|
* Remove empty line and trailing hash, breaks documentation generationDirkjan Bussink2010-02-191-2/+0
| | | | Signed-off-by: Yehuda Katz <yehudakatz@YK.local>
* Reinstate pending tests that were supposed to be fixed before theJoshua Peek2010-02-192-29/+19
| | | | | | beta. Shout louder this time so they actually get fixed.
* Revert behavior from a5684dfa3c16472bfa5d5d861ba78cb6dbadcb59 and ensure ↵José Valim2010-02-191-1/+1
| | | | after_initializer is executed after to_prepare callbacks.
* ruby 1.9 array.to_s returns a string representing an escaped arraySantiago Pastorino2010-02-181-1/+1
| | | | Signed-off-by: Yehuda Katz <yehudakatz@YK.local>
* i18n translate with arrays issue solvedSantiago Pastorino2010-02-182-2/+8
| | | | Signed-off-by: Yehuda Katz <yehudakatz@YK.local>
* Update RendererYehuda Katz2010-02-181-5/+4
|
* Rename router internal option :namespace to :controller_namespace which is ↵José Valim2010-02-171-3/+3
| | | | its real purpose.
* Merge master.José Valim2010-02-1712-18/+39
|\
| * Update AP to start locking down a public API. This work is parallel to some ↵Yehuda Katz2010-02-166-12/+18
| | | | | | | | docs I'm working on.
| * rack-mount 0.5 supportJoshua Peek2010-02-152-2/+2
| |
| * Fix test load paths for those not using bundlerJoshua Peek2010-02-154-5/+20
| |
* | Make Railties tests green again.José Valim2010-02-172-8/+13
| |
* | Ensure render :text => resource first tries to invoke :to_text on itJosé Valim2010-02-163-0/+17
| |
* | AD::TestProcess relies on request.flash, so let's load it.José Valim2010-02-161-0/+2
| |
* | Should allow symbols in :only and :except in routes.José Valim2010-02-162-7/+14
| |
* | Do not swallow controller loading errors unless required.José Valim2010-02-161-10/+4
| |
* | Rename Rails::Subscriber to Rails::LogSubscriberPrem Sichanugrist2010-02-167-29/+29
|/
* name.blank? -> anonymous?Xavier Noria2010-02-141-1/+2
| | | | Signed-off-by: Yehuda Katz <yehudakatz@YK.local>
* Explicit html_escape removed when not neededSantiago Pastorino and José Ignacio Costa2010-02-143-4/+4
| | | | Signed-off-by: Yehuda Katz <yehudakatz@YK.local>
* html_escape mail_to when encode javascript and not hexSantiago Pastorino and José Ignacio Costa2010-02-141-5/+3
| | | | Signed-off-by: Yehuda Katz <yehudakatz@YK.local>
* content_tag should escape its inputBruno Michel2010-02-1410-24/+25
| | | | Signed-off-by: Yehuda Katz <yehudakatz@YK.local>
* simple_format returns a safe buffer escaping unsafe input [Santiago Pastorino]David Heinemeier Hansson2010-02-122-1/+13
|
* Safely concat the ending tag to simple_format or it will be escapedDavid Heinemeier Hansson2010-02-121-1/+1
|
* Revert to rack-mount 0.4.7Jeremy Kemper2010-02-121-1/+1
|
* Wups, rack-mount 0.5.0Jeremy Kemper2010-02-111-1/+1
|
* Bump rack-mount dep to 0.5.3Jeremy Kemper2010-02-111-1/+1
|
* Its not a deprecation if you actually just ignore the callDavid Heinemeier Hansson2010-02-091-0/+2
|
* Adding ruby version spec to all gemspec files to at least 1.8.7Mikel Lindsaar2010-02-081-0/+1
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Fix pluralization for numbers formatted like '1.00'Gabriel Mansour2010-02-072-1/+3
| | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* Fix nested attributes with specified collection.José Valim2010-02-072-7/+33
|
* Fix tiny version number from '3.0.0beta' to '3.0.0.beta1', so 'rake install' ↵Prem Sichanugrist2010-02-061-1/+1
| | | | | | will be run correctly [#3879 status:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* Add a test which ensures namespaced roots.José Valim2010-02-061-0/+10
|
* Routes should not swallow all NameErrors [#3862 status:resolved].José Valim2010-02-061-1/+2
|
* Updates subscriber test for new outputYehuda Katz2010-02-051-1/+1
|
* Lookup the status code and rework the Completed line a bitDavid Heinemeier Hansson2010-02-051-2/+1
|
* More html_safe strings now use the safe_concat methodSantiago Pastorino and José Ignacio Costa2010-02-055-7/+7
| | | | | | [#3856 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* Make UrlWriter includable in a ModuleJeremy Kemper2010-02-051-1/+9
|
* Bump git versions to 3.0.0.beta1 since we've releasedJeremy Kemper2010-02-051-3/+3
|
* Submarine the rake-gemcutter dep in RakefilesJeremy Kemper2010-02-051-4/+5
|
* Fix task definesJeremy Kemper2010-02-041-1/+1
|
* Release using gemcutter gem:push tasksJeremy Kemper2010-02-041-0/+6
|
* Test that csrf meta content is html-escaped, tooJeremy Kemper2010-02-041-1/+2
|
* Revert dumb testJeremy Kemper2010-02-041-2/+2
|
* HTML-escape csrf meta contentsJeremy Kemper2010-02-042-3/+3
|
* Expose CSRF param name alsoJeremy Kemper2010-02-042-2/+2
|
* Expose CSRF tag for UJS adaptersJeremy Kemper2010-02-043-1/+29
|
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-09 20:13:46 +0000