Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Revert "Perf: refactor _assign method to avoid inject and defining unneeded ↵ | José Valim | 2010-10-02 | 1 | -1/+5 |
| | | | | | | | | local var." _assigns must return a hash. This reverts commit e66c1cee86aba1c81152f3d0872313e65cec85a9. | ||||
* | removing more duplicate code. :'( | Aaron Patterson | 2010-10-01 | 1 | -13/+1 |
| | |||||
* | fixing warnings with regexps on assert_match | Aaron Patterson | 2010-10-01 | 1 | -2/+2 |
| | |||||
* | removing more duplicate code | Aaron Patterson | 2010-10-01 | 3 | -30/+17 |
| | |||||
* | delete repeated code | Aaron Patterson | 2010-10-01 | 3 | -36/+18 |
| | |||||
* | use a method that actually exists | Aaron Patterson | 2010-10-01 | 1 | -1/+1 |
| | |||||
* | removing AS::Testing::Default in favor of just undefing default_test | Aaron Patterson | 2010-10-01 | 1 | -2/+1 |
| | |||||
* | Revert "removing crazy finalizer code until there is proof that we need it" | José Valim | 2010-09-30 | 1 | -0/+11 |
| | | | | This reverts commit a40e3c1a9604ab3737ad2465c8f6a6db0fe0cc78. | ||||
* | Properly reload routes defined in class definition | Piotr Sarnacki | 2010-09-30 | 1 | -0/+1 |
| | | | | | | | | | | | | | | | | | Sometimes it's easier to define routes inside Engine or Application class definition (e.g. one file applications). The problem with such case is that if there is a plugin that has config/routes.rb file, it will trigger routes reload on application. Since routes definition for application is not in config/routes.rb file routes_reloader will fail to reload application's routes properly. With this commit you can pass routes definition as a block to routes method, which will allow to properly reload it: class MyApp::Application < Rails::Application routes do resources :users end end | ||||
* | Allow mounting engines at '/' | Piotr Sarnacki | 2010-09-30 | 2 | -17/+78 |
| | | | | | Without that commit script_name always become '/', which results in paths like //posts/1 instead of /posts/1 | ||||
* | Use .find here as it is simpler and faster. | José Valim | 2010-09-30 | 1 | -1/+1 |
| | |||||
* | avoid creating a block if possible | Aaron Patterson | 2010-09-29 | 1 | -2/+2 |
| | |||||
* | fixing regexp warnings | Aaron Patterson | 2010-09-29 | 1 | -1/+1 |
| | |||||
* | tag value can be false, so nil? check is necessary | Aaron Patterson | 2010-09-29 | 1 | -1/+1 |
| | |||||
* | another case of extra nil? check | Neeraj Singh | 2010-09-30 | 1 | -1/+1 |
| | |||||
* | no need to check for nil? | Neeraj Singh | 2010-09-30 | 1 | -2/+2 |
| | |||||
* | no need to check for nil? | Neeraj Singh | 2010-09-30 | 1 | -1/+1 |
| | |||||
* | no need of nil check | Neeraj Singh | 2010-09-30 | 1 | -1/+1 |
| | |||||
* | removing crazy finalizer code until there is proof that we need it | Aaron Patterson | 2010-09-29 | 1 | -9/+0 |
| | |||||
* | removing useless code | Aaron Patterson | 2010-09-29 | 1 | -1/+0 |
| | |||||
* | dry up method checking in the request object | Aaron Patterson | 2010-09-29 | 1 | -10/+9 |
| | |||||
* | reduce function calls on Array | Aaron Patterson | 2010-09-29 | 1 | -3/+2 |
| | |||||
* | removing more lolinject | Aaron Patterson | 2010-09-29 | 1 | -8/+7 |
| | |||||
* | removing lollerject | Aaron Patterson | 2010-09-29 | 1 | -1/+1 |
| | |||||
* | oops, missed a uniq | Aaron Patterson | 2010-09-29 | 1 | -1/+1 |
| | |||||
* | dry up action_methods | Aaron Patterson | 2010-09-29 | 1 | -4/+4 |
| | |||||
* | fixing space error | Aaron Patterson | 2010-09-29 | 1 | -1/+1 |
| | |||||
* | Merge remote branch 'miloops/warnings' | José Valim | 2010-09-29 | 6 | -9/+17 |
|\ | |||||
| * | We can't assign @view_context_class here, define super() in test instead if ↵ | Emilio Tagua | 2010-09-29 | 2 | -1/+2 |
| | | | | | | | | we want to avoid warnings. | ||||
| * | _ is not a valid scheme name character, \w includes it and also is redundant ↵ | Emilio Tagua | 2010-09-29 | 2 | -1/+8 |
| | | | | | | | | | | | | with \d. 'The scheme name consists of a letter followed by any combination of letters, digits, and the plus ("+"), period ("."), or hyphen ("-") characters; and is terminated by a colon (":").' | ||||
| * | Remove redundant conditional. | Emilio Tagua | 2010-09-29 | 1 | -5/+1 |
| | | |||||
| * | Don't try to interpolate string if there's no interpolation point at all. | Emilio Tagua | 2010-09-29 | 1 | -1/+1 |
| | | |||||
| * | Test correct method behaviour. | Emilio Tagua | 2010-09-29 | 2 | -2/+6 |
| | | |||||
| * | Initialize @view_context_class and cache view_context_class value. | Emilio Tagua | 2010-09-29 | 1 | -1/+1 |
| | | |||||
* | | no need to call e.class | Aaron Patterson | 2010-09-29 | 1 | -1/+1 |
| | | |||||
* | | Fix a small typo (ht: masterkain) | José Valim | 2010-09-29 | 1 | -1/+1 |
|/ | |||||
* | Ensure that named routes do not overwrite previously defined routes. | José Valim | 2010-09-29 | 2 | -10/+31 |
| | |||||
* | Fix an error on 1.8.7. | José Valim | 2010-09-29 | 1 | -1/+1 |
| | |||||
* | @_etag is not used anywhere. | José Valim | 2010-09-29 | 1 | -2/+0 |
| | |||||
* | Avoid (@_var ||= nil) pattern by using initialize methods and ensuring ↵ | José Valim | 2010-09-29 | 10 | -34/+42 |
| | | | | everyone calls super as expected. | ||||
* | Merge remote branch 'miloops/warnings' | José Valim | 2010-09-29 | 43 | -109/+90 |
|\ | |||||
| * | Enable warnings now that they can be readed. | Emilio Tagua | 2010-09-28 | 1 | -1/+1 |
| | | |||||
| * | Fix test that wasn't running at all. | Emilio Tagua | 2010-09-28 | 1 | -1/+1 |
| | | |||||
| * | Remove methods to avoid warnings. | Emilio Tagua | 2010-09-28 | 1 | -0/+2 |
| | | |||||
| * | Change test to avoid warnings. | Emilio Tagua | 2010-09-28 | 1 | -1/+1 |
| | | |||||
| * | Redefine duplicated test name. | Emilio Tagua | 2010-09-28 | 1 | -1/+1 |
| | | |||||
| * | Redefine duplicated test name. | Emilio Tagua | 2010-09-28 | 1 | -1/+1 |
| | | |||||
| * | Use redefine_method since baz is already defined. | Emilio Tagua | 2010-09-28 | 1 | -1/+1 |
| | | |||||
| * | Fix more warnings by defining variables and using instance_variable_defined? ↵ | Emilio Tagua | 2010-09-28 | 1 | -2/+4 |
| | | | | | | | | instead instance_variable_get. | ||||
| * | Define @_layout if it is not defined. | Emilio Tagua | 2010-09-28 | 1 | -0/+1 |
| | |