aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack
Commit message (Collapse)AuthorAgeFilesLines
...
* | Properly reload routes defined in class definitionPiotr Sarnacki2010-09-301-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Sometimes it's easier to define routes inside Engine or Application class definition (e.g. one file applications). The problem with such case is that if there is a plugin that has config/routes.rb file, it will trigger routes reload on application. Since routes definition for application is not in config/routes.rb file routes_reloader will fail to reload application's routes properly. With this commit you can pass routes definition as a block to routes method, which will allow to properly reload it: class MyApp::Application < Rails::Application routes do resources :users end end
* | Allow mounting engines at '/'Piotr Sarnacki2010-09-302-17/+78
| | | | | | | | | | Without that commit script_name always become '/', which results in paths like //posts/1 instead of /posts/1
* | Use .find here as it is simpler and faster.José Valim2010-09-301-1/+1
| |
* | avoid creating a block if possibleAaron Patterson2010-09-291-2/+2
| |
* | fixing regexp warningsAaron Patterson2010-09-291-1/+1
| |
* | tag value can be false, so nil? check is necessaryAaron Patterson2010-09-291-1/+1
| |
* | another case of extra nil? checkNeeraj Singh2010-09-301-1/+1
| |
* | no need to check for nil?Neeraj Singh2010-09-301-2/+2
| |
* | no need to check for nil?Neeraj Singh2010-09-301-1/+1
| |
* | no need of nil checkNeeraj Singh2010-09-301-1/+1
| |
* | removing crazy finalizer code until there is proof that we need itAaron Patterson2010-09-291-9/+0
| |
* | removing useless codeAaron Patterson2010-09-291-1/+0
| |
* | dry up method checking in the request objectAaron Patterson2010-09-291-10/+9
| |
* | reduce function calls on ArrayAaron Patterson2010-09-291-3/+2
| |
* | removing more lolinjectAaron Patterson2010-09-291-8/+7
| |
* | removing lollerjectAaron Patterson2010-09-291-1/+1
| |
* | oops, missed a uniqAaron Patterson2010-09-291-1/+1
| |
* | dry up action_methodsAaron Patterson2010-09-291-4/+4
| |
* | fixing space errorAaron Patterson2010-09-291-1/+1
| |
* | Merge remote branch 'miloops/warnings'José Valim2010-09-296-9/+17
|\ \ | |/ |/|
| * We can't assign @view_context_class here, define super() in test instead if ↵Emilio Tagua2010-09-292-1/+2
| | | | | | | | we want to avoid warnings.
| * _ is not a valid scheme name character, \w includes it and also is redundant ↵Emilio Tagua2010-09-292-1/+8
| | | | | | | | | | | | with \d. 'The scheme name consists of a letter followed by any combination of letters, digits, and the plus ("+"), period ("."), or hyphen ("-") characters; and is terminated by a colon (":").'
| * Remove redundant conditional.Emilio Tagua2010-09-291-5/+1
| |
| * Don't try to interpolate string if there's no interpolation point at all.Emilio Tagua2010-09-291-1/+1
| |
| * Test correct method behaviour.Emilio Tagua2010-09-292-2/+6
| |
| * Initialize @view_context_class and cache view_context_class value.Emilio Tagua2010-09-291-1/+1
| |
* | no need to call e.classAaron Patterson2010-09-291-1/+1
| |
* | Fix a small typo (ht: masterkain)José Valim2010-09-291-1/+1
|/
* Ensure that named routes do not overwrite previously defined routes.José Valim2010-09-292-10/+31
|
* Fix an error on 1.8.7.José Valim2010-09-291-1/+1
|
* @_etag is not used anywhere.José Valim2010-09-291-2/+0
|
* Avoid (@_var ||= nil) pattern by using initialize methods and ensuring ↵José Valim2010-09-2910-34/+42
| | | | everyone calls super as expected.
* Merge remote branch 'miloops/warnings'José Valim2010-09-2943-109/+90
|\
| * Enable warnings now that they can be readed.Emilio Tagua2010-09-281-1/+1
| |
| * Fix test that wasn't running at all.Emilio Tagua2010-09-281-1/+1
| |
| * Remove methods to avoid warnings.Emilio Tagua2010-09-281-0/+2
| |
| * Change test to avoid warnings.Emilio Tagua2010-09-281-1/+1
| |
| * Redefine duplicated test name.Emilio Tagua2010-09-281-1/+1
| |
| * Redefine duplicated test name.Emilio Tagua2010-09-281-1/+1
| |
| * Use redefine_method since baz is already defined.Emilio Tagua2010-09-281-1/+1
| |
| * Fix more warnings by defining variables and using instance_variable_defined? ↵Emilio Tagua2010-09-281-2/+4
| | | | | | | | instead instance_variable_get.
| * Define @_layout if it is not defined.Emilio Tagua2010-09-281-0/+1
| |
| * Initialize @path.Emilio Tagua2010-09-281-0/+1
| |
| * Use helper method here.Emilio Tagua2010-09-281-6/+5
| |
| * Silence warnings here, only setting Encoding.default_external for testing.Emilio Tagua2010-09-281-2/+3
| |
| * Silence warnings here, only setting Encoding.default_external for testing.Emilio Tagua2010-09-281-2/+3
| |
| * Remove more warnings on AP.Emilio Tagua2010-09-283-4/+5
| |
| * Define @title to avoid warnings.Emilio Tagua2010-09-281-0/+4
| |
| * Use instance_variable_defined? instead instance_variable_get in tests.Emilio Tagua2010-09-281-2/+2
| |
| * Initialize ivars in tests.Emilio Tagua2010-09-283-0/+3
| |
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-17 01:10:51 +0000