Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | adds tests for #capture | Xavier Noria | 2010-03-16 | 1 | -0/+23 |
| | | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | Some more tweaks on <% %>. | Carlhuda | 2010-03-16 | 4 | -8/+8 |
| | | | | * The cache helper is now semantically "mark this region for caching" * As a result, <% x = cache do %> no longer works | ||||
* | Change array entries to safe doesn't worth then the array is joined as a ↵ | Santiago Pastorino | 2010-03-16 | 1 | -1/+1 |
| | | | | | | string losing the safe property of his entries [#4134 status:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Break a window :/ | Jeremy Kemper | 2010-03-15 | 5 | -7/+7 |
| | |||||
* | RJS may cache an array | Jeremy Kemper | 2010-03-15 | 1 | -1/+1 |
| | |||||
* | Fix link_to with block | Jeremy Kemper | 2010-03-15 | 2 | -5/+2 |
| | |||||
* | link_to_remote -> link_to :remote => true | Jeremy Kemper | 2010-03-15 | 1 | -1/+1 |
| | |||||
* | Swear I ran this test | Jeremy Kemper | 2010-03-15 | 1 | -1/+1 |
| | |||||
* | Integration test url options should account for :protocol not just https? | Jeremy Kemper | 2010-03-15 | 2 | -9/+8 |
| | |||||
* | Move more normalization up to the lookup context, so it does not have to ↵ | José Valim | 2010-03-16 | 4 | -38/+40 |
| | | | | repeat in every resolver. | ||||
* | Revert "Reinstate old default_url_options method signature" | Jeremy Kemper | 2010-03-15 | 1 | -1/+1 |
| | | | | This reverts commit 5913dd478150710fc0b72a0568f68e13c958d6bc. | ||||
* | adds test coverage for with_output_buffer | Xavier Noria | 2010-03-15 | 1 | -3/+45 |
| | | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | Reinstate old default_url_options method signature | Jeremy Kemper | 2010-03-15 | 1 | -1/+1 |
| | |||||
* | Add deprecation notices for <% %>. | Carlhuda | 2010-03-15 | 15 | -97/+88 |
| | | | | | | | | | | | | | | | | * The approach is to compile <% %> into a method call that checks whether the value returned from a block is a String. If it is, it concats to the buffer and prints a deprecation warning. * <%= %> uses exactly the same logic to compile the template, which first checks to see whether it's compiling a block. * This should have no impact on other uses of block in templates. For instance, in <% [1,2,3].each do |i| %><%= i %><% end %>, the call to each returns an Array, not a String, so the result is not concatenated * In two cases (#capture and #cache), a String can be returned that should *never* be concatenated. We have temporarily created a String subclass called NonConcattingString which behaves (and is serialized) identically to String, but is not concatenated by the code that handles deprecated <% %> block helpers. Once we remove support for <% %> block helpers, we can remove NonConcattingString. | ||||
* | with_output_buffer cannot assume there's an output_buffer | Xavier Noria | 2010-03-15 | 2 | -1/+7 |
| | | | | | | [#4182 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | to_str works here | Jeremy Kemper | 2010-03-15 | 1 | -1/+1 |
| | |||||
* | Don't force singularization of singleton resource names, e.g. /preferences ↵ | Andrew White | 2010-03-15 | 2 | -8/+15 |
| | | | | | | [#4089 state:resolved] Signed-off-by: Joshua Peek <josh@joshpeek.com> | ||||
* | read_ and write_fragment cache preserve html safety yet cache strings only | Jeremy Kemper | 2010-03-14 | 2 | -6/+19 |
| | |||||
* | There's a Ruby issue with File.basename different versions returns different ↵ | Santiago Pastorino | 2010-03-14 | 1 | -1/+0 |
| | | | | things, so we shouldn't test that | ||||
* | Making escaped things more readable | Santiago Pastorino | 2010-03-14 | 3 | -3/+3 |
| | |||||
* | Optimize DetailsKey generation. | José Valim | 2010-03-14 | 1 | -4/+5 |
| | |||||
* | Ensure controller filters are executed before stuff starts to happen. | José Valim | 2010-03-13 | 3 | -3/+21 |
| | |||||
* | Remove formats setters from render template, speeding up partial and ↵ | José Valim | 2010-03-13 | 1 | -2/+1 |
| | | | | collection renderings. | ||||
* | Made asset_tag_helper use config.perform_caching instead of ↵ | Denis Odorcic | 2010-03-12 | 2 | -32/+32 |
| | | | | | | ActionController::Base.perform_caching Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Finish cleaning up rendering stack from views and move assigns evaluation to ↵ | José Valim | 2010-03-12 | 13 | -72/+66 |
| | | | | controller (so plugins and/or controllers can overwrite just one method). | ||||
* | Allow anything that responds to render to be given as :template and use ↵ | José Valim | 2010-03-12 | 7 | -118/+63 |
| | | | | find_template instead of find in views. | ||||
* | %= works for content_tag and does not require parenthesis on method call | José Valim | 2010-03-12 | 2 | -49/+8 |
| | |||||
* | Make all AP tests pass for Ruby 1.9.1. | José Valim | 2010-03-12 | 4 | -17/+19 |
| | |||||
* | Fix test | Jeremy Kemper | 2010-03-11 | 1 | -1/+1 |
| | |||||
* | Write strings to fragment cache, not outputbuffers | Jeremy Kemper | 2010-03-11 | 1 | -1/+3 |
| | |||||
* | Delegate #encoding to SafeBuffer too | Jeremy Kemper | 2010-03-11 | 1 | -0/+4 |
| | |||||
* | simplify alt tag generation for images | Eaden McKee | 2010-03-11 | 2 | -3/+6 |
| | | | | | | [#2837 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | ActionController::Base.request_forgery_protection_token should actually be ↵ | Carl Lerche | 2010-03-11 | 1 | -1/+1 |
| | | | | the name of the token and not true. | ||||
* | Add tests for lookup context. | José Valim | 2010-03-11 | 4 | -34/+203 |
| | |||||
* | Merge branch 'master' of github.com:rails/rails | wycats | 2010-03-10 | 14 | -114/+110 |
|\ | |||||
| * | Merge branch 'master' of gitproxy:rails/rails | José Valim | 2010-03-10 | 10 | -109/+96 |
| |\ | |||||
| * | | Optimize and clean up how details key get expired. | José Valim | 2010-03-10 | 9 | -37/+71 |
| | | | |||||
| * | | Remove uneeded methods. | José Valim | 2010-03-10 | 2 | -33/+4 |
| | | | |||||
| * | | Merge branch 'master' of gitproxy:rails/rails | José Valim | 2010-03-09 | 9 | -159/+143 |
| |\ \ | |||||
| * | | | Clean up the API required from ActionView::Template. | José Valim | 2010-03-09 | 5 | -44/+35 |
| | | | | |||||
* | | | | Make form helpers work with <%= | wycats | 2010-03-09 | 10 | -126/+188 |
| | | | | |||||
* | | | | Deprecate block_called_from_erb? pending a solution for getting it into apps | Carlhuda | 2010-03-09 | 9 | -64/+154 |
| |_|/ |/| | | |||||
* | | | skip_relative_url_root url_for option is dead | Joshua Peek | 2010-03-09 | 4 | -7/+5 |
| | | | |||||
* | | | Allow default_url_options to be set on route set | Joshua Peek | 2010-03-09 | 3 | -0/+13 |
| | | | |||||
* | | | RouteSet#rewrite => url_for | Joshua Peek | 2010-03-09 | 5 | -7/+6 |
| | | | |||||
* | | | Unused RouteSet#url_for is hogging a good method name | Joshua Peek | 2010-03-09 | 1 | -13/+4 |
| | | | |||||
* | | | Move AC::UrlRewriter onto route set | Joshua Peek | 2010-03-09 | 7 | -90/+76 |
| |/ |/| | |||||
* | | Reinstate dom_id in controllers. | Justin Ko | 2010-03-09 | 2 | -0/+9 |
| | | | | | | | | | | | | | | [#3040 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | | Refactor the RouteSet so it uses a Generator object instead of one huge method. | wycats | 2010-03-09 | 2 | -88/+109 |
| | | |||||
* | | Get rid of the instance-level URL rewriter | wycats | 2010-03-09 | 5 | -71/+25 |
|/ |