Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Revert "Moved encoding work in progress to a feature branch." | wycats | 2010-05-17 | 15 | -87/+435 |
| | | | | This reverts commit ade756fe42423033bae8e5aea8f58782f7a6c517. | ||||
* | Ruby 1.9: helper path may be a pathname, so convert to a string before ↵ | Jeremy Kemper | 2010-05-16 | 1 | -1/+1 |
| | | | | quoting for regexp | ||||
* | Moved encoding work in progress to a feature branch. | Jeremy Kemper | 2010-05-16 | 15 | -435/+87 |
| | | | | This reverts commits af0d1a88157942c6e6398dbf73891cff1e152405 and 64d109e3539ad600f58536d3ecabd2f87b67fd1c. | ||||
* | Significantly improved internal encoding heuristics and support. | wycats | 2010-05-16 | 15 | -52/+384 |
| | | | | | | | | | | | | | | | | | | | | | | | | | * Default Encoding.default_internal to UTF-8 * Eliminated the use of file-wide magic comments to coerce code evaluated inside the file * Read templates as BINARY, use default_external or template-wide magic comments inside the Template to set the initial encoding * This means that template handlers in Ruby 1.9 will receive Strings encoded in default_internal (UTF-8 by default) * Create a better Exception for encoding issues, and use it when the template source has bytes that are not compatible with the specified encoding * Allow template handlers to opt-into handling BINARY. If they do so, they need to do some of their own manual encoding work * Added a "Configuration Gotchas" section to the intro Rails Guide instructing users to use UTF-8 for everything * Use config.encoding= in Ruby 1.8, and raise if a value that is an invalid $KCODE value is used Also: * Fixed a few tests that were assert() rather than assert_equal() and were caught by Minitest requiring a String for the message * Fixed a test where an assert_select was misformed, also caught by Minitest being more restrictive * Fixed a test where a Rack response was returning a String rather than an Enumerable | ||||
* | Initial work to improve the state of encodings for templates | wycats | 2010-05-16 | 3 | -45/+61 |
| | |||||
* | Take out stale tasks from Actionpack's Rakefile [#4619 state:resolved] | Rizwan Reza | 2010-05-16 | 1 | -19/+0 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Check blocks are not incorrectly detected when compiling erubis templates ↵ | Simon Jefford | 2010-05-16 | 3 | -1/+7 |
| | | | | | | [#4575 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Fixed 1 failure in ActionPack testsuite [#4613 state:resolved] | Hussein Morsy | 2010-05-16 | 1 | -2/+2 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | added support for html attributes in options_for_select [#2165] | pleax | 2010-05-16 | 2 | -2/+81 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Fixed 1 failure and 2 errors in ActionPack testsuite [#4613 state:commited] | rohit | 2010-05-16 | 3 | -6/+6 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Sending :id => nil to form helpers now properly omits the "id" html element ↵ | Jeff Dean | 2010-05-15 | 2 | -5/+118 |
| | | | | | | [#4559 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Optimize the code added in fa99de0bd054576336c9 | José Valim | 2010-05-15 | 1 | -9/+19 |
| | |||||
* | Ruby 1.9: fix invalid rack response in test | Jeremy Kemper | 2010-05-15 | 1 | -1/+1 |
| | |||||
* | make sure `as` is set before trying to build an #{as}_counter. [#2804 ↵ | Jeff Kreeftmeijer | 2010-05-15 | 1 | -1/+1 |
| | | | | | | state:resolved] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | partial counters with :as [#2804 state:resolved] | Jeff Kreeftmeijer | 2010-05-15 | 3 | -0/+11 |
| | | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | Add tests for convenience methods #notice and #alert to flash.now [#4369 ↵ | Anil Wadghule | 2010-05-15 | 1 | -0/+20 |
| | | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | added convenience methods #notice and #alert to flash.now | Martin | 2010-05-15 | 1 | -0/+10 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | fix assert_select messages to its declaration behaviour | Paco Guzman | 2010-05-15 | 2 | -8/+24 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Accept :alt => nil on image_tag [#4558 state:resolved] | Marc-Andre Lafortune | 2010-05-15 | 2 | -2/+3 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Improve previous patch a bit [#3645 state:resolved] | José Valim | 2010-05-15 | 3 | -9/+11 |
| | |||||
* | Let label helpers accept blocks. | Stephen Celis | 2010-05-15 | 4 | -21/+56 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | corrected error message in session/cookie_store [#4546 state:resolved] | Josh Kalderimis | 2010-05-10 | 1 | -1/+1 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Use annoted source code in Template:Error to avoid special cases in the show ↵ | José Valim | 2010-05-09 | 3 | -11/+7 |
| | | | | exceptions middleware. | ||||
* | Fix parsing xml input by ActionDispatch::ParamsParser | Lawrence Pit | 2010-05-06 | 2 | -1/+14 |
| | | | | | | [#4437 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | move assert_template tests to their own test case [#4501 state:resolved] | David Chelimsky | 2010-05-03 | 1 | -41/+46 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Eliminate false positives when passing symbols to assert_template | David Chelimsky | 2010-05-03 | 2 | -5/+27 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Favor %{} in all code instead of (deprecated) {{}} as interpolation syntax ↵ | Lawrence Pit | 2010-05-03 | 2 | -4/+4 |
| | | | | | | for I18n Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Make backtrace_cleaner work as expected. Prior to this patch, the Full Trace ↵ | José Valim | 2010-05-03 | 1 | -26/+6 |
| | | | | rarely showed the full trace. Also, increase performance considerably. | ||||
* | add NullResolver | David Chelimsky | 2010-05-02 | 2 | -0/+20 |
| | | | | | | [#4523 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | add tests for FixtureResolver | David Chelimsky | 2010-05-02 | 1 | -0/+18 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | move FixtureResolver to a file that is accessible outside Rails' own tests | David Chelimsky | 2010-05-02 | 3 | -5/+9 |
| | | | | | | [#4522 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Change event namespace ordering to most-significant first [#4504 state:resolved] | Justin George | 2010-05-02 | 7 | -15/+15 |
| | | | | | | | | | More work still needs to be done on some of these names (render_template.action_view and render_template!.action_view particularly) but this allows (for example) /^sql/ to subscribe to all the various ORMs without further modification Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Speed up I18n helpers in views and add entry to CHANGELOG. | José Valim | 2010-05-01 | 1 | -7/+3 |
| | |||||
* | Use %{} syntax in I18n (faster) instead of {{}}. | José Valim | 2010-05-01 | 2 | -17/+17 |
| | |||||
* | RouteSet does not raise ActionController::RoutingError when no routes match ↵ | Carl Lerche | 2010-04-30 | 4 | -18/+35 |
| | | | | anymore. Instead, it follows the X-Cascade convention. ShowExceptions checks for X-Cascade so that the routing error page can still be displayed. | ||||
* | Merge remote branch 'technoweenie/http_token_authentication' | Jeremy Kemper | 2010-04-30 | 4 | -0/+274 |
|\ | | | | | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
| * | add HTTP Token Authorization support to complement Basic and Digest ↵ | rick | 2010-04-30 | 3 | -0/+272 |
| | | | | | | | | Authorization. | ||||
* | | Merge branch 'master' of github.com:rails/rails | wycats | 2010-04-30 | 7 | -69/+152 |
|\| | |||||
| * | removing the extra assignment statement [#4432 state:resolved] | Neeraj Singh | 2010-04-30 | 1 | -1/+0 |
| | | | | | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
| * | Fix form builder and form helpers inconsistencies [#4432 state:resolved] | Neeraj Singh | 2010-04-29 | 3 | -64/+115 |
| | | | | | | | | | | | | | | | | * datetime_select and select_datetime should be consistent as much as possible * date_select and select_date should be consistent as much as possible * time_select and select_time should be consistent as much as possible Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
| * | ActionCachingTestController rescues from all exceptions. Making sure that ↵ | Neeraj Singh | 2010-04-29 | 2 | -1/+32 |
| | | | | | | | | | | | | all the tests check for valid response. [#4468 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
| * | Move several configuration values from Hash to ActiveSupport::XmlMini, which ↵ | José Valim | 2010-04-29 | 1 | -0/+2 |
| | | | | | | | | | | | | both Hash and Array depends on. Also, refactored ActiveModel serializers to just use ActiveSupport::XmlMini.to_tag. As consequence, if a serialized attribute is an array or a hash, it's not encoded as yaml, but as a hash or array. | ||||
| * | Fix prototype grep depending on JSON encoding regexp as JavaScript regexp | Jeremy Kemper | 2010-04-27 | 1 | -1/+1 |
| | | |||||
| * | Only run load hooks once a file has been fully loaded. | Nathan Weizenbaum | 2010-04-27 | 1 | -2/+2 |
| | | | | | | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | | Merge branch 'master' of github.com:rails/rails | wycats | 2010-04-26 | 31 | -356/+315 |
|\| | |||||
| * | Use Config::CONFIG['host_os'] instead of RUBY_PLATFORM [#4477 state:resolved] | Anil Wadghule | 2010-04-26 | 1 | -1/+2 |
| | | | | | | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
| * | extract ActionController::TestCase::Behavior | David Chelimsky | 2010-04-26 | 1 | -126/+133 |
| | | | | | | | | | | | | | | | | | | | | - this makes it possible for other test frameworks to hook into testing facilities provided by Rails without having to subclass AC::TestCase. [#4474 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
| * | Action Pack: fix tests with -K*, work around Ruby 1.9.1 constant lookup. | Cezary Baginski | 2010-04-25 | 2 | -4/+4 |
| | | | | | | | | | | | | [#4473 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
| * | allow unsubscribe by name or subscription [#4433 state:resolved] | David Chelimsky | 2010-04-24 | 1 | -0/+1 |
| | | | | | | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
| * | Missed commit: explicit source encoding | Jeremy Kemper | 2010-04-24 | 1 | -1/+1 |
| | |