| Commit message (Collapse) | Author | Age | Files | Lines |
|\ |
|
| | |
|
| | |
|
|\ \
| | |
| | | |
rafactored the regex related code in the mapper class
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
test_should_cache_with_trailing_slash_on_url
A trailing slash is removed when a page is cached.
What the test meant to say was : a url with trailing slash
should be cached and the cached page should not have any
trailing slash.
This patch clarifies the name a bit.
|
| | |
| | |
| | |
| | | |
string
|
| | |
| | |
| | |
| | | |
is already html_safe
|
|\ \ \
| | | |
| | | | |
remove unused UserController from test
|
| | | | |
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Secondly it seemed from the method that the intent was to test a case
where layout was declared in a symbol and the method named mention in
layout returns nil.
That case is already covered with class class WithSymbolReturningNil .
Also the case of SymbolReturningString is covered with the class
WithSymbol.
|
| | | |
|
| | |
| | |
| | |
| | | |
dont need a second option to turn that on
|
| | | |
|
|\ \ \
| | | |
| | | | |
Make escape_javascript happy to handle SafeBuffers
|
| | | |
| | | |
| | | |
| | | |
| | | | |
* see GH#1553
* allow for the fact that gsub on SafeBuffer does not pass match variables $1, $2 etc to a block
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
If before_filter list was being called mistakenly then
the test should fail. However test will not fail because
second filter is assigning new values to @list. To truly
test that first before_filter is not called when it should
not be called then @list should not assigned value unconditionally.
This patch will make the test fail if first filter is called.
|
|\ \ \
| | | |
| | | | |
test name should reflect the name of the method
|
| | | |
| | | |
| | | |
| | | | |
that is actually being called
|
|\ \ \ \
| | | | |
| | | | | |
remove unused class from test
|
| |/ / / |
|
|\ \ \ \
| |/ / /
|/| | | |
Fix ActionPack tests on `master`
|
| | | |
| | | |
| | | |
| | | | |
This was introduced in [2684f17a17e4f97bdb89d20b4cd08585235263a2] :bomb:
|
| | | |
| | | |
| | | |
| | | |
| | | | |
* Fix the problem on manipulating on the `ActiveSupport::SafeBuffer`
* Make sure that we run `escape_javascript` on the `String`, to avoid unexpected behavior.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
cloning before manipulation only on `OutputBuffer`.
After the fragment rendering, `Builder` returns the `String` object instead of `ActionView::OutputBuffer`. Somehow the same procedure which was in [823aa223efbac6ad4d31ea33402892267bb77cb4] does not play nice with the String, and result in the fragment got lost.
|
|\ \ \ \
| |/ / /
|/| | | |
Don't operate on the safebuffer, operate on a string and convert.
|
| | |/
| |/| |
|
| | | |
|
|/ /
| |
| |
| | |
safebuffer.
|
|/
|
| |
Fixes #1489
|
|
|
|
| |
and fixed helpers to work correctly in such case
|
|\
| |
| |
| |
| | |
Conflicts:
activerecord/RUNNING_UNIT_TESTS
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| | |
the same default route for both new and previously persisted records. The default path given in the example would have generated a routing error for new records. form_for actually uses polymorphic_path to determine which route to use based on the state of the record. The example has been updated to reflect the method's actual behavior.
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This commit restores the ability to assign cookies for testing via
@request.env['HTTP_COOKIE'] and @request.cookies, e.g:
@request.env['HTTP_COOKIE'] = 'user_name=david'
get :index
assert_equal 'david', cookies[:user_name]
and
@request.cookies[:user_name] = 'david'
get :index
assert_equal 'david', cookies[:user_name]
Assigning via cookies[] is the preferred method and will take precedence
over the other two methods. This is so that cookies set in controller
actions have precedence and are carried over between calls to get, post, etc.
|
| | |
|
|\ \
| | |
| | | |
sprockets gem update to beta9
|
| | | |
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Assigning cookies for test cases should now use cookies[], e.g:
cookies[:email] = 'user@example.com'
get :index
assert_equal 'user@example.com', cookies[:email]
To clear the cookies, use clear, e.g:
cookies.clear
get :index
assert_nil cookies[:email]
We now no longer write out HTTP_COOKIE and the cookie jar is
persistent between requests so if you need to manipulate the environment
for your test you need to do it before the cookie jar is created.
|
|\ \ \
| | | |
| | | | |
Fix creating an empty route on 1.8. Closes #1210
|