Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Fix brittle query string comparisons | Joshua Peek | 2009-10-17 | 1 | -7/+18 |
| | |||||
* | Fix standalone run of routing test. Only reference controllers that are ↵ | Joshua Peek | 2009-10-17 | 1 | -8/+8 |
| | | | | provided in fake_controllers | ||||
* | Stop using with_controllers in tests | Joshua Peek | 2009-10-17 | 1 | -96/+72 |
| | |||||
* | No longer need this special routing exception message because these kinds of ↵ | Joshua Peek | 2009-10-17 | 1 | -13/+0 |
| | | | | ambiguous generations are deprecated | ||||
* | Drop support for routing :generate_all | Joshua Peek | 2009-10-17 | 1 | -14/+0 |
| | |||||
* | Invalid route requirements should always raise an exception even if they are ↵ | Joshua Peek | 2009-10-17 | 1 | -8/+0 |
| | | | | unused | ||||
* | Merge branch 'master' into orchestra | Jeremy Kemper | 2009-10-15 | 5 | -7/+7 |
|\ | |||||
| * | Fix a few more 1.9 bugs. Rack 1.0.1 is required for 1.9 compliance but not ↵ | Yehuda Katz | 2009-10-15 | 1 | -1/+1 |
| | | | | | | | | release, so bundling 1.0.1 from git | ||||
| * | Rack responses need to wrap Strings in 1.9 | Yehuda Katz | 2009-10-15 | 1 | -1/+1 |
| | | |||||
| * | Update MetalTest for constant scoping change in 1.9 | Yehuda Katz | 2009-10-15 | 1 | -2/+2 |
| | | |||||
| * | Fix test to correctly handle 1.9 Array#to_s behavior | Yehuda Katz | 2009-10-15 | 1 | -1/+1 |
| | | |||||
| * | Work around apparent bug in 1.9 | Yehuda Katz | 2009-10-15 | 1 | -2/+2 |
| | | |||||
* | | Renamed Orchestra to Notifications once again [#3321 state:resolved] | José Valim | 2009-10-15 | 1 | -1/+1 |
| | | |||||
* | | Unify benchmark APIs. | José Valim | 2009-10-15 | 1 | -86/+0 |
| | | |||||
* | | Instrument cache store events only if required. | José Valim | 2009-10-15 | 1 | -1/+1 |
| | | |||||
* | | Update Orchestra instrumentations and move part of logging to Orchestra. | José Valim | 2009-10-15 | 1 | -8/+1 |
| | | |||||
* | | Revert "Rename Orchestra to Notifications [#3321 state:resolved]" | José Valim | 2009-10-15 | 1 | -2/+2 |
|/ | | | | This reverts commit 8cbf825425dc8ad3770881ea4e100b9023c69ce2. | ||||
* | Don't push siblings on load path if using bundled env | Jeremy Kemper | 2009-10-14 | 1 | -5/+8 |
| | |||||
* | Merge branch 'arel' | Jeremy Kemper | 2009-10-14 | 1 | -6/+10 |
|\ | |||||
| * | Clarify AR dependency | Jeremy Kemper | 2009-10-14 | 1 | -6/+10 |
| | | |||||
* | | Rename Orchestra to Notifications [#3321 state:resolved] | Joshua Peek | 2009-10-14 | 1 | -2/+2 |
|/ | |||||
* | Make IntegrationTest::Runner propagate method_missing to ancestors. | George Ogata | 2009-10-15 | 1 | -0/+18 |
| | | | | | | | Fixes RSpec integration example groups, which mixes its Matchers module into ActiveSupport::TestCase. Signed-off-by: Michael Koziarski <michael@koziarski.com> | ||||
* | Test cases should see all the cookies, not just cookies that have been set ↵ | Craig Smith | 2009-10-15 | 1 | -0/+17 |
| | | | | | | | | | | | | | in the controller. Previously this example would always pass, even when cookies.delete was not called. @request.cookies['foo'] = 'bar' get :delete_cookie assert_nil cookies['foo'] Signed-off-by: Michael Koziarski <michael@koziarski.com> [#2768 state:committed] | ||||
* | Make sure non-escaped urls aren't considered safe | Michael Koziarski | 2009-10-15 | 1 | -0/+5 |
| | |||||
* | ActionView.url_for doesn't escape by default | Phil Darnowsky | 2009-10-15 | 1 | -3/+13 |
| | | | | | | | | | | | | | | | | | ActionView::Helpers::UrlHelper#url_for used to escape the URLs it generated by default. This was most commonly seen when generating a path with multiple query parameters, e.g. url_for(:controller => :foo, :action => :bar, :this => 123, :that => 456) would return http://example.com/foo/bar?that=456&this=123 escaping an ampersand that shouldn't be escaped. This is both wrong and inconsistent with the behavior of ActionController#url_for, and is changed. Signed-off-by: Michael Koziarski <michael@koziarski.com> | ||||
* | Start adding configuration to ActionView instead of using constants. | Yehuda Katz | 2009-10-14 | 3 | -0/+16 |
| | | | | | | | By using config rather than hardcoded constants, we can evolve the configuration system over time (we'd just need to update the config method with more robust capabilities and all consumers would get the capabilities with no code changes) | ||||
* | CookieJar#delete should return the key's value, consistent with a Hash | Jeffrey Hardy | 2009-10-14 | 2 | -2/+9 |
| | | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | Kill mock routing assertion that tests router implementation | Joshua Peek | 2009-10-10 | 1 | -13/+0 |
| | |||||
* | Fix failing safe buffer test. We don't patch CGI.escapeHTML, only ERB:Util. | Joshua Peek | 2009-10-10 | 1 | -1/+1 |
| | |||||
* | Move safe buffer into test/template | Joshua Peek | 2009-10-10 | 1 | -0/+0 |
| | |||||
* | Relative url generations are covered more thoroughly by url rewriter tests | Joshua Peek | 2009-10-10 | 1 | -12/+0 |
| | |||||
* | Add define another "stuff" controller to support routing tests | Joshua Peek | 2009-10-10 | 1 | -0/+1 |
| | |||||
* | Drop implementation specific routing test assertions | Joshua Peek | 2009-10-10 | 1 | -3/+0 |
| | |||||
* | Add define a "stuff" controller in fixtures to support routing tests | Joshua Peek | 2009-10-10 | 1 | -0/+1 |
| | |||||
* | API change: content_tag_for outputs prefixed class name | Joshua Peek | 2009-10-08 | 1 | -1/+1 |
| | |||||
* | Switch to on-by-default XSS escaping for rails. | Michael Koziarski | 2009-10-08 | 12 | -6/+121 |
| | | | | | | | | | | | | This consists of: * String#html_safe! a method to mark a string as 'safe' * ActionView::SafeBuffer a string subclass which escapes anything unsafe which is concatenated to it * Calls to String#html_safe! throughout the rails helpers * a 'raw' helper which lets you concatenate trusted HTML from non-safety-aware sources (e.g. presantized strings in the DB) * New ERB implementation based on erubis which uses a SafeBuffer instead of a String Hat tip to Django for the inspiration. | ||||
* | Coerce all out going body parts to Strings | Joshua Peek | 2009-10-05 | 2 | -0/+41 |
| | |||||
* | Only draw default route once | Joshua Peek | 2009-10-03 | 1 | -22/+37 |
| | |||||
* | Use with_routing helper in tests instead of modifying global route set | Joshua Peek | 2009-10-03 | 4 | -101/+125 |
| | |||||
* | Redraw default routes on all internal integration tests. We don't need ↵ | Joshua Peek | 2009-10-03 | 15 | -41/+34 |
| | | | | SimpleRouteCase anymore | ||||
* | Avoid creating new controller constants during test runtime. All routable ↵ | Joshua Peek | 2009-10-03 | 2 | -68/+21 |
| | | | | controllers should be defined beforehand. | ||||
* | Moved shared form helper models into fake_models | Joshua Peek | 2009-10-03 | 3 | -99/+98 |
| | |||||
* | Changing directories during the test breaks file loading when ran by itself | Joshua Peek | 2009-10-03 | 2 | -32/+22 |
| | |||||
* | Don't load rubygems for isolated tests | Joshua Peek | 2009-10-03 | 1 | -2/+3 |
| | |||||
* | Move improved isolated test runner to AP | Joshua Peek | 2009-10-03 | 1 | -0/+16 |
| | |||||
* | File extra test folders into controller, dispatch, or template | Joshua Peek | 2009-10-03 | 25 | -17/+16 |
| | |||||
* | Add custom "with_routing" to internal tests to fix reseting session after using | Joshua Peek | 2009-10-03 | 14 | -20/+30 |
| | | | | with_routing. This only affects our internal AP tests. | ||||
* | Ported the new ActionView::TestCase from 2-3-stable to master [#3260 | Erik Ostrom | 2009-09-28 | 4 | -11/+175 |
| | | | | | | | | | | | | | | | | | state:resolved] The test case now mimicks the template environment more closely, so it's possible to use render, load helper dependencies. This also fixes assert_select, and similar assertions. Because view tests and helpers generally don't render full templates assert_select looks first in rendered and then in output_buffer to find the rendered output. Additional `master'-only changes: Made the Action Pack Rakefile run the ActionView::TestCase tests, and made ActionView::Rendering#_render_text always return a string. Signed-off-by: Joshua Peek <josh@joshpeek.com> | ||||
* | Introduce :almost keyword for distance_of_time_in_words. Make 1.75 days - 2 ↵ | John Trupiano | 2009-09-28 | 2 | -21/+37 |
| | | | | | | | days return '2 days'. Signed-off-by: Michael Koziarski <michael@koziarski.com> [#3266 state:committed] | ||||
* | Enhancing distance_of_time_in_words to prefix year output with over and ↵ | Jay Pignata | 2009-09-28 | 1 | -7/+8 |
| | | | | | | | about depending upon how many months have elapsed Signed-off-by: Michael Koziarski <michael@koziarski.com> [#3106 state:committed] |