aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/test
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | | pull up the "options.delete(:controller)" logicAaron Patterson2015-08-111-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | we want to try to pull this logic up to where the user actually passed in "controller" so that it's close to the related call. That way when we're down the stack, we don't need to wonder "why are we doing this?"
* | | | | Refactor route assertion methods in resources testeileencodes2015-08-081-50/+51
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The tests and methods were hard to read with `options[:options]` all over the place. This refactoring makes the code easier to understand. The change came out of work for moving the underlying code of controller tests to integraiton tests.
* | | | | Merge pull request #11352 from xaviershay/dispatcher-apiRafael Mendonça França2015-08-083-17/+14
|\ \ \ \ \ | | | | | | | | | | | | Allow a custom dispatcher to be provided to routing.
| * | | | | Allow a custom dispatcher to be provided to routing.Xavier Shay2015-08-073-17/+14
| | | | | |
* | | | | | Fix deprecation warning in testseileencodes2015-08-081-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Using the string version of the class reference is now deprecated when referencing middleware. This should be written as a class not as a string. Deprecation warning that this change fixes: ``` DEPRECATION WARNING: Passing strings or symbols to the middleware builder is deprecated, please change them to actual class references. For example: "ActionDispatch::ShowExceptions" => ActionDispatch::ShowExceptions ```
* | | | | | Refactor to remove DrawOnce moduleeileencodes2015-08-081-27/+8
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | We were doing extra work that could be pushed off to Integration test and SharedRoutes. Creating an extra module isn't necessary when those are created by their respective classes.
* | | | | remove vestigial codeAaron Patterson2015-08-071-43/+0
| | | | | | | | | | | | | | | | | | | | | | | | | Looks like this was left over from converting Rails to Rack. I think it's safe to remove now.
* | | | | finish deprecating handling strings and symbolsAaron Patterson2015-08-075-61/+20
| | | | | | | | | | | | | | | | | | | | | | | | | since we only work with instances of classes, it greatly simplifies the `Middleware` implementation.
* | | | | Using strings or symbols for middleware class names is deprecated.Aaron Patterson2015-08-073-30/+26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Convert things like this: middleware.use "Foo::Bar" to this: middleware.use Foo::Bar
* | | | | simplify the Middleware constructorAaron Patterson2015-08-071-39/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We should do the hard work outside the constructor. Also fix the tests to not directly construct middleware objects, but to go through the stack object.
* | | | | do not add common ports to HTTP_HOSTMichael Grosser2015-08-061-0/+19
| | | | | | | | | | | | | | | | | | | | | | | | | - webservers do not do it - it makes redirect urls ugly when request.host is used for redirection
* | | | | ExceptionWrapper doesn't need to know about `env`Aaron Patterson2015-08-061-17/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ExceptionWrapper only cares about the backtrace cleaner, so lets just pass the cleaner to the wrapper. It does not need to know that env exists or what key the backtrace cleaner is stored in
* | | | | use a request object to reduce string allocations and not know about ENV keysAaron Patterson2015-08-061-1/+1
| | | | |
* | | | | Merge pull request #21131 from eagletmt/percent-filenameRafael Mendonça França2015-08-062-0/+21
|\ \ \ \ \ | | | | | | | | | | | | Fix Encoding::UndefinedConversionError with multibyte UTF-8 filename containing "%" character
| * | | | | Add failing spec on utf8 filename with percent characterKohei Suzuki2015-08-042-0/+21
| |/ / / /
* / / / / Adds missing argument handling for ActionController::TestSession toMatthew Gerrior2015-08-061-0/+10
|/ / / / | | | | | | | | | | | | allow testing controllers that use session#fetch with a default value.
* / / / Add missing assertion for test_route_with_colon_firstAditya Kapoor2015-08-031-2/+4
|/ / /
* | | Merge pull request #20590 from vngrs/set_default_charsetRafael Mendonça França2015-07-271-0/+7
|\ \ \ | | | | | | | | Document, refactor and create test case for ActionDispatch::Response
| * | | Document, refactor and create test case for ↵Mehmet Emin İNAÇ2015-06-171-0/+7
| | | | | | | | | | | | | | | | ActionDispatch::Response#charset= method
* | | | Fix state being carried over from previous transactionRoque Pinel2015-07-201-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This clears the transaction record state when the transaction finishes with a `:committed` status. Considering the following example where `name` is a required attribute. Before we had `new_record?` returning `true` for a persisted record: ```ruby author = Author.create! name: 'foo' author.name = nil author.save # => false author.new_record? # => true ```
* | | | Fix exception overwritten for parameters fetch methodRoque Pinel2015-07-181-0/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When executing an `ActionController::Parameters#fetch` with a block that raises a `KeyError` the raised `KeyError` will be rescued and converted to an `ActionController::ParameterMissing` exception, covering up the original exception. [Jonas Schubert Erlandsson & Roque Pinel]
* | | | Stop using deprecated `render :text` in testPrem Sichanugrist2015-07-1732-215/+215
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This will silence deprecation warnings. Most of the test can be changed from `render :text` to render `:plain` or `render :body` right away. However, there are some tests that needed to be fixed by hand as they actually assert the default Content-Type returned from `render :body`.
* | | | Add deprecation warning for `render :text`Prem Sichanugrist2015-07-171-11/+42
| | | | | | | | | | | | | | | | | | | | | | | | We've started on discouraging the usage of `render :text` in #12374. This is a follow-up commit to make sure that we print out the deprecation warning.
* | | | Skip a few failing tests on JRuby with the attached ticketsRobin Dupret2015-07-173-0/+8
| | | |
* | | | Make AC::Parameters not inherited from HashPrem Sichanugrist2015-07-156-7/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is another take at #14384 as we decided to wait until `master` is targeting Rails 5.0. This commit is implementation-complete, as it guarantees that all the public methods on the hash-inherited Parameters are still working (based on test case). We can decide to follow-up later if we want to remove some methods out from Parameters.
* | | | Merge pull request #20866 from jdantonio/countdown-latchAaron Patterson2015-07-142-21/+21
|\ \ \ \ | | | | | | | | | | Replace `ActiveSupport::Concurrency::Latch` with `Concurrent::CountDownLatch` from concurrent-ruby.
| * | | | Replaced `ActiveSupport::Concurrency::Latch` with concurrent-ruby.Jerry D'Antonio2015-07-132-21/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The concurrent-ruby gem is a toolset containing many concurrency utilities. Many of these utilities include runtime-specific optimizations when possible. Rather than clutter the Rails codebase with concurrency utilities separate from the core task, such tools can be superseded by similar tools in the more specialized gem. This commit replaces `ActiveSupport::Concurrency::Latch` with `Concurrent::CountDownLatch`, which is functionally equivalent.
* | | | | Merge pull request #20877 from sikachu/rename-ac-test_responseRafael Mendonça França2015-07-141-1/+1
|\ \ \ \ \ | | | | | | | | | | | | Change AC::TestResponse to AD::TestResponse
| * | | | | Change AC::TestResponse to AD::TestResponsePrem Sichanugrist2015-07-141-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ActionController::TestResponse was removed in d9fe10c and caused a test failure on Action View as its test case still refers to it.
* | | | | | only call methods that are on the superclassAaron Patterson2015-07-143-7/+6
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | We want to treat the response object as if it's a real response object (not a test object), so we should only call methods that are on the superclass.
* | | | | use a lookup table for `assert_response`Aaron Patterson2015-07-131-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We shouldn't depend on specific methods imlemented in the TestResponse subclass because the response could actually be a real response object. In the future, we should either push the aliased predicate methods in TestResponse up to the real response object, or remove them
* | | | | only have one TestResponse classAaron Patterson2015-07-131-1/+1
|/ / / /
* | | | use `Rack::Test::UploadedFile` when uploading filesAaron Patterson2015-07-091-2/+2
| | | | | | | | | | | | | | | | | | | | We should use rack-test's upload file objects on the test side so that we will be able to correctly generate mime blob posts in the future
* | | | set parameters as a query stringAaron Patterson2015-07-091-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | We should convert request parameters to a query string, then let the request object parse that query string. This should give us results that are more similar to the real-world
* | | | use JSON to communicate between the controller and the testsAaron Patterson2015-07-091-12/+12
| | | |
* | | | build and assign parameters rather than rely on mutationsAaron Patterson2015-07-081-3/+3
| | | | | | | | | | | | | | | | | | | | We should assign parameters to the request object rather than mutate the hash that is returned by `query_parameters` or `request_parameters`
* | | | request objects are no longer recycledAaron Patterson2015-07-081-6/+0
| | | | | | | | | | | | | | | | | | | | | | | | Instead of trying to manually clear out a request object, lets just allocate a new one. The rack ENV is reused and cleaned (still), but the request object is not.
* | | | pass the variant as a parameter to more reflect real world appsAaron Patterson2015-07-081-3/+3
| | | |
* | | | add a new constructor for allocating test requestsAaron Patterson2015-07-081-9/+9
| | | |
* | | | make `env` a required parameterAaron Patterson2015-07-081-6/+6
| | | |
* | | | remove call to build_requestAaron Patterson2015-07-081-1/+0
| | | |
* | | | let the superclass build the request and responseAaron Patterson2015-07-0810-47/+13
| | | | | | | | | | | | | | | | | | | | We should leverage the request / response objects that the superclass has already allocated for us.
* | | | pass variants in rather than mutating the request.Aaron Patterson2015-07-071-48/+31
| | | | | | | | | | | | | | | | | | | | | | | | Variants are typically set in the controller based on some attribute of the request that the browser sent. We should make our tests more in line with reality by doing the same and not mutating the request object.
* | | | pass cookies from the jar in the HTTP_COOKIE headereileencodes2015-07-071-2/+0
| | | | | | | | | | | | | | | | | | | | we should be pushing the cookies in via headers rather than maintaining some object and "recycling" it.
* | | | Merge pull request #13897 from gmalette/nested-parameter-filtering-2Arthur Nogueira Neves2015-07-061-0/+1
|\ \ \ \ | | | | | | | | | | Allow filtering params based on parent keys
| * | | | Allow filtering params based on parent keysGuillaume Malette2015-06-221-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add the possibility to only filter parameters based on their full path instead of relying on the immediate key. config.filter_parameters += ['credit_card.code'] { 'credit_card' => { 'code' => '[FILTERED]' }, 'source' => { 'code' => '<%= puts 5 %>' } }
* | | | | Fix the random caching test failure.Kasper Timm Hansen2015-07-051-0/+1
| | | | |
* | | | | Improve error messages in cookies_testeileencodes2015-06-271-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Using `assert_predicate` and `assert_match` instead of just `assert` is preferrable because better error messages are output. In the case of `assert response.cookies.empty?` the error message was `Failed assertion, no message given.` but now with `assert_predicate` it will be `Expected {"user_name"=>"david"} to be empty?.` For `assert_match(/user_name=david/, response.headers["Set-Cookie"])` as well, the message returned was unhelpful - `Failed assertion, no message given.` but now will tell what was expected and what was returned with `Expected /user_name=david/ to match "user_name=nope; path=/".`
* | | | | Merge pull request #20276 from davetron5000/revert-head-on-no-templateKasper Timm Hansen2015-06-271-0/+21
|\ \ \ \ \ | | | | | | | | | | | | Allow default_render to take a block to customize behavior when there's no template
| * | | | | Override default_render's behavior with a blockDave Copeland2015-06-201-0/+21
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In 0de4a23 the behavior when there is a missing template was changed to not raise an error, but instead head :no_content. This is a breaking change and some gems rely on this happening. To allow gems and other code to work around this, allow `default_render` to take a block which, if provided, will execute the contents of that block instead of doing the `head :no_content`.
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-18 03:33:15 +0000