| Commit message (Collapse) | Author | Age | Files | Lines | ||
|---|---|---|---|---|---|---|
| ... | ||||||
| * | | rack SPEC doesn't allow `first` on the body | Aaron Patterson | 2015-08-25 | 1 | -8/+12 | |
| | | | | | | | | | collect the body and make assert against the collected body | |||||
| * | | adding a direct dispatch method to controller classes | Aaron Patterson | 2015-08-25 | 1 | -8/+2 | |
| | | | | | | | | | This saves a lambda and request allocation on each request. | |||||
| * | | Merge pull request #21368 from rodzyn/remove_mocha | Kasper Timm Hansen | 2015-08-25 | 5 | -163/+209 | |
| |\ \ | | | | | | | Get rid of mocha tests in actionpack - part 2 | |||||
| | * | | Get rid of mocha tests - part 2 | Marcin Olichwirowicz | 2015-08-25 | 5 | -163/+209 | |
| | | | | ||||||
| * | | | Merge pull request #21366 from amitsuroliya/remove_unused_variable | Rafael Mendonça França | 2015-08-25 | 2 | -13/+13 | |
| |\ \ \ | | | | | | | | | Remove more unused block arguments | |||||
| | * | | | Remove more unused block arguments | amitkumarsuroliya | 2015-08-25 | 2 | -13/+13 | |
| | | | | | ||||||
| * | | | | Merge pull request #21345 from aditya-kapoor/trim-ap | Rafael Mendonça França | 2015-08-25 | 2 | -6/+4 | |
| |\ \ \ \ | |/ / / |/| | | | Trim out least needed controllers from AP test suite | |||||
| | * | | | Trim out unneeded controllers from AP test suite | Aditya Kapoor | 2015-08-24 | 2 | -6/+4 | |
| | | | | | ||||||
| * | | | | Merge pull request #21094 from aditya-kapoor/add-missing-ap-tests | Rafael Mendonça França | 2015-08-25 | 1 | -0/+10 | |
| |\ \ \ \ | | | | | | | | | | | add missing test for action regexp for routing | |||||
| | * | | | | add missing tests for action regexp | Aditya Kapoor | 2015-08-02 | 1 | -0/+10 | |
| | | | | | | ||||||
| * | | | | | Remove unused block arguments | Anshul Sharma | 2015-08-25 | 1 | -1/+1 | |
| | | | | | | ||||||
| * | | | | | remove more direct `env` mutations | Aaron Patterson | 2015-08-24 | 1 | -1/+1 | |
| | | | | | | ||||||
| * | | | | | remove dead code :bomb: | Aaron Patterson | 2015-08-24 | 1 | -2/+0 | |
| | | | | | | ||||||
| * | | | | | use `make_set` helper method to generate route sets | Aaron Patterson | 2015-08-24 | 1 | -31/+1 | |
| | | | | | | | | | | | | | | | | | | | | | We should keep the route set generation logic in one place | |||||
| * | | | | | subclass and delegate rather than mutating existing objects | Aaron Patterson | 2015-08-24 | 1 | -12/+29 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | If we subclass and augment the superclass, then we don't need to have setters for particular things on the superclass. | |||||
| * | | | | | temp files are no more require | Gaurav Sharma | 2015-08-25 | 1 | -1/+0 | |
| | | | | | | | | | | | | | | | | `:nail_care:` | |||||
| * | | | | | use a custom request class to determine the controller class | Aaron Patterson | 2015-08-24 | 1 | -23/+21 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | controller class resolution has been moved to the request object, so we should override that method instead of relying on the RouteSet to generate the controller class. | |||||
| * | | | | | Merge pull request #21355 from akihiro17/remove-variables | Rafael Mendonça França | 2015-08-24 | 1 | -2/+2 | |
| |\ \ \ \ \ | |_|_|/ / |/| | | | | Remove unused variables | |||||
| | * | | | | Remove unused variables | akihiro17 | 2015-08-24 | 1 | -2/+2 | |
| | | |/ / | |/| | | ||||||
| * | | | | Merge pull request #21321 from rodzyn/removing_mocha | Kasper Timm Hansen | 2015-08-24 | 10 | -78/+103 | |
| |\ \ \ \ | |/ / / |/| | | | Get rid of mocha tests in actionpack - part 1 | |||||
| | * | | | Get rid of mocha tests - part 1 | Marcin Olichwirowicz | 2015-08-24 | 10 | -78/+103 | |
| | | | | | ||||||
| * | | | | use a request object in the session middleware | Aaron Patterson | 2015-08-22 | 2 | -22/+24 | |
| | | | | | | | | | | | | | | | | | | | | | This commit allows us to use one request object rather than allocating multiple request objects to deal with the session. | |||||
| * | | | | Refactor to remove controller class from route to request | eileencodes | 2015-08-22 | 1 | -1/+1 | |
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | This refactoring moves the controller class name that was on the route set to the request. The purpose of this refactoring is for changes we need to move controller tests to integration tests, mainly being able to access the controller on the request instead of having to go through the router. [Eileen M. Uchitelle & Aaron Patterson] | |||||
| * | | | pass a request object to the headers object | Aaron Patterson | 2015-08-21 | 1 | -1/+1 | |
| | | | | ||||||
| * | | | move header allocation to a helper method | Aaron Patterson | 2015-08-21 | 1 | -5/+9 | |
| | | | | | | | | | | | | | | | | I'm going to change the constructor, so it's easier to do it in one place. | |||||
| * | | | Merge pull request #21106 from amitsuroliya/fix_routing_test | Andrew White | 2015-08-21 | 1 | -6/+0 | |
| |\ \ \ | | | | | | | | | Remove duplicity in tests | |||||
| | * | | | Remove duplicity in tests | amitkumarsuroliya | 2015-08-03 | 1 | -6/+0 | |
| | |/ / | ||||||
| * | | | point at rack master | Aaron Patterson | 2015-08-20 | 1 | -1/+1 | |
| | | | | ||||||
| * | | | make the routes reader private | Aaron Patterson | 2015-08-18 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | nobody should be touching the routes hash without going through the NamedRouteCollection object. | |||||
| * | | | symbols will always be constructed with strings. :bomb: | Aaron Patterson | 2015-08-18 | 1 | -1/+1 | |
| | | | | ||||||
| * | | | test the verb method on the route, specifically | Aaron Patterson | 2015-08-17 | 1 | -1/+1 | |
| | | | | ||||||
| * | | | routes are always constructed with a hash for the conditions | Aaron Patterson | 2015-08-17 | 3 | -4/+4 | |
| | | | | ||||||
| * | | | introduce an alternate constructor for Route objects | Aaron Patterson | 2015-08-17 | 1 | -12/+12 | |
| | | | | | | | | | | | | | | | | I want to change the real constructor to take a particular parameter for matching the request method | |||||
| * | | | default pattern to use a joined string | Aaron Patterson | 2015-08-17 | 2 | -13/+15 | |
| | | | | | | | | | | | | | | | | The string we create is almost always the same, so rather than joining all the time, lets join once, then reuse that string everywhere. | |||||
| * | | | use the mapper to build the routing table | Aaron Patterson | 2015-08-15 | 2 | -231/+103 | |
| | | | | | | | | | | | | | | | | | | | We should build the routes using the user facing API which is `Mapper`. This frees up the library internals to change as we see fit. IOW we shouldn't be testing internals. | |||||
| * | | | only keep one hash of named routes | Aaron Patterson | 2015-08-14 | 2 | -13/+14 | |
| | | | | | | | | | | | | | | | | The outer router object already keeps a hash of named routes, so we should just use that. | |||||
| * | | | rm add_route2 | Aaron Patterson | 2015-08-14 | 2 | -41/+51 | |
| | | | | | | | | | | | | | | | | refactor the tests with a backwards compatible method call so we can rm add_route2 from the journey router | |||||
| * | | | pass pass the mapping object down the add_route stack | Aaron Patterson | 2015-08-14 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | then we can let the mapping object derive stuff that the Route object needs. | |||||
| * | | | pass the mapping object to build_route | Aaron Patterson | 2015-08-14 | 1 | -16/+5 | |
| | | | | | | | | | | | | | | | | now that we aren't doing options manipulations, we can just pass the mapping object down and read values from it. | |||||
| * | | | deprecate passing a string for both the beginning path and :path option | Aaron Patterson | 2015-08-14 | 1 | -1/+4 | |
| | | | | ||||||
| * | | | pass the path ast down | Aaron Patterson | 2015-08-14 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | now we don't need to add it to a hash and delete it from the hash later just to pass it around | |||||
| * | | | pull up path parsing | Aaron Patterson | 2015-08-14 | 1 | -1/+2 | |
| | | | | | | | | | | | | | | | | `add_route` needs the AST, so rather than shove it in a hash and delete later, lets move parsing up the stack so we can pass down later | |||||
| * | | | use predicate methods instead of hard coding verb strings | Aaron Patterson | 2015-08-14 | 2 | -6/+6 | |
| | | | | | | | | | | | | | | | | also change the feeler to subclass AD::Request so that it has all the methods that Request has | |||||
| * | | | implement `requirements` in terms of routes | Aaron Patterson | 2015-08-14 | 1 | -1/+1 | |
| | | | | ||||||
| * | | | implement the `asts` method in terms of paths / patterns | Aaron Patterson | 2015-08-14 | 1 | -12/+11 | |
| | | | | | | | | | | | | | Eventually I want to eliminate the FakeSet test class | |||||
| * | | | extract ast finding to a method | Aaron Patterson | 2015-08-14 | 1 | -9/+13 | |
| | | | | | | | | | | | | | | | | I'm going to reimplement this using route objects, so it will be easier if we just change ast access to go through a method rather than hashes | |||||
| * | | | stop adding path_info to the conditions hash | Aaron Patterson | 2015-08-14 | 1 | -9/+9 | |
| | | | | | | | | | | | | | we don't need to keep adding it and deleting if from hashes. | |||||
| * | | | remove Strexp | Aaron Patterson | 2015-08-13 | 4 | -74/+61 | |
| | | | | | | | | | | | | | | | | This was a useless object. We can just directly construct a Path::Pattern object without a Strexp object. | |||||
| * | | | pass anchor directly to `Pattern` | Aaron Patterson | 2015-08-13 | 4 | -39/+38 | |
| | | | | | | | | | | | | | | | | the caller already has it, there is no reason to pack it in to an object and just throw that object away. | |||||
| * | | | pull up options_constrants extraction | Aaron Patterson | 2015-08-13 | 1 | -1/+1 | |
| | | | | ||||||
 |
index : rails.git | |
| Mirror of official rails repo with custom fixes. | Harald Eilertsen |
| aboutsummaryrefslogtreecommitdiffstats |