Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | | Revert "Merge pull request #20584 from arthurnn/fix_url" | Arthur Neves | 2015-06-17 | 1 | -7/+0 | |
| | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 0b3397872582f2cf1bc6960960a6393f477c55e6, reversing changes made to 56d52e3749180e6c1dcf7166adbad967470aa78b. As pointed out on the PR, this will hide development mistakes too, which is not ideal. | |||||
* | | | Catch InvalidURIError on bad paths on redirect. | Arthur Neves | 2015-06-16 | 1 | -0/+7 | |
| |/ |/| | | | | | | | Handle URI::InvalidURIError errors on the redirect route method, so it wont raise a 500 if a bad path is given. | |||||
* | | remove `header=` on the response object. | Aaron Patterson | 2015-06-15 | 1 | -0/+2 | |
| | | | | | | | | | | | | People should be free to mutate the header object, but not to set a new header object. That header object may be specific to the webserver, and we need to hide it's internals. | |||||
* | | Deprecate passing hash as first parameter into ActionController::Head | Mehmet Emin İNAÇ | 2015-06-15 | 3 | -10/+31 | |
| | | ||||||
* | | Fix flakyness. | Kasper Timm Hansen | 2015-06-15 | 1 | -0/+1 | |
| | | | | | | | | Brought on by my own stupidity :) | |||||
* | | ActionDispatch::SSL should keep original header's behavior | Fumiaki MATSUSHIMA | 2015-06-14 | 1 | -0/+11 | |
| | | | | | | | | | | | | `ActionDispatch::SSL` changes headers to `Hash`. So some headers will be broken if there are some middlewares on ActionDispatch::SSL and if it uses `Rack::Utils::HeaderHash`. | |||||
* | | Return 204 if render is not called in API controllers | Jorge Bejar | 2015-06-11 | 1 | -0/+15 | |
| | | ||||||
* | | Add test coverage for implicit render in empty actions | Jorge Bejar | 2015-06-11 | 1 | -0/+14 | |
| | | ||||||
* | | Include ParamsWrapper in AC::API | Jorge Bejar | 2015-06-11 | 1 | -0/+26 | |
| | | | | | | | | | | | | | | | | | | ParamsWrapper was initially removed from API controllers according to the following discusision: https://github.com/rails-api/rails-api/issues/33 However, we're including it again so Rails API devs can decide whether to enable or disable it. | |||||
* | | Rename test methods in api conditional get controller tests | Jorge Bejar | 2015-06-11 | 1 | -2/+2 | |
| | | ||||||
* | | Routes resources avoid :new and :edit endpoints if api_only is enabled | Jorge Bejar | 2015-06-11 | 1 | -0/+75 | |
| | | ||||||
* | | Remove extra whitespaces | Santiago Pastorino | 2015-06-11 | 1 | -1/+1 | |
| | | ||||||
* | | Use new hash syntax | Santiago Pastorino | 2015-06-11 | 2 | -7/+7 | |
| | | ||||||
* | | Remove Unneeded ApiPublicExceptions middleware, PublicExceptions already ↵ | Santiago Pastorino | 2015-06-11 | 1 | -37/+0 | |
| | | | | | | | | does the work | |||||
* | | Use nex hash syntax on tests | Santiago Pastorino | 2015-06-11 | 1 | -5/+5 | |
| | | ||||||
* | | Add ApiPublicException middleware | Santiago Pastorino | 2015-06-11 | 1 | -2/+39 | |
| | | ||||||
* | | Move Model test class inside RenderersApiController namespace | Santiago Pastorino | 2015-06-11 | 1 | -8/+8 | |
| | | ||||||
* | | Add ActionController API functionality | Santiago Pastorino | 2015-06-11 | 7 | -0/+184 | |
| | | ||||||
* | | Change the `index` arg of `ActionDispatch::Static#new` to a kwarg | Yuki Nishijima | 2015-06-11 | 1 | -1/+1 | |
| | | ||||||
* | | extract required_defaults from the conditions hash before constructing the route | Aaron Patterson | 2015-06-08 | 3 | -48/+48 | |
| | | | | | | | | | | this way we can remove the strange "respond_to?" conditional in the `matches?` loop | |||||
* | | Merge pull request #19094 from phoet/have_bearer_be_valid_as_well | Rafael Mendonça França | 2015-06-01 | 1 | -1/+8 | |
|\ \ | | | | | | | Have Bearer be valid as well | |||||
| * | | allow `Bearer` as well as `Token` | phoet | 2015-06-01 | 1 | -0/+7 | |
| | | | ||||||
| * | | actually test what the name says | phoet | 2015-06-01 | 1 | -1/+1 | |
| | | | ||||||
* | | | Merge pull request #20138 from tgxworld/deprecated_assert_template | Rafael Mendonça França | 2015-06-01 | 11 | -492/+101 | |
|\ \ \ | | | | | | | | | Deprecate `assert_template` and `assigns()`. | |||||
| * | | | Remove `assigns` and `assert_template`. | Guo Xiang Tan | 2015-05-30 | 11 | -492/+101 | |
| |/ / | ||||||
* | | | Merge pull request #20284 from kaspth/fix-caching-test | Rafael Mendonça França | 2015-06-01 | 3 | -3/+9 | |
|\ \ \ | |/ / |/| | | Move expectation to instance level. | |||||
| * | | Replace expectation with state check. | Kasper Timm Hansen | 2015-05-30 | 3 | -3/+9 | |
| | | | | | | | | | | | | The tests would still pass if the cache call in the rendered templates were removed. | |||||
* | | | Fix warning about ambiguous first argument | Arun Agrawal | 2015-05-29 | 1 | -1/+1 | |
| | | | ||||||
* | | | Merge pull request #20017 from eliotsykes/configurable-static-index-filename | Rafael Mendonça França | 2015-05-28 | 5 | -0/+18 | |
|\ \ \ | | | | | | | | | | | | | config.static_index configures directory Index "index.html" filename | |||||
| * | | | config.static_index configures directory index "index.html" filename | Eliot Sykes | 2015-05-28 | 5 | -0/+18 | |
| | | | | | | | | | | | | | | | | | | | | | | | | Set `config.static_index` to serve a static directory index file not named `index`. For example, to serve `main.html` instead of `index.html` for directory requests, set `config.static_index` to `"main"`. | |||||
* | | | | Deprecate `:nothing` option for render method | Mehmet Emin İNAÇ | 2015-05-28 | 8 | -13/+23 | |
|/ / / | | | | | | | | | | `head` method works similar to `render` method with `:nothing` option | |||||
* | | | Merge pull request #19808 from byroot/action-parameter | Rafael Mendonça França | 2015-05-27 | 1 | -0/+20 | |
|\ \ \ | | | | | | | | | [PoC] Stop shadowing parameters named `action` | |||||
| * | | | Allow to parameters named `action` or `controller` from AC::TestCase helpers | Jean Boussier | 2015-04-18 | 1 | -0/+20 | |
| | | | | ||||||
* | | | | Add assertion for get? method into test cases | Mehmet Emin İNAÇ | 2015-05-27 | 1 | -0/+1 | |
| | | | | ||||||
* | | | | Merge pull request #17788 from sivagollapalli/master | Arthur Nogueira Neves | 2015-05-20 | 1 | -0/+5 | |
|\ \ \ \ | | | | | | | | | | | Issue#17703 Test case for tempfile attribute | |||||
| * | | | | Issue#17703 Test case for tempfile attribute | Siva Gollapalli | 2015-04-16 | 1 | -0/+5 | |
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | + To avoid regression I am adding this test case on action pack Changed to assert from assert_equal + Added msg to assertion Modified msg | |||||
* | | | | Prefer assert_not over refute | Rafael Mendonça França | 2015-05-18 | 2 | -2/+2 | |
| | | | | ||||||
* | | | | ActionDispatch::Journey::Routes#empty? test cases | Valentine Valyaeff | 2015-05-19 | 2 | -0/+16 | |
| |/ / |/| | | ||||||
* | | | Silence ambiguous first argument warning | Prem Sichanugrist | 2015-05-04 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | | | | | | This silences: actionpack/test/journey/route_test.rb:33: warning: ambiguous first argument; put parentheses or a space even after `/' operator | |||||
* | | | Give authentication methods the ability to customize response message. | Keenan Brock | 2015-05-03 | 2 | -6/+6 | |
| | | | | | | | | | | | | Digest allowed the messages. Add the same feature to basic and token | |||||
* | | | Merge pull request #18392 from brainopia/fix_route_requirements | Arthur Nogueira Neves | 2015-04-27 | 1 | -0/+8 | |
|\ \ \ | | | | | | | | | Correct route requirements by overriding defaultls | |||||
| * | | | Correct route requirements by overriding defaultls (fixes #18373) | brainopia | 2015-01-08 | 1 | -0/+8 | |
| | | | | ||||||
* | | | | Merge pull request #19904 from zzak/rm_route_wrapper_internal_hacks | Rafael Mendonça França | 2015-04-26 | 1 | -0/+16 | |
|\ \ \ \ | | | | | | | | | | | Rm route wrapper internal hacks | |||||
| * | | | | Fix rake routes for api apps | Jorge Bejar | 2015-04-25 | 1 | -0/+16 | |
| | | | | | | | | | | | | | | | | | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | |||||
* | | | | | Removed unused code from request_forgery_protection tests | Prathamesh Sonpatki | 2015-04-26 | 1 | -17/+0 | |
|/ / / / | ||||||
* | | | | Why do we add a top-level constant here? | Akira Matsuda | 2015-04-25 | 1 | -5/+3 | |
| | | | | ||||||
* | | | | Remove unused WorkshopsController class in redirect_test. | Bryce Boe | 2015-04-23 | 1 | -3/+0 | |
| |/ / |/| | | ||||||
* | | | Merge pull request #19736 from kmcphillips/master | Rafael Mendonça França | 2015-04-14 | 1 | -0/+17 | |
|\ \ \ | | | | | | | | | Set default form builder for a controller | |||||
| * | | | Override default form builder for a controller | Kevin McPhillips | 2015-04-13 | 1 | -0/+17 | |
| | | | | ||||||
* | | | | Use `silence_warnings` on `StaticTests` | eileencodes | 2015-04-14 | 1 | -6/+12 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When 7e504927 was merged setting `Encoding.default_internal` and `Encoding.default_external` would throw a warning when the ActionPack tests were run. Example warning: `actionpack/test/dispatch/static_test.rb:12: warning: setting Encoding.default_external` This patch silences the warnings as other similar tests do for setting default_internal and default_external. |