| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|/ / / |
|
|\ \ \
| | | |
| | | | |
multipart POST - utf8 param name not encoded
|
| | | | |
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The env hash passed to `Http::Headers#new` must be in env format.
Also be aware that the passed hash is modified directly.
docs and test-cases for setting headers/env in functional tests.
Follow up to #9700.
|
| | |
| | |
| | |
| | | |
stale on live streams(issue #9636)
|
| | | |
|
| | |
| | |
| | |
| | | |
Closes #6513.
|
| | |
| | |
| | |
| | |
| | | |
Also:
cleanup, use consistent syntax for `Http::Header` and test.
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
If an explicit name has been given and it already ends with "[]"
Before:
select(:category, [], {}, multiple: true, name: "post[category][]")
# => <select name="post[category][][]" ...>
After:
select(:category, [], {}, multiple: true, name: "post[category][]")
# => <select name="post[category][]" ...>
|
| | | |
|
|\ \ \
| | | |
| | | | |
Allow use of assert_template with the :file option.
|
| | | |
| | | |
| | | |
| | | | |
This worked in Rails 3.2, but was a regression in 4.0.0.beta1
|
| | | | |
|
| |/ /
|/| | |
|
| | |
| | |
| | |
| | |
| | |
| | | |
Fix ActionDispatch::Request#formats on xhr requests when HTTP_ACCEPT
header is empty string. About issue #7774, same fix as in commit bebb02f
but for xhr requests.
|
|/ /
| |
| |
| |
| |
| |
| |
| | |
Rather than trying to use gsub to remove the optional route segments,
which will fail with nested optional segments, use a custom visitor
class that returns a empty string for group nodes.
Closes #9524
|
|\ \
| | |
| | | |
Fix for #9360 content_for regression
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Closes #9466.
Passing `format: true` used to override the constraints: { format: /json/ }
with `/.+/`. This patch only sets the format if there is no constraint present.
|
|\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Fix calculation of db_runtime property in
ActiveRecord::Railties::ControllerRuntime#cleanup_view_runtime.
Previously, after raising ActionView::MissingTemplate, db_runtime was
not populated.
Closes #9218, Fixes #9215.
Conflicts:
activerecord/CHANGELOG.md
|
| | | |
| | | |
| | | |
| | | | |
exception
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
* use 1.9 style hash syntax
* don't use brances on assert_equal
* prefere " over '
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
With 155cd5e6 the number_helpers were moved into AS all the tests were copied over
but the tests in AP were not deleted. This is confusing.
I removed all duplicated tests and reorganized the tests in AP to only test the
functionality, that is added in AP.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Closes #9435.
Skip valid encoding checks for non-String parameters that come
from the matched route's defaults.
|
| | | |
| | | |
| | | |
| | | | |
Closes #9432.
|
|\ \ \ \
| | | | |
| | | | | |
Journey::Path::Pattern#new raise more meaningful exception message.
|
| | | | |
| | | | |
| | | | |
| | | | | |
exception message.
|
|/ / / / |
|
|\ \ \ \
| |_|_|/
|/| | | |
Custom dependency trackers for the template digestor
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | | |
Since all changes from #9347 are related to AS, it seems proper that the
test is placed there as well.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
ActiveSupport::NumberHelper#number_to_human now returns the number unaltered when
the units hash does not contain the needed key, e.g. when the number provided is less
than the largest key provided.
|
|\ \ \ \
| | | | |
| | | | | |
use ISO 8601 format in time_tag helper
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Before `time_tag Date.today` will return `<time
datetime="2013-02-14T00:00:00+00:00">February 14, 2013</time>`.
This commit fixes time_tag helper to use RFC-3339 full-date format
(Y-m-d) in datetime attribute.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
determine the match shorthand target early.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Closes #7554.
This patch determines the `controller#action` directly
in the `match` method when the shorthand syntax is used.
this prevents problems with namespaces and scopes.
|
| |_|_|_|/
|/| | | |
| | | | |
| | | | | |
This reverts commit 6871bd9818a9a7d9d8c7e21e253d64c0410fde1d.
|
| | | | | |
|
|/ / / / |
|
|\ \ \ \
| | | | |
| | | | | |
remove assigned but unused variables
|
| | | | | |
|
|/ / / / |
|
| |/ /
|/| |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This reverts commit bb842e8d2111e50b21a14b8bd6d89371a4b9cd68, reversing
changes made to 40c287c7983c20c498f6a8a2ea49e9a6455347f7.
This was causing issues in one of our apps we just upgraded.
ActionController::RoutingError: No route matches [GET]
"/images/favicon.ico"
favicon_link_tag now returns '/images/favicon.ico' and in 3.2 returned
'/favicon.ico'
Browsers by default look for favicon.ico in the root directory
Conflicts:
actionpack/CHANGELOG.md
actionpack/lib/action_view/helpers/asset_tag_helper.rb
|
|/ /
| |
| |
| |
| | |
If you want an ability to parse XML parameters, please install
`actionpack-xml_parser` gem.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Previous implementation of time_zone_options_for_select did not dup the
ActiveSupport::TimeZone.all array. When :priority_zones were provided
the method would reject! the zones from the memoized TimeZones array
thus affecting future requests to the server. Essentially whatever
zones were specified as :priority_zones would show up for the first
request but then disappear from the time zone options on future
requests.
|