aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/test
Commit message (Collapse)AuthorAgeFilesLines
...
* | Set the content-type to `text/html` if the options[:html] is trueakihiro172015-08-291-1/+0
| | | | | | | | | | | | In this commit, we set the content-type to `text/html` in AbstractController if the `options[:html]` is true so that we don't include ActionView::Rendering into ActionController::Metal to set it properly. I removed the if `options[:plain]` statement because `AbstractController#rendered_format` returns `Mime::TEXT` by default.
* | revises 877e42eXavier Noria2015-08-281-6/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * A string in the example lacked quotes. * The tests asserted stuff about :last_name, whereas test params do not have that key. * But, the first one passed, why? After hitting my head against the wall and doing some obscure rituals realized the new #require had an important typo, wanted to iterate over the array argument (key), but it ran over its own hash keys (method #keys). * Modified the test to prevent the same typo to happen again. * The second test assigned to an unused variable safe_params that has been therefore removed. * Grammar of the second test description. * Since I was on it, reworded both test descriptions.
* | [Feature] params.require requires array of paramsGaurish Sharma2015-08-281-0/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This PR adds ability to accept arrays which allows you to require multiple values in one method. so instead of this: ```ruby params.require(:person).require(:first_name) params.require(:person).require(:last_name) ``` Here it will be one line for each params, so say if I require 10params, it will be 10lines of repeated code which is not dry. So I have added new method which does this in one line: ```ruby params.require(:person).require([:first_name, :last_name]) ``` Comments welcome
* | Merge pull request #21384 from ↵Yves Senn2015-08-271-0/+10
|\ \ | | | | | | | | | | | | jeremyf/updating-ActionController-TestSession-to-behave-as-a-hash-with-indifferent Updating TestSession to access with indifference
| * | Updating TestSession to access with indifferenceJeremy Friesen2015-08-261-0/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The following Rails code failed (with a `KeyError` exception) under test: ```ruby class ApplicationController < ActionController::Base def user_strategy # At this point: # ```ruby # session == { # "user_strategy"=>"email", # "user_identifying_value"=>"hello@world.com" # } # ``` if session.key?(:user_strategy) session.fetch(:user_strategy) end end end ``` When I checked the session's keys (`session.keys`), I got an array of strings. If I accessed `session[:user_strategy]` I got the expected `'email'` value. However if I used `session.fetch(:user_strategy)` I got a `KeyError` exception. This appears to be a Rails 4.2.4 regression (as the code works under Rails 4.2.3). Closes #21383
* | | remove RackDelegation moduleAaron Patterson2015-08-262-4/+0
| | | | | | | | | | | | | | | | | | Since all controller instances are required to have a request and response object, RackDelegation is no longer needed (we always have to delegate to the response)
* | | include ActionView::Rendering in the minimal controllerAaron Patterson2015-08-261-0/+1
| | | | | | | | | | | | without this module, the content type is not set correctly
* | | Removed duplicate requiring minitest/mock as it is already required in ↵Ronak Jangir2015-08-261-1/+0
|/ / | | | | | | method_call_assertions
* | provide a request and response to all controllersAaron Patterson2015-08-255-4/+12
| | | | | | | | | | | | | | | | | | | | Controllers should always have a request and response when responding. Since we make this The Rule(tm), then controllers don't need to be somewhere in limbo between "asking a response object for a rack response" or "I, myself contain a rack response". This duality leads to conditionals spread through the codebase that we can delete: * https://github.com/rails/rails/blob/85a78d9358aa728298cd020cdc842b55c16f9549/actionpack/lib/action_controller/metal.rb#L221-L223
* | Fix another rack SPEC violationAaron Patterson2015-08-251-1/+1
| |
* | rack SPEC doesn't allow `first` on the bodyAaron Patterson2015-08-251-8/+12
| | | | | | | | collect the body and make assert against the collected body
* | adding a direct dispatch method to controller classesAaron Patterson2015-08-251-8/+2
| | | | | | | | This saves a lambda and request allocation on each request.
* | Merge pull request #21368 from rodzyn/remove_mochaKasper Timm Hansen2015-08-255-163/+209
|\ \ | | | | | | Get rid of mocha tests in actionpack - part 2
| * | Get rid of mocha tests - part 2Marcin Olichwirowicz2015-08-255-163/+209
| | |
* | | Merge pull request #21366 from amitsuroliya/remove_unused_variableRafael Mendonça França2015-08-252-13/+13
|\ \ \ | | | | | | | | Remove more unused block arguments
| * | | Remove more unused block arguments amitkumarsuroliya2015-08-252-13/+13
| | | |
* | | | Merge pull request #21345 from aditya-kapoor/trim-apRafael Mendonça França2015-08-252-6/+4
|\ \ \ \ | |/ / / |/| | | Trim out least needed controllers from AP test suite
| * | | Trim out unneeded controllers from AP test suiteAditya Kapoor2015-08-242-6/+4
| | | |
* | | | Merge pull request #21094 from aditya-kapoor/add-missing-ap-testsRafael Mendonça França2015-08-251-0/+10
|\ \ \ \ | | | | | | | | | | add missing test for action regexp for routing
| * | | | add missing tests for action regexpAditya Kapoor2015-08-021-0/+10
| | | | |
* | | | | Remove unused block argumentsAnshul Sharma2015-08-251-1/+1
| | | | |
* | | | | remove more direct `env` mutationsAaron Patterson2015-08-241-1/+1
| | | | |
* | | | | remove dead code :bomb:Aaron Patterson2015-08-241-2/+0
| | | | |
* | | | | use `make_set` helper method to generate route setsAaron Patterson2015-08-241-31/+1
| | | | | | | | | | | | | | | | | | | | We should keep the route set generation logic in one place
* | | | | subclass and delegate rather than mutating existing objectsAaron Patterson2015-08-241-12/+29
| | | | | | | | | | | | | | | | | | | | | | | | | If we subclass and augment the superclass, then we don't need to have setters for particular things on the superclass.
* | | | | temp files are no more requireGaurav Sharma2015-08-251-1/+0
| | | | | | | | | | | | | | | `:nail_care:`
* | | | | use a custom request class to determine the controller classAaron Patterson2015-08-241-23/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | controller class resolution has been moved to the request object, so we should override that method instead of relying on the RouteSet to generate the controller class.
* | | | | Merge pull request #21355 from akihiro17/remove-variablesRafael Mendonça França2015-08-241-2/+2
|\ \ \ \ \ | |_|_|/ / |/| | | | Remove unused variables
| * | | | Remove unused variablesakihiro172015-08-241-2/+2
| | |/ / | |/| |
* | | | Merge pull request #21321 from rodzyn/removing_mochaKasper Timm Hansen2015-08-2410-78/+103
|\ \ \ \ | |/ / / |/| | | Get rid of mocha tests in actionpack - part 1
| * | | Get rid of mocha tests - part 1Marcin Olichwirowicz2015-08-2410-78/+103
| | | |
* | | | use a request object in the session middlewareAaron Patterson2015-08-222-22/+24
| | | | | | | | | | | | | | | | | | | | This commit allows us to use one request object rather than allocating multiple request objects to deal with the session.
* | | | Refactor to remove controller class from route to requesteileencodes2015-08-221-1/+1
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | This refactoring moves the controller class name that was on the route set to the request. The purpose of this refactoring is for changes we need to move controller tests to integration tests, mainly being able to access the controller on the request instead of having to go through the router. [Eileen M. Uchitelle & Aaron Patterson]
* | | pass a request object to the headers objectAaron Patterson2015-08-211-1/+1
| | |
* | | move header allocation to a helper methodAaron Patterson2015-08-211-5/+9
| | | | | | | | | | | | | | | I'm going to change the constructor, so it's easier to do it in one place.
* | | Merge pull request #21106 from amitsuroliya/fix_routing_testAndrew White2015-08-211-6/+0
|\ \ \ | | | | | | | | Remove duplicity in tests
| * | | Remove duplicity in testsamitkumarsuroliya2015-08-031-6/+0
| |/ /
* | | point at rack masterAaron Patterson2015-08-201-1/+1
| | |
* | | make the routes reader privateAaron Patterson2015-08-181-1/+1
| | | | | | | | | | | | | | | nobody should be touching the routes hash without going through the NamedRouteCollection object.
* | | symbols will always be constructed with strings. :bomb:Aaron Patterson2015-08-181-1/+1
| | |
* | | test the verb method on the route, specificallyAaron Patterson2015-08-171-1/+1
| | |
* | | routes are always constructed with a hash for the conditionsAaron Patterson2015-08-173-4/+4
| | |
* | | introduce an alternate constructor for Route objectsAaron Patterson2015-08-171-12/+12
| | | | | | | | | | | | | | | I want to change the real constructor to take a particular parameter for matching the request method
* | | default pattern to use a joined stringAaron Patterson2015-08-172-13/+15
| | | | | | | | | | | | | | | The string we create is almost always the same, so rather than joining all the time, lets join once, then reuse that string everywhere.
* | | use the mapper to build the routing tableAaron Patterson2015-08-152-231/+103
| | | | | | | | | | | | | | | | | | We should build the routes using the user facing API which is `Mapper`. This frees up the library internals to change as we see fit. IOW we shouldn't be testing internals.
* | | only keep one hash of named routesAaron Patterson2015-08-142-13/+14
| | | | | | | | | | | | | | | The outer router object already keeps a hash of named routes, so we should just use that.
* | | rm add_route2Aaron Patterson2015-08-142-41/+51
| | | | | | | | | | | | | | | refactor the tests with a backwards compatible method call so we can rm add_route2 from the journey router
* | | pass pass the mapping object down the add_route stackAaron Patterson2015-08-141-1/+1
| | | | | | | | | | | | | | | then we can let the mapping object derive stuff that the Route object needs.
* | | pass the mapping object to build_routeAaron Patterson2015-08-141-16/+5
| | | | | | | | | | | | | | | now that we aren't doing options manipulations, we can just pass the mapping object down and read values from it.
* | | deprecate passing a string for both the beginning path and :path optionAaron Patterson2015-08-141-1/+4
| | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-09 21:46:14 +0000