aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/test
Commit message (Collapse)AuthorAgeFilesLines
* Fix incorrectly appended square brackets to a multiple select boxOlek Janiszewski2013-03-081-0/+8
| | | | | | | | | | | | | | If an explicit name has been given and it already ends with "[]" Before: select(:category, [], {}, multiple: true, name: "post[category][]") # => <select name="post[category][][]" ...> After: select(:category, [], {}, multiple: true, name: "post[category][]") # => <select name="post[category][]" ...>
* Fix warningsCarlos Antonio da Silva2013-03-071-2/+2
|
* Merge pull request #9464 from jcoyne/assert_template_fileRafael Mendonça França2013-03-071-0/+35
|\ | | | | Allow use of assert_template with the :file option.
| * Allow use of assert_template with the :file option.Justin Coyne2013-03-011-0/+35
| | | | | | | | This worked in Rails 3.2, but was a regression in 4.0.0.beta1
* | Add missing require to debug helper testCarlos Antonio da Silva2013-03-051-2/+2
| |
* | Add DebugHelperTestrobertomiranda2013-03-051-0/+8
| |
* | Fix formats on xhr requests when HTTP_ACCEPT is empty stringmaximerety2013-03-041-0/+5
| | | | | | | | | | | | Fix ActionDispatch::Request#formats on xhr requests when HTTP_ACCEPT header is empty string. About issue #7774, same fix as in commit bebb02f but for xhr requests.
* | Use custom visitor class for optimized url helpersAndrew White2013-03-031-0/+6
|/ | | | | | | | Rather than trying to use gsub to remove the optional route segments, which will fail with nested optional segments, use a custom visitor class that returns a empty string for group nodes. Closes #9524
* Merge pull request #9366 from killthekitten/fix-content_for-regressionRafael Mendonça França2013-02-281-0/+4
|\ | | | | Fix for #9360 content_for regression
| * Fix #9360 regression in content_forNikolay Shebanov2013-02-251-0/+4
| |
* | `format: true` does not override existing format constraints.Yves Senn2013-02-271-0/+24
| | | | | | | | | | | | | | Closes #9466. Passing `format: true` used to override the constraints: { format: /json/ } with `/.+/`. This patch only sets the format if there is no constraint present.
* | Merge pull request #9218 from Fivell/masterCarlos Antonio da Silva2013-02-271-0/+14
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix calculation of db_runtime property in ActiveRecord::Railties::ControllerRuntime#cleanup_view_runtime. Previously, after raising ActionView::MissingTemplate, db_runtime was not populated. Closes #9218, Fixes #9215. Conflicts: activerecord/CHANGELOG.md
| * | fix db_runtime attribute value after raising ActionView::MissingTemplate ↵Igor2013-02-271-0/+14
| | | | | | | | | | | | exception
* | | cleanup AP number_helpers_testYves Senn2013-02-271-47/+47
| | | | | | | | | | | | | | | | | | * use 1.9 style hash syntax * don't use brances on assert_equal * prefere " over '
* | | remove duplicated number_helper tests in AP. They are already in AS.Yves Senn2013-02-271-270/+22
| | | | | | | | | | | | | | | | | | | | | | | | With 155cd5e6 the number_helpers were moved into AS all the tests were copied over but the tests in AP were not deleted. This is confusing. I removed all duplicated tests and reorganized the tests in AP to only test the functionality, that is added in AP.
* | | allow non-String default params in the router.Yves Senn2013-02-261-1/+21
| | | | | | | | | | | | | | | | | | | | | Closes #9435. Skip valid encoding checks for non-String parameters that come from the matched route's defaults.
* | | the router allows String contraints.Yves Senn2013-02-261-0/+36
| | | | | | | | | | | | Closes #9432.
* | | Merge pull request #9434 from zires/devRafael Mendonça França2013-02-261-0/+4
|\ \ \ | | | | | | | | Journey::Path::Pattern#new raise more meaningful exception message.
| * | | Make ActionDispatch::Journey::Path::Pattern#new raise more meaningful ↵zires2013-02-271-0/+4
| | | | | | | | | | | | | | | | exception message.
* | | | Add tests for #9441Francesco Rodriguez2013-02-261-0/+16
|/ / /
* | | Merge pull request #8530 from dasch/dependency-trackersDavid Heinemeier Hansson2013-02-252-1/+48
|\ \ \ | | | | | | | | Custom dependency trackers for the template digestor
| * | | Register trackers on extensions, not handlersDaniel Schierbeck2013-02-202-5/+6
| | | |
| * | | Return an empty array if no tracker is foundDaniel Schierbeck2013-02-201-2/+9
| | | |
| * | | Allow registering custom dependency trackersDaniel Schierbeck2013-02-202-1/+40
| | | |
* | | | fix respond_to without blocks not working if one of the blocks is allgrosser2013-02-242-0/+22
| | | |
* | | | Move number_to_human test from AP to ASCarlos Antonio da Silva2013-02-221-5/+0
| | | | | | | | | | | | | | | | | | | | Since all changes from #9347 are related to AS, it seems proper that the test is placed there as well.
* | | | Address edge case for number_to_human with units option.hoffm2013-02-221-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | ActiveSupport::NumberHelper#number_to_human now returns the number unaltered when the units hash does not contain the needed key, e.g. when the number provided is less than the largest key provided.
* | | | Merge pull request #9334 from NARKOZ/time_tagAndrew White2013-02-211-18/+18
|\ \ \ \ | | | | | | | | | | use ISO 8601 format in time_tag helper
| * | | | fix time_tag helper and update tests to not rely on dynamically generated valuesNihad Abbasov2013-02-221-18/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Before `time_tag Date.today` will return `<time datetime="2013-02-14T00:00:00+00:00">February 14, 2013</time>`. This commit fixes time_tag helper to use RFC-3339 full-date format (Y-m-d) in datetime attribute.
* | | | | Merge pull request #9361 from senny/improved_match_shorthand_syntaxAndrew White2013-02-211-0/+27
|\ \ \ \ \ | | | | | | | | | | | | determine the match shorthand target early.
| * | | | | determine the match shorthand target early.Yves Senn2013-02-211-0/+27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Closes #7554. This patch determines the `controller#action` directly in the `match` method when the shorthand syntax is used. this prevents problems with namespaces and scopes.
* | | | | | Revert "Revert "Merge pull request #4803 from lucascaton/master""Santiago Pastorino2013-02-211-1/+1
| |_|_|_|/ |/| | | | | | | | | | | | | | This reverts commit 6871bd9818a9a7d9d8c7e21e253d64c0410fde1d.
* | | | | Use #grep to filter priority zones when a regexp is givenCarlos Antonio da Silva2013-02-211-2/+4
| | | | |
* | | | | Fix test name and refactor fake timezones creation in form options testCarlos Antonio da Silva2013-02-211-3/+3
|/ / / /
* | | | Merge pull request #9354 from NARKOZ/remove-warningsSteve Klabnik2013-02-211-2/+2
|\ \ \ \ | | | | | | | | | | remove assigned but unused variables
| * | | | remove assigned but unused variable warningNihad Abbasov2013-02-211-2/+2
| | | | |
* | | | | Rack::Test::UploadedFile is a permitted scalarFabio Kreusch2013-02-211-1/+2
|/ / / /
* | / / Revert "Merge pull request #4803 from lucascaton/master"Santiago Pastorino2013-02-201-1/+1
| |/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit bb842e8d2111e50b21a14b8bd6d89371a4b9cd68, reversing changes made to 40c287c7983c20c498f6a8a2ea49e9a6455347f7. This was causing issues in one of our apps we just upgraded. ActionController::RoutingError: No route matches [GET] "/images/favicon.ico" favicon_link_tag now returns '/images/favicon.ico' and in 3.2 returned '/favicon.ico' Browsers by default look for favicon.ico in the root directory Conflicts: actionpack/CHANGELOG.md actionpack/lib/action_view/helpers/asset_tag_helper.rb
* | | Remove XML Parser from ActionDispatchPrem Sichanugrist2013-02-202-313/+15
|/ / | | | | | | | | If you want an ability to parse XML parameters, please install `actionpack-xml_parser` gem.
* | Fix time_zone_options_for_select to not mutate TimeZones arrayBrian McManus2013-02-191-0/+7
| | | | | | | | | | | | | | | | | | | | Previous implementation of time_zone_options_for_select did not dup the ActiveSupport::TimeZone.all array. When :priority_zones were provided the method would reject! the zones from the memoized TimeZones array thus affecting future requests to the server. Essentially whatever zones were specified as :priority_zones would show up for the first request but then disappear from the time zone options on future requests.
* | InvalidMessage is in ActiveSupport::MessageEncryptor namespaceSantiago Pastorino2013-02-191-3/+18
| | | | | | | | Closes #9302
* | Fix AP tests related to routes inspector output and the new column titlesCarlos Antonio da Silva2013-02-191-20/+65
| |
* | Merge pull request #8704 from senny/remove_regexp_global_from_url_forAaron Patterson2013-02-141-0/+3
|\ \ | | | | | | replace regexp global in #url_for
| * | replace regexp global in #url_forYves Senn2013-01-161-0/+3
| | |
* | | Merge pull request #9221 from thenickcox/image_alt_attributeCarlos Antonio da Silva2013-02-111-1/+2
|\ \ \ | | | | | | | | Improve img alt attribute for screen readers
| * | | Improve img alt attribute for screen readersthenickcox2013-02-091-1/+2
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently, the img_alt method in ActionView keeps underscores in the alt attribute. Because underscores are pronounced in Apple's VoiceOver Utility, this has serious implications for accessibility. This patch makes underscored or hyphenated file names (both common in projects) read more naturally in screen readers by replacing them with spaces. See method documentation for details. Added documentation to image_alt method
* | | the `:controller` option for routes can contain numbers. closes #9231.Yves Senn2013-02-091-0/+12
| | |
* | | Fix #9168 Initialize NullCookieJar with all options needed for KeyGeneratorAndrey Chernih2013-02-081-0/+35
|/ /
* | ruby constant syntax is not supported as routing `:controller` option.Yves Senn2013-02-061-9/+40
| | | | | | | | | | | | | | | | | | | | The current implementation only works correctly if you supply the `:controller` with directory notation (eg. `:controller => 'admin/posts'`). The ruby constant notation (eg. `:controller => 'Admin::Posts`) leads to unexpected problems with `url_for`. This patch prints a warning for every non supported `:controller` option. I also added documentation how to work with namespaced controllers. The warning links to that documentation in the rails guide.
* | partials inside directory work with `assert_template`Yves Senn2013-02-043-0/+14
| | | | | | | | | | | | | | | | | | | | previously when a partial was placed inside a directory (eg. '/dir/_partial'), `assert_template` did not replace the '_' prefix when looking through rendered tempaltes, which resulted in an error. I modified it to replace both, the leading '_' and the last '_' after a '/'.
generated by cgit v1.2.3 (git 2.25.1) at 2024-10-30 22:27:04 +0000