Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | Safely cleans up a test to avoid relying on a particular test order | wycats | 2010-03-04 | 1 | -10/+23 | |
| | ||||||
* | Fixes test ordering bug (ht: evan) | wycats | 2010-03-04 | 1 | -0/+3 | |
| | ||||||
* | Fix a bunch of failing AP / AM specs created from the previous ↵ | Carl Lerche | 2010-03-04 | 1 | -27/+15 | |
| | | | | AbstractController configuration refactor. | |||||
* | Merge branch 'configuration_refactor' | Carl Lerche | 2010-03-03 | 12 | -224/+129 | |
|\ | ||||||
| * | Move the original config method onto AbstractController | Carl Lerche | 2010-03-03 | 2 | -2/+2 | |
| | | ||||||
| * | Start refactoring the method of configuring ActionView | Carlhuda | 2010-03-03 | 4 | -24/+23 | |
| | | ||||||
| * | Deprecate IP spoofing settings that are directly on the controller in favor ↵ | Carlhuda | 2010-03-03 | 1 | -2/+0 | |
| | | | | | | | | of configuring a middleware | |||||
| * | Move remote_ip to a middleware: | Carlhuda | 2010-03-03 | 1 | -5/+7 | |
| | | | | | | | | | | * ActionController::Base.ip_spoofing_check deprecated => config.action_dispatch.ip_spoofing_check * ActionController::Base.trusted_proxies deprecated => config.action_dispatch.trusted_proxies | |||||
| * | ActionController::Base.use_accept_header is not actually used anymore, so ↵ | Carl Lerche | 2010-03-03 | 4 | -26/+0 | |
| | | | | | | | | let's deprecate it. | |||||
| * | ActionDispatch::Request deprecates #request_uri | Carl Lerche | 2010-03-03 | 3 | -17/+17 | |
| | | | | | | | | * Refactored ActionPatch to use fullpath instead | |||||
| * | Fix tests for the request refactor | Carl Lerche | 2010-03-03 | 3 | -21/+40 | |
| | | ||||||
| * | Tweak the semantic of various URL related methods of ActionDispatch::Request | Carlhuda | 2010-03-03 | 4 | -87/+16 | |
| | | ||||||
| * | Work on deprecating ActionController::Base.relative_url_root | Carlhuda | 2010-03-03 | 3 | -39/+22 | |
| | | ||||||
| * | Move session_store and session_options to the AC configuration object | Carlhuda | 2010-03-03 | 1 | -2/+3 | |
| | | ||||||
* | | don't depend on the order of cookies (Hash ordering bug) | Yehuda Katz | 2010-03-03 | 1 | -1/+1 | |
|/ | ||||||
* | Fix failing Action Pack tests | Carlhuda | 2010-03-02 | 4 | -3/+14 | |
| | ||||||
* | No longer add missing leading / on path args to assert_redirected_to. ↵ | Jeremy Kemper | 2010-03-02 | 1 | -2/+4 | |
| | | | | Deprecated in 2.3.6. | |||||
* | Fix some tests that relied on hardcoded Exception information (ht: evan) | Yehuda Katz | 2010-03-02 | 1 | -2/+2 | |
| | ||||||
* | Action Mailer setup obviated by test bundle | Jeremy Kemper | 2010-03-02 | 1 | -12/+1 | |
| | ||||||
* | Change AV formats so they can delegate to the controller. Now users (or ↵ | Carlhuda | 2010-03-01 | 2 | -0/+2 | |
| | | | | plugins) can override details_for_render in their controllers and add appropriate additional details. Now if only they could *do* something with those details... | |||||
* | add activesupport and activemodel load paths to actionpack tests | Joshua Peek | 2010-02-28 | 1 | -0/+6 | |
| | ||||||
* | Remove implicit controller namespacing from new dsl | Joshua Peek | 2010-02-28 | 3 | -7/+13 | |
| | ||||||
* | 1.9 seems to have a bug involving cloned classes and super. Fix it by not ↵ | Carlhuda | 2010-02-26 | 1 | -8/+12 | |
| | | | | cloning (and instead creating classes on demand). The 1.9 bug should be investigated. | |||||
* | If IntegrationSession is initialized with an objects that responds to ↵ | Carlhuda | 2010-02-26 | 4 | -6/+3 | |
| | | | | #routes, automatically extend the URL helpers from the RouteSet onto it | |||||
* | Upon further reflection, we realized that SharedTestRoutes is not really a ↵ | Carlhuda | 2010-02-26 | 1 | -1/+0 | |
| | | | | | | | | hack, but is instead a standin (in the Rails tests) for Rails.application.routes. * In a real application, action_controller/railties.rb does AC::Base.include(app.routes.url_helpers) * ActionController itself does not know about Rails.application, but instead can have named routes for any router * SharedTestRoutes are created in abstract_unit to stand in for Rails.application.routes, and is used in internal functional tests | |||||
* | Relatively speaking, it's not actually that bad... | Carlhuda | 2010-02-26 | 1 | -2/+0 | |
| | ||||||
* | Setting UrlFor in with_routing is no longer needed now that it's not global | Carlhuda | 2010-02-26 | 1 | -4/+5 | |
| | ||||||
* | Remove traces of SharedTestRoutes from user code; leave it as a standin for ↵ | Carlhuda | 2010-02-26 | 1 | -1/+0 | |
| | | | | Rails.application.routes in Rails internal tests | |||||
* | Stop setting UrlFor using SharedTestHelpers | Carlhuda | 2010-02-26 | 2 | -4/+4 | |
| | ||||||
* | Silence test deprecation warnings | Carlhuda | 2010-02-26 | 2 | -17/+56 | |
| | ||||||
* | Rename named_url_helpers to url_helpers and url_helpers to url_for | Carlhuda | 2010-02-26 | 7 | -14/+14 | |
| | ||||||
* | Fix controller_path returnsing an empty string in Ruby 1.8.7 [#4036 ↵ | José Valim | 2010-02-26 | 1 | -0/+9 | |
| | | | | status:resolved] | |||||
* | Rename metaclass to singleton_class | Carlhuda | 2010-02-25 | 3 | -4/+4 | |
| | ||||||
* | Get URL helpers working again in integration tests. | Carlhuda | 2010-02-25 | 1 | -17/+7 | |
| | ||||||
* | Continued effort to deglobalize the router | Carlhuda | 2010-02-25 | 2 | -27/+8 | |
| | ||||||
* | Fix all of AP's tests with the non global router | Carlhuda | 2010-02-25 | 2 | -5/+7 | |
| | ||||||
* | Merge branch 'master' of github.com:rails/rails | Carlhuda | 2010-02-25 | 1 | -1/+1 | |
| | ||||||
* | WIP: Remove the global router | Carlhuda | 2010-02-25 | 11 | -65/+101 | |
| | ||||||
* | add time_separator for minutes only if minutes aren't hidden | Santiago Pastorino | 2010-02-25 | 1 | -0/+41 | |
| | | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | |||||
* | Renamed LocalizedCache to DetailsCache. | José Valim | 2010-02-24 | 1 | -1/+1 | |
| | ||||||
* | Cleanup render callstack and make render(:json => {}, :status => 401) work ↵ | José Valim | 2010-02-24 | 1 | -0/+10 | |
| | | | | again. | |||||
* | Remove ActionController::Base.resources_path_names | Carl Lerche | 2010-02-24 | 1 | -9/+10 | |
| | ||||||
* | Fix render :file => "#{Rails.root}/public/404.html", :status => :not_found. ↵ | Yehuda Katz | 2010-02-23 | 2 | -0/+10 | |
| | | | | Closes #8994 | |||||
* | Revert "Fix test load paths for those not using bundler" | Carlhuda | 2010-02-23 | 4 | -19/+4 | |
| | | | | | | This reverts commit eec2d301d4ce9df9c71c1a5aa63053eb970b6818. This commit broke tests. You cannot have a file called "bundler" on the load path. | |||||
* | Makes send_file work again by deferring to Rack::Sendfile. | Carlhuda | 2010-02-23 | 2 | -25/+2 | |
| | | | | | | | | | | * Add the Rack::Sendfile middleware * Make the header to use configurable via config.action_dispatch.x_sendfile_header (default to "X-Sendfile"). * Add Railties tests to confirm that these work * Remove the :stream, :buffer_size, and :x_senfile default options to send_file * Change the log subscriber to always say "Sent file" * Add deprecation warnings for options that are now no-ops Note that servers can configure this by setting X-Sendfile-Type. Hosting companies and those creating packages of servers specially designed for Rails applications are encouraged to specify this header so that this can work transparently. | |||||
* | Fix streaming by having it create a File object, which can be handled by ↵ | Carlhuda | 2010-02-23 | 1 | -3/+11 | |
| | | | | Rack servers as appropriate | |||||
* | Use ActionDispatch::Routing everywhere | Martin Schürrer | 2010-02-21 | 7 | -26/+26 | |
| | ||||||
* | Add a tests which ensures filtered_parameters does not raise an error for a ↵ | José Valim | 2010-02-21 | 1 | -1/+1 | |
| | | | | mixed array [#3928 status:resolved] | |||||
* | Require persisted? in ActiveModel::Lint and remove new_record? and ↵ | José Valim | 2010-02-21 | 8 | -73/+51 | |
| | | | | destroyed? methods. ActionPack does not care if the resource is new or if it was destroyed, it cares only if it's persisted somewhere or not. | |||||
* | AMo #key is now #to_key and CI is probably happy | snusnu | 2010-02-20 | 3 | -10/+11 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Obviously #key is a too common name to be included in the AMo interface, #to_key fits better and also relates nicely to #to_param. Thx wycats, koz and josevalim for the suggestion. AR's #to_key implementation now takes customized primary keys into account and there's a testcase for that too. The #to_param AMo lint makes no assumptions on how the method behaves in the presence of composite primary keys. It leaves the decision wether to provide a default, or to raise and thus signal to the user that implementing this method will need his special attention, up to the implementers. All AMo cares about is that #to_param is implemented and returns nil in case of a new_record?. The default CompliantObject used in lint_test provides a naive default implementation that just joins all key attributes with '-'. The #to_key default implementation in lint_test's CompliantObject now returns [id] instead of [1]. This was previously causing the (wrong) tests I added for AR's #to_key implementation to pass. The #to_key tests added with this patch should be better. The CI failure was caused by my lack of knowledge about the test:isolated task. The tests for the record_identifier code in action_controller are using fake non AR models and I forgot to stub the #to_key method over there. This issue didn't come up when running the test task, only test:isolated revealed it. This patch fixes that. All tests pass isolated or not, well, apart from one previously unpended test in action_controller that is unrelated to my patch. |