| Commit message (Collapse) | Author | Age | Files | Lines | |
|---|---|---|---|---|---|
| * | Moved ActionView::Assertions dependency from Action Pack's lib to ↵ | Timm | 2014-06-16 | 1 | -0/+2 |
| | | | | | abstract_unit.rb. | ||||
| * | Nokogiri leaves '<' unescaped, so the assert_select looking for '<' will ↵ | Timm | 2014-06-16 | 1 | -2/+3 |
| | | | | | never work. Switched to assert_matching the reponse body. | ||||
| * | Removed require's for html-scanner. | Timm | 2014-06-16 | 2 | -2/+0 |
| | | |||||
| * | Moved Dom and Selector assertions from ActionDispatch to ActionView. | Timm | 2014-06-16 | 1 | -350/+0 |
| | | |||||
| * | Fixed: assert_select_encoded finds the right content. No longer uses a ↵ | Timm | 2014-06-16 | 1 | -9/+2 |
| | | | | | <encoded> wrapper. Updated tests to reflect this. | ||||
| * | Fixed: test_nested_assert_select selects from elements instead of ↵ | Timm | 2014-06-16 | 1 | -2/+2 |
| | | | | | elements[0] and elements[1]. | ||||
| * | Changed xml_namespace test to correct syntax. However, Nokogiri won't ↵ | Timm | 2014-06-16 | 1 | -2/+3 |
| | | | | | recognize the namespace. | ||||
| * | Changed test methods to use new substitution syntax more in line with css ↵ | Timm | 2014-06-16 | 1 | -3/+3 |
| | | | | | selectors. | ||||
| * | Fixed typo in method name. Fixed Nokogiri::CSS::SyntaxError. | Timm | 2014-06-15 | 1 | -2/+2 |
| | | |||||
| * | Changed tests to assert_kind_of Loofah::HTML::Document. | Timm | 2014-06-15 | 1 | -3/+3 |
| | | |||||
| * | Removed selector_test.rb since HTML::Selector will be removed. Soon. | Timm | 2014-06-15 | 1 | -629/+0 |
| | | |||||
| * | Fixed Nokogiri::CSS::SyntaxErrors. | Timm | 2014-06-15 | 1 | -2/+2 |
| | | | | | Fixed a Nokogiri::CSS::SyntaxError by using its expected format for unicode characters. | ||||
| * | Removed tag.rb since it has been deprecated. | Timm | 2014-06-15 | 2 | -184/+0 |
| | | |||||
| * | Merge pull request #15545 from zuhao/refactor_actionpack_assert_select_test | Yves Senn | 2014-06-08 | 1 | -1/+4 |
| |\ | | | | | Restore test deliveries for ActionMailer. | ||||
| | * | Restore test deliveries for ActionMailer. | Zuhao Wan | 2014-06-07 | 1 | -1/+4 |
| | | | |||||
| * | | Handle client disconnect during live streaming | Matthew Draper | 2014-06-08 | 1 | -0/+89 |
| | | | | | | | | | .. even when the producer is blocked for a write. | ||||
| * | | adds some details to the rationale of converted_arrays [ci skip] | Xavier Noria | 2014-06-07 | 1 | -1/+1 |
| | | | |||||
| * | | adds a regression test for the strong params converted arrays cache | Xavier Noria | 2014-06-07 | 1 | -1/+18 |
| | | | | | | | | | This is a regression test for 29844dd. | ||||
| * | | Revert "Convert StrongParameters cache to a hash. This fixes an unbounded" | Xavier Noria | 2014-06-07 | 1 | -1/+1 |
| |/ | | | | | | | | | | | | | | | | | | | | We cannot cache keys because arrays are mutable. We rather want to cache the arrays. This behaviour is tailor-made for the usage pattern strongs params is designed for. In a forthcoming commit I am going to add a test that covers why we need to cache by value. Every strong params instance has a live span of a request, the cache goes away with the object. Since strong params have such a concrete intention, it would be interesting to see if there are actually any real-world use cases that are an actual leak, one that practically may matter. I am not convinced that the theoretical leak has any practical consequences, but if it can be shown there are, then I believe we should either get rid of the cache (which is an optimization), or else wipe it in the mutating API. This reverts commit e63be2769c039e4e9ada523a8497ce3206cc8a9b. | ||||
| * | Merge pull request #15530 from zuhao/refactor_actionpack_reloader_test | Matthew Draper | 2014-06-06 | 1 | -0/+5 |
| |\ | | | | | Reset callbacks after test. | ||||
| | * | Reset callbacks after test. | Zuhao Wan | 2014-06-05 | 1 | -0/+5 |
| | | | | | | | | | Otherwise the state of callback chain is leaked. | ||||
| * | | Merge pull request #15532 from zuhao/refactor_actionpack_response_test | Yves Senn | 2014-06-05 | 1 | -2/+4 |
| |\ \ | | | | | | | Restore Response.default_headers after test. | ||||
| | * | | Restore Response.default_headers after test. | Zuhao Wan | 2014-06-05 | 1 | -2/+4 |
| | | | | |||||
| * | | | Avoid hard-coded value in test setup/teardown. | Zuhao Wan | 2014-06-05 | 1 | -1/+2 |
| |/ / | |||||
| * | | Merge pull request #15529 from zuhao/refactor_actionpack_mime_type_test | Yves Senn | 2014-06-05 | 2 | -8/+0 |
| |\ \ | |/ |/| | Make sure Mime::Type is not altered after tests. | ||||
| | * | Mime::PNG is already defined. | Zuhao Wan | 2014-06-05 | 2 | -8/+0 |
| | | | |||||
| * | | Avoid hardcoded value in test setup/teardown. | Zuhao Wan | 2014-06-05 | 1 | -1/+2 |
| |/ | |||||
| * | Merge pull request #15498 from zenspider/fix_memory_leak | Guillermo Iguaran | 2014-06-03 | 1 | -1/+1 |
| |\ | | | | | Convert StrongParameters cache to a hash. This fixes an unbounded memory leak | ||||
| | * | Convert StrongParameters cache to a hash. This fixes an unbounded | Ryan Davis | 2014-06-03 | 1 | -1/+1 |
| | | | | | | | | | | | | | memory leak demonstrated on @tenderlove's latest blog post: http://tenderlovemaking.com/2014/06/02/yagni-methods-are-killing-me.html | ||||
| * | | Partially revert deprecation of *_filter | Rafael Mendonça França | 2014-06-03 | 1 | -5/+3 |
| | | | | | | | | | | | | | | | | | | | | | | | We are going to deprecate only on Rails 5 to make easier plugin maintainers support different Rails versions. Right now we are only discouraging their usage. This reverts commit 6c5f43bab8206747a8591435b2aa0ff7051ad3de. Conflicts: actionpack/CHANGELOG.md | ||||
| * | | Merge pull request #15349 from tgxworld/remove_duplicated_method_call | Rafael Mendonça França | 2014-06-03 | 1 | -4/+1 |
| |\ \ | | | | | | | Remove duplicated HashWithIndifferentAccess#with_indifferent_access. | ||||
| | * | | Remove duplicated HashWithIndifferentAccess#with_indifferent_access. | Guo Xiang Tan | 2014-05-26 | 1 | -4/+1 |
| | | | | |||||
| * | | | Routes specifying 'to:' must be a string that contains a "#" or a rack | Aaron Patterson | 2014-06-03 | 2 | -24/+32 |
| | | | | | | | | | | | | | | | | application. Use of a symbol should be replaced with `action: symbol`. Use of a string without a "#" should be replaced with `controller: string`. | ||||
| * | | | use the factory method to construct the mapping | Aaron Patterson | 2014-06-03 | 1 | -1/+1 |
| | | | | |||||
| * | | | add tests for mixing :to and controller / action | Aaron Patterson | 2014-06-03 | 1 | -0/+48 |
| | | | | |||||
| * | | | add tests for nested lambda constraints | Aaron Patterson | 2014-06-03 | 1 | -0/+27 |
| | | | | |||||
| * | | | test with an empty via | Aaron Patterson | 2014-06-03 | 1 | -0/+8 |
| | | | | |||||
| * | | | add a test for missing "via" parameter | Aaron Patterson | 2014-06-03 | 1 | -0/+8 |
| | | | | |||||
| * | | | Mapping never actually uses @set, so rm | Aaron Patterson | 2014-05-29 | 1 | -1/+1 |
| | | | | |||||
| * | | | no more is_a checks on instantiation | Aaron Patterson | 2014-05-29 | 1 | -4/+0 |
| | | | | |||||
| * | | | Path::Pattern is instantiated internally, so make the contructor require a ↵ | Aaron Patterson | 2014-05-29 | 4 | -39/+43 |
| | | | | | | | | | | | | | strexp object | ||||
| * | | | Strexp#names is only used in a test, so rm | Aaron Patterson | 2014-05-29 | 1 | -32/+0 |
| | | | | |||||
| * | | | add an alternate constructor to Strexp that takes a string | Aaron Patterson | 2014-05-29 | 4 | -31/+31 |
| | | | | |||||
| * | | | use a parser to extract the group parts from the path | Aaron Patterson | 2014-05-29 | 1 | -2/+2 |
| | | | | |||||
| * | | | Merge branch 'master' into mapper | Aaron Patterson | 2014-05-29 | 3 | -19/+20 |
| |\ \ \ | | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * master: Update url to rake docs [ci skip] Name#model_name doesn't return a String object Result sets never override a model's column type [ci skip] Make last note show up in postgresql guide. Add missing `:param` option from the docs for Mapper#match [ci skip] Option discovered by @zackperdue in #14741, implemented in #5581. Add @senny's changed from #14741, including code font for `resources` options, and wrapped to 80 chars. [ci skip] Use github url for homepage of log4r [ci skip] Remove TODO. Ensure we always use instances of the adapter specific column class Fix indentation from 1b4b26f [ci skip] [ci skip] Improve form_helpers.md guide. Clear inflections after test. Remove unnecessary include for integration tests. Added documentation for the :param option for resourceful routing | ||||
| | * | | Merge pull request #15061 from tgxworld/remove_unnecessary_include | Matthew Draper | 2014-05-29 | 1 | -1/+0 |
| | |\ \ | | | | | | | | | Remove unnecessary include for integration tests. | ||||
| | | * | | Remove unnecessary include for integration tests. | Guo Xiang Tan | 2014-05-11 | 1 | -1/+0 |
| | | | | | |||||
| | * | | | Merge pull request #15399 from tgxworld/remove_todo_router_test | Guillermo Iguaran | 2014-05-28 | 1 | -11/+1 |
| | |\ \ \ | | | | | | | | | | | Remove TODO. | ||||
| | | * | | | Remove TODO. | Guo Xiang Tan | 2014-05-28 | 1 | -11/+1 |
| | | | | | | |||||
| | * | | | | Merge pull request #15384 from zuhao/refactor_actionpack_params_wrapper_test | Yves Senn | 2014-05-29 | 1 | -7/+19 |
| | |\ \ \ \ | | | | | | | | | | | | | Clear inflections after test. | ||||
 |
index : rails.git | |
| Mirror of official rails repo with custom fixes. | Harald Eilertsen |
| aboutsummaryrefslogtreecommitdiffstats |