Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | pass the variant as a parameter to more reflect real world apps | Aaron Patterson | 2015-07-08 | 1 | -3/+3 |
| | |||||
* | add a new constructor for allocating test requests | Aaron Patterson | 2015-07-08 | 1 | -9/+9 |
| | |||||
* | make `env` a required parameter | Aaron Patterson | 2015-07-08 | 1 | -6/+6 |
| | |||||
* | remove call to build_request | Aaron Patterson | 2015-07-08 | 1 | -1/+0 |
| | |||||
* | let the superclass build the request and response | Aaron Patterson | 2015-07-08 | 10 | -47/+13 |
| | | | | | We should leverage the request / response objects that the superclass has already allocated for us. | ||||
* | pass variants in rather than mutating the request. | Aaron Patterson | 2015-07-07 | 1 | -48/+31 |
| | | | | | | Variants are typically set in the controller based on some attribute of the request that the browser sent. We should make our tests more in line with reality by doing the same and not mutating the request object. | ||||
* | pass cookies from the jar in the HTTP_COOKIE header | eileencodes | 2015-07-07 | 1 | -2/+0 |
| | | | | | we should be pushing the cookies in via headers rather than maintaining some object and "recycling" it. | ||||
* | Merge pull request #13897 from gmalette/nested-parameter-filtering-2 | Arthur Nogueira Neves | 2015-07-06 | 1 | -0/+1 |
|\ | | | | | Allow filtering params based on parent keys | ||||
| * | Allow filtering params based on parent keys | Guillaume Malette | 2015-06-22 | 1 | -0/+1 |
| | | | | | | | | | | | | | | | | | | | | Add the possibility to only filter parameters based on their full path instead of relying on the immediate key. config.filter_parameters += ['credit_card.code'] { 'credit_card' => { 'code' => '[FILTERED]' }, 'source' => { 'code' => '<%= puts 5 %>' } } | ||||
* | | Fix the random caching test failure. | Kasper Timm Hansen | 2015-07-05 | 1 | -0/+1 |
| | | |||||
* | | Improve error messages in cookies_test | eileencodes | 2015-06-27 | 1 | -3/+3 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Using `assert_predicate` and `assert_match` instead of just `assert` is preferrable because better error messages are output. In the case of `assert response.cookies.empty?` the error message was `Failed assertion, no message given.` but now with `assert_predicate` it will be `Expected {"user_name"=>"david"} to be empty?.` For `assert_match(/user_name=david/, response.headers["Set-Cookie"])` as well, the message returned was unhelpful - `Failed assertion, no message given.` but now will tell what was expected and what was returned with `Expected /user_name=david/ to match "user_name=nope; path=/".` | ||||
* | | Merge pull request #20276 from davetron5000/revert-head-on-no-template | Kasper Timm Hansen | 2015-06-27 | 1 | -0/+21 |
|\ \ | | | | | | | Allow default_render to take a block to customize behavior when there's no template | ||||
| * | | Override default_render's behavior with a block | Dave Copeland | 2015-06-20 | 1 | -0/+21 |
| |/ | | | | | | | | | | | | | | | | | | | In 0de4a23 the behavior when there is a missing template was changed to not raise an error, but instead head :no_content. This is a breaking change and some gems rely on this happening. To allow gems and other code to work around this, allow `default_render` to take a block which, if provided, will execute the contents of that block instead of doing the `head :no_content`. | ||||
* | | Merge pull request #19431 from hmarr/head-routing | Rafael Mendonça França | 2015-06-22 | 1 | -3/+2 |
|\ \ | |/ |/| | Respect routing precedence for HEAD requests | ||||
| * | Respect routing precedence for HEAD requests | Harry Marr | 2015-03-20 | 1 | -3/+2 |
| | | | | | | | | | | | | | | Fixes the issue described in #18764 - prevents Rack middleware from swallowing up HEAD requests that should have been matched by a higher-precedence `get` route, but still allows Rack middleware to respond to HEAD requests. | ||||
* | | Revert "Merge pull request #20584 from arthurnn/fix_url" | Arthur Neves | 2015-06-17 | 1 | -7/+0 |
| | | | | | | | | | | | | | | | | This reverts commit 0b3397872582f2cf1bc6960960a6393f477c55e6, reversing changes made to 56d52e3749180e6c1dcf7166adbad967470aa78b. As pointed out on the PR, this will hide development mistakes too, which is not ideal. | ||||
* | | Catch InvalidURIError on bad paths on redirect. | Arthur Neves | 2015-06-16 | 1 | -0/+7 |
| | | | | | | | | | | Handle URI::InvalidURIError errors on the redirect route method, so it wont raise a 500 if a bad path is given. | ||||
* | | remove `header=` on the response object. | Aaron Patterson | 2015-06-15 | 1 | -0/+2 |
| | | | | | | | | | | | | People should be free to mutate the header object, but not to set a new header object. That header object may be specific to the webserver, and we need to hide it's internals. | ||||
* | | Deprecate passing hash as first parameter into ActionController::Head | Mehmet Emin İNAÇ | 2015-06-15 | 3 | -10/+31 |
| | | |||||
* | | Fix flakyness. | Kasper Timm Hansen | 2015-06-15 | 1 | -0/+1 |
| | | | | | | | | Brought on by my own stupidity :) | ||||
* | | ActionDispatch::SSL should keep original header's behavior | Fumiaki MATSUSHIMA | 2015-06-14 | 1 | -0/+11 |
| | | | | | | | | | | | | `ActionDispatch::SSL` changes headers to `Hash`. So some headers will be broken if there are some middlewares on ActionDispatch::SSL and if it uses `Rack::Utils::HeaderHash`. | ||||
* | | Return 204 if render is not called in API controllers | Jorge Bejar | 2015-06-11 | 1 | -0/+15 |
| | | |||||
* | | Add test coverage for implicit render in empty actions | Jorge Bejar | 2015-06-11 | 1 | -0/+14 |
| | | |||||
* | | Include ParamsWrapper in AC::API | Jorge Bejar | 2015-06-11 | 1 | -0/+26 |
| | | | | | | | | | | | | | | | | | | ParamsWrapper was initially removed from API controllers according to the following discusision: https://github.com/rails-api/rails-api/issues/33 However, we're including it again so Rails API devs can decide whether to enable or disable it. | ||||
* | | Rename test methods in api conditional get controller tests | Jorge Bejar | 2015-06-11 | 1 | -2/+2 |
| | | |||||
* | | Routes resources avoid :new and :edit endpoints if api_only is enabled | Jorge Bejar | 2015-06-11 | 1 | -0/+75 |
| | | |||||
* | | Remove extra whitespaces | Santiago Pastorino | 2015-06-11 | 1 | -1/+1 |
| | | |||||
* | | Use new hash syntax | Santiago Pastorino | 2015-06-11 | 2 | -7/+7 |
| | | |||||
* | | Remove Unneeded ApiPublicExceptions middleware, PublicExceptions already ↵ | Santiago Pastorino | 2015-06-11 | 1 | -37/+0 |
| | | | | | | | | does the work | ||||
* | | Use nex hash syntax on tests | Santiago Pastorino | 2015-06-11 | 1 | -5/+5 |
| | | |||||
* | | Add ApiPublicException middleware | Santiago Pastorino | 2015-06-11 | 1 | -2/+39 |
| | | |||||
* | | Move Model test class inside RenderersApiController namespace | Santiago Pastorino | 2015-06-11 | 1 | -8/+8 |
| | | |||||
* | | Add ActionController API functionality | Santiago Pastorino | 2015-06-11 | 7 | -0/+184 |
| | | |||||
* | | Change the `index` arg of `ActionDispatch::Static#new` to a kwarg | Yuki Nishijima | 2015-06-11 | 1 | -1/+1 |
| | | |||||
* | | extract required_defaults from the conditions hash before constructing the route | Aaron Patterson | 2015-06-08 | 3 | -48/+48 |
| | | | | | | | | | | this way we can remove the strange "respond_to?" conditional in the `matches?` loop | ||||
* | | Merge pull request #19094 from phoet/have_bearer_be_valid_as_well | Rafael Mendonça França | 2015-06-01 | 1 | -1/+8 |
|\ \ | | | | | | | Have Bearer be valid as well | ||||
| * | | allow `Bearer` as well as `Token` | phoet | 2015-06-01 | 1 | -0/+7 |
| | | | |||||
| * | | actually test what the name says | phoet | 2015-06-01 | 1 | -1/+1 |
| | | | |||||
* | | | Merge pull request #20138 from tgxworld/deprecated_assert_template | Rafael Mendonça França | 2015-06-01 | 11 | -492/+101 |
|\ \ \ | | | | | | | | | Deprecate `assert_template` and `assigns()`. | ||||
| * | | | Remove `assigns` and `assert_template`. | Guo Xiang Tan | 2015-05-30 | 11 | -492/+101 |
| |/ / | |||||
* | | | Merge pull request #20284 from kaspth/fix-caching-test | Rafael Mendonça França | 2015-06-01 | 3 | -3/+9 |
|\ \ \ | |/ / |/| | | Move expectation to instance level. | ||||
| * | | Replace expectation with state check. | Kasper Timm Hansen | 2015-05-30 | 3 | -3/+9 |
| | | | | | | | | | | | | The tests would still pass if the cache call in the rendered templates were removed. | ||||
* | | | Fix warning about ambiguous first argument | Arun Agrawal | 2015-05-29 | 1 | -1/+1 |
| | | | |||||
* | | | Merge pull request #20017 from eliotsykes/configurable-static-index-filename | Rafael Mendonça França | 2015-05-28 | 5 | -0/+18 |
|\ \ \ | | | | | | | | | | | | | config.static_index configures directory Index "index.html" filename | ||||
| * | | | config.static_index configures directory index "index.html" filename | Eliot Sykes | 2015-05-28 | 5 | -0/+18 |
| | | | | | | | | | | | | | | | | | | | | | | | | Set `config.static_index` to serve a static directory index file not named `index`. For example, to serve `main.html` instead of `index.html` for directory requests, set `config.static_index` to `"main"`. | ||||
* | | | | Deprecate `:nothing` option for render method | Mehmet Emin İNAÇ | 2015-05-28 | 8 | -13/+23 |
|/ / / | | | | | | | | | | `head` method works similar to `render` method with `:nothing` option | ||||
* | | | Merge pull request #19808 from byroot/action-parameter | Rafael Mendonça França | 2015-05-27 | 1 | -0/+20 |
|\ \ \ | | | | | | | | | [PoC] Stop shadowing parameters named `action` | ||||
| * | | | Allow to parameters named `action` or `controller` from AC::TestCase helpers | Jean Boussier | 2015-04-18 | 1 | -0/+20 |
| | | | | |||||
* | | | | Add assertion for get? method into test cases | Mehmet Emin İNAÇ | 2015-05-27 | 1 | -0/+1 |
| | | | | |||||
* | | | | Merge pull request #17788 from sivagollapalli/master | Arthur Nogueira Neves | 2015-05-20 | 1 | -0/+5 |
|\ \ \ \ | | | | | | | | | | | Issue#17703 Test case for tempfile attribute |