aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/test
Commit message (Collapse)AuthorAgeFilesLines
...
* | Fix order dependent testsAkira Matsuda2013-07-261-0/+4
| | | | | | | | Reset ActionView::Base.logger after tests
* | Fix order dependent AP testAkira Matsuda2013-07-261-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | any_instance.stubs + unstub with Mocha doesn't restore the original status in the following case, so we need to undef Customer#to_json before every test require 'test/unit' require 'mocha/setup' module M def foo() :foo; end end class C include M undef_method :foo end C.any_instance.stubs(:foo).returns(:mocha) C.any_instance.unstub(:foo)
* | Allow overriding of all headers from passed environment hashAndrew White2013-07-251-0/+30
| | | | | | | | | | | | | | Allow REMOTE_ADDR, HTTP_HOST and HTTP_USER_AGENT to be overridden from the environment passed into `ActionDispatch::TestRequest.new`. Fixes #11590
* | Fix failing test missed for the past year :(Andrew White2013-07-171-1/+1
| | | | | | | | | | | | | | | | | | When optimized path helpers were re-introduced in d7014bc the test added in a328f2f broke but no-one noticed because it wasn't being run by the test suite. Fix the test by checking for nil values or empty strings after the args have been parameterized.
* | Skip Rack applications and redirects when generating urlsAndrew White2013-07-163-12/+69
| | | | | | | | | | | | | | | | | | | | When generating an unnamed url (i.e. using `url_for` with an options hash) we should skip anything other than standard Rails routes otherwise it will match the first mounted application or redirect and generate a url with query parameters rather than raising an error if the options hash doesn't match any defined routes. Fixes #8018
* | Removed unused file! Moved to actionviewArun Agrawal2013-07-131-91/+0
| | | | | | | | Removed unused file as this has been moved to actionview
* | add test-case to verify `error.path` when a helper was not found.Yves Senn2013-07-121-0/+5
| | | | | | | | | | This verifies the code added with: https://github.com/rails/rails/commit/99c9d18601539c7e7e87f26bb047add1f93072af
* | move `MissingHelperError` out of the `ClassMethods` module.Yves Senn2013-07-121-1/+1
| |
* | Remove accidentally committed vi .swp file.Marc Schütz2013-07-101-0/+0
| |
* | Show real LoadError on helpers requirePiotr Niełacny2013-07-103-0/+25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When helper try to require missing file rails will throw exception about missing helper. # app/helpers/my_helper.rb require 'missing' module MyHelper end And when we try do load helper class ApplicationController helper :my end Rails will throw exception. This is wrong because there is a helper file. Missing helper file helpers/my_helper.rb Now when helper try to require non-existed file rails will throw proper exception. No such file to load -- missing
* | Use Request#raw_post instead Request#bodyPaul Nikitochkin2013-07-081-0/+7
| | | | | | | | | | | | | | | | In order to get raw_post to be not empty after ParamsParser#parse_formatted_parameters, added rewinding of body stream input on parsing json params. Closes #11345
* | Merge pull request #11313 from gsamokovarov/url-encoded-params-testRafael Mendonça França2013-07-061-25/+27
|\ \ | | | | | | Cleanup ul_encoded_params_parsing_test
| * | Cleanup ul_encoded_params_parsing_testGenadi Samokovarov2013-07-051-25/+27
| | |
* | | Space is not required for Set-Cookie headerYamagishi Kazutoshi2013-07-051-0/+29
|/ /
* | Remove `page_cache_extension` deprecated methodFrancesco Rodriguez2013-07-011-15/+0
| |
* | use bytesize rather than force encodingAaron Patterson2013-06-281-2/+1
| |
* | Re-remove deprecated API.kennyj2013-06-281-7/+0
| |
* | Merge pull request #11000 from sbeckeriv/accept_headerCarlos Antonio da Silva2013-06-251-0/+6
|\ \ | | | | | | | | | Fix undefined method `ref' for nil:NilClass for bad accept headers
| * | Fix undefined method `ref' for nil:NilClass for bad accept headersStephen Becker IV2013-06-191-0/+6
| | |
* | | test-case => failingYves Senn2013-06-251-0/+13
| | |
* | | Merge pull request #11069 from ykzts/actiondispatch-ssl-secure-flag-igonore-caseGuillermo Iguaran2013-06-241-0/+14
|\ \ \ | | | | | | | | Flag cookies as secure with ignore case in ActionDispatch::SSL
| * | | Flag cookies as secure with ignore case in ActionDispatch::SSLYamagishi Kazutoshi2013-06-241-0/+14
| | | |
* | | | ActionDispatch:SSL: don't include STS header in non-https responsesGeoff Buesing2013-06-231-0/+5
|/ / /
* | | Don't remove trailing slash from PATH_INFO for mounted appsPiotr Sarnacki2013-06-211-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously when app was mounted as following: class Foo def call(env) [200, {}, [env['PATH_INFO']]] end end RackMountRailsBug::Application.routes.draw do mount RackTest.new => "/foo" end trailing slash was removed from PATH_INFO. For example requesting GET /foo/bar/ on routes defined above would result in a response containing "/foo/bar" instead of "/foo/bar/". This commit fixes the issue. (closes #3215)
* | | Remove digestor fixtures from APŁukasz Strzałkowski2013-06-2012-25/+0
| | | | | | | | | | | | They were moved to actionview/ and are not used in actionpack
* | | Remove unneeded test fixtures in AVPiotr Sarnacki2013-06-20108-281/+0
| | |
* | | Remove unneeded filesPiotr Sarnacki2013-06-202-50/+0
| | |
* | | Move template tests from actionpack to actionviewPiotr Sarnacki2013-06-2052-16208/+0
| | |
* | | Added test for link_to_unless to make sure the result consistency.dtaniwaki2013-06-161-0/+5
| | |
* | | Use a case insensitive URI Regexp for #asset_pathDavid Celis2013-06-161-2/+5
|/ / | | | | | | | | | | | | | | | | | | | | | | | | Context: https://gist.github.com/radar/5793814 The `URI_REGEXP` that various AssetUrl helpers use is currently case sensitive when checking for a URI scheme. This means if you try to pass a URL like `HTTP://www.example.com/path/to/image.jpg`, you end up with a bogus asset path: `/assets/HTTP://www.example.com/path/to/image.jpg`. URLs are case insensitive, so this regexp should be as well. Signed-off-by: David Celis <me@davidcel.is>
* | collection tags accept html attributes as the last element of collectionVasiliy Ermolovich2013-06-161-0/+16
| |
* | Update the HTML boolean attributes per the HTML 5.1 specAlex Peattie2013-06-141-2/+2
| | | | | | | | | | | | | | - Add attributes `allowfullscreen`, `default`, `inert`, `sortable`, `truespeed`, `typemustmatch`. - Fix attribute `seamless` (previously misspelled `seemless`). - Use `assert_dom_equal` instead of `assert_equal` in test.
* | Don't set X-UA-Compatible header by defaultGuillermo Iguaran2013-06-131-3/+1
| | | | | | | | | | | | We are setting this header to chrome=1 for Chrome Frame and this will be retired soon. Check http://blog.chromium.org/2013/06/retiring-chrome-frame.html for details
* | Warning removed for MinitestArun Agrawal2013-06-121-1/+1
| |
* | Fix mismatching variable names when using an underscoreDrew Ulmer2013-06-041-13/+41
| | | | | | | | | | | | | | | | The ERBTracker template digest helper class was using a regex to match render calls and it was incorrectly not matching against variables with underscores in the name. This caused it to use the wrong regex match data to populate the template dependency. Because underscore is a valid character for a variable, this fixes the ERBTracker to match it properly.
* | Raise ArgumentError to fix Rails 4.1 deprecation warn message.kennyj2013-06-021-5/+7
| |
* | Remove Mime::Type#verify_request? and Mime::Type.browser_generated_types ↵kennyj2013-06-022-21/+0
| | | | | | | | were deprecated.
* | Remove ActionView::Template#mime_type was deprecated.kennyj2013-06-011-7/+0
| |
* | Remove ActionController::RecordIdentifier was deprecated.kennyj2013-06-012-63/+3
| |
* | Remove :confirm and :disable_with options from ↵kennyj2013-06-011-28/+0
| | | | | | | | ActionView::Helpers::FormTagHelper were deprecated.
* | Remove link_to_function / button_to_function from ↵kennyj2013-06-011-42/+0
| | | | | | | | ActionView::Helpers::JavascriptHelper were deprecated.
* | Remove :confirm and :disable_with options for ↵kennyj2013-06-011-75/+0
| | | | | | | | ActionView::Helpers::UrlHelper#link_to and #button_to were deprecated.
* | `RoutesInspector` deals with routes using regexp as `:controller` optionYves Senn2013-05-301-0/+9
| |
* | Running isolated testsArun Agrawal2013-05-281-15/+0
| | | | | | | | These stopped running don't know when. But these should be running now.
* | Add has_named_route? to the mapper APIJosé Valim2013-05-201-0/+13
| |
* | Fix named routing regression from 3.2.13schneems2013-05-161-0/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When named route that is nested is used in 3.2.13 Example `routes.rb`: ``` resources :nested do resources :builder, :controller => 'nested/builder' end ``` In 3.2.12 and 3.2.12 this named route would work: ``` nested_builder_path(:last_step, :nested_id => "foo") ``` Generating a url that looks like `/nested/foo/builder/last_step`. This PR fixes the regression when building urls via the optimized helper. Any explicit keys set in the options are removed from the list of implicitly mapped keys. Not sure if this is exactly how the original version worked, but this fixes this use case regression.
* | Revert "Integration tests support the OPTIONS http method"Rafael Mendonça França2013-05-161-17/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit ad46884af567d6f8d6d8d777f372c39e81a560ba. Conflicts: actionpack/CHANGELOG.md actionpack/lib/action_dispatch/testing/integration.rb actionpack/test/controller/integration_test.rb Reason: It will conflict with a lot of test cases. Better to call `process` directly since this is a very uncommon HTTP method. Fixes #10638.
* | Merge pull request #10636 from seanwalbran/fix-asset-host-proc-returning-nilRafael Mendonça França2013-05-161-0/+11
|\ \ | | | | | | fix rails4 regression with asset_host Proc returning nil
| * | restore ability to return nil from asset_host proc, add testSean Walbran2013-05-151-0/+11
| | |
* | | Revert "Add the options method to action_controller testcase."Rafael Mendonça França2013-05-161-5/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 0303c2325fab253adf5e4a0b738cb469c048f008. Conflicts: actionpack/lib/action_controller/test_case.rb REASON: It will conflict with a lot of test cases. Better to call `process` directly since this is a very uncommon HTTP method. Fixes #10638.