Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Custom flash should be defined only for the class that defines it and it's ↵ | Ricardo de Cillo | 2013-09-13 | 1 | -0/+12 |
| | | | | subclasses. | ||||
* | Merge pull request #12159 from nashby/issue-12149 | Rafael Mendonça França | 2013-09-12 | 1 | -0/+9 |
|\ | | | | | do not break params filtering on nil values | ||||
| * | do not break params filtering on nil values | Vasiliy Ermolovich | 2013-09-07 | 1 | -0/+9 |
| | | | | | | | | closes #12149 | ||||
* | | Removed semicolon and added space | Anupam Choudhury | 2013-09-13 | 1 | -2/+2 |
| | | |||||
* | | Reset ActionView::Base.logger instead of AC::Base.logger | Akira Matsuda | 2013-09-10 | 1 | -1/+1 |
| | | | | | | | | see: 9b0ac0bc74569db460f87ea6888b3847be0ff5be | ||||
* | | Make AC standalone rendering work | Santiago Pastorino | 2013-09-10 | 1 | -0/+15 |
| | | |||||
* | | Remove helper fixtures not used in any test | claudiob | 2013-09-09 | 1 | -2/+0 |
|/ | | | | | | The fixture for module AbcHelper defines three functions bare_a, bare_b and bare_c, but only bare_a is used in the code that tests helper functions. | ||||
* | Revert "Port all remaining self.protected_instance_variables to class methods" | Łukasz Strzałkowski | 2013-09-02 | 1 | -1/+1 |
| | | | | This reverts commit 7de994fa215e9f4c2856d85034bc4dd7b65d0c01. | ||||
* | Merge pull request #11912 from jonkessler/respond-to-signature-fixes | Rafael Mendonça França | 2013-08-31 | 1 | -0/+5 |
|\ | | | | | Update Rails::Railtie::Configuration and ActionDispatch::Response#respond_to? to accept include_private argument | ||||
| * | update Rails::Railtie::Configuration and ↵ | Jon Kessler | 2013-08-16 | 1 | -0/+5 |
| | | | | | | | | ActionDispatch::Response#respond_to? to accept include_private argument | ||||
* | | Port all remaining self.protected_instance_variables to class methods | Łukasz Strzałkowski | 2013-08-29 | 1 | -1/+1 |
| | | |||||
* | | Move abstract's controller tests to AV | Łukasz Strzałkowski | 2013-08-25 | 15 | -891/+0 |
| | | | | | | | | The ones that were actually testing AV functionality and should belong in there | ||||
* | | Extend basic rendering, test it in railties | Łukasz Strzałkowski | 2013-08-25 | 1 | -19/+0 |
| | | |||||
* | | Basic rendering test | Łukasz Strzałkowski | 2013-08-25 | 1 | -0/+19 |
| | | |||||
* | | Move AP's capture tests to AV | Łukasz Strzałkowski | 2013-08-25 | 1 | -79/+0 |
| | | |||||
* | | Move remaining layouts tests to AV | Łukasz Strzałkowski | 2013-08-25 | 10 | -270/+0 |
| | | |||||
* | | Remove unused fixtures and models from AP tests | Łukasz Strzałkowski | 2013-08-25 | 7 | -12/+0 |
| | | |||||
* | | Move render_test to AV | Łukasz Strzałkowski | 2013-08-25 | 1 | -1298/+106 |
| | | |||||
* | | Load AV::Layout to AM::Base in railties | Łukasz Strzałkowski | 2013-08-25 | 1 | -0/+3 |
| | | |||||
* | | Remove RenderERBUtils from AP (only AV use it) | Łukasz Strzałkowski | 2013-08-25 | 1 | -22/+0 |
| | | |||||
* | | Remove AV::TestCase from AP | Łukasz Strzałkowski | 2013-08-25 | 1 | -8/+0 |
| | | |||||
* | | Load AV::Layouts dynamicly via railties | Łukasz Strzałkowski | 2013-08-25 | 1 | -0/+2 |
| | | |||||
* | | Create AbstractController::Rendering interface | Łukasz Strzałkowski | 2013-08-25 | 7 | -2/+9 |
| | | | | | | | | This interface should be use when implementing renderers. | ||||
* | | Fix AP test suite after moving stuff to AV | Łukasz Strzałkowski | 2013-08-25 | 5 | -6/+7 |
| | | |||||
* | | Move view_paths from AP to AV | Łukasz Strzałkowski | 2013-08-25 | 3 | -176/+0 |
| | | |||||
* | | Display exceptions in text format for xhr request | Kir Shatrov | 2013-08-22 | 1 | -0/+41 |
| | | |||||
* | | Merge pull request #11443 from wangjohn/sse_reloader_class | Santiago Pastorino | 2013-08-19 | 1 | -0/+88 |
|\ \ | | | | | | | SSE class for ActionController::Live | ||||
| * | | Creating an SSE class to be used with ActionController::Live. | wangjohn | 2013-07-30 | 1 | -0/+88 |
| | | | |||||
* | | | Fail informatively in #respond_with when no appropriate #api_behavior ↵ | Ben Woosley | 2013-08-17 | 1 | -0/+31 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | renderer is available. Currently if a user calls #respond_with(csvable), but has not csv renderer available, Responder will just run through the default render behavior twice, raising ActionView::MissingTemplate both times. This changes ActionController::Metal::Responder#api_behavior to check in advance whether there is a renderer available, and raise ActionController::MissingRenderer if not. | ||||
* | | | Split the 1200+ line mime_responds_test into 3 more focused and manageable ↵ | Ben Woosley | 2013-08-17 | 3 | -587/+587 |
| | | | | | | | | | | | | test files. | ||||
* | | | Merge branch 'master' of github.com:rails/docrails | Vijay Dev | 2013-08-17 | 3 | -6/+1 |
|\ \ \ | |_|/ |/| | | | | | | | | | | | | | | | | | Conflicts: actionview/README.rdoc activerecord/lib/active_record/migration.rb guides/source/development_dependencies_install.md guides/source/getting_started.md | ||||
| * | | Revert "Merge branch 'master' of github.com:rails/docrails" | Vijay Dev | 2013-08-17 | 3 | -6/+1 |
| |/ | | | | | | | | | | | | | This reverts commit 70d6e16fbad75b89dd1798ed697e7732b8606fa3, reversing changes made to ea4db3bc078fb3093ecdddffdf4f2f4ff3e1e8f9. Seems to be a code merge done by mistake. | ||||
* | | Execute conditional procs on controller filters only for current action. | Nicholas Jakobsen | 2013-08-10 | 1 | -0/+9 |
| | | | | | | | | | | | | :only and :except options for controller filters are now added before :if and :unless. This prevents running :if and :unless procs when not on the specified. Closes #11786. | ||||
* | | Add timeout to test_async_stream | Gaurish Sharma | 2013-08-02 | 1 | -1/+1 |
|/ | | | | | | | | | | Without timeout: this test executed infinitely on JRuby Passes on MRI With Timeout: this test gracefully fails on JRuby Passes on MRI, tested on v2.0 & v1.9.3 | ||||
* | Reset ActionView::Base.logger instead of AC::Base.logger | Akira Matsuda | 2013-07-26 | 1 | -1/+1 |
| | | | | see: 9b0ac0bc74569db460f87ea6888b3847be0ff5be | ||||
* | Fix order dependent tests | Akira Matsuda | 2013-07-26 | 1 | -0/+4 |
| | | | | Reset ActionView::Base.logger after tests | ||||
* | Fix order dependent AP test | Akira Matsuda | 2013-07-26 | 1 | -0/+1 |
| | | | | | | | | | | | | | | | | | | | | | | any_instance.stubs + unstub with Mocha doesn't restore the original status in the following case, so we need to undef Customer#to_json before every test require 'test/unit' require 'mocha/setup' module M def foo() :foo; end end class C include M undef_method :foo end C.any_instance.stubs(:foo).returns(:mocha) C.any_instance.unstub(:foo) | ||||
* | Allow overriding of all headers from passed environment hash | Andrew White | 2013-07-25 | 1 | -0/+30 |
| | | | | | | | Allow REMOTE_ADDR, HTTP_HOST and HTTP_USER_AGENT to be overridden from the environment passed into `ActionDispatch::TestRequest.new`. Fixes #11590 | ||||
* | Fix failing test missed for the past year :( | Andrew White | 2013-07-17 | 1 | -1/+1 |
| | | | | | | | | | When optimized path helpers were re-introduced in d7014bc the test added in a328f2f broke but no-one noticed because it wasn't being run by the test suite. Fix the test by checking for nil values or empty strings after the args have been parameterized. | ||||
* | Skip Rack applications and redirects when generating urls | Andrew White | 2013-07-16 | 3 | -12/+69 |
| | | | | | | | | | | When generating an unnamed url (i.e. using `url_for` with an options hash) we should skip anything other than standard Rails routes otherwise it will match the first mounted application or redirect and generate a url with query parameters rather than raising an error if the options hash doesn't match any defined routes. Fixes #8018 | ||||
* | Removed unused file! Moved to actionview | Arun Agrawal | 2013-07-13 | 1 | -91/+0 |
| | | | | Removed unused file as this has been moved to actionview | ||||
* | add test-case to verify `error.path` when a helper was not found. | Yves Senn | 2013-07-12 | 1 | -0/+5 |
| | | | | | This verifies the code added with: https://github.com/rails/rails/commit/99c9d18601539c7e7e87f26bb047add1f93072af | ||||
* | move `MissingHelperError` out of the `ClassMethods` module. | Yves Senn | 2013-07-12 | 1 | -1/+1 |
| | |||||
* | Remove accidentally committed vi .swp file. | Marc Schütz | 2013-07-10 | 1 | -0/+0 |
| | |||||
* | Show real LoadError on helpers require | Piotr Niełacny | 2013-07-10 | 3 | -0/+25 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | When helper try to require missing file rails will throw exception about missing helper. # app/helpers/my_helper.rb require 'missing' module MyHelper end And when we try do load helper class ApplicationController helper :my end Rails will throw exception. This is wrong because there is a helper file. Missing helper file helpers/my_helper.rb Now when helper try to require non-existed file rails will throw proper exception. No such file to load -- missing | ||||
* | Use Request#raw_post instead Request#body | Paul Nikitochkin | 2013-07-08 | 1 | -0/+7 |
| | | | | | | | | In order to get raw_post to be not empty after ParamsParser#parse_formatted_parameters, added rewinding of body stream input on parsing json params. Closes #11345 | ||||
* | Merge pull request #11313 from gsamokovarov/url-encoded-params-test | Rafael Mendonça França | 2013-07-06 | 1 | -25/+27 |
|\ | | | | | Cleanup ul_encoded_params_parsing_test | ||||
| * | Cleanup ul_encoded_params_parsing_test | Genadi Samokovarov | 2013-07-05 | 1 | -25/+27 |
| | | |||||
* | | Space is not required for Set-Cookie header | Yamagishi Kazutoshi | 2013-07-05 | 1 | -0/+29 |
|/ | |||||
* | Remove `page_cache_extension` deprecated method | Francesco Rodriguez | 2013-07-01 | 1 | -15/+0 |
| |