Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Minor cleanup, helper method was only used once | Ayrton De Craene | 2012-10-15 | 1 | -5/+1 |
| | |||||
* | Cleanup trailing whitespaces | dfens | 2012-10-12 | 1 | -1/+1 |
| | |||||
* | When executing permit with just a key that points to a hash, DO NOT allow ↵ | Santiago Pastorino | 2012-10-12 | 1 | -1/+5 |
| | | | | | | | | | | | | | | all the hash params.require(:person).permit(:projects_attributes) was returning => {"projects_attributes"=>{"0"=>{"name"=>"Project 1"}}} When should return => {} You should be doing ... params.require(:person).permit(projects_attributes: :name) to get just the projects attributes you want to allow | ||||
* | Allow for deep directory path for view templates. | Andy Shipman | 2012-10-11 | 3 | -0/+7 |
| | |||||
* | recognizes when a partial was rendered twice. Closes #3675 | Yves Senn | 2012-10-11 | 2 | -0/+10 |
| | |||||
* | Remove old asset tag concatenation | Joshua Peek | 2012-10-10 | 1 | -752/+0 |
| | | | | Use sprockets, jammit, or some other asset bundler | ||||
* | Rename "Fixtures" class to "FixtureSet" | Alexey Muranov | 2012-10-07 | 1 | -1/+1 |
| | | | | Rename `ActiveRecord::Fixtures` class to `ActiveRecord::FixtureSet`. Instances of this class normally hold a collection of fixtures (records) loaded either from a single YAML file, or from a file and a folder with the same name. This change make the class name singular and makes the class easier to distinguish from the modules like `ActiveRecord::TestFixtures`, which operates on multiple fixture sets, or `DelegatingFixtures`, `::Fixtures`, etc., and from the class `ActiveRecord::Fixture`, which corresponds to a single fixture. | ||||
* | Ruby 2 compat. CGI.escapeHTML has changed the way it escapes apostrophes a ↵ | Jeremy Kemper | 2012-10-06 | 1 | -1/+1 |
| | | | | few times, so fix up the test to work with however it chooses to escape. | ||||
* | Update some code styles. | Rafael Mendonça França | 2012-10-06 | 1 | -150/+180 |
| | | | | | * Uses the Ruby 1.9 hash syntax * Avoid escaping " inside string using the %{} syntax | ||||
* | Accept :remote as symbol in link_to options | Riley Lynch | 2012-10-06 | 1 | -0/+14 |
| | | | | | Accept either :remote or 'remote' in both the html_options and (url_)options hash arguments to link_to. | ||||
* | can't pass :locals to #assert_template without a view test case. Closes #3415 | Yves Senn | 2012-10-06 | 1 | -0/+11 |
| | | | | | | | | | | | the documentation on #assert_template states that the :locals option is only available in view test cases: # In a view test case, you can also assert that specific locals are passed # to partials: I added a warning when it's passed in an inapropriate context to prevent a NoMethodError. | ||||
* | Allow parameter filters to match multi-parameter attributes | Rafael Mendonça França | 2012-10-05 | 1 | -0/+33 |
| | | | | | | | This will make easier to permit date/time attributes generated by helpers like date_select. [Sven Schwyn + Rafael Mendonça França] | ||||
* | ActionController::Parameters#permit! is recursive | Brendan Loudermilk | 2012-10-04 | 1 | -0/+7 |
| | |||||
* | rename page_cache_extension option to default_static_extension | Francesco Rodriguez | 2012-10-03 | 1 | -0/+15 |
| | |||||
* | extract AP Page and Action caching to actionpack-deprecated_caching gem | Francesco Rodriguez | 2012-10-03 | 2 | -739/+16 |
| | |||||
* | Failsafe exception returns text/plain. | Steve Klabnik | 2012-10-01 | 1 | -0/+16 |
| | | | | | | | It's best to just return text/plain when something has gone terribly wrong. Fixes #5660. | ||||
* | resource and resources do no longer modify passed options | Yves Senn | 2012-10-01 | 1 | -0/+20 |
| | | | | this is a patch for #7777. | ||||
* | fix cache store test | Steve Klabnik | 2012-09-30 | 1 | -0/+1 |
| | | | | Pull #7800 broke the build, this should fix it. | ||||
* | `assert_template` no more passing with what ever string that matches. | Hugo Roque | 2012-09-29 | 2 | -0/+23 |
| | | | | | | | | | | | | | | | | | | | | | | | Given Im rendering an template `/layout/hello.html.erb`, assert_template was passing with any string that matches. This behavior allowed false passing like: assert_template "layout" assert_template "out/hello" Now the passing possibilities are: assert_template "layout/hello" assert_template "hello" fixing assert_template bug when template matches expected, but not ends with Cherry Pick Merge: Fixes issue #3849 assert_template false positive taking redundant test off prevening incorrect assert_template when rendering with repeated names in path updating CHANGELOG with bugfix: assert_template false passing | ||||
* | move metal/caching_test into controller/caching_test | Francesco Rodriguez | 2012-09-27 | 2 | -37/+42 |
| | |||||
* | remove method redefinition warnings | Rafael Mendonça França | 2012-09-27 | 2 | -2/+2 |
| | | | | | actionpack/test/template/spec_type_test.rb:32: warning: method redefined; discarding old test_spec_type_wont_match_non_space_characters actionpack/test/controller/spec_type_test.rb:30: warning: previous definition of test_spec_type_wont_match_non_space_characters was here | ||||
* | Merge pull request #7444 from szimek/params_parser_raises_parsing_error | Aaron Patterson | 2012-09-26 | 2 | -2/+6 |
|\ | | | | | Raise generic ParseError exception when ParamsParser fails parsing request params | ||||
| * | Make ActionDispatch::ParamsParser::ParseError#original_exception return the ↵ | Szymon Nowak | 2012-08-27 | 2 | -2/+4 |
| | | | | | | | | original exception. | ||||
| * | Fix ActionDispatch::ParamsParser::ParseError message for XML and JSON parsers. | Szymon Nowak | 2012-08-24 | 2 | -2/+4 |
| | | |||||
| * | Raise generic ParseError exception when ActionDispatch::ParamsParser fails ↵ | Szymon Nowak | 2012-08-24 | 2 | -2/+2 |
| | | | | | | | | parsing request params. | ||||
* | | fixing most tests on Ruby 2.0 | Aaron Patterson | 2012-09-25 | 1 | -2/+2 |
| | | |||||
* | | allow to pass numerical value to size option in image_tag | Nihad Abbasov | 2012-09-25 | 1 | -1/+1 |
| | | | | | | | | | | This will set image's both width and height attributes to value passed in size option. | ||||
* | | Merge pull request #7749 from blowmage/minitest | Aaron Patterson | 2012-09-25 | 6 | -1/+382 |
|\ \ | | | | | | | Improve support for minitest's spec DSL | ||||
| * | | Register AD::IntegrationTest for minitest's spec DSL | Mike Moore | 2012-09-24 | 1 | -0/+41 |
| | | | |||||
| * | | Support helper tests using spec DSL | Mike Moore | 2012-09-24 | 2 | -1/+57 |
| | | | | | | | | | | | | | | | Improve how helper tests to resolve the helper class from the test name. Add tests for helper tests using the minitest spec DSL. | ||||
| * | | Register helper and view tests for minitest's spec DSL | Mike Moore | 2012-09-24 | 1 | -0/+39 |
| | | | |||||
| * | | Allow strings in the controller test describe blocks | Mike Moore | 2012-09-24 | 2 | -0/+129 |
| | | | | | | | | | | | | | | | Allow controller tests using the spec DSL to match strings. Add test coverage for the register_spec_type calls. | ||||
| * | | Support controller tests using spec DSL - fixes #7743 | Mike Moore | 2012-09-24 | 1 | -0/+116 |
| | | | | | | | | | | | | Add tests for controller tests using the minitest spec DSL. | ||||
* | | | depreacte unused Mime::Type#verify_request? and ↵ | grosser | 2012-09-24 | 2 | -7/+13 |
|/ / | | | | | | | Mime::Type.browser_generated_types | ||||
* | | fixes the suite for uploaded files | Xavier Noria | 2012-09-23 | 1 | -6/+6 |
| | | |||||
* | | Accept parameters in methods delegated to tempfile | Sergio Gil Pérez de la Manga | 2012-09-22 | 1 | -0/+6 |
| | | |||||
* | | Delegate ActionDispatch::Http::UploadedFile#close to tempfile | Sergio Gil Pérez de la Manga | 2012-09-20 | 1 | -0/+6 |
| | | |||||
* | | Removing to_shorthand from default_controller_and_action. Fixes #6497 | Luiz Felipe | 2012-09-19 | 1 | -0/+7 |
| | | | | | | | | | | When using shortcut routes inside an engine the "to_shorthand" variable is set to true, causing the module scope of the route to not be applied. | ||||
* | | Correct parameter access. | Philip Arndt | 2012-09-19 | 1 | -1/+1 |
| | | | | | | * The params as supplied pass born in authors[0] but not authors[1] so it seems like the test isn't covering what it should be covering. | ||||
* | | Merge pull request #7251 from rails/integrate-strong_parameters | David Heinemeier Hansson | 2012-09-18 | 7 | -41/+251 |
|\ \ | | | | | | | Integrate strong_parameters in Rails 4 | ||||
| * | | Support fields_for attributes, which may have numeric symbols as hash keys | Guillermo Iguaran | 2012-09-16 | 1 | -0/+18 |
| | | | |||||
| * | | Add config.action_controller.permit_all_attributes to bypass ↵ | Guillermo Iguaran | 2012-09-16 | 1 | -0/+14 |
| | | | | | | | | | | | | StrongParameters protection | ||||
| * | | Change tainted/untainted wording to permitted/forbidden | Guillermo Iguaran | 2012-09-16 | 3 | -26/+26 |
| | | | |||||
| * | | Don't use assert_nothing_raised when assert_equal is used | Guillermo Iguaran | 2012-09-16 | 1 | -4/+2 |
| | | | |||||
| * | | require abstract_unit in parameters tests | Guillermo Iguaran | 2012-09-16 | 3 | -0/+3 |
| | | | |||||
| * | | Remove integration between attr_accessible/protected and ↵ | Guillermo Iguaran | 2012-09-16 | 2 | -41/+0 |
| | | | | | | | | | | | | AC::Metal::ParamsWrapper | ||||
| * | | Integrate ActionController::Parameters from StrongParameters gem | Guillermo Iguaran | 2012-09-16 | 5 | -0/+218 |
| | | | |||||
* | | | log 404 status when ActiveRecord::RecordNotFound was raised (#7646) | Yves Senn | 2012-09-17 | 1 | -0/+15 |
| | | | |||||
* | | | Merge pull request #7669 from guilleiguaran/rename-rb-handler | Carlos Antonio da Silva | 2012-09-17 | 2 | -3/+3 |
|\ \ \ | | | | | | | | | Rename .rb template handler to .ruby to avoid conflicts with mustache classes | ||||
| * | | | Rename .rb template handler to .ruby to avoid conflicts with mustache views ↵ | Guillermo Iguaran | 2012-09-17 | 2 | -3/+3 |
| |/ / | | | | | | | | | | classes |