aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/test
Commit message (Collapse)AuthorAgeFilesLines
* Reload action_methods in AbstractController after defining new method.Piotr Sarnacki2010-08-041-0/+14
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Use AS::OrderedHash when trusting in the order of the hashSantiago Pastorino2010-08-011-2/+3
|
* Fix label form helper to use I18n and html options, without the need of ↵Carlos Antonio da Silva2010-08-011-2/+9
| | | | | | | | | | | 'nil' text param: Before: f.label :title, nil, :class => 'title' After : f.label :title, :class => 'title' [#5267 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* Makes form_helper use overriden model accessorsSantiago Pastorino2010-08-011-0/+17
| | | | [#3374 state:committed]
* link_to_function now expects a piece of javascript code for the onclick ↵Rodrigo Dominguez2010-07-291-4/+5
| | | | | | | | parameter [#5179] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* Removed deprecated APIs in text and number helpers [#5156 state:resolved]Łukasz Strzałkowski2010-07-261-27/+0
| | | | | | They're deprecated since 2008. It's time to get rid of them. Signed-off-by: José Valim <jose.valim@gmail.com>
* Add assertion to link_to_function test with block and capture, and more ↵Carlos Antonio da Silva2010-07-251-5/+4
| | | | | | expressive test name [#5179 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* Change returning with tapSantiago Pastorino2010-07-251-1/+1
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Fixed output_buffer encoding problem [#5179]Sebastian A. Espindola2010-07-251-0/+9
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> Signed-off-by: José Valim <jose.valim@gmail.com>
* These tests are trusting in the order of the elements so use OrderedHash ↵Santiago Pastorino2010-07-211-13/+9
| | | | instead of Hash
* Fixed a globbed route issue where slashes were being escaped, causing ↵Brian Rose2010-07-211-0/+7
| | | | | | assert_routing to fail. [#5135 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* remote_function patch with more detailed testAndrew Kaspick2010-07-211-0/+6
| | | | Signed-off-by: wycats <wycats@gmail.com>
* Ensure insert_before in middleware stack raises a meaningful error message ↵José Valim2010-07-211-0/+10
| | | | [#3679 state:resolved]
* Moved a few methods from RecordIdentifier to ActiveModel::NamingPiotr Sarnacki2010-07-211-40/+0
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Extract ParameterFilter class from FilterParameters mixinBryan Helmkamp2010-07-191-4/+4
| | | | Signed-off-by: wycats <wycats@gmail.com>
* Remove assert_valid. It was already deprecated on Rails 2.3.José Valim2010-07-191-15/+0
|
* Exceptions from views should be rescued based on the original exception. If ↵Neeraj Singh2010-07-191-0/+27
| | | | | | | | a handler for original exception is missing then apply ActiveView::TemplateError [#2034 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* Set session options id to nil is respected and cancels lazy loading.José Valim2010-07-181-1/+19
|
* select :include_blank or :prompt should return escaped string [#5099 ↵Ivan Torres2010-07-181-0/+23
| | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* remove size attribute from tag generated by file_field helper [#5084 ↵Miles Egan2010-07-131-0/+5
| | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* Routes should respect namespace even if action is a regexp and just ↵José Valim2010-07-121-3/+15
| | | | controller is given to to.
* Fix setting helpers_path to a string or pathnameJeremy Kemper2010-07-072-4/+4
|
* When a dynamic :controller segment is present in the path add a Regexp ↵Andrew White2010-07-071-11/+25
| | | | | | | | | | | constraint that allow matching on multiple path segments. Using a namespace block isn't compatible with dynamic routes so we raise an ArgumentError if we detect a :module present in the scope. [#5052 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* Refactor handling of :only and :except options. The rules are:Andrew White2010-07-061-47/+190
| | | | | | | | | | | 1. Don't inherit when specified as an option on a resource 2. Don't push into scope when specified as an option on a resource 2. Resources pull in :only or :except options from scope 3. Either :only or :except in nested scope overwrites parent scope [#5048 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* Recognize should also work with route is wrapped in a constraint.José Valim2010-07-061-1/+4
|
* Adds tests for content negotiation change introduced in dc5300adb6d46252c26ePatrik Stenmark2010-07-041-0/+20
| | | | Signed-off-by: wycats <wycats@gmail.com>
* Fix syntax of routing tests so they actually runAndrew White2010-07-041-12/+18
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Refactor resource options and scoping. Resource classes are now only ↵Andrew White2010-07-041-2/+81
| | | | | | responsible for controlling how they are named. All other options passed to resources are pushed out to the scope. Signed-off-by: José Valim <jose.valim@gmail.com>
* Refactor recall parameter normalization [#5021 state:resolved]Andrew White2010-07-031-2/+27
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Fix routes with :controller segment when namespaced [#5034 state:resolved]José Valim2010-07-022-12/+29
|
* Unify routes naming by renaming router to routesPiotr Sarnacki2010-07-023-13/+13
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* porting session.clear fix to master branch. [#5030 state:resolved]Aaron Patterson2010-07-011-0/+22
| | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* A couple enhancements to the router:José Valim2010-06-301-0/+27
| | | | | | | | * Allow to use the get :symbol shortcut outside resources scopes as well; * Fix a bug where :action was not being picked from given options; * Giving :as option inside a resource now changes just the relative name instead of the full name;
* We are trying to test that & escapes here not that &amp; is being escaped, ↵Santiago Pastorino2010-06-291-3/+2
| | | | | | also added a cosmetic change to test_link_tag_with_query_and_no_name Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* s/escape_once/html_escape/, since html safety is the contract that now says ↵Xavier Noria2010-06-302-4/+4
| | | | whether something has to be escaped
* url_for no longer escapes HTML, the :escape option is also goneXavier Noria2010-06-301-16/+4
| | | | Rationale: url_for is just a path/URL generator, it is the responsability of the caller to escape conveniently HTML needs it, JavaScript needs different escaping, a text mail needs no escaping at all, etc.
* Rename _snowman_ to _snowman to be in sync with _method and _csrf_token.José Valim2010-06-292-2/+2
|
* Restores the escaping of urls generated from hashes. [#4765 state:resolved]Andrew White2010-06-281-8/+4
| | | | | | | | | | | | | | HTML specifications recommend the escaping of urls in web pages, which url_for does by default for string urls and consquently urls generated by path helpers as these return strings. Hashes passed to url_for are not escaped by default and this commit reverses this default so that they are escaped. Undoes the changes of this commit: http://github.com/rails/rails/commit/1b3195b63ca44f0a70b61b75fcf4991cb2fbb944 Signed-off-by: José Valim <jose.valim@gmail.com>
* Merge :constraints from scope into resource options [#2694 state:resolved]Andrew White2010-06-281-0/+43
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Remove invalid conditions from route [#4989 state:resolved]Andrew White2010-06-281-0/+12
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Deprecate the old router DSL. Since it is still used intensively across ↵José Valim2010-06-282-15/+23
| | | | ActionPack test suite, patches that translates Rails internal tests to the new router DSL are welcome (note though that a few tests shouldn't be translated since they are testing exactly the old mapper API, like the ones in actionpack/test/controller/resource_test.rb and actionpack/test/controller/routing_test.rb)
* Strip_tags never ending attribute should not raise a TypeError [#4870 ↵Bruno Michel2010-06-281-0/+4
| | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* Fix several known web encoding issues:wycats2010-06-275-194/+276
| | | | | | | | | | | | | | | | | | | | | | | * Specify accept-charset on all forms. All recent browsers, as well as IE5+, will use the encoding specified for form parameters * Unfortunately, IE5+ will not look at accept-charset unless at least one character in the form's values is not in the page's charset. Since the user can override the default charset (which Rails sets to UTF-8), we provide a hidden input containing a unicode character, forcing IE to look at the accept-charset. * Now that the vast majority of web input is UTF-8, we set the inbound parameters to UTF-8. This will eliminate many cases of incompatible encodings between ASCII-8BIT and UTF-8. * You can safely ignore params[:_snowman_] TODO: * Validate inbound text to confirm it is UTF-8 * Combine the whole_form implementations in form_helper_test and form_tag_helper_test
* Upgrade to Rack 1.2.1Jeremy Kemper2010-06-271-8/+14
|
* Move Rails module to abstract_unit to make test in isolation workSantiago Pastorino2010-06-282-3/+3
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Fixed that an ArgumentError is thrown when request.session_options[:id] is ↵Michael Lovitt2010-06-274-0/+75
| | | | | | | | read in the following scenario: when the cookie store is used, and the session contains a serialized object of an unloaded class, and no session data accesses have occurred yet. Pushed the stale_session_check responsibility out of the SessionHash and down into the session store, closer to where the deserialization actually occurs. Added some test coverage for this case and others related to deserialization of unloaded types. [#4938] Signed-off-by: José Valim <jose.valim@gmail.com>
* Normalize recall params when the route is not a standard route otherwise ↵Andrew White2010-06-271-0/+22
| | | | | | :controller and :action may appear in the generated url [#4326 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* Change reference to Test::Unit::AssertionFailedError to the generic ↵David Trasbo2010-06-261-1/+1
| | | | | | ActiveSupport::TestCase::Assertion [#4987 state:commited] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* Support optional static segements as well [#4832 state:resolved]Andrew White2010-06-261-0/+34
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Fixed normalize_path in Routing::Mapper to handle optional prefix segments ↵Paul Barry2010-06-261-0/+46
| | | | | | with static and dynamic parts Signed-off-by: José Valim <jose.valim@gmail.com>