aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/test
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | adds a regression test for the strong params converted arrays cacheXavier Noria2014-06-071-1/+18
| | | | | | | | | | | | | | | | This is a regression test for 29844dd.
* | | | Revert "Convert StrongParameters cache to a hash. This fixes an unbounded"Xavier Noria2014-06-071-1/+1
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We cannot cache keys because arrays are mutable. We rather want to cache the arrays. This behaviour is tailor-made for the usage pattern strongs params is designed for. In a forthcoming commit I am going to add a test that covers why we need to cache by value. Every strong params instance has a live span of a request, the cache goes away with the object. Since strong params have such a concrete intention, it would be interesting to see if there are actually any real-world use cases that are an actual leak, one that practically may matter. I am not convinced that the theoretical leak has any practical consequences, but if it can be shown there are, then I believe we should either get rid of the cache (which is an optimization), or else wipe it in the mutating API. This reverts commit e63be2769c039e4e9ada523a8497ce3206cc8a9b.
* | | Merge pull request #15530 from zuhao/refactor_actionpack_reloader_testMatthew Draper2014-06-061-0/+5
|\ \ \ | | | | | | | | Reset callbacks after test.
| * | | Reset callbacks after test.Zuhao Wan2014-06-051-0/+5
| | | | | | | | | | | | | | | | Otherwise the state of callback chain is leaked.
* | | | Merge pull request #15532 from zuhao/refactor_actionpack_response_testYves Senn2014-06-051-2/+4
|\ \ \ \ | | | | | | | | | | Restore Response.default_headers after test.
| * | | | Restore Response.default_headers after test.Zuhao Wan2014-06-051-2/+4
| | | | |
* | | | | Avoid hard-coded value in test setup/teardown.Zuhao Wan2014-06-051-1/+2
|/ / / /
* | | | Merge pull request #15529 from zuhao/refactor_actionpack_mime_type_testYves Senn2014-06-052-8/+0
|\ \ \ \ | |/ / / |/| | | Make sure Mime::Type is not altered after tests.
| * | | Mime::PNG is already defined.Zuhao Wan2014-06-052-8/+0
| | | |
* | | | Avoid hardcoded value in test setup/teardown.Zuhao Wan2014-06-051-1/+2
|/ / /
* | | Merge pull request #15498 from zenspider/fix_memory_leakGuillermo Iguaran2014-06-031-1/+1
|\ \ \ | | | | | | | | Convert StrongParameters cache to a hash. This fixes an unbounded memory leak
| * | | Convert StrongParameters cache to a hash. This fixes an unboundedRyan Davis2014-06-031-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | memory leak demonstrated on @tenderlove's latest blog post: http://tenderlovemaking.com/2014/06/02/yagni-methods-are-killing-me.html
* | | | Partially revert deprecation of *_filterRafael Mendonça França2014-06-031-5/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We are going to deprecate only on Rails 5 to make easier plugin maintainers support different Rails versions. Right now we are only discouraging their usage. This reverts commit 6c5f43bab8206747a8591435b2aa0ff7051ad3de. Conflicts: actionpack/CHANGELOG.md
* | | | Merge pull request #15349 from tgxworld/remove_duplicated_method_callRafael Mendonça França2014-06-031-4/+1
|\ \ \ \ | | | | | | | | | | Remove duplicated HashWithIndifferentAccess#with_indifferent_access.
| * | | | Remove duplicated HashWithIndifferentAccess#with_indifferent_access.Guo Xiang Tan2014-05-261-4/+1
| | | | |
* | | | | Routes specifying 'to:' must be a string that contains a "#" or a rackAaron Patterson2014-06-032-24/+32
| | | | | | | | | | | | | | | | | | | | | | | | | application. Use of a symbol should be replaced with `action: symbol`. Use of a string without a "#" should be replaced with `controller: string`.
* | | | | use the factory method to construct the mappingAaron Patterson2014-06-031-1/+1
| | | | |
* | | | | add tests for mixing :to and controller / actionAaron Patterson2014-06-031-0/+48
| | | | |
* | | | | add tests for nested lambda constraintsAaron Patterson2014-06-031-0/+27
| | | | |
* | | | | test with an empty viaAaron Patterson2014-06-031-0/+8
| | | | |
* | | | | add a test for missing "via" parameterAaron Patterson2014-06-031-0/+8
| | | | |
* | | | | Mapping never actually uses @set, so rmAaron Patterson2014-05-291-1/+1
| | | | |
* | | | | no more is_a checks on instantiationAaron Patterson2014-05-291-4/+0
| | | | |
* | | | | Path::Pattern is instantiated internally, so make the contructor require a ↵Aaron Patterson2014-05-294-39/+43
| | | | | | | | | | | | | | | | | | | | strexp object
* | | | | Strexp#names is only used in a test, so rmAaron Patterson2014-05-291-32/+0
| | | | |
* | | | | add an alternate constructor to Strexp that takes a stringAaron Patterson2014-05-294-31/+31
| | | | |
* | | | | use a parser to extract the group parts from the pathAaron Patterson2014-05-291-2/+2
| | | | |
* | | | | Merge branch 'master' into mapperAaron Patterson2014-05-293-19/+20
|\ \ \ \ \ | | |/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * master: Update url to rake docs [ci skip] Name#model_name doesn't return a String object Result sets never override a model's column type [ci skip] Make last note show up in postgresql guide. Add missing `:param` option from the docs for Mapper#match [ci skip] Option discovered by @zackperdue in #14741, implemented in #5581. Add @senny's changed from #14741, including code font for `resources` options, and wrapped to 80 chars. [ci skip] Use github url for homepage of log4r [ci skip] Remove TODO. Ensure we always use instances of the adapter specific column class Fix indentation from 1b4b26f [ci skip] [ci skip] Improve form_helpers.md guide. Clear inflections after test. Remove unnecessary include for integration tests. Added documentation for the :param option for resourceful routing
| * | | | Merge pull request #15061 from tgxworld/remove_unnecessary_includeMatthew Draper2014-05-291-1/+0
| |\ \ \ \ | | | | | | | | | | | | Remove unnecessary include for integration tests.
| | * | | | Remove unnecessary include for integration tests.Guo Xiang Tan2014-05-111-1/+0
| | | | | |
| * | | | | Merge pull request #15399 from tgxworld/remove_todo_router_testGuillermo Iguaran2014-05-281-11/+1
| |\ \ \ \ \ | | | | | | | | | | | | | | Remove TODO.
| | * | | | | Remove TODO.Guo Xiang Tan2014-05-281-11/+1
| | | | | | |
| * | | | | | Merge pull request #15384 from zuhao/refactor_actionpack_params_wrapper_testYves Senn2014-05-291-7/+19
| |\ \ \ \ \ \ | | | | | | | | | | | | | | | | Clear inflections after test.
| | * | | | | | Clear inflections after test.Zuhao Wan2014-05-281-7/+19
| | | | | | | |
* | | | | | | | "controllers" should be a valid path nameAaron Patterson2014-05-291-0/+10
| | | | | | | |
* | | | | | | | add a test for controllers without colonsAaron Patterson2014-05-281-0/+10
| | | | | | | |
* | | | | | | | add a test for existing mapper functionalityAaron Patterson2014-05-281-0/+12
|/ / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | I'm not sure if this is actually used, but I'm adding a test to define the behavior
* | | | | | | add tests for argument error casesAaron Patterson2014-05-281-0/+27
| | | | | | |
* | | | | | | Merge pull request #15386 from ↵Santiago Pastorino2014-05-281-3/+6
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | zuhao/refactor_actionpack_request_forgery_protection_test Avoid hardcoded `request_forgery_protection_token` value in teardown.
| * | | | | | | Avoid hardcoded value in teardown.Zuhao Wan2014-05-281-3/+6
| | | | | | | |
* | | | | | | | Merge pull request #15388 from zuhao/refactor_actionpack_send_file_testSantiago Pastorino2014-05-281-2/+6
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | Unregister Mime::Type in teardown.
| * | | | | | | | Unregister Mime::Type in teardown.Zuhao Wan2014-05-281-2/+6
| |/ / / / / / /
* | | | | | | | Merge pull request #15385 from zuhao/refactor_actionpack_render_other_testSantiago Pastorino2014-05-281-4/+7
|\ \ \ \ \ \ \ \ | |/ / / / / / / |/| | | | | | | Add and remove renderer inside the test to prevent leak.
| * | | | | | | Add and remove renderer inside the test to prevent leak.Zuhao Wan2014-05-281-4/+7
| |/ / / / / /
* | | | | | | Merge pull request #15383 from ↵Yves Senn2014-05-281-10/+8
|\ \ \ \ \ \ \ | |/ / / / / / |/| | | | | | | | | | | | | | | | | | | | zuhao/refactor_actionpack_localized_templates_test Move I18n.locale setting into setup and teardown.
| * | | | | | Move I18n.locale setting into setup and teardown.Zuhao Wan2014-05-281-10/+8
| |/ / / / /
* / / / / / Add with_default_charset helper.Zuhao Wan2014-05-281-12/+20
|/ / / / /
* | | | | Deprecate all *_filter callbacks in favor of *_action callbacksRafael Mendonça França2014-05-273-194/+196
| | | | | | | | | | | | | | | | | | | | | | | | | This is the continuation of the work started at 9d62e04838f01f5589fa50b0baa480d60c815e2c
* | | | | PARAMETERS_KEY is only used in the request, so move the constant thereAaron Patterson2014-05-271-5/+5
| | | | |
* | | | | Merge branch 'constraints'Aaron Patterson2014-05-271-2/+6
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * constraints: rm reset_parameters because we automatically do it from 9ca4839a move path_parameter encoding check to the request object dispatcher doesn't need `call` anymore call `serve` with the request on dispatchers constraints class does not need the request class anymore give all endpoints a superclass skip the build business if the stack is empty stop hardcoding path_parameters and get it from the request we do not need to cache rack_app a redirect is not a dispatcher by definition, so eliminate test push is_a check up to where the Constraints object is allocated pass the request object to the application pass a request to `matches?` so we can avoid creating excess requests nothing is passed to `rack_app` anymore, so rm the params one fewer is_a check Constraints#app should never return another Constraints object, so switch to if statement eliminate dispatcher is_a checks push is_a?(Dispatcher) check in to one place Always construct route objects with Constraint objects Conflicts: actionpack/lib/action_controller/metal.rb
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-09 18:00:18 +0000