Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
| * | | | | | rm reset_parameters because we automatically do it from 9ca4839a | Aaron Patterson | 2014-05-27 | 1 | -3/+0 | |
| | | | | | | ||||||
| * | | | | | pass the request object to the application | Aaron Patterson | 2014-05-25 | 1 | -2/+5 | |
| | | | | | | ||||||
| * | | | | | push is_a?(Dispatcher) check in to one place | Aaron Patterson | 2014-05-24 | 1 | -0/+1 | |
| | | | | | | ||||||
| * | | | | | Always construct route objects with Constraint objects | Aaron Patterson | 2014-05-24 | 1 | -0/+3 | |
| | | | | | | ||||||
* | | | | | | Skip individual tests upon Dalli::RingError | Matthew Draper | 2014-05-27 | 1 | -0/+18 | |
| |_|/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Unlike the outer `rescue`, this one is much more precise about what we want to handle: a connection failure (`Dalli::RingError`) is not relevant to what we're testing here. But other Dalli errors may well be indicating an actual problem. | |||||
* | | | | | The correct status to test should be :switching_protocols. | Zuhao Wan | 2014-05-25 | 1 | -2/+2 | |
|/ / / / | ||||||
* | | | | Merge pull request #14986 from dlangevin/trailing-slash-url-generation | Rafael Mendonça França | 2014-05-24 | 1 | -0/+18 | |
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes URL generation with trailing_slash: true Conflicts: actionpack/lib/action_dispatch/http/url.rb | |||||
| * | | | | Fixes URL generation with trailing_slash: true | Dan Langevin | 2014-05-22 | 1 | -0/+18 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | URL generation with trailing_slash: true was adding a trailing slash after .:format Routes.draw do resources :bars end bars_url(trailing_slash: true, format: 'json') # => /bars.json/ This commit removes that extra trailing slash | |||||
* | | | | | glob_param is never used, so rm | Aaron Patterson | 2014-05-23 | 1 | -1/+5 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | this also changes the constructor. We don't need to pass more options than "defaults" (whatever defaults are, ugh. probably another hash of stupid stuff). | |||||
* | | | | | decouple the router object from the request class | Aaron Patterson | 2014-05-23 | 1 | -14/+6 | |
| | | | | | ||||||
* | | | | | pass the correct custom request to the recognize method | Aaron Patterson | 2014-05-23 | 1 | -13/+10 | |
| | | | | | ||||||
* | | | | | switch to the `serve` method so we can remove the request class (eventually) | Aaron Patterson | 2014-05-23 | 1 | -2/+6 | |
| | | | | | ||||||
* | | | | | extract request allocation from the main app serving routine | Aaron Patterson | 2014-05-23 | 1 | -0/+1 | |
| | | | | | ||||||
* | | | | | remove NullRequest and just always pass a request class | Aaron Patterson | 2014-05-23 | 1 | -3/+7 | |
| | | | | | ||||||
* | | | | | use the request object since we have it | Aaron Patterson | 2014-05-23 | 2 | -6/+6 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | stop hardcoding hash keys and use the accessors provided on the request object. | |||||
* | | | | | stop using PARAMETERS_KEY, and use the accessor on the request object | Aaron Patterson | 2014-05-22 | 1 | -0/+3 | |
| | | | | | | | | | | | | | | | | | | | | this decouples our code from the env hash a bit. | |||||
* | | | | | use symbol keys for path_parameters | Aaron Patterson | 2014-05-22 | 1 | -5/+5 | |
| | | | | | ||||||
* | | | | | Form full URI as string to be parsed in Rack::Test. | Guo Xiang Tan | 2014-05-21 | 1 | -6/+6 | |
| | | | | | | | | | | | | | | | | | | | | There are performance gains to be made by avoiding URI setter methods. | |||||
* | | | | | middle variable is never used, so rm | Aaron Patterson | 2014-05-21 | 1 | -14/+14 | |
| | | | | | ||||||
* | | | | | we don't use this parameter for anything, so rm | Aaron Patterson | 2014-05-20 | 1 | -20/+19 | |
| | | | | | ||||||
* | | | | | Merge pull request #11346 from tomykaira/fix_10257 | Rafael Mendonça França | 2014-05-20 | 1 | -0/+7 | |
|\ \ \ \ \ | | | | | | | | | | | | | Check authentication scheme in Basic auth | |||||
| * | | | | | Check authentication scheme in Basic auth | tomykaira | 2013-07-07 | 1 | -0/+7 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `authenticate_with_http_basic` and its families should check the authentication schema is "Basic". Different schema, such as OAuth2 Bearer should be rejected by basic auth, but it was passing as the test shows. This fixes #10257. | |||||
* | | | | | | Merge pull request #15182 from zuhao/refactor_actionpack_respond_with_test_2 | Yves Senn | 2014-05-20 | 1 | -4/+10 | |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | Un-define :to_json for Customer class after stubbing. | |||||
| * | | | | | | Add using_resouce_with_json to controller. | Zuhao Wan | 2014-05-20 | 1 | -4/+10 | |
| | |_|_|_|/ | |/| | | | | ||||||
* | | | | | | Merge pull request #15178 from zuhao/refactor_actionpack_respond_with_test | Yves Senn | 2014-05-20 | 1 | -0/+19 | |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | Deregister csv renderer after test to prevent leak. | |||||
| * | | | | | | Add ActionController::Renderers.remove. | Zuhao Wan | 2014-05-20 | 1 | -0/+19 | |
| |/ / / / / | ||||||
* / / / / / | Revert "Rewrite journey routes formatter for performance" | Aaron Patterson | 2014-05-19 | 1 | -0/+20 | |
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 5c224de9e110763ec7a0f01f5b604bcf81f40bfb. Conflicts: actionpack/lib/action_dispatch/journey/visitors.rb 5c224de9e110763ec7a0f01f5b604bcf81f40bfb introduced a bug in the formatter. This commit includes a regression test. | |||||
* | | | | | Ensure :js is defined regardless of the outcome of the test. | Zuhao Wan | 2014-05-17 | 1 | -5/+11 | |
| | | | | | ||||||
* | | | | | fixes stack level too deep exception on action named 'status' returning ↵ | Christiaan Van den Poel | 2014-05-15 | 1 | -0/+31 | |
| | | | | | | | | | | | | | | | | | | | | 'head :ok' | |||||
* | | | | | Add RFC4791 MKCALENDAR method | kasper | 2014-05-15 | 1 | -2/+3 | |
| | | | | | ||||||
* | | | | | Remove unused method in RouteSet test. | Guo Xiang Tan | 2014-05-15 | 1 | -4/+0 | |
| | | | | | ||||||
* | | | | | Merge pull request #14137 from dasch/better-fragment-cache-instrumentation | Rafael Mendonça França | 2014-05-14 | 1 | -0/+16 | |
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add controller and action name to the fragment caching instrumentation payload Conflicts: actionpack/CHANGELOG.md | |||||
| * | | | | | Add controller and action name to the instrumentation payload | Daniel Schierbeck | 2014-05-10 | 1 | -0/+16 | |
| | | | | | | ||||||
* | | | | | | Merge pull request #15070 from ayamomiji/sse-patch | Aaron Patterson | 2014-05-14 | 1 | -0/+16 | |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | Add multiple lines message support for SSE module | |||||
| * | | | | | | Add multiple lines message support for SSE module | ayaya | 2014-05-12 | 1 | -0/+16 | |
| | | | | | | | ||||||
* | | | | | | | _recall should be set to a hash or not set | Aaron Patterson | 2014-05-13 | 1 | -2/+2 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Then we can avoid nil checks | |||||
* | | | | | | | Fix regression on `assert_redirected_to`. | Arthur Neves | 2014-05-13 | 1 | -0/+6 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `assert_redirected_to` would fail if there is no controller set on a `ActionDispatch::IntegrationTest`, as _compute_redirect_to_location would be called on the controller to build the url. This regression was introduced after 1dacfbabf3bb1e0a9057dd2a016b1804e7fa38c0. [fixes #14691] | |||||
* | | | | | | | this class is a model, so it should act like one | Aaron Patterson | 2014-05-12 | 1 | -0/+3 | |
|/ / / / / / | ||||||
* | | | / / | Remove redundant tests method. | Guo Xiang Tan | 2014-05-11 | 1 | -2/+0 | |
| |_|_|/ / |/| | | | | ||||||
* | | | | | Always use the provided port for protocol relative urls | Andrew White | 2014-05-11 | 1 | -0/+12 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | There may be situations where you need to tunnel SSL connections over port 80 so we shouldn't remove it if it has been explicitly provided. | |||||
* | | | | | ActionDispatch::Http::URL.normalize_port should not strip port for protocol ↵ | Guilherme Cavalcanti | 2014-05-11 | 1 | -0/+12 | |
| | | | | | | | | | | | | | | | | | | | | relative URL. | |||||
* | | | | | just call the method and assert the return value | Aaron Patterson | 2014-05-09 | 1 | -8/+1 | |
| | | | | | | | | | | | | | | | | | | | | do not test internals | |||||
* | | | | | HTTP::Headers#key? correctly converts | schneems | 2014-05-07 | 1 | -0/+2 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously if you were looking for a given key, the header may incorrectly tell you that it did not exist even though it would return a valid value: ```ruby env = { "CONTENT_TYPE" => "text/plain" } headers = ActionDispatch::Http::Headers.new(env) headers["Content-Type"] # => "text/plain" headers.key?("Content-Type") # => false ``` This PR fixes that behavior by converting the key before checking for presence | |||||
* | | | | | Merge pull request #14945 from tomkadwill/form_authenticity_param_refactor | Rafael Mendonça França | 2014-05-06 | 1 | -5/+26 | |
|\ \ \ \ \ | | | | | | | | | | | | | Moved 'params[request_forgery_protection_token]' into its own method and... | |||||
| * | | | | | Moved 'params[request_forgery_protection_token]' into its own method and ↵ | Tom Kadwill | 2014-05-06 | 1 | -5/+26 | |
| | |_|/ / | |/| | | | | | | | | | | | | | improved tests. | |||||
* / | | | | Only accept actions without File::SEPARATOR in the name. | Rafael Mendonça França | 2014-05-06 | 1 | -1/+16 | |
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This will avoid directory traversal in implicit render. Fixes: CVE-2014-0130 Conflicts: actionpack/lib/abstract_controller/base.rb | |||||
* | | | | Use assert_raises | Rafael Mendonça França | 2014-05-04 | 1 | -3/+1 | |
| | | | | ||||||
* | | | | Merge pull request #11166 from xavier/callable_constraint_verification | Rafael Mendonça França | 2014-05-04 | 1 | -0/+15 | |
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Callable route constraint verification Conflicts: actionpack/CHANGELOG.md | |||||
| * | | | | Verify that route constraints respond to the expected messages instead of ↵ | Xavier Defrang | 2013-06-28 | 1 | -0/+15 | |
| | | | | | | | | | | | | | | | | | | | | silently failing to enforce the constraint | |||||
* | | | | | Remove tests method for test cases when controller can be inferred. | Guo Xiang | 2014-05-03 | 5 | -21/+1 | |
| |/ / / |/| | | |