aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/test
Commit message (Collapse)AuthorAgeFilesLines
* Added test for link_to_unless to make sure the result consistency.dtaniwaki2013-06-161-0/+5
|
* Use a case insensitive URI Regexp for #asset_pathDavid Celis2013-06-161-2/+5
| | | | | | | | | | | | | Context: https://gist.github.com/radar/5793814 The `URI_REGEXP` that various AssetUrl helpers use is currently case sensitive when checking for a URI scheme. This means if you try to pass a URL like `HTTP://www.example.com/path/to/image.jpg`, you end up with a bogus asset path: `/assets/HTTP://www.example.com/path/to/image.jpg`. URLs are case insensitive, so this regexp should be as well. Signed-off-by: David Celis <me@davidcel.is>
* collection tags accept html attributes as the last element of collectionVasiliy Ermolovich2013-06-161-0/+16
|
* Update the HTML boolean attributes per the HTML 5.1 specAlex Peattie2013-06-141-2/+2
| | | | | | | - Add attributes `allowfullscreen`, `default`, `inert`, `sortable`, `truespeed`, `typemustmatch`. - Fix attribute `seamless` (previously misspelled `seemless`). - Use `assert_dom_equal` instead of `assert_equal` in test.
* Don't set X-UA-Compatible header by defaultGuillermo Iguaran2013-06-131-3/+1
| | | | | | We are setting this header to chrome=1 for Chrome Frame and this will be retired soon. Check http://blog.chromium.org/2013/06/retiring-chrome-frame.html for details
* Warning removed for MinitestArun Agrawal2013-06-121-1/+1
|
* Fix mismatching variable names when using an underscoreDrew Ulmer2013-06-041-13/+41
| | | | | | | | The ERBTracker template digest helper class was using a regex to match render calls and it was incorrectly not matching against variables with underscores in the name. This caused it to use the wrong regex match data to populate the template dependency. Because underscore is a valid character for a variable, this fixes the ERBTracker to match it properly.
* Raise ArgumentError to fix Rails 4.1 deprecation warn message.kennyj2013-06-021-5/+7
|
* Remove Mime::Type#verify_request? and Mime::Type.browser_generated_types ↵kennyj2013-06-022-21/+0
| | | | were deprecated.
* Remove ActionView::Template#mime_type was deprecated.kennyj2013-06-011-7/+0
|
* Remove ActionController::RecordIdentifier was deprecated.kennyj2013-06-012-63/+3
|
* Remove :confirm and :disable_with options from ↵kennyj2013-06-011-28/+0
| | | | ActionView::Helpers::FormTagHelper were deprecated.
* Remove link_to_function / button_to_function from ↵kennyj2013-06-011-42/+0
| | | | ActionView::Helpers::JavascriptHelper were deprecated.
* Remove :confirm and :disable_with options for ↵kennyj2013-06-011-75/+0
| | | | ActionView::Helpers::UrlHelper#link_to and #button_to were deprecated.
* `RoutesInspector` deals with routes using regexp as `:controller` optionYves Senn2013-05-301-0/+9
|
* Running isolated testsArun Agrawal2013-05-281-15/+0
| | | | These stopped running don't know when. But these should be running now.
* Add has_named_route? to the mapper APIJosé Valim2013-05-201-0/+13
|
* Fix named routing regression from 3.2.13schneems2013-05-161-0/+11
| | | | | | | | | | | | | | | | | | | | | | When named route that is nested is used in 3.2.13 Example `routes.rb`: ``` resources :nested do resources :builder, :controller => 'nested/builder' end ``` In 3.2.12 and 3.2.12 this named route would work: ``` nested_builder_path(:last_step, :nested_id => "foo") ``` Generating a url that looks like `/nested/foo/builder/last_step`. This PR fixes the regression when building urls via the optimized helper. Any explicit keys set in the options are removed from the list of implicitly mapped keys. Not sure if this is exactly how the original version worked, but this fixes this use case regression.
* Revert "Integration tests support the OPTIONS http method"Rafael Mendonça França2013-05-161-17/+1
| | | | | | | | | | | | | | This reverts commit ad46884af567d6f8d6d8d777f372c39e81a560ba. Conflicts: actionpack/CHANGELOG.md actionpack/lib/action_dispatch/testing/integration.rb actionpack/test/controller/integration_test.rb Reason: It will conflict with a lot of test cases. Better to call `process` directly since this is a very uncommon HTTP method. Fixes #10638.
* Merge pull request #10636 from seanwalbran/fix-asset-host-proc-returning-nilRafael Mendonça França2013-05-161-0/+11
|\ | | | | fix rails4 regression with asset_host Proc returning nil
| * restore ability to return nil from asset_host proc, add testSean Walbran2013-05-151-0/+11
| |
* | Revert "Add the options method to action_controller testcase."Rafael Mendonça França2013-05-161-5/+0
| | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 0303c2325fab253adf5e4a0b738cb469c048f008. Conflicts: actionpack/lib/action_controller/test_case.rb REASON: It will conflict with a lot of test cases. Better to call `process` directly since this is a very uncommon HTTP method. Fixes #10638.
* | Merge pull request #10591 from acapilleri/cond_callback_testAaron Patterson2013-05-151-0/+13
|\ \ | |/ |/| add test for skip_before_filter with condition
| * add test for skip_before_filter with conditionAngelo capilleri2013-05-131-0/+13
| |
* | use public api for testing rather than grabbing instance variablesAaron Patterson2013-05-141-1/+1
|/
* Replace multi_json with jsonErik Michaels-Ober2013-05-111-1/+1
|
* Fix that JSON and XML exception responses should give the HTTP error message ↵Jeremy Kemper2013-05-081-2/+2
| | | | for their status, by default, not the message from the underlying exception
* Test that #fresh_when accepts an arrayBrandon Keepers2013-05-071-2/+19
| | | | https://github.com/rails/etagger/pull/3
* Allow numbers in partial name for digestingBryan Ricker2013-05-062-1/+8
| | | | | | | | | | Add failing test for template with number at the end Use \w for RENDER_DEPENDENCY regex Spacing Add CHANGELOG entry
* Fix failing AP testCarlos Antonio da Silva2013-05-011-1/+1
|
* Merge pull request #9857 from yyyc514/bad_params_should_400Aaron Patterson2013-04-302-0/+7
|\ | | | | failure to parse params should trigger a 400 Bad Request
| * failure to parse params should trigger a 400 Bad RequestJosh Goebel2013-03-212-0/+7
| |
* | Revert "Merge pull request #10337 from eimermusic/fix_template_digestor_lookup"Rafael Mendonça França2013-04-251-1/+1
| | | | | | | | | | | | | | | | This reverts commit b4239622afc4f3f73808fd0c97512f3a534e07dd, reversing changes made to f99ce3c188f5dde57e2ff63e6a22363c62f0a4cd. Reason: This broke the build https://travis-ci.org/rails/rails/jobs/6629894
* | Merge pull request #10337 from eimermusic/fix_template_digestor_lookupRafael Mendonça França2013-04-251-1/+1
|\ \ | | | | | | | | | | | | | | | | | | Fix ActionView::Digestor to correctly pass format to LookupContext Conflicts: actionpack/CHANGELOG.md
| * | AV Digestor correctly passes format to LookupContextMartin Westin2013-04-251-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | ActionView::Digestor now passes arguments correctly to LookupContext::find method. This makes cache digests respect the format option correctly. FixtureFinder in tests also changed to reflect this.
* | | Add support for extra options to `force_ssl`Andrew White2013-04-251-14/+106
| | | | | | | | | | | | | | | | | | | | | | | | This commit adds support for passing additional url options along with a :status option and any of the flash-related options to `redirect_to` (i.e. :flash, :alert & :notice). Closes #7570.
* | | Use `request.fullpath` to build redirect url in `force_ssl`Andrew White2013-04-251-0/+63
|/ / | | | | | | | | | | | | | | | | | | | | The `force_ssl` command now builds the redirect url from `request.fullpath`. This ensures that the format is maintained and it doesn't redirect to a route that has the same parameters but is defined earlier in `routes.rb`. Also any optional segments are maintained. Fixes #7528. Fixes #9061. Fixes #10305.
* | Add test for `format: false` with resources - closes #10323Andrew White2013-04-241-0/+29
| |
* | Return a 405 response for unknown HTTP methodsLewis Marshall2013-04-222-0/+12
| |
* | Removing tests for deprecated options in active support. Thewangjohn2013-04-211-8/+0
| | | | | | | | | | +use_full_path+ option was removed in 3b3790a4 and passing the template handler to render was deprecated in 43d27e91.
* | Refactor ActionDispatch::Http::URL.build_host_urlAndrew White2013-04-181-0/+41
| | | | | | | | | | Add support for extracting the port from the :host option and for removing the subdomain by using nil, false or ''.
* | Add url generation tests for #10185Andrew White2013-04-181-0/+2
| |
* | Passing subdomain: '' to url_for removes the subdomain (instead of adding a ↵Derek Watson2013-04-182-0/+27
| | | | | | | | | | | | leading .) Adding a boolean route constraint checks for presence/absence of request property
* | Avoid leak into controller's action_methodsprintercu2013-04-181-0/+6
| |
* | options_from_collection_for_select helper takes html attributesVasiliy Ermolovich2013-04-111-0/+7
| | | | | | | | as the last element of the array
* | Merge pull request #9604 from sgrif/live_streaming_exceptionsRafael Mendonça França2013-04-081-1/+75
|\ \ | | | | | | Exceptions raised when using ActionController::Live cause server crash
| * | Exception handling for controllers using ActionController::LiveSean Griffin2013-03-181-1/+75
| | | | | | | | | | | | | | | | | | | | | | | | | | | Any exceptions that occured at the view or controller level for a controller using ActionController::Live would cause the server to either hang with an open socket indefinitely, or immediately crash (depending on whether the server was launched with rails s or directly). Changed the behavior of exceptions to act the same as streaming templates for html requests, and allow for an on_error callback if needed.
* | | Fix explicit names on multiple file fieldsRyan McGeary2013-04-051-0/+10
| | | | | | | | | | | | | | | | | | | | | | | | If a file field tag is passed the multiple option, it is turned into an array field (appending "[]"), but if the file field is passed an explicit name as an option, leave the name alone (do not append "[]"). Fixes #9830
* | | Fix indent and remove extra white spacesCarlos Antonio da Silva2013-04-051-15/+17
| | |
* | | Ensure mail_to helper does not modify the given html options hashCarlos Antonio da Silva2013-04-041-1/+7
| | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-02 16:40:33 +0000