aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/test
Commit message (Collapse)AuthorAgeFilesLines
* Ensure number helpers can handle HTML safe strings - closes #1597.Andrew White2011-06-101-0/+7
|
* add missing ensureNeeraj Singh2011-06-101-0/+1
|
* replaced and with && as per coding guidelinesNeeraj Singh2011-06-101-1/+1
|
* The test name is misleading. It saysNeeraj Singh2011-06-101-1/+1
| | | | | | | | | | | | test_should_cache_with_trailing_slash_on_url A trailing slash is removed when a page is cached. What the test meant to say was : a url with trailing slash should be cached and the cached page should not have any trailing slash. This patch clarifies the name a bit.
* ensuring that json_escape returns html safe strings when passed an html safe ↵Aaron Patterson2011-06-091-0/+10
| | | | string
* Make sure `escape_javascript` return `SafeBuffer` if the incoming argument ↵Prem Sichanugrist2011-06-091-0/+2
| | | | is already html_safe
* Merge pull request #1606 from neerajdotname/remove_users_controller_from_testJosé Valim2011-06-091-3/+0
|\ | | | | remove unused UserController from test
| * remove unused user_controller from testNeeraj Singh2011-06-081-3/+0
| |
* | class WithSymbolReturningString is not used anywhere in the test.Neeraj Singh2011-06-081-12/+0
|/ | | | | | | | | | | Secondly it seemed from the method that the intent was to test a case where layout was declared in a symbol and the method named mention in layout returns nil. That case is already covered with class class WithSymbolReturningNil . Also the case of SymbolReturningString is covered with the class WithSymbol.
* Merge pull request #1560 from sikachu/master-escapejsJosé Valim2011-06-081-0/+7
|\ | | | | Make escape_javascript happy to handle SafeBuffers
| * Make escape_javascript happy to handle SafeBuffersPaul Gallagher2011-06-081-0/+7
| | | | | | | | | | * see GH#1553 * allow for the fact that gsub on SafeBuffer does not pass match variables $1, $2 etc to a block
* | Make test meaningfulNeeraj Singh2011-06-081-1/+1
|/ | | | | | | | | | If before_filter list was being called mistakenly then the test should fail. However test will not fail because second filter is assigning new values to @list. To truly test that first before_filter is not called when it should not be called then @list should not assigned value unconditionally. This patch will make the test fail if first filter is called.
* Merge pull request #1549 from neerajdotname/rename_to_method_for_actionJosé Valim2011-06-081-2/+2
|\ | | | | test name should reflect the name of the method
| * test name should reflect the name of the methodNeeraj Singh2011-06-081-2/+2
| | | | | | | | that is actually being called
* | Merge pull request #1548 from neerajdotname/remove_class_me5José Valim2011-06-081-6/+0
|\ \ | | | | | | remove unused class from test
| * | remove unused class from testNeeraj Singh2011-06-081-6/+0
| |/
* / Fix failing test on uninitialized `Rails.config.assets.prefix`Prem Sichanugrist2011-06-081-0/+1
|/ | | | This was introduced in [2684f17a17e4f97bdb89d20b4cd08585235263a2] :bomb:
* remove warning: assigned but unused variableSantiago Pastorino2011-06-086-10/+6
|
* Added missing assert to test checking form with namespaced isolated model ↵Piotr Sarnacki2011-06-071-5/+5
| | | | and fixed helpers to work correctly in such case
* Add backward compatibility for testing cookiesAndrew White2011-06-051-2/+49
| | | | | | | | | | | | | | | | | | | This commit restores the ability to assign cookies for testing via @request.env['HTTP_COOKIE'] and @request.cookies, e.g: @request.env['HTTP_COOKIE'] = 'user_name=david' get :index assert_equal 'david', cookies[:user_name] and @request.cookies[:user_name] = 'david' get :index assert_equal 'david', cookies[:user_name] Assigning via cookies[] is the preferred method and will take precedence over the other two methods. This is so that cookies set in controller actions have precedence and are carried over between calls to get, post, etc.
* Ensure cookie keys are stringsAndrew White2011-06-051-0/+9
|
* Allow multiple sources in Sprockets helpersGuillermo Iguaran2011-06-053-0/+6
|
* Refactor ActionController::TestCase cookiesAndrew White2011-06-043-26/+23
| | | | | | | | | | | | | | | | | | Assigning cookies for test cases should now use cookies[], e.g: cookies[:email] = 'user@example.com' get :index assert_equal 'user@example.com', cookies[:email] To clear the cookies, use clear, e.g: cookies.clear get :index assert_nil cookies[:email] We now no longer write out HTTP_COOKIE and the cookie jar is persistent between requests so if you need to manipulate the environment for your test you need to do it before the cookie jar is created.
* fix creating an empty route on 1.8. Closes #1210Damien Mathieu2011-06-011-0/+6
|
* Corrected some typos and American vs. Queen's English issuesLee Reilly2011-05-291-2/+2
|
* Merge pull request #1203 from dchelimsky/stringify-parameter-values-in-testsJosé Valim2011-05-281-0/+10
|\ | | | | Stringify param values in controller tests.
| * Stringify param values in controller tests.David Chelimsky2011-05-221-0/+10
| | | | | | | | | | | | | | | | This reduces false positives that come from using ints in params in tests, which do not get converted to strings in the tests. In implementations going through rack, they do get converted to strings. - David Chelimsky and Sam Umbach
* | Fix typo in test.Andrés Botero2011-05-281-1/+1
| |
* | fixed asset_paths when called from sprockets for relative_url_rootjacott2011-05-281-0/+6
| |
* | don't raise an exception if the format isn't recognizeddmathieu2011-05-261-0/+6
| | | | | | | | Fixed while traveling to heuruko
* | removed deprecated methods, and related tests, from ActionPackJosh Kalderimis2011-05-248-105/+3
| |
* | Move the last pockets of Sprockets stuff into the Sprockets directorywycats2011-05-231-2/+1
| |
* | Move javascript/css helpers into the Sprockets helper and just have them ↵wycats2011-05-231-12/+12
| | | | | | | | override the old behavior
* | Start moving some logic from being embedded in AV into the Rails Sprockets ↵wycats2011-05-231-0/+2
| | | | | | | | extensions
* | Replace references to ActiveSupport::SecureRandom with just SecureRandom, ↵Jon Leighton2011-05-232-4/+4
| | | | | | | | and require 'securerandom' from the stdlib when active support is required.
* | Merge pull request #1228 from fcheung/db_time_fix2José Valim2011-05-231-0/+26
|\ \ | | | | | | Take into account time spent in AR even if a redirect occurs or if it is after the render
| * | Take into account time spent in AR even if a redirect occurs or if it is ↵Frederick Cheung2011-05-231-0/+26
| | | | | | | | | | | | after the render
* | | Eliminate uninitialized instance variable warningwycats2011-05-221-2/+2
| | |
* | | Prepare the context in URLHelperTest so that there are no required ↵wycats2011-05-221-0/+2
| | | | | | | | | | | | uninitialized instance variables
* | | Merge pull request #1222 from arunagw/sprockets-fixesJosé Valim2011-05-222-8/+0
|\ \ \ | | | | | | | | We don't need to load version any more as Sprockets.beta8 is included.
| * | | We don't need to load version any more as Sprockets.beta8 is included. Arun Agrawal2011-05-232-8/+0
| | | |
* | | | Always initialize @title in caching test to avoid uninitialized instance ↵wycats2011-05-221-0/+3
|/ / / | | | | | | | | | variable warning
* | | Merge branch '3-1-stable'Joshua Peek2011-05-223-2/+11
|\ \ \ | | | | | | | | | | | | | | | | | | | | Conflicts: actionpack/actionpack.gemspec activemodel/activemodel.gemspec
| * | | Add debug_asset supportJoshua Peek2011-05-223-2/+11
| | |/ | |/|
* | | Revert "Take into account time spent in AR even if a redirect occurs or if ↵David Heinemeier Hansson2011-05-221-26/+0
| | | | | | | | | | | | | | | | | | it is after the render" because it's causing test failures about missing db_during_render. This reverts commit 60b55baca9e381deb3a0a85580f089f4caf551d4.
* | | Make sure that we're able to run Action Pack test standalone.Prem Sichanugrist2011-05-222-2/+8
| | | | | | | | | | | | | | | | | | | | | | | | Sprocket was trying to look for these two things: * `Rails::VERSION::STRING` * `.initializer(str)` in `Rails::Engine` This commit added require to version.rb into Abstract Unit, and mocking the `Rails::Engine.initializer` in `sprockets_helper_test.rb`
* | | Take into account time spent in AR even if a redirect occurs or if it is ↵Frederick Cheung2011-05-221-0/+26
| |/ |/| | | | | after the render
* | Add method fields_for_with_index to FormHelperJorge Bejar2011-05-211-0/+125
|/
* Merge pull request #1151 from joshk/wrap_params_options_changeJosé Valim2011-05-192-9/+9
|\ | | | | renamed the wrap_parameters :only and :except options to :include and :ex
| * renamed the wrap_parameters :only and :except options to :include and ↵Josh Kalderimis2011-05-192-9/+9
| | | | | | | | :exclude to make it consistent with controller filters