| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| |
| | |
config.static_index configures directory Index "index.html" filename
|
| |
| |
| |
| |
| |
| | |
Set `config.static_index` to serve a static directory index file not
named `index`. For example, to serve `main.html` instead of `index.html`
for directory requests, set `config.static_index` to `"main"`.
|
|/
|
|
| |
`head` method works similar to `render` method with `:nothing` option
|
|\
| |
| | |
[PoC] Stop shadowing parameters named `action`
|
| | |
|
| | |
|
|\ \
| | |
| | | |
Issue#17703 Test case for tempfile attribute
|
| |/
| |
| |
| |
| |
| |
| |
| |
| |
| | |
+ To avoid regression I am adding this test case on action pack
Changed to assert from assert_equal
+ Added msg to assertion
Modified msg
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| |
| | |
This silences:
actionpack/test/journey/route_test.rb:33: warning: ambiguous first
argument; put parentheses or a space even after `/' operator
|
| |
| |
| |
| | |
Digest allowed the messages.
Add the same feature to basic and token
|
|\ \
| | |
| | | |
Correct route requirements by overriding defaultls
|
| | | |
|
|\ \ \
| | | |
| | | | |
Rm route wrapper internal hacks
|
| | | |
| | | |
| | | |
| | | | |
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
|
|/ / / |
|
| | | |
|
| |/
|/| |
|
|\ \
| | |
| | | |
Set default form builder for a controller
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
When 7e504927 was merged setting `Encoding.default_internal` and
`Encoding.default_external` would throw a warning when the ActionPack
tests were run.
Example warning: `actionpack/test/dispatch/static_test.rb:12: warning:
setting Encoding.default_external`
This patch silences the warnings as other similar tests do for setting
default_internal and default_external.
|
|/ /
| |
| |
| |
| |
| |
| | |
supercaracal/fix_force_ssl_redirection_flash_error"
This reverts commit d215620340be7cb29e2aa87aab22da5ec9e6e6a7, reversing
changes made to bbbbfe1ac02162ecb5e9a7b560134a3221f129f3.
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Windows
* https://github.com/rails/rails/issues/19187
* https://github.com/rails/rails/pull/19533
* https://github.com/macournoyer/thin/issues/268
These are serious Rails 4 regression for Redmine Bitnami Windows users.
https://community.bitnami.com/t/problems-with-3-0-1-installation-see-report-inside/30195/
It is not caused on webrick users.
Related:
* https://github.com/rack/rack/issues/732#issuecomment-67677272
* https://github.com/phusion/passenger/issues/1328
|
| |
| |
| |
| |
| |
| | |
Related: #19617, #19187, #19533, #19689, #19675.
'drb/unix' does not exist on mingw.
|
| | |
|
|\ \
| | |
| | | |
avoid error when sort mixture keys in symbol and string
|
| | |
| | |
| | |
| | |
| | |
| | | |
it is avoid sort errot within different and mixed keys.
used `sort_by` + `block` to list parameter by keys.
keep minimum changes
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
After merging #19377 ActionPack tests were missing a require for
`ActiveSupport::LogSubscriber::TestHelper` and change didn't take
into account that logger could be nil. Added the require and only log to
info if logger exists.
This wasn't caught earlier because these tests only run after a merge.
|
|/ / |
|
|\ \
| | |
| | | |
Return super in ActionController::Parameters.const_missing
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The current implementation of ActionController::Parameters.const_missing
returns `ActionController::Parameters.always_permitted_parameters` even
if its `super` returns a constant without raising error. This prevents its
subclass in a autoloading module/class from taking advantage of
autoloading constants.
class SomeParameters < ActionController::Parameters
def do_something
DefinedSomewhere.do_something
end
end
In the code above, `DefinedSomewhere` is to be autoloaded with
`Module.const_missing` but `ActionController::Parameters.const_missing`
returns `always_permitted_parameters` instead of the autoloaded
constant.
This pull request fixes the issue respecting `const_missing`'s `super`.
|
| | |
| | |
| | |
| | |
| | | |
setup as block run before setup actlually runs so it will fail for our
case
|
|/ /
| |
| |
| | |
Closes #18933.
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| | |
Previously, an empty X_FORWARDED_HOST header would cause
Actiondispatch::Http:URL.raw_host_with_port to return nil, causing
Actiondispatch::Http:URL.host to raise a NoMethodError.
|
| |
| |
| |
| |
| |
| |
| | |
Preserving RACK_ENV behavior.
This reverts commit 7bdc7635b885e473f6a577264fd8efad1c02174f, reversing
changes made to 45786be516e13d55a1fca9a4abaddd5781209103.
|
| |
| |
| |
| |
| |
| | |
ActionDispatch::IntegrationTest HTTP request methods will accept only
certain kwargs in the future. This test caused a deprecation warning
when running ActionPack tests. Added `params` and `headers` to fix.
|
| | |
|
| | |
|
| |
| |
| |
| |
| | |
Regexp is broken for both content types including charsets and for
integration tests, where the content_type is a Mime::Type and not String
|
|\ \
| | |
| | | |
Return truthy value from head method
|
| | |
| | |
| | |
| | |
| | |
| | | |
It was returning false in normal circumstances.
This broke the `head :ok and return if` construct.
Add appropriate test.
|
|\ \ \
| | | |
| | | | |
Use request.session.id instead of request.session_options[:id]
|
| |/ /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
As of the upgrade to Rack 1.5, request.session_options[:id] is no
longer populated. Reflect this change in the tests by using
request.session.id instead.
Related change in Rack:
https://github.com/rack/rack/commit/83a270d6
|
| | | |
|
|/ /
| |
| |
| |
| | |
Rack::Lint raises an error saying "Content-Type header found in 304
response, not allowed".
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This fixes the reasons 4cf3b8a, 303567e, and fa63448 needed to be
reverted in 7142059. The revert has been reverted and this fixes
the issues caused previously.
If we call `super` first we will end up nuking the session settings in the
application tests that do `setup do` - so any session login or cookie
settings will not be persisted thoughout the test sessions.
Calling `super` last prevents `@integration_session` from getting nuked
and set to nil if it's already set.
Test added to prevent regression of this behavior in the future.
|