aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/test
Commit message (Collapse)AuthorAgeFilesLines
* Revert "Merge pull request #4803 from lucascaton/master"Santiago Pastorino2013-02-201-1/+1
| | | | | | | | | | | | | | | This reverts commit bb842e8d2111e50b21a14b8bd6d89371a4b9cd68, reversing changes made to 40c287c7983c20c498f6a8a2ea49e9a6455347f7. This was causing issues in one of our apps we just upgraded. ActionController::RoutingError: No route matches [GET] "/images/favicon.ico" favicon_link_tag now returns '/images/favicon.ico' and in 3.2 returned '/favicon.ico' Browsers by default look for favicon.ico in the root directory Conflicts: actionpack/CHANGELOG.md actionpack/lib/action_view/helpers/asset_tag_helper.rb
* Remove XML Parser from ActionDispatchPrem Sichanugrist2013-02-202-313/+15
| | | | | If you want an ability to parse XML parameters, please install `actionpack-xml_parser` gem.
* Fix time_zone_options_for_select to not mutate TimeZones arrayBrian McManus2013-02-191-0/+7
| | | | | | | | | | Previous implementation of time_zone_options_for_select did not dup the ActiveSupport::TimeZone.all array. When :priority_zones were provided the method would reject! the zones from the memoized TimeZones array thus affecting future requests to the server. Essentially whatever zones were specified as :priority_zones would show up for the first request but then disappear from the time zone options on future requests.
* InvalidMessage is in ActiveSupport::MessageEncryptor namespaceSantiago Pastorino2013-02-191-3/+18
| | | | Closes #9302
* Fix AP tests related to routes inspector output and the new column titlesCarlos Antonio da Silva2013-02-191-20/+65
|
* Merge pull request #8704 from senny/remove_regexp_global_from_url_forAaron Patterson2013-02-141-0/+3
|\ | | | | replace regexp global in #url_for
| * replace regexp global in #url_forYves Senn2013-01-161-0/+3
| |
* | Merge pull request #9221 from thenickcox/image_alt_attributeCarlos Antonio da Silva2013-02-111-1/+2
|\ \ | | | | | | Improve img alt attribute for screen readers
| * | Improve img alt attribute for screen readersthenickcox2013-02-091-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently, the img_alt method in ActionView keeps underscores in the alt attribute. Because underscores are pronounced in Apple's VoiceOver Utility, this has serious implications for accessibility. This patch makes underscored or hyphenated file names (both common in projects) read more naturally in screen readers by replacing them with spaces. See method documentation for details. Added documentation to image_alt method
* | | the `:controller` option for routes can contain numbers. closes #9231.Yves Senn2013-02-091-0/+12
| | |
* | | Fix #9168 Initialize NullCookieJar with all options needed for KeyGeneratorAndrey Chernih2013-02-081-0/+35
|/ /
* | ruby constant syntax is not supported as routing `:controller` option.Yves Senn2013-02-061-9/+40
| | | | | | | | | | | | | | | | | | | | The current implementation only works correctly if you supply the `:controller` with directory notation (eg. `:controller => 'admin/posts'`). The ruby constant notation (eg. `:controller => 'Admin::Posts`) leads to unexpected problems with `url_for`. This patch prints a warning for every non supported `:controller` option. I also added documentation how to work with namespaced controllers. The warning links to that documentation in the rails guide.
* | partials inside directory work with `assert_template`Yves Senn2013-02-043-0/+14
| | | | | | | | | | | | | | | | | | | | previously when a partial was placed inside a directory (eg. '/dir/_partial'), `assert_template` did not replace the '_' prefix when looking through rendered tempaltes, which resulted in an error. I modified it to replace both, the leading '_' and the last '_' after a '/'.
* | descriptive `assert_template` error when partial wasn't renderedYves Senn2013-02-041-0/+9
| | | | | | | | | | | | | | When `assert_template` is used with the :locals option, and the partial was not rendered, a method_missing error was raised. This changes first checks, if the partial actually was rendered and raises a descriptive error.
* | Missing or unneeded require extract_optionsAkira Matsuda2013-02-012-0/+2
| |
* | Fix `content_tag_for` with array html option.Semyon Perepelitsa2013-01-311-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It would embed array as string instead of joining it like `content_tag` does: content_tag(:td, class: ["foo", "bar"]){} #=> '<td class="foo bar"></td>' Before: content_tag_for(:td, item, class: ["foo", "bar"]){} #=> '<td class="item [&quot;foo&quot;, &quot;bar&quot;]" id="item_1"></td>' After: content_tag_for(:td, item, class: ["foo", "bar"]){} #=> '<td class="item foo bar" id="item_1"></td>'
* | Add 'X-UA-Compatible' => 'chrome=1' to default headersGuillermo Iguaran2013-01-291-1/+3
| |
* | Remove BestStandardsSupport middlewareGuillermo Iguaran2013-01-291-35/+0
| |
* | Remove yaml Proc param parser testBrendon Murphy2013-01-281-13/+0
| | | | | | | | | | | | | | | | I don't believe this test is exercising any explicit params_parser behavior that the other two Proc tests aren't already doing. Given that we now know it's a bad idea to load user input via YAML.load, somebody reading this test might get a dangerous idea about building out a YAML params parser.
* | Make current_url? work with a HEAD methodMichiel Sikkes2013-01-281-0/+6
| | | | | | | | | | | | ActionDispatch::Head was removed in favor of Rack::Head. But Rack::Head does not convert GET requests to HEAD requests so we need to do checking for HEAD requests ourselves.
* | Merge pull request #9032 from firmhouse/head-breaks-csrfSantiago Pastorino2013-01-281-0/+4
|\ \ | | | | | | Make HEAD work / convert to GET once more
| * | Added a test that shows that a HEAD request does not normally pass CSRF ↵Michiel Sikkes2013-01-221-0/+4
| | | | | | | | | | | | protection
* | | Use Encoding::UTF_8 constant :do_not_litter:Akira Matsuda2013-01-283-6/+6
| | |
* | | add fetch to CookieJarAaron Patterson2013-01-271-0/+30
| | |
* | | Add keys/values methods to TestSessionCarlos Antonio da Silva2013-01-251-5/+11
| | | | | | | | | | | | Bring back the same API we have with Request::Session.
* | | Integrate Action Pack with Rack 1.5Carlos Antonio da Silva2013-01-254-14/+14
| | | | | | | | | | | | | | | | | | All ActionPack and Railties tests are passing. Closes #8891. [Carlos Antonio da Silva + Santiago Pastorino]
* | | Set Thread.abort_on_exception for the whole AS, AP, and AR testsAkira Matsuda + Koichi Sasada2013-01-241-0/+2
| | | | | | | | | | | | this would give us some more clues in case a test silently dies inside Thread
* | | ActionDispatch::Http::UploadedFile is a permitted scalar [Closes #9051]Xavier Noria2013-01-231-1/+2
|/ /
* | Lets kepp using Ruby 1.9 syntaxRafael Mendonça França2013-01-222-37/+37
| |
* | Remove tabs, use spaces :scissors:Carlos Antonio da Silva2013-01-221-2/+2
| | | | | | | | [ci skip]
* | Merge branch 'isolating_tests'Akira Matsuda2013-01-222-2/+12
|\ \ | | | | | | | | | Now we're almost ready to remove this: https://github.com/rails/rails/blob/5294ad8/activesupport/lib/active_support/test_case.rb#L29
| * | Restore I18n.locale after running testsAkira Matsuda2013-01-221-1/+7
| | |
| * | Make sure to reset default_url_optionsAkira Matsuda2013-01-221-1/+5
| | |
* | | Stylistic pass at form_helper_testRafael Mendonça França2013-01-211-286/+362
| | |
* | | Capture block so content won't leak.José Mota2013-01-211-0/+57
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | The [following pull request](https://github.com/rails/rails/pull/8916) fixed the block being passed to the appropriate helper method. However, the content being passed into the block is generating repeated markup on the page due to some weird ERb evaluation. This commit tries to capture the block's generated output so the page isn't flooded with markup. [Rafael França + José Mota] Closes #8936
* | Duplicate possible frozen string from routeAndrew White2013-01-211-0/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | Ruby 1.9 freezes Hash string keys by default so where a route is defined like this: get 'search' => 'search' then the Mapper will derive the action from the key. This blows up later when the action is added to the parameters hash and the encoding is forced. Closes #3429
* | Merge pull request #9014 from virusman/form_helpers_ar_testsRafael Mendonça França2013-01-212-0/+92
|\ \ | | | | | | AR integration tests for form helpers
| * | Added AR integration tests for form helpersvirusman2013-01-212-0/+92
| | |
* | | Merge pull request #9001 from schneems/schneems/routes-path-jsRafael Mendonça França2013-01-211-0/+8
|\ \ \ | | | | | | | | In Browser Path Matching with Javascript
| * | | In Browser Path Matching with Javascriptschneems2013-01-201-0/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When debugging routes ,it can sometimes be difficult to understand exactly how the paths are matched. This PR adds a JS based path matching widget to the `/rails/info/routes` output. You can enter in a path, and it will tell you which of the routes that path matches, while preserving order (top match wins). The matching widget in action: ![](http://f.cl.ly/items/3A2F0v2m3m1Z1p3P3O3k/path-match.gif) Prior to this PR the only way to check matching paths is via mental math, or typing in a path in the url bar and seeing where it goes. This feature will be an invaluable debugging tool by dramatically decreasing the time needed to check a path match. ATP actionpack
* | | | Fix setting expected value in translation testsCarlos Antonio da Silva2013-01-211-2/+2
| |/ / |/| | | | | | | | It was being set to nil instead due to the wrong assignment.
* | | Merge pull request #9007 from dpree/masterRafael Mendonça França2013-01-201-35/+46
|\ \ \ | |/ / |/| | Enhanced tests for AbstractController::Translation module
| * | Removed ActionController::Base dependency from abstract controller ↵Jens Bissinger2013-01-201-41/+46
| | | | | | | | | | | | translation tests.
| * | Test abstract controller's localize method.Jens Bissinger2013-01-201-0/+6
| | |
* | | Add missing assert callsCarlos Antonio da Silva2013-01-201-2/+2
| | |
* | | strong parameters filters permitted scalarsXavier Noria2013-01-202-17/+164
|/ /
* | Merge pull request #8978 from chrismcg/remove_i18n_symbol_dependencyAaron Patterson2013-01-191-3/+8
|\ \ | | | | | | Remove i18n symbol dependency
| * | Remove i18n symbol dependencyChris McGrath2013-01-171-3/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | date.order is the only key in rails i18n that is required to be a symbol. This patch allows for symbols or strings which means: * No requirement for symbol type in .yml files. A future YAML.safe_load wouldn't need to load symbols * Rails could actually use json rather than yml as the backend
* | | Restore and adapt the implementation reverted atRafael Mendonça França2013-01-192-8/+8
| | | | | | | | | | | | | | | | | | https://github.com/rails/rails/commit/cc1c3c5be061e7572018f734e5239750ab449e3f Now instead of raise, we log by default in development and test
* | | Added ability to raise or log on unpermitted params.Thomas Drake-Brockman2013-01-202-0/+83
| | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-09 18:42:49 +0000