Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | add the fetch method to sessions | Damien Mathieu | 2013-10-29 | 1 | -0/+13 |
| | |||||
* | don't mutate hash with fetch | Doug Cole | 2013-10-26 | 1 | -0/+6 |
| | |||||
* | pass app config to controller helper proxy | Tima Maslyuchenko | 2013-10-24 | 1 | -0/+6 |
| | | | | | | | | | | | | | | | After this fix application config become available when calling helper outisde of view config/application.rb #... config.asset_host = 'http://mycdn.com' #... Somewhere else ActionController::Base.helpers.asset_path('fallback.png') # => http://mycdn.com/assets/fallback.png | ||||
* | Correct error in Utils.normalize_path that changed paths improperly | Josh Symonds | 2013-10-23 | 1 | -0/+8 |
| | |||||
* | Removing unused fake models from actionpack tests | Thiago Pradi | 2013-10-16 | 1 | -95/+0 |
| | |||||
* | Respect `SCRIPT_NAME` when using `redirect` with a relative path | Andrew White | 2013-10-10 | 1 | -0/+100 |
| | | | | | | | | | | | | | | | | Example: # application routes.rb mount BlogEngine => '/blog' # engine routes.rb get '/admin' => redirect('admin/dashboard') This now redirects to the path `/blog/admin/dashboard`, whereas before it would've generated an invalid url because there would be no slash between the host name and the path. It also allows redirects to work where the application is deployed to a subdirectory of a website. Fixes #7977 | ||||
* | Fixing repond_with working directly on the options hash | BlueHotDog | 2013-10-09 | 2 | -0/+15 |
| | | | | | | | | This fixes an issue where the respond_with worked directly with the given options hash, so that if a user relied on it after calling respond_with, the hash wouldn't be the same. Fixes #12029 | ||||
* | Merge pull request #12354 from kennyj/fix_12293 | Rafael Mendonça França | 2013-09-28 | 1 | -0/+15 |
|\ | | | | | Closes #12293. Strong parameters should permit nested number as key. | ||||
| * | Strong parameters should permit nested number as key. Closes #12293 | kennyj | 2013-09-27 | 1 | -0/+15 |
| | | |||||
* | | Merge pull request #12233 from claudiob/delete-actionpack-unused-fixture | Yves Senn | 2013-09-27 | 1 | -5/+0 |
|\ \ | |/ |/| | Remove HelperyTestHelper not used in any test | ||||
| * | Remove HelperyTestHelper not used in any test | claudiob | 2013-09-14 | 1 | -5/+0 |
| | | | | | | | | | | | | HelperyTestHelper was introduced in 66ef922 by @josevalim to pair with HelperyTestController. This test controller was later removed in e10a253 by @strzalek, leaving HelperyTestHelper unused | ||||
* | | add test_scoped_root_as_name | Sam Ruby | 2013-09-24 | 1 | -0/+13 |
| | | | | | | | | test for regression introduced by https://github.com/rails/rails/pull/9155 | ||||
* | | Fix incorrect assert_redirected_to failure message | Derek Prior | 2013-09-19 | 1 | -0/+18 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In some instances, `assert_redirected_to` assertion was returning an incorrect and misleading failure message when the assertion failed. This was due to a disconnect in how the assertion computes the redirect string for the failure message and how `redirect_to` computes the string that is actually used for redirection. I made the `_compute_redirect_to_loaction` method used by `redirect_to` public and call that from the method `assert_redirect_to` uses to calculate the URL. The reveals a new test failure due to the regex used by `_compute_redirect_to_location` allow `_` in the URL scheme. | ||||
* | | NullSessionHash#destroy should be a no-op | Jonathan Baudanza | 2013-09-18 | 1 | -0/+10 |
| | | | | | | | | Previously it was raising a NilException | ||||
* | | Fix an issue where router can't recognize downcased url encoding path. | kennyj | 2013-09-19 | 1 | -0/+4 |
|/ | |||||
* | Custom flash should be defined only for the class that defines it and it's ↵ | Ricardo de Cillo | 2013-09-13 | 1 | -0/+12 |
| | | | | subclasses. | ||||
* | Merge pull request #12159 from nashby/issue-12149 | Rafael Mendonça França | 2013-09-12 | 1 | -0/+9 |
|\ | | | | | do not break params filtering on nil values | ||||
| * | do not break params filtering on nil values | Vasiliy Ermolovich | 2013-09-07 | 1 | -0/+9 |
| | | | | | | | | closes #12149 | ||||
* | | Removed semicolon and added space | Anupam Choudhury | 2013-09-13 | 1 | -2/+2 |
| | | |||||
* | | Reset ActionView::Base.logger instead of AC::Base.logger | Akira Matsuda | 2013-09-10 | 1 | -1/+1 |
| | | | | | | | | see: 9b0ac0bc74569db460f87ea6888b3847be0ff5be | ||||
* | | Make AC standalone rendering work | Santiago Pastorino | 2013-09-10 | 1 | -0/+15 |
| | | |||||
* | | Remove helper fixtures not used in any test | claudiob | 2013-09-09 | 1 | -2/+0 |
|/ | | | | | | The fixture for module AbcHelper defines three functions bare_a, bare_b and bare_c, but only bare_a is used in the code that tests helper functions. | ||||
* | Revert "Port all remaining self.protected_instance_variables to class methods" | Łukasz Strzałkowski | 2013-09-02 | 1 | -1/+1 |
| | | | | This reverts commit 7de994fa215e9f4c2856d85034bc4dd7b65d0c01. | ||||
* | Merge pull request #11912 from jonkessler/respond-to-signature-fixes | Rafael Mendonça França | 2013-08-31 | 1 | -0/+5 |
|\ | | | | | Update Rails::Railtie::Configuration and ActionDispatch::Response#respond_to? to accept include_private argument | ||||
| * | update Rails::Railtie::Configuration and ↵ | Jon Kessler | 2013-08-16 | 1 | -0/+5 |
| | | | | | | | | ActionDispatch::Response#respond_to? to accept include_private argument | ||||
* | | Port all remaining self.protected_instance_variables to class methods | Łukasz Strzałkowski | 2013-08-29 | 1 | -1/+1 |
| | | |||||
* | | Move abstract's controller tests to AV | Łukasz Strzałkowski | 2013-08-25 | 15 | -891/+0 |
| | | | | | | | | The ones that were actually testing AV functionality and should belong in there | ||||
* | | Extend basic rendering, test it in railties | Łukasz Strzałkowski | 2013-08-25 | 1 | -19/+0 |
| | | |||||
* | | Basic rendering test | Łukasz Strzałkowski | 2013-08-25 | 1 | -0/+19 |
| | | |||||
* | | Move AP's capture tests to AV | Łukasz Strzałkowski | 2013-08-25 | 1 | -79/+0 |
| | | |||||
* | | Move remaining layouts tests to AV | Łukasz Strzałkowski | 2013-08-25 | 10 | -270/+0 |
| | | |||||
* | | Remove unused fixtures and models from AP tests | Łukasz Strzałkowski | 2013-08-25 | 7 | -12/+0 |
| | | |||||
* | | Move render_test to AV | Łukasz Strzałkowski | 2013-08-25 | 1 | -1298/+106 |
| | | |||||
* | | Load AV::Layout to AM::Base in railties | Łukasz Strzałkowski | 2013-08-25 | 1 | -0/+3 |
| | | |||||
* | | Remove RenderERBUtils from AP (only AV use it) | Łukasz Strzałkowski | 2013-08-25 | 1 | -22/+0 |
| | | |||||
* | | Remove AV::TestCase from AP | Łukasz Strzałkowski | 2013-08-25 | 1 | -8/+0 |
| | | |||||
* | | Load AV::Layouts dynamicly via railties | Łukasz Strzałkowski | 2013-08-25 | 1 | -0/+2 |
| | | |||||
* | | Create AbstractController::Rendering interface | Łukasz Strzałkowski | 2013-08-25 | 7 | -2/+9 |
| | | | | | | | | This interface should be use when implementing renderers. | ||||
* | | Fix AP test suite after moving stuff to AV | Łukasz Strzałkowski | 2013-08-25 | 5 | -6/+7 |
| | | |||||
* | | Move view_paths from AP to AV | Łukasz Strzałkowski | 2013-08-25 | 3 | -176/+0 |
| | | |||||
* | | Display exceptions in text format for xhr request | Kir Shatrov | 2013-08-22 | 1 | -0/+41 |
| | | |||||
* | | Merge pull request #11443 from wangjohn/sse_reloader_class | Santiago Pastorino | 2013-08-19 | 1 | -0/+88 |
|\ \ | | | | | | | SSE class for ActionController::Live | ||||
| * | | Creating an SSE class to be used with ActionController::Live. | wangjohn | 2013-07-30 | 1 | -0/+88 |
| | | | |||||
* | | | Fail informatively in #respond_with when no appropriate #api_behavior ↵ | Ben Woosley | 2013-08-17 | 1 | -0/+31 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | renderer is available. Currently if a user calls #respond_with(csvable), but has not csv renderer available, Responder will just run through the default render behavior twice, raising ActionView::MissingTemplate both times. This changes ActionController::Metal::Responder#api_behavior to check in advance whether there is a renderer available, and raise ActionController::MissingRenderer if not. | ||||
* | | | Split the 1200+ line mime_responds_test into 3 more focused and manageable ↵ | Ben Woosley | 2013-08-17 | 3 | -587/+587 |
| | | | | | | | | | | | | test files. | ||||
* | | | Merge branch 'master' of github.com:rails/docrails | Vijay Dev | 2013-08-17 | 3 | -6/+1 |
|\ \ \ | |_|/ |/| | | | | | | | | | | | | | | | | | Conflicts: actionview/README.rdoc activerecord/lib/active_record/migration.rb guides/source/development_dependencies_install.md guides/source/getting_started.md | ||||
| * | | Revert "Merge branch 'master' of github.com:rails/docrails" | Vijay Dev | 2013-08-17 | 3 | -6/+1 |
| |/ | | | | | | | | | | | | | This reverts commit 70d6e16fbad75b89dd1798ed697e7732b8606fa3, reversing changes made to ea4db3bc078fb3093ecdddffdf4f2f4ff3e1e8f9. Seems to be a code merge done by mistake. | ||||
* | | Execute conditional procs on controller filters only for current action. | Nicholas Jakobsen | 2013-08-10 | 1 | -0/+9 |
| | | | | | | | | | | | | :only and :except options for controller filters are now added before :if and :unless. This prevents running :if and :unless procs when not on the specified. Closes #11786. | ||||
* | | Add timeout to test_async_stream | Gaurish Sharma | 2013-08-02 | 1 | -1/+1 |
|/ | | | | | | | | | | Without timeout: this test executed infinitely on JRuby Passes on MRI With Timeout: this test gracefully fails on JRuby Passes on MRI, tested on v2.0 & v1.9.3 | ||||
* | Reset ActionView::Base.logger instead of AC::Base.logger | Akira Matsuda | 2013-07-26 | 1 | -1/+1 |
| | | | | see: 9b0ac0bc74569db460f87ea6888b3847be0ff5be |