aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/test
Commit message (Collapse)AuthorAgeFilesLines
* Fix warning about ambiguous first argumentArun Agrawal2015-05-291-1/+1
|
* Merge pull request #20017 from eliotsykes/configurable-static-index-filenameRafael Mendonça França2015-05-285-0/+18
|\ | | | | | | config.static_index configures directory Index "index.html" filename
| * config.static_index configures directory index "index.html" filenameEliot Sykes2015-05-285-0/+18
| | | | | | | | | | | | Set `config.static_index` to serve a static directory index file not named `index`. For example, to serve `main.html` instead of `index.html` for directory requests, set `config.static_index` to `"main"`.
* | Deprecate `:nothing` option for render methodMehmet Emin İNAÇ2015-05-288-13/+23
|/ | | | `head` method works similar to `render` method with `:nothing` option
* Merge pull request #19808 from byroot/action-parameterRafael Mendonça França2015-05-271-0/+20
|\ | | | | [PoC] Stop shadowing parameters named `action`
| * Allow to parameters named `action` or `controller` from AC::TestCase helpersJean Boussier2015-04-181-0/+20
| |
* | Add assertion for get? method into test casesMehmet Emin İNAÇ2015-05-271-0/+1
| |
* | Merge pull request #17788 from sivagollapalli/masterArthur Nogueira Neves2015-05-201-0/+5
|\ \ | | | | | | Issue#17703 Test case for tempfile attribute
| * | Issue#17703 Test case for tempfile attributeSiva Gollapalli2015-04-161-0/+5
| |/ | | | | | | | | | | | | | | | | | | + To avoid regression I am adding this test case on action pack Changed to assert from assert_equal + Added msg to assertion Modified msg
* | Prefer assert_not over refuteRafael Mendonça França2015-05-182-2/+2
| |
* | ActionDispatch::Journey::Routes#empty? test casesValentine Valyaeff2015-05-192-0/+16
| |
* | Silence ambiguous first argument warningPrem Sichanugrist2015-05-041-1/+1
| | | | | | | | | | | | | | This silences: actionpack/test/journey/route_test.rb:33: warning: ambiguous first argument; put parentheses or a space even after `/' operator
* | Give authentication methods the ability to customize response message.Keenan Brock2015-05-032-6/+6
| | | | | | | | Digest allowed the messages. Add the same feature to basic and token
* | Merge pull request #18392 from brainopia/fix_route_requirementsArthur Nogueira Neves2015-04-271-0/+8
|\ \ | | | | | | Correct route requirements by overriding defaultls
| * | Correct route requirements by overriding defaultls (fixes #18373)brainopia2015-01-081-0/+8
| | |
* | | Merge pull request #19904 from zzak/rm_route_wrapper_internal_hacksRafael Mendonça França2015-04-261-0/+16
|\ \ \ | | | | | | | | Rm route wrapper internal hacks
| * | | Fix rake routes for api appsJorge Bejar2015-04-251-0/+16
| | | | | | | | | | | | | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* | | | Removed unused code from request_forgery_protection testsPrathamesh Sonpatki2015-04-261-17/+0
|/ / /
* | | Why do we add a top-level constant here?Akira Matsuda2015-04-251-5/+3
| | |
* | | Remove unused WorkshopsController class in redirect_test.Bryce Boe2015-04-231-3/+0
| |/ |/|
* | Merge pull request #19736 from kmcphillips/masterRafael Mendonça França2015-04-141-0/+17
|\ \ | | | | | | Set default form builder for a controller
| * | Override default form builder for a controllerKevin McPhillips2015-04-131-0/+17
| | |
* | | Use `silence_warnings` on `StaticTests`eileencodes2015-04-141-6/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When 7e504927 was merged setting `Encoding.default_internal` and `Encoding.default_external` would throw a warning when the ActionPack tests were run. Example warning: `actionpack/test/dispatch/static_test.rb:12: warning: setting Encoding.default_external` This patch silences the warnings as other similar tests do for setting default_internal and default_external.
* | | Revert "Merge pull request #19682 from ↵Santiago Pastorino2015-04-121-25/+0
|/ / | | | | | | | | | | | | supercaracal/fix_force_ssl_redirection_flash_error" This reverts commit d215620340be7cb29e2aa87aab22da5ec9e6e6a7, reversing changes made to bbbbfe1ac02162ecb5e9a7b560134a3221f129f3.
* | fix a wrong feature test method nameTaishi Kasuga2015-04-111-1/+1
| |
* | [Rails4 regression] prevent thin and puma cause error in Non ASCII URL on ↵Toshi MARUYAMA2015-04-091-0/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Windows * https://github.com/rails/rails/issues/19187 * https://github.com/rails/rails/pull/19533 * https://github.com/macournoyer/thin/issues/268 These are serious Rails 4 regression for Redmine Bitnami Windows users. https://community.bitnami.com/t/problems-with-3-0-1-installation-see-report-inside/30195/ It is not caused on webrick users. Related: * https://github.com/rack/rack/issues/732#issuecomment-67677272 * https://github.com/phusion/passenger/issues/1328
* | wrap "require 'drb/unix'" by bgin-end at test/abstract_unit.rbToshi MARUYAMA2015-04-091-1/+5
| | | | | | | | | | | | Related: #19617, #19187, #19533, #19689, #19675. 'drb/unix' does not exist on mingw.
* | fix fails to force_ssl_redirection if session_store is disabledTaishi Kasuga2015-04-091-0/+25
| |
* | Merge pull request #19633 from y00rb/sort_router_parameters_duplicated_keysRafael Mendonça França2015-04-082-0/+40
|\ \ | | | | | | avoid error when sort mixture keys in symbol and string
| * | sort_by instead of sortYang Bo2015-04-082-0/+40
| | | | | | | | | | | | | | | | | | it is avoid sort errot within different and mixed keys. used `sort_by` + `block` to list parameter by keys. keep minimum changes
* | | Fix ActionPack tests after changes to missing template loggereileencodes2015-04-061-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | After merging #19377 ActionPack tests were missing a require for `ActiveSupport::LogSubscriber::TestHelper` and change didn't take into account that logger could be nil. Added the require and only log to info if logger exists. This wasn't caught earlier because these tests only run after a merge.
* | | head no_content when there is no template or action performedStephen Bussey2015-04-051-6/+16
|/ /
* | Merge pull request #19544 from shuhei/fix-parameters-const-missingXavier Noria2015-03-281-1/+8
|\ \ | | | | | | Return super in ActionController::Parameters.const_missing
| * | Return super in ActionController::Parameters.const_missingShuhei Kagawa2015-03-281-1/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The current implementation of ActionController::Parameters.const_missing returns `ActionController::Parameters.always_permitted_parameters` even if its `super` returns a constant without raising error. This prevents its subclass in a autoloading module/class from taking advantage of autoloading constants. class SomeParameters < ActionController::Parameters def do_something DefinedSomewhere.do_something end end In the code above, `DefinedSomewhere` is to be autoloaded with `Module.const_missing` but `ActionController::Parameters.const_missing` returns `always_permitted_parameters` instead of the autoloaded constant. This pull request fixes the issue respecting `const_missing`'s `super`.
* | | Define a setup method instead of using setup as blockRafael Mendonça França2015-03-271-1/+2
| | | | | | | | | | | | | | | setup as block run before setup actlually runs so it will fail for our case
* | | Provide friendlier access to request variantsGeorge Claghorn2015-03-241-19/+30
|/ / | | | | | | Closes #18933.
* | Fix failing tests for #19474Andrew White2015-03-231-2/+2
| |
* | remove old unavailable link with relevant fixGaurav Sharma2015-03-231-2/+2
| |
* | Fix handling of empty X_FORWARDED_HOST header.adam2015-03-201-0/+3
| | | | | | | | | | | | Previously, an empty X_FORWARDED_HOST header would cause Actiondispatch::Http:URL.raw_host_with_port to return nil, causing Actiondispatch::Http:URL.host to raise a NoMethodError.
* | Revert "Merge pull request #19404 from dmathieu/remove_rack_env"Jeremy Kemper2015-03-201-1/+1
| | | | | | | | | | | | | | Preserving RACK_ENV behavior. This reverts commit 7bdc7635b885e473f6a577264fd8efad1c02174f, reversing changes made to 45786be516e13d55a1fca9a4abaddd5781209103.
* | Fix kwargs warning in `test_get_xml`eileencodes2015-03-201-1/+1
| | | | | | | | | | | | ActionDispatch::IntegrationTest HTTP request methods will accept only certain kwargs in the future. This test caused a deprecation warning when running ActionPack tests. Added `params` and `headers` to fix.
* | Fix test messages use directly true, false and nil instead of their symbolAkshay Vishnoi2015-03-191-3/+3
| |
* | don't fallback to RACK_ENV when RAILS_ENV is not presentDamien Mathieu2015-03-191-1/+1
| |
* | Compare content_type with Mime::XML instead of regexpBoris Peterbarg2015-03-161-0/+17
| | | | | | | | | | Regexp is broken for both content types including charsets and for integration tests, where the content_type is a Mime::Type and not String
* | Merge pull request #19291 from hired/return-truthy-value-from-headRafael Mendonça França2015-03-131-0/+11
|\ \ | | | | | | Return truthy value from head method
| * | Return true from head methodJoel Hayhurst2015-03-121-0/+11
| | | | | | | | | | | | | | | | | | It was returning false in normal circumstances. This broke the `head :ok and return if` construct. Add appropriate test.
* | | Merge pull request #19309 from f1sherman/dont-set-session-options-idGuillermo Iguaran2015-03-124-12/+4
|\ \ \ | | | | | | | | Use request.session.id instead of request.session_options[:id]
| * | | Use request.session.id instead of request.session_options[:id]Brian John2015-03-124-12/+4
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | As of the upgrade to Rack 1.5, request.session_options[:id] is no longer populated. Reflect this change in the tests by using request.session.id instead. Related change in Rack: https://github.com/rack/rack/commit/83a270d6
* | | Also skip Content-Encoding and Vary header if 304Kohei Suzuki2015-03-121-1/+2
| | |
* | | 304 response should not include Content-Type headerKohei Suzuki2015-03-101-0/+9
|/ / | | | | | | | | Rack::Lint raises an error saying "Content-Type header found in 304 response, not allowed".
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-17 12:27:28 +0000