| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|\ \
| | |
| | | |
Allow filtering params based on parent keys
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Add the possibility to only filter parameters based on
their full path instead of relying on the immediate key.
config.filter_parameters += ['credit_card.code']
{ 'credit_card' => { 'code' => '[FILTERED]' },
'source' => { 'code' => '<%= puts 5 %>' } }
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Using `assert_predicate` and `assert_match` instead of just `assert` is
preferrable because better error messages are output.
In the case of `assert response.cookies.empty?` the error message was
`Failed assertion, no message given.` but now with `assert_predicate` it
will be `Expected {"user_name"=>"david"} to be empty?.`
For `assert_match(/user_name=david/,
response.headers["Set-Cookie"])` as well, the message returned was
unhelpful - `Failed assertion, no message given.` but now will tell what
was expected and what was returned with `Expected /user_name=david/ to
match "user_name=nope; path=/".`
|
|\ \ \
| | | |
| | | | |
Allow default_render to take a block to customize behavior when there's no template
|
| |/ /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
In 0de4a23 the behavior when there is a missing template was changed to
not raise an error, but instead head :no_content. This is a breaking
change and some gems rely on this happening.
To allow gems and other code to work around this, allow
`default_render` to take a block which, if provided, will
execute the contents of that block instead of doing the `head :no_content`.
|
|\ \ \
| |/ /
|/| | |
Respect routing precedence for HEAD requests
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Fixes the issue described in #18764 - prevents Rack middleware from
swallowing up HEAD requests that should have been matched by a
higher-precedence `get` route, but still allows Rack middleware to
respond to HEAD requests.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This reverts commit 0b3397872582f2cf1bc6960960a6393f477c55e6, reversing
changes made to 56d52e3749180e6c1dcf7166adbad967470aa78b.
As pointed out on the PR, this will hide development mistakes too, which
is not ideal.
|
| |/
|/|
| |
| |
| | |
Handle URI::InvalidURIError errors on the redirect route method, so it
wont raise a 500 if a bad path is given.
|
| |
| |
| |
| |
| |
| | |
People should be free to mutate the header object, but not to set a new
header object. That header object may be specific to the webserver, and
we need to hide it's internals.
|
| | |
|
| |
| |
| |
| | |
Brought on by my own stupidity :)
|
| |
| |
| |
| |
| |
| | |
`ActionDispatch::SSL` changes headers to `Hash`.
So some headers will be broken if there are some middlewares
on ActionDispatch::SSL and if it uses `Rack::Utils::HeaderHash`.
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
ParamsWrapper was initially removed from API controllers according to
the following discusision:
https://github.com/rails-api/rails-api/issues/33
However, we're including it again so Rails API devs can decide
whether to enable or disable it.
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| | |
does the work
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| |
| | |
this way we can remove the strange "respond_to?" conditional in the
`matches?` loop
|
|\ \
| | |
| | | |
Have Bearer be valid as well
|
| | | |
|
| | | |
|
|\ \ \
| | | |
| | | | |
Deprecate `assert_template` and `assigns()`.
|
| |/ / |
|
|\ \ \
| |/ /
|/| | |
Move expectation to instance level.
|
| | |
| | |
| | |
| | | |
The tests would still pass if the cache call in the rendered templates were removed.
|
| | | |
|
|\ \ \
| | | |
| | | |
| | | | |
config.static_index configures directory Index "index.html" filename
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Set `config.static_index` to serve a static directory index file not
named `index`. For example, to serve `main.html` instead of `index.html`
for directory requests, set `config.static_index` to `"main"`.
|
|/ / /
| | |
| | |
| | | |
`head` method works similar to `render` method with `:nothing` option
|
|\ \ \
| | | |
| | | | |
[PoC] Stop shadowing parameters named `action`
|
| | | | |
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
Issue#17703 Test case for tempfile attribute
|
| |/ / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
+ To avoid regression I am adding this test case on action pack
Changed to assert from assert_equal
+ Added msg to assertion
Modified msg
|
| | | | |
|
| |/ /
|/| | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This silences:
actionpack/test/journey/route_test.rb:33: warning: ambiguous first
argument; put parentheses or a space even after `/' operator
|
| | |
| | |
| | |
| | | |
Digest allowed the messages.
Add the same feature to basic and token
|
|\ \ \
| | | |
| | | | |
Correct route requirements by overriding defaultls
|
| | | | |
|