aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/test
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #5622 from rafaelfranca/fix-2492-3-2Jeremy Kemper2012-03-271-0/+35
|\ | | | | [3-2-stable] Fix label_tag to merge the options hash with the object hash
| * Check if the options hash already exists and merge it with the anotherRafael Mendonça França2012-03-271-6/+19
| | | | | | | | | | | | hash. Closes #2492 and #5614
| * Fixing issue #2492. ActionView::Base.field_error_proc doesn't call for label.Andrey Samsonov2012-03-271-0/+22
| | | | | | | | | | | | objectify_options method should be applied to the proper options arg. See explanation and example of the bug - https://github.com/kryzhovnik/rails_field_error_proc_bug_example
* | Merge pull request #5619 from jcoleman/textarea-newline-fix-breaks-hamlSantiago Pastorino2012-03-271-6/+6
|\ \ | |/ |/| Textarea newline fix breaks haml (3-2-stable)
| * Don't break Haml with textarea newline fix.James Coleman2012-03-271-6/+6
| | | | | | | | | | | | See issue #393, issue #4000, issue #5190, and issue #5191. Adds a newline after the textarea opening tag based on @codykrieger's original patch so that we don't cause regressions in Haml-using apps. The regression caused textarea tags to add newlines to the field unintentionally (each update/save added an extra newline.) Also fix 6 more tests that didn't yet have the newline expectation.
* | If partial is rendered in controller, grab format from templatePiotr Sarnacki2012-03-272-0/+14
|/ | | | | | | | | Previously `rendered_format` was set only based on mime types passed in Accept header, which was wrong if first type from Accept was different than rendered partial. The fix is to simply move setting rendered_format to the place where template is available and grab format from the template. If it fails we can fallback to formats passed by Accept header.
* apply form_for namespace option to date_selectSergey Nartimov2012-03-261-0/+8
|
* Build fix for ruby1.8.7-358Arun Agrawal2012-03-192-9/+7
|
* Add missing test for #5308Piotr Sarnacki2012-03-173-0/+15
|
* Fix #5440 - multiple render_to_string breaks partials formatsPiotr Sarnacki2012-03-175-0/+30
| | | | | | | | | This fixes situation where rendering template to string sets `rendered_format` to the format rendered there. This is ok to have consistent formats rendered in partials, but it breaks on next renders if format is explicitly set or on last render where default format does not necessarily need to be the format of first rendered template.
* Merge pull request #5457 from brianmario/typo-fixAaron Patterson2012-03-151-1/+1
| | | | Fix typo in redirect test
* Merge pull request #5456 from brianmario/redirect-sanitizationAaron Patterson2012-03-151-0/+20
| | | | Strip null bytes from Location header
* Merge pull request #5338 from mreinsch/3-2-static_invalid_byte_sequenceAaron Patterson2012-03-151-0/+4
|\ | | | | 3 2 static invalid byte sequence
| * fix ArgumentError being raised in case of invalid byte sequencesMichael Reinsch2012-03-081-0/+4
| |
* | Remove ActionController::TestCase#rescue_action_in_public!Piotr Sarnacki2012-03-151-5/+0
| | | | | | | | | | | | This method has no effect since exception handling was moved to middlewares and ActionController tests do not use any middlewares.
* | Allow you to force the authenticity_token to be rendered even on remote ↵David Heinemeier Hansson2012-03-141-0/+11
| | | | | | | | forms if you pass true
* | Do not include the authenticity token in forms where remote: true as ajax ↵David Heinemeier Hansson2012-03-141-0/+11
|/ | | | forms use the meta-tag value
* Add test case for #5307Carlos Antonio da Silva2012-03-071-2/+6
|
* Failing test for mime responder respond_with using a block.Mario Visic2012-03-051-0/+36
|
* Fix #5238, rendered_format is not set when template is not renderedPiotr Sarnacki2012-03-021-2/+6
|
* Merge branch '3-2-2' into 3-2-stableAaron Patterson2012-03-011-1/+8
|\ | | | | | | | | | | | | | | | | | | | | | | | | * 3-2-2: bumping to 3.2.2 Ensure [] respects the status of the buffer. Merge pull request #4834 from sskirby/fix_usage_of_psql_in_db_test_prepare Merge pull request #5084 from johndouthat/patch-1 updating RAILS_VERSION delete vulnerable AS::SafeBuffer#[] use AS::SafeBuffer#clone_empty for flushing the output_buffer add AS::SafeBuffer#clone_empty fix output safety issue with select options
| * Merge branch '3-2-stable-security' into 3-2-2Aaron Patterson2012-03-011-1/+8
| |\ | | | | | | | | | | | | | | | | | | | | | | | | * 3-2-stable-security: Ensure [] respects the status of the buffer. delete vulnerable AS::SafeBuffer#[] use AS::SafeBuffer#clone_empty for flushing the output_buffer add AS::SafeBuffer#clone_empty fix output safety issue with select options
| | * fix output safety issue with select optionsSergey Nartimov2012-02-201-1/+8
| | |
* | | Add a new line after the textarea opening tag.Rafael Mendonça França2012-02-272-37/+37
| | | | | | | | | | | | Closes #393
* | | Adding tests for non-optional glob parametersAndrew White2012-02-261-2/+27
| | |
* | | assert => assert_equalArun Agrawal2012-02-251-3/+3
| | |
* | | Checking headers in a better way. as doing hereArun Agrawal2012-02-251-4/+3
| | | | | | | | | | | | 406ece4729e8fd81f156bcb3fce16e938522466e
* | | Build fix for ruby187-p358Arun Agrawal2012-02-251-2/+7
|/ /
* | format lookup for partials is derived from the format in which the template ↵Santiago Pastorino2012-02-223-4/+9
| | | | | | | | | | | | is being rendered Closes #5025 part 2
* | Don't wrap the raise with ensureSantiago Pastorino2012-02-211-1/+1
| |
* | Restore lookup formats to the previous value after searching for the failing ↵Santiago Pastorino2012-02-211-1/+2
| | | | | | | | view
* | Fix some warnings on 3-2-stablekennyj2012-02-214-25/+27
|/
* Fix a failing testSantiago Pastorino2012-02-201-0/+2
|
* Use the right format when a partial is missing.Santiago Pastorino2012-02-202-0/+8
| | | | Closes #5025
* Reset memoized hash keys when new entry addedChris Kelly2012-02-201-0/+6
|
* Remove fixture files with Windows incompatible filenamesAndrew White2012-02-2013-39/+88
| | | | | | Windows doesn't allow `\ / : * ? " < > |` in filenames so create the fixture files at runtime and ignore the incompatible ones when running on Windows.
* Fix ActionDispatch::Static to serve files with unencoded PCHARAndrew White2012-02-1713-0/+40
| | | | | | | | | | | RFC 3986[1] allows sub-delim characters in path segments unencoded, however Rack::File requires them to be encoded so we use URI's unescape method to leave them alone and then escape them again. Also since the path gets passed to Dir[] we need to escape any glob characters in the path. [1]: http://www.ietf.org/rfc/rfc3986.txt
* backporting #4918 to 3.2 stable; adding extra test for accept header given ↵Aditya Sanghi2012-02-171-0/+12
| | | | by googlebot
* adding tests to document behavior for #4817Aaron Patterson2012-02-141-0/+26
|
* Rack body respond to each and not to joinSantiago Pastorino2012-02-141-0/+12
| | | | | | | This fixes undef `to_str' for Rack::Chunked::Body when using caches_action + streaming on an action Closes #5027
* Merge pull request #4988 from kennyj/fix_4720-3Aaron Patterson2012-02-101-0/+26
| | | | Fix GH #4720. Routing problem with nested namespace and already camelized controller option.
* Added unit test to cover changes to RouteSet.url_forRyan McGeary2012-02-071-0/+16
| | | | | ActionDispatch::Routing::RouteSet.url_for now handles passing params through to ActionDispatch::Http::Url.url_for
* Fixed force_ssl redirects to include original query paramsRyan McGeary2012-02-061-0/+6
| | | | | | `ActionController.force_ssl` redirects http URLs to their https equivalent; however, when a URL contains a query string, the resulting redirect lacked the original query string.
* Merge pull request #4908 from kennyj/fix_3864José Valim2012-02-061-0/+33
| | | | Fix url_for method's behavior. GH #3684.
* Merge pull request #4870 from sikachu/3-2-stable-responder-fixJosé Valim2012-02-042-0/+35
|\ | | | | Fix override API response bug in respond_with
| * Fix override API response bug in respond_withPrem Sichanugrist2012-02-032-0/+35
| | | | | | | | | | | | | | | | | | | | Default responder was only using the given respond block when user requested for HTML format, or JSON/XML format with valid resource. This fix the responder so that it will use the given block regardless of the validity of the resource. Note that in this case you'll have to check for object's validity by yourself in the controller. Fixes #4796
* | Merge pull request #4879 from kennyj/fix_4873José Valim2012-02-041-0/+6
|/ | | | Fix GH #4873. Allow swapping same class middleware.
* don't set the hidden checkbox value if it's nilDamien Mathieu2012-01-271-0/+8
|
* check_box helper with :disabled => true generates disabled hidden field. ↵Tadas Tamošauskas2012-01-271-4/+3
| | | | fixes #1953
* Test for unicode path supportPaul McMahon2012-01-251-0/+20
| | | | This is currently broken due to a bug in journey.