| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| | |
[3-2-stable] Fix label_tag to merge the options hash with the object hash
|
| |
| |
| |
| |
| |
| | |
hash.
Closes #2492 and #5614
|
| |
| |
| |
| |
| |
| | |
objectify_options method should be applied to the proper options arg.
See explanation and example of the bug - https://github.com/kryzhovnik/rails_field_error_proc_bug_example
|
|\ \
| |/
|/| |
Textarea newline fix breaks haml (3-2-stable)
|
| |
| |
| |
| |
| |
| | |
See issue #393, issue #4000, issue #5190, and issue #5191. Adds a newline after the textarea opening tag based on @codykrieger's original patch so that we don't cause regressions in Haml-using apps. The regression caused textarea tags to add newlines to the field unintentionally (each update/save added an extra newline.)
Also fix 6 more tests that didn't yet have the newline expectation.
|
|/
|
|
|
|
|
|
|
| |
Previously `rendered_format` was set only based on mime types
passed in Accept header, which was wrong if first type from
Accept was different than rendered partial. The fix is to simply
move setting rendered_format to the place where template
is available and grab format from the template. If it fails
we can fallback to formats passed by Accept header.
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
| |
This fixes situation where rendering template to string
sets `rendered_format` to the format rendered there.
This is ok to have consistent formats rendered in partials,
but it breaks on next renders if format is explicitly set
or on last render where default format does not necessarily
need to be the format of first rendered template.
|
|
|
|
| |
Fix typo in redirect test
|
|
|
|
| |
Strip null bytes from Location header
|
|\
| |
| | |
3 2 static invalid byte sequence
|
| | |
|
| |
| |
| |
| |
| |
| | |
This method has no effect since exception handling was
moved to middlewares and ActionController tests do not
use any middlewares.
|
| |
| |
| |
| | |
forms if you pass true
|
|/
|
|
| |
forms use the meta-tag value
|
| |
|
| |
|
| |
|
|\
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
* 3-2-2:
bumping to 3.2.2
Ensure [] respects the status of the buffer.
Merge pull request #4834 from sskirby/fix_usage_of_psql_in_db_test_prepare
Merge pull request #5084 from johndouthat/patch-1
updating RAILS_VERSION
delete vulnerable AS::SafeBuffer#[]
use AS::SafeBuffer#clone_empty for flushing the output_buffer
add AS::SafeBuffer#clone_empty
fix output safety issue with select options
|
| |\
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
* 3-2-stable-security:
Ensure [] respects the status of the buffer.
delete vulnerable AS::SafeBuffer#[]
use AS::SafeBuffer#clone_empty for flushing the output_buffer
add AS::SafeBuffer#clone_empty
fix output safety issue with select options
|
| | | |
|
| | |
| | |
| | |
| | | |
Closes #393
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | | |
406ece4729e8fd81f156bcb3fce16e938522466e
|
|/ / |
|
| |
| |
| |
| |
| |
| | |
is being rendered
Closes #5025 part 2
|
| | |
|
| |
| |
| |
| | |
view
|
|/ |
|
| |
|
|
|
|
| |
Closes #5025
|
| |
|
|
|
|
|
|
| |
Windows doesn't allow `\ / : * ? " < > |` in filenames so create
the fixture files at runtime and ignore the incompatible ones when
running on Windows.
|
|
|
|
|
|
|
|
|
|
|
| |
RFC 3986[1] allows sub-delim characters in path segments unencoded,
however Rack::File requires them to be encoded so we use URI's
unescape method to leave them alone and then escape them again.
Also since the path gets passed to Dir[] we need to escape any glob
characters in the path.
[1]: http://www.ietf.org/rfc/rfc3986.txt
|
|
|
|
| |
by googlebot
|
| |
|
|
|
|
|
|
|
| |
This fixes undef `to_str' for Rack::Chunked::Body when using
caches_action + streaming on an action
Closes #5027
|
|
|
|
| |
Fix GH #4720. Routing problem with nested namespace and already camelized controller option.
|
|
|
|
|
| |
ActionDispatch::Routing::RouteSet.url_for now handles passing params through to
ActionDispatch::Http::Url.url_for
|
|
|
|
|
|
| |
`ActionController.force_ssl` redirects http URLs to their https equivalent;
however, when a URL contains a query string, the resulting redirect lacked the
original query string.
|
|
|
|
| |
Fix url_for method's behavior. GH #3684.
|
|\
| |
| | |
Fix override API response bug in respond_with
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Default responder was only using the given respond block when user
requested for HTML format, or JSON/XML format with valid resource. This
fix the responder so that it will use the given block regardless of the
validity of the resource. Note that in this case you'll have to check
for object's validity by yourself in the controller.
Fixes #4796
|
|/
|
|
| |
Fix GH #4873. Allow swapping same class middleware.
|
| |
|
|
|
|
| |
fixes #1953
|
|
|
|
| |
This is currently broken due to a bug in journey.
|