aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/test
Commit message (Collapse)AuthorAgeFilesLines
* Revert "Merge pull request #8017 from jcoglan/objectless_sessions"Jon Leighton2012-11-091-21/+0
| | | | | | | | | | | | This reverts commit 36376560fdd02f955ae3bf6b7792b784443660ad, reversing changes made to 3148ed9a4bb7efef30b846dc945d73ceebcc3f0f. Conflicts: actionpack/lib/action_dispatch/middleware/flash.rb Reason: it broke Sam's CI https://github.com/rails/rails/pull/8017#issuecomment-10210655
* Merge pull request #8017 from jcoglan/objectless_sessionsJon Leighton2012-11-081-0/+21
|\ | | | | Store FlashHashes in the session as plain hashes
| * Store FlashHashes in the session as plain hashes rather than custom objects ↵James Coglan2012-11-031-0/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | with unstable class names and instance variables. Refactor FlashHash to take values for its ivars in the constructor, to pretty up FlashHash.from_session_value. Remove stale comment on FlashHash: it is no longer Marshaled in the session so we can change its implementation. Remove blank lines I introduced in controller/test_case.rb. Unit tests for FlashHash#to_session_value. Put in a compatibility layer to accept FlashHash serializations from Rails 3.0+. Test that Rails 3.2 session flashes are correctly converted to the new format. Remove code path for processing Rails 3.0 FlashHashes since they can no longer deserialize.
* | Merge pull request #8115 from senny/7842_handle_trailing_slash_with_enginesRafael Mendonça França2012-11-081-0/+5
|\ \ | | | | | | handle trailing slash with engines (test case for #7842)
| * | test case to lock down the behavior of #7842Yves Senn2012-11-041-0/+5
| |/
* | Test that permitted? is sticky on accessors, mutators, and mergesBenjamin Quorning2012-11-061-0/+24
| |
* | Test that not permitted is sticky on #exceptBenjamin Quorning2012-11-061-0/+1
| |
* | Current tests are testing stickiness of non-permitted parametersBenjamin Quorning2012-11-061-3/+3
| |
* | Fix buggy testsBenjamin Quorning2012-11-061-4/+4
| |
* | Add ensure block to make sure the state is properly restoredCarlos Antonio da Silva2012-11-041-1/+1
|/
* Support :multiple option on input tags with :indexDaniel Fox, Grant Hutchins & Trace Wax2012-11-021-0/+13
| | | | | When you have an explicit index set, then when you build an input tag with :multiple => true, it doesn't add [] to the end of its name, although it should.
* Add test to avoid regression of 1bfc5b4Rafael Mendonça França2012-11-021-0/+8
|
* Revert "Merge pull request #7668 from Draiken/fix_issue_6497"Rafael Mendonça França2012-11-021-7/+0
| | | | | | | | | | | | | | This reverts commit f4ad0ebe7a6b17658bddfeb996e3c34835b75623, reversing changes made to 8b2cbb3a832101f0e672ee309beca0f8c555b292. Conflicts: actionpack/CHANGELOG.md REASON: This added introduced a bug when you have a shorthand route inside a nested namespace. See https://github.com/rafaelfranca/rails/commit/281367eb770faf8077c1fd6194188e92ed1637a1
* Fix #8086 (BestStandardsSupport rewrites app X-UA-Compatible header, now ↵Nikita Afanasenko2012-11-011-0/+34
| | | | | | | appends). Now `BestStandardsSupport` middleware appends it's `X-UA-Compatible` value to app's value. Also test for `BestStandardsSupport` middleware added.
* Add test to ensure data attributes are properly escaped with tag helpersCarlos Antonio da Silva2012-11-011-2/+7
| | | | Closes #8091
* No need for the debuggerDavid Heinemeier Hansson2012-10-311-1/+0
|
* Allow #permit to take its list of permitted parameters as an arrayDavid Heinemeier Hansson2012-10-311-0/+5
|
* Revert "if format is unknown NullMimeTypeObject is returned"Guillermo Iguaran2012-10-311-11/+1
| | | | This reverts commit a8560fa361958b33d76e4468eb5c07d82a20196e.
* if format is unknown NullMimeTypeObject is returnedAngelo capilleri2012-10-311-1/+11
| | | | | | | | | | If a unknown format is passed in a request, the methods html?, xml?, json? ...etc Nil Exception. This patch add a class NullMimeTypeObject, that is returned when request.format is unknown and it responds false to the methods that ends with '?'. It refers to #7837, not fixes because it's not considered a improvement not a bug.
* Fix failing tests and use new hash style in deprecation messagesCarlos Antonio da Silva2012-10-292-12/+12
|
* Improve the deprecation message of link_to_function andRafael Mendonça França2012-10-271-6/+6
| | | | | | button_to_function Point the the Unobtrusive JavaScript secion in the JavaScript guide
* cleanup, remove trailing whitespace within actionpackYves Senn2012-10-279-15/+15
|
* give access to the original exception raised in case of a parse errorAaron Patterson2012-10-251-0/+14
|
* do not lose backtrace information from the raised exceptionAaron Patterson2012-10-251-4/+5
|
* check_box value can be not only an object of Array classVasiliy Ermolovich2012-10-201-0/+6
| | | | there is a chance that `value` is a Set or an object that reponses to `include?` method so let's handle this case
* Add i18n scope to disance_of_time_in_words.Steve Klabnik2012-10-191-10/+19
| | | | This fixes #733.
* add test for fetch with a blockAaron Patterson2012-10-181-0/+4
|
* prefer composition over inheritenceAaron Patterson2012-10-181-0/+16
|
* Merge pull request #7975 from butcher/extend_date_select_helper_functionalityRafael Mendonça França2012-10-181-0/+16
|\ | | | | | | | | | | | | Extend date_select helper functionality. Conflicts: actionpack/CHANGELOG.md
| * Extend date_select helper functionality.Pavel Nikitin2012-10-181-0/+16
| |
* | Permit string and float values in the multiparameter attributesRafael Mendonça França2012-10-181-9/+14
| |
* | use the tmp filesystem rather than our own thing.Aaron Patterson2012-10-171-5/+9
|/
* Ignore asset url query string or anchor when appending extensions and ↵Joshua Peek2012-10-151-1/+18
| | | | computing public path
* Extract compute_asset_extname and allow extname to be disabledJoshua Peek2012-10-151-6/+15
|
* Merge branch 'master' into asset-path-helperJoshua Peek2012-10-151-5/+1
|\ | | | | | | | | Conflicts: railties/test/application/configuration_test.rb
| * Minor cleanup, helper method was only used onceAyrton De Craene2012-10-151-5/+1
| |
* | :fire: Rails asset id supportJoshua Peek2012-10-151-80/+1
| |
* | Allow asset url config to be undefinedJoshua Peek2012-10-131-0/+41
| |
* | Add a few more compute_asset_path testsJoshua Peek2012-10-131-0/+8
| |
* | JAVASCRIPTS_DIR, STYLESHEETS_DIR, ASSETS_DIR don't even exist anymoreJoshua Peek2012-10-121-28/+0
| |
* | Ensure AssetUrlHelper can be mixed into AC::BaseJoshua Peek2012-10-121-0/+33
| |
* | Refactor AssetUrlHelper to make it friendly for plugins and extensionsJoshua Peek2012-10-121-1/+35
| | | | | | | | | | | | | | | | Add asset_path/url helper for a consolidated entry point Expose compute_asset_path as a public API Expose compute_asset_host as a public API Move RAILS_ASSET_ID to its own module, AssetIdHelper Removed AV::AssetPaths
* | Add asset_path and asset_url helpersJoshua Peek2012-10-121-0/+18
|/
* Cleanup trailing whitespacesdfens2012-10-121-1/+1
|
* When executing permit with just a key that points to a hash, DO NOT allow ↵Santiago Pastorino2012-10-121-1/+5
| | | | | | | | | | | | | | all the hash params.require(:person).permit(:projects_attributes) was returning => {"projects_attributes"=>{"0"=>{"name"=>"Project 1"}}} When should return => {} You should be doing ... params.require(:person).permit(projects_attributes: :name) to get just the projects attributes you want to allow
* Allow for deep directory path for view templates.Andy Shipman2012-10-113-0/+7
|
* recognizes when a partial was rendered twice. Closes #3675Yves Senn2012-10-112-0/+10
|
* Remove old asset tag concatenationJoshua Peek2012-10-101-752/+0
| | | | Use sprockets, jammit, or some other asset bundler
* Rename "Fixtures" class to "FixtureSet"Alexey Muranov2012-10-071-1/+1
| | | | Rename `ActiveRecord::Fixtures` class to `ActiveRecord::FixtureSet`. Instances of this class normally hold a collection of fixtures (records) loaded either from a single YAML file, or from a file and a folder with the same name. This change make the class name singular and makes the class easier to distinguish from the modules like `ActiveRecord::TestFixtures`, which operates on multiple fixture sets, or `DelegatingFixtures`, `::Fixtures`, etc., and from the class `ActiveRecord::Fixture`, which corresponds to a single fixture.
* Ruby 2 compat. CGI.escapeHTML has changed the way it escapes apostrophes a ↵Jeremy Kemper2012-10-061-1/+1
| | | | few times, so fix up the test to work with however it chooses to escape.