Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | More cleanup of ActionView and reduction in need for blocks in some cases: | Yehuda Katz | 2009-08-15 | 5 | -13/+3 | |
| | | | | | | | | * only one of partial_name or :as will be available as a local * `object` is removed * Simplify _layout_for in most cases. * Remove <% render :partial do |args| %> * <% render :partial do %> still works fine | |||||
* | Clean up ActionView some: | Yehuda Katz | 2009-08-15 | 1 | -11/+23 | |
| | | | | | | | | | | * Call _evaluate_assigns_and_ivars at the two entry points so we don't have to do a check at every render. * Make template.render viable without having to go through a wrapper method * Remove old TemplateHandler#render(template, local_assigns) path so we don't have to set self.template every time we render a template. * Move Template rescuing code to Template#render so it gets caught every time. * Pull in some tests from Pratik that test render @object in ActionView | |||||
* | Attempt to rewrite most of the highly coupled router segments tests | Joshua Peek | 2009-08-14 | 1 | -741/+221 | |
| | ||||||
* | Kill routing timed tests | Joshua Peek | 2009-08-14 | 1 | -50/+3 | |
| | ||||||
* | Use safe tmp dir | Joshua Peek | 2009-08-13 | 2 | -0/+2 | |
| | ||||||
* | Merge branch 'master' of git://github.com/rails/rails | José Valim | 2009-08-13 | 3 | -4/+3 | |
|\ | ||||||
| * | More perf work: | Yehuda Katz | 2009-08-11 | 1 | -1/+0 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Move #set_cookie and #delete_cookie inline to optimize. These optimizations should almost certainly be sent back upstream to Rack. The optimization involves using an ivar for cookies instead of indexing into the headers each time. * Was able to use a bare Hash for headers now that cookies have their own joining semantics (some code assumed that the raw cookies were an Array). * Cache blankness of body on body= * Improve expand_cache_key for Arrays of a single element (common in our case) * Use a simple layout condition check unless conditions are used * Cache visible actions * Lazily load the UrlRewriter * Make etag an ivar that is set on prepare! | |||||
| * | Tentatively accept the ":as or :object, but not both" solution | Yehuda Katz | 2009-08-11 | 1 | -1/+1 | |
| | | ||||||
| * | Add some more caching to the lookup | Yehuda Katz | 2009-08-11 | 1 | -2/+2 | |
| | | ||||||
* | | Ensure collections are not treated as nested resources. | José Valim | 2009-08-13 | 2 | -11/+28 | |
|/ | ||||||
* | Introduce grouped_collection_select helper. | codeape | 2009-08-09 | 1 | -0/+34 | |
| | | | | | | [#1249 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | |||||
* | Deprecate router generation "best match" sorting | Joshua Peek | 2009-08-09 | 3 | -7/+9 | |
| | ||||||
* | Make sure link_to generates the form with the specified :href if any [#2254 ↵ | Max Lapshin | 2009-08-10 | 1 | -0/+8 | |
| | | | | | | state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | |||||
* | Fixed to_label_tag to accept id attribute without changing for attribute ↵ | Matt Duncan | 2009-08-09 | 1 | -0/+16 | |
| | | | | | | [#2660 status:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Added both the documentation and a test case for the collection path name ↵ | Hugo Peixoto | 2009-08-09 | 1 | -0/+44 | |
| | | | | | | | | customization feature. [#1218 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | |||||
* | Fix that RedCloth shouldn't be required to run tests | Jeremy Kemper | 2009-08-09 | 1 | -12/+18 | |
| | ||||||
* | Allow to configure trusted proxies via ↵ | Felipe Talavera | 2009-08-09 | 1 | -0/+28 | |
| | | | | | | ActionController::Base.trusted_proxies [#2126 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | |||||
* | Support passing Redcloth options via textilize helper [#2973 state:resolved] | rizwanreza | 2009-08-09 | 1 | -0/+17 | |
| | | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | |||||
* | Make http digest work with different server/browser combinations | José Valim | 2009-08-09 | 1 | -6/+29 | |
| | | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | |||||
* | Use response_body rather than performed? | Yehuda Katz | 2009-08-09 | 1 | -1/+1 | |
| | ||||||
* | Rendering a template from ActionView will default to looking for partials ↵ | Yehuda Katz | 2009-08-09 | 1 | -0/+1 | |
| | | | | | | | | | only in the current mime type. * The old behavior was tested only as a side-effect of a different test--the original tests remain; a new template in the XML mime was added. * If you are relying on the current behavior and object to this change, please participate in http://groups.google.com/group/rubyonrails-core/browse_thread/thread/6ef25f3c108389bd | |||||
* | Clean up partial object some more; replace passing around a block to a ↵ | Yehuda Katz | 2009-08-09 | 1 | -1/+0 | |
| | | | | single block ivar | |||||
* | Merge branch 'patches' | Michael Koziarski | 2009-08-09 | 1 | -0/+29 | |
|\ | ||||||
| * | Don't call additional methods on builders passed to the atom_feed helper. | Michael Koziarski | 2009-08-09 | 1 | -0/+29 | |
| | | | | | | | | | | | | Additionally, actually test that the atom_feed helper works with :xml as an option. [#1836 state:committed] | |||||
* | | Add :redirect to the testable RJS statements [#2612 state:resolved] | Jon Wood | 2009-08-09 | 1 | -0/+7 | |
| | | | | | | | | | | | | | | Example : assert_select_rjs :redirect, root_path Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | |||||
* | | Fix HTTP basic authentication for long credentials [#2572 state:resolved] | Jan Schwenzien | 2009-08-09 | 1 | -0/+25 | |
|/ | | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | |||||
* | Allow content_tag options to take an array [#1741 state:resolved] ↵ | rizwanreza | 2009-08-08 | 1 | -0/+13 | |
| | | | | | | | | | | [rizwanreza, Nick Quaranto] Example: content_tag('p', "limelight", :class => ["song", "play"]) # => <p class="song play">limelight</p> Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | |||||
* | Add test ensuring redirect_to uses the given protocol [#2886] | Dan Croak | 2009-08-08 | 1 | -0/+10 | |
| | | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | |||||
* | Allow radio buttons to work with booleans. | José Valim | 2009-08-08 | 1 | -0/+10 | |
| | | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | |||||
* | Add :include_blank option for select_tag [#1987 status:resolved] | rizwanreza | 2009-08-08 | 1 | -0/+12 | |
| | | | | | Signed-off-by: José Valim <jose.valim@gmail.com> Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | |||||
* | Polymorphic routes generates collection URL from model class [#1089 ↵ | Niklas Holmgren | 2009-08-08 | 1 | -0/+31 | |
| | | | | | | | state:resolved] Signed-off-by: Dan Pickett <dpickett@enlightsolutions.com> Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | |||||
* | Merge commit 'jose/responder' | Yehuda Katz | 2009-08-08 | 1 | -5/+5 | |
|\ | ||||||
| * | Renamed ActionController::Renderer to ActionController::Responder and ↵ | José Valim | 2009-08-08 | 1 | -5/+5 | |
| | | | | | | | | ActionController::MimeResponds::Responder to ActionController::MimeResponds::Collector. | |||||
* | | Fixes "Cached fragment hit" written to log even if fragment is not cached ↵ | Yehuda Katz | 2009-08-08 | 1 | -0/+15 | |
|/ | | | | (Erik Andrejko) [#2917 state:resolved] | |||||
* | Fix number_to_precision rounding error [#2071 state:resolved] | wmoxam | 2009-08-08 | 1 | -0/+1 | |
| | | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | |||||
* | Ruby 1.9 compat: fix route recognition encoding test | Jeremy Kemper | 2009-08-07 | 1 | -1/+1 | |
| | ||||||
* | Rename find_by_parts and find_by_parts? to find and exists? | Yehuda Katz | 2009-08-07 | 2 | -3/+3 | |
| | ||||||
* | Renamed presenter to renderer, added some documentation and defined its API. | José Valim | 2009-08-07 | 4 | -10/+24 | |
| | ||||||
* | Encapsulate respond_with behavior in a presenter. | José Valim | 2009-08-07 | 1 | -22/+18 | |
| | ||||||
* | Add destroyed? to ActiveRecord, include tests for polymorphic urls for ↵ | José Valim | 2009-08-07 | 5 | -76/+78 | |
| | | | | destroyed objects and refactor mime responds tests and documentation. | |||||
* | Add nagivational behavior to respond_with. | José Valim | 2009-08-07 | 6 | -17/+91 | |
| | ||||||
* | Merge branch 'master' of git://github.com/rails/rails into old | José Valim | 2009-08-07 | 10 | -78/+32 | |
|\ | ||||||
| * | Replace _render_template_with_layout with _render_template since the layout ↵ | Yehuda Katz | 2009-08-07 | 2 | -2/+4 | |
| | | | | | | | | is optional | |||||
| * | Clean up render @object a bit more. | Yehuda Katz | 2009-08-07 | 1 | -57/+0 | |
| | | ||||||
| * | Move AbstractController to a top-level component | Yehuda Katz | 2009-08-06 | 2 | -2/+1 | |
| | | ||||||
| * | Replace _action_view with view_context to reflect that it is public and that ↵ | Yehuda Katz | 2009-08-06 | 1 | -1/+1 | |
| | | | | | | | | it does not need to be an ActionView instance | |||||
| * | Make sure javascript_include_tag/stylesheet_link_tag does not append ".js" ↵ | Matthew Rudy Jacobs | 2009-08-05 | 1 | -2/+6 | |
| | | | | | | | | | | | | or ".css" onto external urls [#1664 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | |||||
| * | Remove legacy processing and content_length | Yehuda Katz | 2009-08-02 | 3 | -9/+2 | |
| | | | | | | | | | | | | | | | | | | | | | | * convert_content_type! is handled by assign_default_content_type_and_charset! * set_content_length! should be handled by the endpoint server. Otherwise each middleware that modifies the body has to do the expensive work of recalculating content_length. * convert_language! appears to be legacy. There are no tests for this * convert_cookies! should be handled by the new HeaderHash in Rack * Use an integer for .status's internal representation to avoid needing to do String manipulation just to find out the status | |||||
| * | Update cache_control to be a Hash of options that is used to build the header. | Yehuda Katz | 2009-08-02 | 3 | -4/+4 | |
| | | | | | | | | * Significantly simplifies setting and modifying cache control in other areas | |||||
| * | Ruby 1.9: fix encoding for test_file_stream | Jeremy Kemper | 2009-08-01 | 1 | -1/+2 | |
| | |