aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/test
Commit message (Collapse)AuthorAgeFilesLines
* Improve error messages in cookies_testeileencodes2015-06-271-3/+3
| | | | | | | | | | | | | | | Using `assert_predicate` and `assert_match` instead of just `assert` is preferrable because better error messages are output. In the case of `assert response.cookies.empty?` the error message was `Failed assertion, no message given.` but now with `assert_predicate` it will be `Expected {"user_name"=>"david"} to be empty?.` For `assert_match(/user_name=david/, response.headers["Set-Cookie"])` as well, the message returned was unhelpful - `Failed assertion, no message given.` but now will tell what was expected and what was returned with `Expected /user_name=david/ to match "user_name=nope; path=/".`
* Merge pull request #20276 from davetron5000/revert-head-on-no-templateKasper Timm Hansen2015-06-271-0/+21
|\ | | | | Allow default_render to take a block to customize behavior when there's no template
| * Override default_render's behavior with a blockDave Copeland2015-06-201-0/+21
| | | | | | | | | | | | | | | | | | | | In 0de4a23 the behavior when there is a missing template was changed to not raise an error, but instead head :no_content. This is a breaking change and some gems rely on this happening. To allow gems and other code to work around this, allow `default_render` to take a block which, if provided, will execute the contents of that block instead of doing the `head :no_content`.
* | Merge pull request #19431 from hmarr/head-routingRafael Mendonça França2015-06-221-3/+2
|\ \ | |/ |/| Respect routing precedence for HEAD requests
| * Respect routing precedence for HEAD requestsHarry Marr2015-03-201-3/+2
| | | | | | | | | | | | | | Fixes the issue described in #18764 - prevents Rack middleware from swallowing up HEAD requests that should have been matched by a higher-precedence `get` route, but still allows Rack middleware to respond to HEAD requests.
* | Revert "Merge pull request #20584 from arthurnn/fix_url"Arthur Neves2015-06-171-7/+0
| | | | | | | | | | | | | | | | This reverts commit 0b3397872582f2cf1bc6960960a6393f477c55e6, reversing changes made to 56d52e3749180e6c1dcf7166adbad967470aa78b. As pointed out on the PR, this will hide development mistakes too, which is not ideal.
* | Catch InvalidURIError on bad paths on redirect.Arthur Neves2015-06-161-0/+7
| | | | | | | | | | Handle URI::InvalidURIError errors on the redirect route method, so it wont raise a 500 if a bad path is given.
* | remove `header=` on the response object.Aaron Patterson2015-06-151-0/+2
| | | | | | | | | | | | People should be free to mutate the header object, but not to set a new header object. That header object may be specific to the webserver, and we need to hide it's internals.
* | Deprecate passing hash as first parameter into ActionController::HeadMehmet Emin İNAÇ2015-06-153-10/+31
| |
* | Fix flakyness.Kasper Timm Hansen2015-06-151-0/+1
| | | | | | | | Brought on by my own stupidity :)
* | ActionDispatch::SSL should keep original header's behaviorFumiaki MATSUSHIMA2015-06-141-0/+11
| | | | | | | | | | | | `ActionDispatch::SSL` changes headers to `Hash`. So some headers will be broken if there are some middlewares on ActionDispatch::SSL and if it uses `Rack::Utils::HeaderHash`.
* | Return 204 if render is not called in API controllersJorge Bejar2015-06-111-0/+15
| |
* | Add test coverage for implicit render in empty actionsJorge Bejar2015-06-111-0/+14
| |
* | Include ParamsWrapper in AC::APIJorge Bejar2015-06-111-0/+26
| | | | | | | | | | | | | | | | | | ParamsWrapper was initially removed from API controllers according to the following discusision: https://github.com/rails-api/rails-api/issues/33 However, we're including it again so Rails API devs can decide whether to enable or disable it.
* | Rename test methods in api conditional get controller testsJorge Bejar2015-06-111-2/+2
| |
* | Routes resources avoid :new and :edit endpoints if api_only is enabledJorge Bejar2015-06-111-0/+75
| |
* | Remove extra whitespacesSantiago Pastorino2015-06-111-1/+1
| |
* | Use new hash syntaxSantiago Pastorino2015-06-112-7/+7
| |
* | Remove Unneeded ApiPublicExceptions middleware, PublicExceptions already ↵Santiago Pastorino2015-06-111-37/+0
| | | | | | | | does the work
* | Use nex hash syntax on testsSantiago Pastorino2015-06-111-5/+5
| |
* | Add ApiPublicException middlewareSantiago Pastorino2015-06-111-2/+39
| |
* | Move Model test class inside RenderersApiController namespaceSantiago Pastorino2015-06-111-8/+8
| |
* | Add ActionController API functionalitySantiago Pastorino2015-06-117-0/+184
| |
* | Change the `index` arg of `ActionDispatch::Static#new` to a kwargYuki Nishijima2015-06-111-1/+1
| |
* | extract required_defaults from the conditions hash before constructing the routeAaron Patterson2015-06-083-48/+48
| | | | | | | | | | this way we can remove the strange "respond_to?" conditional in the `matches?` loop
* | Merge pull request #19094 from phoet/have_bearer_be_valid_as_wellRafael Mendonça França2015-06-011-1/+8
|\ \ | | | | | | Have Bearer be valid as well
| * | allow `Bearer` as well as `Token`phoet2015-06-011-0/+7
| | |
| * | actually test what the name saysphoet2015-06-011-1/+1
| | |
* | | Merge pull request #20138 from tgxworld/deprecated_assert_templateRafael Mendonça França2015-06-0111-492/+101
|\ \ \ | | | | | | | | Deprecate `assert_template` and `assigns()`.
| * | | Remove `assigns` and `assert_template`.Guo Xiang Tan2015-05-3011-492/+101
| |/ /
* | | Merge pull request #20284 from kaspth/fix-caching-testRafael Mendonça França2015-06-013-3/+9
|\ \ \ | |/ / |/| | Move expectation to instance level.
| * | Replace expectation with state check.Kasper Timm Hansen2015-05-303-3/+9
| | | | | | | | | | | | The tests would still pass if the cache call in the rendered templates were removed.
* | | Fix warning about ambiguous first argumentArun Agrawal2015-05-291-1/+1
| | |
* | | Merge pull request #20017 from eliotsykes/configurable-static-index-filenameRafael Mendonça França2015-05-285-0/+18
|\ \ \ | | | | | | | | | | | | config.static_index configures directory Index "index.html" filename
| * | | config.static_index configures directory index "index.html" filenameEliot Sykes2015-05-285-0/+18
| | | | | | | | | | | | | | | | | | | | | | | | Set `config.static_index` to serve a static directory index file not named `index`. For example, to serve `main.html` instead of `index.html` for directory requests, set `config.static_index` to `"main"`.
* | | | Deprecate `:nothing` option for render methodMehmet Emin İNAÇ2015-05-288-13/+23
|/ / / | | | | | | | | | `head` method works similar to `render` method with `:nothing` option
* | | Merge pull request #19808 from byroot/action-parameterRafael Mendonça França2015-05-271-0/+20
|\ \ \ | | | | | | | | [PoC] Stop shadowing parameters named `action`
| * | | Allow to parameters named `action` or `controller` from AC::TestCase helpersJean Boussier2015-04-181-0/+20
| | | |
* | | | Add assertion for get? method into test casesMehmet Emin İNAÇ2015-05-271-0/+1
| | | |
* | | | Merge pull request #17788 from sivagollapalli/masterArthur Nogueira Neves2015-05-201-0/+5
|\ \ \ \ | | | | | | | | | | Issue#17703 Test case for tempfile attribute
| * | | | Issue#17703 Test case for tempfile attributeSiva Gollapalli2015-04-161-0/+5
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | + To avoid regression I am adding this test case on action pack Changed to assert from assert_equal + Added msg to assertion Modified msg
* | | | Prefer assert_not over refuteRafael Mendonça França2015-05-182-2/+2
| | | |
* | | | ActionDispatch::Journey::Routes#empty? test casesValentine Valyaeff2015-05-192-0/+16
| |/ / |/| |
* | | Silence ambiguous first argument warningPrem Sichanugrist2015-05-041-1/+1
| | | | | | | | | | | | | | | | | | | | | This silences: actionpack/test/journey/route_test.rb:33: warning: ambiguous first argument; put parentheses or a space even after `/' operator
* | | Give authentication methods the ability to customize response message.Keenan Brock2015-05-032-6/+6
| | | | | | | | | | | | Digest allowed the messages. Add the same feature to basic and token
* | | Merge pull request #18392 from brainopia/fix_route_requirementsArthur Nogueira Neves2015-04-271-0/+8
|\ \ \ | | | | | | | | Correct route requirements by overriding defaultls
| * | | Correct route requirements by overriding defaultls (fixes #18373)brainopia2015-01-081-0/+8
| | | |
* | | | Merge pull request #19904 from zzak/rm_route_wrapper_internal_hacksRafael Mendonça França2015-04-261-0/+16
|\ \ \ \ | | | | | | | | | | Rm route wrapper internal hacks
| * | | | Fix rake routes for api appsJorge Bejar2015-04-251-0/+16
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* | | | | Removed unused code from request_forgery_protection testsPrathamesh Sonpatki2015-04-261-17/+0
|/ / / /
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-04 18:57:33 +0000