| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|\
| |
| | |
Refactor debug view
|
| |
| |
| | |
Avoid logic in ERB and use helpers
|
|/
|
|
| |
`_generate_paths_by_default` should always be private.
|
|\
| |
| | |
Fix OR in Journey patterns
|
| | |
|
|\ \
| | |
| | | |
Pure rack apps can be mounted with a name
|
| |/
| |
| |
| | |
See https://github.com/rails/rails/commit/9b15828b5c347395b42066a588c88e5eb4e72279#commitcomment-8764492
|
|/ |
|
|\
| |
| |
| | |
Allow authentication header to not have to specify 'token=' key.
|
| |
| |
| |
| | |
Fixes: https://github.com/rails/rails/issues/17108.
|
|\ \
| | |
| | | |
Do not rescue Exception in ActionDispatch::ParamsParser
|
| | |
| | |
| | |
| | |
| | | |
Unlike ShowExceptions or PublicExceptions, ParamsParser shouldn't
transform exceptions like Interrupt and NoMemoryError into ParserError.
|
|\ \ \ |
|
|/ / /
| | |
| | |
| | | |
url_for
|
|\ \ \ |
|
| |/ /
| | |
| | |
| | |
| | |
| | | |
Fixes https://github.com/rails/rails/issues/16958
[Byron Bischoff & Melanie Gilman]
|
|\ \ \
| | | |
| | | | |
Show source view and backtrace on missing template errors
|
| |/ /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This will help you debug missing template errors, especially if they
come from a programmatic template selection. Thanks to @dhh for
suggesting that.
As a bonus, also show request and response info on the routing error
page for consistency.
|
| | |
| | |
| | |
| | | |
Reference #17453
|
|/ /
| |
| |
| |
| | |
These are currently working "by accident" because `match_route` does not check
that the name is valid.
|
| |
| |
| |
| |
| |
| | |
Reference #17453
[Godfrey Chan, Washington Luiz]
|
| |
| |
| |
| | |
Fixes https://github.com/rails/rails/issues/17714.
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This reverts commit f93df52845766216f0fe36a4586f8abad505cac4, reversing
changes made to a455e3f4e9dbfb9630d47878e1239bc424fb7d13.
Conflicts:
actionpack/lib/action_controller/test_case.rb
actionview/lib/action_view/test_case.rb
|
|\ \
| | |
| | | |
Fix for assigns(:..) resetting template assertions
|
| | |
| | |
| | |
| | | |
When calling assigns(:...) or cookies(:...), template assertions would be reset, which they obviously shouldn't be.
|
| | |
| | |
| | |
| | |
| | | |
It returns multiple source extracts since 1ed264bc. Also cleaned its
result structure, as we no longer need the file in a code extract.
|
| | |
| | |
| | |
| | |
| | |
| | | |
Those three can be nil when exception backtrace is nil. This happens and
that forced a couple of nil guards in the code. I'm proposing to make
those always return an array, even on nil backtrace.
|
|\ \ \
| |/ /
|/| | |
Add basic tests for ActionDispatch::ExceptionWrapper
|
| | | |
|
| | |
| | |
| | |
| | | |
Closes #17586
|
| | |
| | |
| | |
| | |
| | |
| | | |
We added a deprecation warning for these cases in aa1fadd, so these are now
causing deprecation warnings in the test output. AFAICT, in these two cases, the
option is not integral to the purpose of the test, so they can be safely removed
|
|/ /
| |
| |
| |
| |
| | |
Follow up to 212057b9. Since that commit, we need to pass the `route_name`
explicitly. This is one of the left-over cases that was not handled in that
commit, which was causing `use_route` to be ignored in functional tests.
|
| |
| |
| |
| | |
Fixes: https://github.com/rails/rails/issues/16814
|
|\ \
| | |
| | | |
Remove redundant `to_s` in interpolation
|
| | | |
|
|\ \ \
| |/ /
|/| |
| | |
| | | |
* master-sec:
FileHandler should not be called for files outside the root
|
| |/
| |
| |
| |
| | |
FileHandler#matches? should return false for files that are outside the
"root" path.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
In cases where this option is set to `true`, the option is redundant and can
be safely removed; otherwise, the corresponding `*_url` helper should be
used instead.
Fixes #17294.
See also #17363.
[Dan Olson, Godfrey Chan]
|
|\ \
| | |
| | | |
Show the user’s application in the source window and select the correct ...
|
| | |
| | |
| | |
| | | |
trace list, closes #17312
|
|/ /
| |
| |
| |
| |
| | |
See comment in this patch for the rationale.
References #16468
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The scanner in Journey fails to recognize routes that use literals
from the sub-delims section of RFC 3986.
This commit enhance the compatibility of Journey with the RFC by
adding support of authorized delimiters to the scanner.
Fix #17212
|
|/
|
|
| |
[related #17233]
|
|
|
|
|
|
|
|
| |
Request#check_method would use to_sentence(locale: :en), which breaks when
I18n.available_locales does not include :en and
I18n.enforce_available_locales is true (default).
Inlined to_sentence functionality to solve this.
|
|
|
|
| |
This is to match the changes in Rails Dom Testing rails/rails-dom-testing#20.
|
|
|
|
|
|
| |
Hash#keys.each allocates an array of keys; Hash#each_key iterates through the
keys without allocating a new array. This is the reason why Hash#each_key
exists.
|
|
|
|
|
|
|
|
| |
This reverts commit 9d05d6de52871e57bfbf54a60de005e8a5f5b0e4, reversing
changes made to 0863c9248fd47a15e88e05ce4fcd80966684c0e3.
The change in the behaviour reported at #16958 doesn't exist since 4.0
and 4.1 works in the same way
|