| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| |
| |
| |
| | |
for their status, by default, not the message from the underlying exception
|
| |
| |
| |
| | |
https://github.com/rails/etagger/pull/3
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Add failing test for template with number at the end
Use \w for RENDER_DEPENDENCY regex
Spacing
Add CHANGELOG entry
|
| | |
|
|\ \
| | |
| | | |
failure to parse params should trigger a 400 Bad Request
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This reverts commit b4239622afc4f3f73808fd0c97512f3a534e07dd, reversing
changes made to f99ce3c188f5dde57e2ff63e6a22363c62f0a4cd.
Reason: This broke the build
https://travis-ci.org/rails/rails/jobs/6629894
|
|\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Fix ActionView::Digestor to correctly pass format to LookupContext
Conflicts:
actionpack/CHANGELOG.md
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
ActionView::Digestor now passes arguments correctly to
LookupContext::find method. This makes cache digests
respect the format option correctly.
FixtureFinder in tests also changed to reflect this.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This commit adds support for passing additional url options along
with a :status option and any of the flash-related options to
`redirect_to` (i.e. :flash, :alert & :notice).
Closes #7570.
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The `force_ssl` command now builds the redirect url from `request.fullpath`.
This ensures that the format is maintained and it doesn't redirect to a route
that has the same parameters but is defined earlier in `routes.rb`. Also any
optional segments are maintained.
Fixes #7528.
Fixes #9061.
Fixes #10305.
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | |
| | | |
+use_full_path+ option was removed in 3b3790a4 and passing the template
handler to render was deprecated in 43d27e91.
|
| | |
| | |
| | |
| | |
| | | |
Add support for extracting the port from the :host option and for
removing the subdomain by using nil, false or ''.
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | | |
leading .)
Adding a boolean route constraint checks for presence/absence of request property
|
| | | |
|
| | |
| | |
| | |
| | | |
as the last element of the array
|
|\ \ \
| | | |
| | | | |
Exceptions raised when using ActionController::Live cause server crash
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Any exceptions that occured at the view or controller level for a
controller using ActionController::Live would cause the server to either
hang with an open socket indefinitely, or immediately crash (depending
on whether the server was launched with rails s or directly). Changed
the behavior of exceptions to act the same as streaming templates for
html requests, and allow for an on_error callback if needed.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
If a file field tag is passed the multiple option, it is turned into an
array field (appending "[]"), but if the file field is passed an
explicit name as an option, leave the name alone (do not append "[]").
Fixes #9830
|
| | | | |
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
Add block support for the mail_to helper
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | | |
Introduced in 2c22376fe04b89e8f34620139720b85a85ce3428
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
trevorturk/remove-fixme-comments-about-legacy-key-generator
Remove comments about removing LegacyKeyGenerator in 4.1
|
| | | | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
routing bugfixes when matching multiple paths
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Closes #9913.
We need to expand the match shorthand syntax for every path.
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
This problem was introduced with:
https://github.com/rails/rails/commit/d03aa104e069be4e301efa8cefb90a2a785a7bff
|
| |_|/ / / /
|/| | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Closes #10071
`#normalize_path!` depends on the options so we need to call
`#normalize_options!` first to make sure everything is set correctly.
|
| |/ / / /
|/| | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
We don't actually need a rails.png in the AP fixtures, the tests
that use it don't actually try to load the file.
We also don't need to get rid of it with the dummy reset either.
Finally, it's not needed in the sample application that's included
with the Rails Guides.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Rename DummyKeyGenerator -> LegacyKeyGenerator
|
| | | | | | |
|
|/ / / / / |
|
| | | | | |
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Cookie-base session store auto-upgrade
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Automatically configure cookie-based sessions to use the best cookie jar given the app's config
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Revert grep to select since they are not the same
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Added a regression test that will fail if anyone tries to change
time_zone_select to use grep again thinking it will work when it does
not.
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
A previous commit swapped out a call to select for a call to grep in
time_zone_options_for_select. This behavior actually causes the
regexp priority option to stop working.
ActiveSupport::TimeZone overrides the =~ operator which is what the
select block was using previously. Enumerable#grep
checks pattern === element and in this case that would be /US/ ===
ActiveSupport::TimeZone which does not work because
ActiveSupport::TimeZone does not supply an implicit converting to_str
method, only an explicit to_s method.
It would be impossible to provide a to_str method that behaves
identically to the =~ method provided on ActiveSupport::TimeZone
so the only option is to revert back to using select with =~.
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
fix request methods test
|
| | | | | | | | |
|
|/ / / / / / / |
|
| |/ / / / /
|/| | | | | |
|
|/ / / / / |
|
|\ \ \ \ \
| |/ / / /
|/| | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
lucisferre/improve-layout-override-fallback-behavior
Provides standard layout lookup behavior for method and proc cases
Conflicts:
actionpack/CHANGELOG.md
|