Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | object/try should be required after abstract_unit to have AS in the load path | Santiago Pastorino | 2010-08-14 | 1 | -1/+1 | |
| | ||||||
* | Deletes trailing whitespaces (over text files only find * -type f -exec sed ↵ | Santiago Pastorino | 2010-08-14 | 52 | -246/+246 | |
| | | | | 's/[ \t]*$//' -i {} \;) | |||||
* | It's snowing! | Jeremy Kemper | 2010-08-12 | 2 | -2/+2 | |
| | ||||||
* | Replace snowman with utf8=✓ | wycats | 2010-08-11 | 2 | -2/+2 | |
| | ||||||
* | layout_for works again with objects as specified in the documentation and ↵ | José Valim & Carlos Antonio da Silva | 2010-08-11 | 3 | -0/+7 | |
| | | | | Rails 2.3 [#5357 state:resolved] | |||||
* | rename _snowman to _e | wycats | 2010-08-09 | 2 | -2/+2 | |
| | ||||||
* | adds missing requires for Object#try | Xavier Noria | 2010-08-09 | 1 | -0/+1 | |
| | ||||||
* | adds URL to the body generated by the redirect macro in the routes mapper as ↵ | Xavier Noria | 2010-08-09 | 1 | -30/+25 | |
| | | | | per the RFC, extracts common test pattern into a test macro, adds a test to cover the :status option | |||||
* | Reload action_methods in AbstractController after defining new method. | Piotr Sarnacki | 2010-08-04 | 1 | -0/+14 | |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Use AS::OrderedHash when trusting in the order of the hash | Santiago Pastorino | 2010-08-01 | 1 | -2/+3 | |
| | ||||||
* | Fix label form helper to use I18n and html options, without the need of ↵ | Carlos Antonio da Silva | 2010-08-01 | 1 | -2/+9 | |
| | | | | | | | | | | | 'nil' text param: Before: f.label :title, nil, :class => 'title' After : f.label :title, :class => 'title' [#5267 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | |||||
* | Makes form_helper use overriden model accessors | Santiago Pastorino | 2010-08-01 | 1 | -0/+17 | |
| | | | | [#3374 state:committed] | |||||
* | link_to_function now expects a piece of javascript code for the onclick ↵ | Rodrigo Dominguez | 2010-07-29 | 1 | -4/+5 | |
| | | | | | | | | parameter [#5179] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | |||||
* | Removed deprecated APIs in text and number helpers [#5156 state:resolved] | Łukasz Strzałkowski | 2010-07-26 | 1 | -27/+0 | |
| | | | | | | They're deprecated since 2008. It's time to get rid of them. Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Add assertion to link_to_function test with block and capture, and more ↵ | Carlos Antonio da Silva | 2010-07-25 | 1 | -5/+4 | |
| | | | | | | expressive test name [#5179 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Change returning with tap | Santiago Pastorino | 2010-07-25 | 1 | -1/+1 | |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Fixed output_buffer encoding problem [#5179] | Sebastian A. Espindola | 2010-07-25 | 1 | -0/+9 | |
| | | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | These tests are trusting in the order of the elements so use OrderedHash ↵ | Santiago Pastorino | 2010-07-21 | 1 | -13/+9 | |
| | | | | instead of Hash | |||||
* | Fixed a globbed route issue where slashes were being escaped, causing ↵ | Brian Rose | 2010-07-21 | 1 | -0/+7 | |
| | | | | | | assert_routing to fail. [#5135 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | remote_function patch with more detailed test | Andrew Kaspick | 2010-07-21 | 1 | -0/+6 | |
| | | | | Signed-off-by: wycats <wycats@gmail.com> | |||||
* | Ensure insert_before in middleware stack raises a meaningful error message ↵ | José Valim | 2010-07-21 | 1 | -0/+10 | |
| | | | | [#3679 state:resolved] | |||||
* | Moved a few methods from RecordIdentifier to ActiveModel::Naming | Piotr Sarnacki | 2010-07-21 | 1 | -40/+0 | |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Extract ParameterFilter class from FilterParameters mixin | Bryan Helmkamp | 2010-07-19 | 1 | -4/+4 | |
| | | | | Signed-off-by: wycats <wycats@gmail.com> | |||||
* | Remove assert_valid. It was already deprecated on Rails 2.3. | José Valim | 2010-07-19 | 1 | -15/+0 | |
| | ||||||
* | Exceptions from views should be rescued based on the original exception. If ↵ | Neeraj Singh | 2010-07-19 | 1 | -0/+27 | |
| | | | | | | | | a handler for original exception is missing then apply ActiveView::TemplateError [#2034 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Set session options id to nil is respected and cancels lazy loading. | José Valim | 2010-07-18 | 1 | -1/+19 | |
| | ||||||
* | select :include_blank or :prompt should return escaped string [#5099 ↵ | Ivan Torres | 2010-07-18 | 1 | -0/+23 | |
| | | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | remove size attribute from tag generated by file_field helper [#5084 ↵ | Miles Egan | 2010-07-13 | 1 | -0/+5 | |
| | | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Routes should respect namespace even if action is a regexp and just ↵ | José Valim | 2010-07-12 | 1 | -3/+15 | |
| | | | | controller is given to to. | |||||
* | Fix setting helpers_path to a string or pathname | Jeremy Kemper | 2010-07-07 | 2 | -4/+4 | |
| | ||||||
* | When a dynamic :controller segment is present in the path add a Regexp ↵ | Andrew White | 2010-07-07 | 1 | -11/+25 | |
| | | | | | | | | | | | constraint that allow matching on multiple path segments. Using a namespace block isn't compatible with dynamic routes so we raise an ArgumentError if we detect a :module present in the scope. [#5052 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Refactor handling of :only and :except options. The rules are: | Andrew White | 2010-07-06 | 1 | -47/+190 | |
| | | | | | | | | | | | 1. Don't inherit when specified as an option on a resource 2. Don't push into scope when specified as an option on a resource 2. Resources pull in :only or :except options from scope 3. Either :only or :except in nested scope overwrites parent scope [#5048 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Recognize should also work with route is wrapped in a constraint. | José Valim | 2010-07-06 | 1 | -1/+4 | |
| | ||||||
* | Adds tests for content negotiation change introduced in dc5300adb6d46252c26e | Patrik Stenmark | 2010-07-04 | 1 | -0/+20 | |
| | | | | Signed-off-by: wycats <wycats@gmail.com> | |||||
* | Fix syntax of routing tests so they actually run | Andrew White | 2010-07-04 | 1 | -12/+18 | |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Refactor resource options and scoping. Resource classes are now only ↵ | Andrew White | 2010-07-04 | 1 | -2/+81 | |
| | | | | | | responsible for controlling how they are named. All other options passed to resources are pushed out to the scope. Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Refactor recall parameter normalization [#5021 state:resolved] | Andrew White | 2010-07-03 | 1 | -2/+27 | |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Fix routes with :controller segment when namespaced [#5034 state:resolved] | José Valim | 2010-07-02 | 2 | -12/+29 | |
| | ||||||
* | Unify routes naming by renaming router to routes | Piotr Sarnacki | 2010-07-02 | 3 | -13/+13 | |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | porting session.clear fix to master branch. [#5030 state:resolved] | Aaron Patterson | 2010-07-01 | 1 | -0/+22 | |
| | | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | |||||
* | A couple enhancements to the router: | José Valim | 2010-06-30 | 1 | -0/+27 | |
| | | | | | | | | * Allow to use the get :symbol shortcut outside resources scopes as well; * Fix a bug where :action was not being picked from given options; * Giving :as option inside a resource now changes just the relative name instead of the full name; | |||||
* | We are trying to test that & escapes here not that & is being escaped, ↵ | Santiago Pastorino | 2010-06-29 | 1 | -3/+2 | |
| | | | | | | also added a cosmetic change to test_link_tag_with_query_and_no_name Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | |||||
* | s/escape_once/html_escape/, since html safety is the contract that now says ↵ | Xavier Noria | 2010-06-30 | 2 | -4/+4 | |
| | | | | whether something has to be escaped | |||||
* | url_for no longer escapes HTML, the :escape option is also gone | Xavier Noria | 2010-06-30 | 1 | -16/+4 | |
| | | | | Rationale: url_for is just a path/URL generator, it is the responsability of the caller to escape conveniently HTML needs it, JavaScript needs different escaping, a text mail needs no escaping at all, etc. | |||||
* | Rename _snowman_ to _snowman to be in sync with _method and _csrf_token. | José Valim | 2010-06-29 | 2 | -2/+2 | |
| | ||||||
* | Restores the escaping of urls generated from hashes. [#4765 state:resolved] | Andrew White | 2010-06-28 | 1 | -8/+4 | |
| | | | | | | | | | | | | | | HTML specifications recommend the escaping of urls in web pages, which url_for does by default for string urls and consquently urls generated by path helpers as these return strings. Hashes passed to url_for are not escaped by default and this commit reverses this default so that they are escaped. Undoes the changes of this commit: http://github.com/rails/rails/commit/1b3195b63ca44f0a70b61b75fcf4991cb2fbb944 Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Merge :constraints from scope into resource options [#2694 state:resolved] | Andrew White | 2010-06-28 | 1 | -0/+43 | |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Remove invalid conditions from route [#4989 state:resolved] | Andrew White | 2010-06-28 | 1 | -0/+12 | |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Deprecate the old router DSL. Since it is still used intensively across ↵ | José Valim | 2010-06-28 | 2 | -15/+23 | |
| | | | | ActionPack test suite, patches that translates Rails internal tests to the new router DSL are welcome (note though that a few tests shouldn't be translated since they are testing exactly the old mapper API, like the ones in actionpack/test/controller/resource_test.rb and actionpack/test/controller/routing_test.rb) | |||||
* | Strip_tags never ending attribute should not raise a TypeError [#4870 ↵ | Bruno Michel | 2010-06-28 | 1 | -0/+4 | |
| | | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> |