aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/test
Commit message (Collapse)AuthorAgeFilesLines
* Fix filter :only and :except with implicit actionsAndrew White2011-03-231-11/+16
| | | | | | | The method_name argument is "default_render" for implicit actions so use the action_name attribute to determine which callbacks to run. [#5673 state:resolved]
* Add a failing test case for an implicit action with a before filter.Manfred Stienstra2011-03-233-0/+24
| | | | Signed-off-by: Andrew White <andyw@pixeltrix.co.uk>
* Do not show optional (.:format) block for wildcard route [#6605 state:resolved]Prem Sichanugrist2011-03-221-0/+7
| | | | This will make the output of `rake routes` to be correctly match to the behavior of the application, as the regular expression used to match the path is greedy and won't capture the format part by default
* SJIS is an alias to Windows-31J in ruby trunk. Use SHIFT_JIS for this testAaron Patterson2011-03-211-2/+2
|
* [action_view] added custom patterns to template resolverChris Kowalik2011-03-204-0/+34
|
* fixes an issue with number_to_human when converting values which are less ↵Josh Kalderimis2011-03-161-1/+3
| | | | | | than 1 but greater than -1 [#6576 state:resolved] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* do not automatically add format to routes that end in a slashAaron Patterson2011-03-111-0/+51
|
* Filter sensitive query string parameters in the log [#6244 state:committed]Prem Sichanugrist & Xavier Noria2011-03-111-0/+38
| | | | | | This provides more safety to applications that put secret information in the query string, such as API keys or SSO tokens. Signed-off-by: Xavier Noria <fxn@hashref.com>
* Filter params that return nil for to_param and allow through false valuesAndrew White2011-03-091-0/+8
|
* Improve testing of cookies in functional tests:Andrew White2011-03-062-2/+67
| | | | | | | | | - cookies can be set using string or symbol keys - cookies are preserved across calls to get, post, etc. - cookie names and values are escaped - cookies can be cleared using @request.cookies.clear [#6272 state:resolved]
* Raise ArgumentError if route name is invalid [#6517 state:resolved]Andrew White2011-03-061-0/+32
|
* added failing test for fields_for with a record object that inherits from HashDiego Carrion2011-03-061-0/+19
| | | | Signed-off-by: Andrew White <andyw@pixeltrix.co.uk>
* Action Pack typos.R.T. Lechow2011-03-052-2/+2
|
* Add an option to FormBuilder to omit hidden field with idAlexander Uvarov2011-03-041-0/+135
| | | | | | [#4551 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* make sure string keys are always looked up from the class cacheAaron Patterson2011-03-021-0/+25
|
* Ruby 1.8: Y U NO FUN?Aaron Patterson2011-03-021-1/+3
|
* Fix Action caching bug where an action that has a non-cacheable response ↵Cheah Chu Yeow2011-03-021-0/+5
| | | | | | | | | | always renders a nil response body. It now correctly renders the response body. Note that only GET and HTTP 200 responses can be cached. [#6480 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* refactor Reference to a ClassCache object, fix lazy lookup in Middleware so ↵Aaron Patterson2011-03-011-0/+50
| | | | that anonymous classes are supported
* use a subclass of AS::TZ for testing html outputAaron Patterson2011-02-281-4/+11
|
* updated Time, Date and DateTime current methods in AS to use Time.zone and ↵Josh Kalderimis2011-02-281-2/+2
| | | | | | not Time.zone_default. [#6410 state:committed]
* javascript_include_tag shouldn't raise if you register an expansion key with ↵Santiago Pastorino2011-02-281-2/+10
| | | | nil value
* Add tests for register expansion methods with key = []Santiago Pastorino2011-02-281-2/+12
|
* Add test to prevent regression on namespace root nested in a resourceAndrew White2011-02-141-0/+9
| | | | [#6389 state:resolved]
* Fix named route helper for routes nested inside deeply nested resourcesAndrew White2011-02-141-1/+9
| | | | [#6416 state:resolved]
* Fix assert_recognizes with block constraints [#5805 state:resolved]Andrew White2011-02-131-0/+103
|
* Allow for the format of time_tag in AP to be changed via an option argument.Josh Kalderimis2011-02-121-5/+11
| | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* Added time_tag helper to AP for HTML5 time tag [#5919 state:resolved]Sjoerd Andringa2011-02-121-1/+21
| | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* Applied changes to stylesheet_link_tag from javascript_include_tag which ↵Josh Kalderimis2011-02-131-0/+23
| | | | corrects issues with ordering and duplicates.
* This corrects two issues with javascript_include_tag, the order at which ↵Josh Kalderimis2011-02-131-1/+24
| | | | | | | | they are expanded, and removing duplicates. When individual js assets are specified, they will override the order of the same asset specified in an expansion. [#5938 state:resolved]
* Remove duplicated action pack tests added to fix issue with fields_for, ↵Carlos Antonio da Silva2011-02-121-42/+0
| | | | | | nested attributes and erb Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* Add block support to button_tag helperTom Stuart2011-02-121-0/+9
| | | | | | | | | | | | | | | | | | | As per the HTML 4.01 spec: Buttons created with the BUTTON element function just like buttons created with the INPUT element, but they offer richer rendering possibilities: the BUTTON element may have content. For example, a BUTTON element that contains an image functions like and may resemble an INPUT element whose type is set to "image", but the BUTTON element type allows content. Since rich content is the main purpose of the <button> element, it makes sense for the button_tag helper to accept a block. http://www.w3.org/TR/html401/interact/forms.html#edef-BUTTON http://dev.w3.org/html5/spec/the-button-element.html#the-button-element Signed-off-by: Santiago Pastorino and Emilio Tagua <santiago+emilioe@wyeworks.com>
* Make type="submit" the default for button_tag helperTom Stuart2011-02-121-1/+8
| | | | | | | | | | | | "submit" is the default value of the <button> element's type attribute according to the HTML 4.01 and the HTML5 draft specs, so if button_tag is going to have a default, type="submit" is a more sensible choice than type="button". http://www.w3.org/TR/html401/interact/forms.html#adef-type-BUTTON http://dev.w3.org/html5/spec/the-button-element.html#attr-button-type Signed-off-by: Santiago Pastorino and Emilio Tagua <santiago+emilioe@wyeworks.com>
* Removed Array#safe_join in AS core_ext and moved it to a view helper with ↵Josh Kalderimis2011-02-102-21/+30
| | | | | | the same same. This also changes how safe_join works, if items or the separator are not html_safe they are html_escape'd, a html_safe string is always returned. Signed-off-by: José Valim <jose.valim@gmail.com>
* Revert "Removed Array#safe_join in AS core_ext and moved it to a view helper ↵José Valim2011-02-102-55/+21
| | | | | | | | with the same same." Applied the wrong version. This reverts commit 98c0c5db50a7679b3d58769ac22cb0a27a62c930.
* Removed Array#safe_join in AS core_ext and moved it to a view helper with ↵Josh Kalderimis2011-02-102-21/+55
| | | | the same same.
* Change the CSRF whitelisting to only apply to get requestsMichael Koziarski2011-02-081-136/+75
| | | | | | | | Unfortunately the previous method of browser detection and XHR whitelisting is unable to prevent requests issued from some Flash animations and Java applets. To ease the work required to include the CSRF token in ajax requests rails now supports providing the token in a custom http header: X-CSRF-Token: ... This fixes CVE-2011-0447
* Use Mime::Type references.José Valim2011-02-083-1/+17
|
* Ensure render is case sensitive even on systems with case-insensitive ↵José Valim2011-02-081-0/+10
| | | | | | filesystems. This fixes CVE-2011-0449
* Be sure to javascript_escape the email address to prevent apostrophes ↵Michael Koziarski2011-02-081-4/+5
| | | | | | inadvertently causing javascript errors. This fixes CVE-2011-0446
* Add tests showing the LH issue #6381: fields_for with inline blocks and ↵Carlos Antonio da Silva2011-02-081-1/+85
| | | | | | nested attributes already persisted Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* cleaning up some warnings on 1.9.3Aaron Patterson2011-02-078-27/+25
|
* put authenticity_token option in parity w/ remoteDan Pickett2011-02-061-2/+2
| | | | | | [#6228 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* Allow page_cache_directory to be set as a PathnameAndre Arko2011-02-061-0/+11
| | | | | | For example, page_cache_directory = Rails.root.join("public/cache") Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* Added tests for form_for and an authenticity_token option. Added docs for ↵Timothy N. Tsvetkov2011-02-051-0/+18
| | | | | | | | for_for and authenticity_token option. Added section to form helpers guide about forms for external resources and new authenticity_token option for form_tag and form_for helpers. [#6228 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* fixed bug with nested resources within shallow scopegerman2011-02-041-0/+62
| | | | | | [#6372 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* removing generation of id in submit helperFranco Brusatti2011-02-031-6/+6
| | | | | | [#6369 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* Add a test for 'render :layout'Anton Astashov2011-02-032-0/+9
| | | | | | | | | To make sure it will show block contents if it is placed after 'render :partial' [#5557 state:resolved] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* Protocol-relative URL support.Stephen Celis2011-02-021-1/+14
| | | | | | [#5774 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* add test to check class is being escaped in form_classSantiago Pastorino2011-02-011-0/+4
|
* Allow customization of form class for button_toAndrei Bocan2011-02-011-0/+4
| | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>