aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/test
Commit message (Collapse)AuthorAgeFilesLines
* Got tests to pass with some more changes.Yehuda Katz2009-08-1514-91/+79
| | | | | | | | | | | | | | | | * request.formats is much simpler now * For XHRs or Accept headers with a single item, we use the Accept header * For other requests, we use params[:format] or fallback to HTML * This is primarily to work around the fact that browsers provide completely broken Accept headers, so we have to whitelist the few cases we can specifically isolate and treat other requests as coming from the browser * For APIs, we can support single-item Accept headers, which disambiguates from the browsers * Requests to an action that only has an XML template from the browser will no longer find the template. This worked previously because most browsers provide a catch-all */*, but this was mostly accidental behavior. If you want to serve XML, either use the :xml format in links, or explicitly specify the XML template: render "template.xml".
* More cleanup of ActionView and reduction in need for blocks in some cases:Yehuda Katz2009-08-155-13/+3
| | | | | | | | * only one of partial_name or :as will be available as a local * `object` is removed * Simplify _layout_for in most cases. * Remove <% render :partial do |args| %> * <% render :partial do %> still works fine
* Clean up ActionView some:Yehuda Katz2009-08-151-11/+23
| | | | | | | | | | * Call _evaluate_assigns_and_ivars at the two entry points so we don't have to do a check at every render. * Make template.render viable without having to go through a wrapper method * Remove old TemplateHandler#render(template, local_assigns) path so we don't have to set self.template every time we render a template. * Move Template rescuing code to Template#render so it gets caught every time. * Pull in some tests from Pratik that test render @object in ActionView
* Attempt to rewrite most of the highly coupled router segments testsJoshua Peek2009-08-141-741/+221
|
* Kill routing timed testsJoshua Peek2009-08-141-50/+3
|
* Use safe tmp dirJoshua Peek2009-08-132-0/+2
|
* Merge branch 'master' of git://github.com/rails/railsJosé Valim2009-08-133-4/+3
|\
| * More perf work:Yehuda Katz2009-08-111-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | * Move #set_cookie and #delete_cookie inline to optimize. These optimizations should almost certainly be sent back upstream to Rack. The optimization involves using an ivar for cookies instead of indexing into the headers each time. * Was able to use a bare Hash for headers now that cookies have their own joining semantics (some code assumed that the raw cookies were an Array). * Cache blankness of body on body= * Improve expand_cache_key for Arrays of a single element (common in our case) * Use a simple layout condition check unless conditions are used * Cache visible actions * Lazily load the UrlRewriter * Make etag an ivar that is set on prepare!
| * Tentatively accept the ":as or :object, but not both" solutionYehuda Katz2009-08-111-1/+1
| |
| * Add some more caching to the lookupYehuda Katz2009-08-111-2/+2
| |
* | Ensure collections are not treated as nested resources.José Valim2009-08-132-11/+28
|/
* Introduce grouped_collection_select helper.codeape2009-08-091-0/+34
| | | | | | [#1249 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* Deprecate router generation "best match" sortingJoshua Peek2009-08-093-7/+9
|
* Make sure link_to generates the form with the specified :href if any [#2254 ↵Max Lapshin2009-08-101-0/+8
| | | | | | state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* Fixed to_label_tag to accept id attribute without changing for attribute ↵Matt Duncan2009-08-091-0/+16
| | | | | | [#2660 status:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* Added both the documentation and a test case for the collection path name ↵Hugo Peixoto2009-08-091-0/+44
| | | | | | | | customization feature. [#1218 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* Fix that RedCloth shouldn't be required to run testsJeremy Kemper2009-08-091-12/+18
|
* Allow to configure trusted proxies via ↵Felipe Talavera2009-08-091-0/+28
| | | | | | ActionController::Base.trusted_proxies [#2126 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* Support passing Redcloth options via textilize helper [#2973 state:resolved]rizwanreza2009-08-091-0/+17
| | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* Make http digest work with different server/browser combinationsJosé Valim2009-08-091-6/+29
| | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* Use response_body rather than performed?Yehuda Katz2009-08-091-1/+1
|
* Rendering a template from ActionView will default to looking for partials ↵Yehuda Katz2009-08-091-0/+1
| | | | | | | | | only in the current mime type. * The old behavior was tested only as a side-effect of a different test--the original tests remain; a new template in the XML mime was added. * If you are relying on the current behavior and object to this change, please participate in http://groups.google.com/group/rubyonrails-core/browse_thread/thread/6ef25f3c108389bd
* Clean up partial object some more; replace passing around a block to a ↵Yehuda Katz2009-08-091-1/+0
| | | | single block ivar
* Merge branch 'patches'Michael Koziarski2009-08-091-0/+29
|\
| * Don't call additional methods on builders passed to the atom_feed helper.Michael Koziarski2009-08-091-0/+29
| | | | | | | | | | | | Additionally, actually test that the atom_feed helper works with :xml as an option. [#1836 state:committed]
* | Add :redirect to the testable RJS statements [#2612 state:resolved]Jon Wood2009-08-091-0/+7
| | | | | | | | | | | | | | Example : assert_select_rjs :redirect, root_path Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* | Fix HTTP basic authentication for long credentials [#2572 state:resolved]Jan Schwenzien2009-08-091-0/+25
|/ | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* Allow content_tag options to take an array [#1741 state:resolved] ↵rizwanreza2009-08-081-0/+13
| | | | | | | | | | [rizwanreza, Nick Quaranto] Example: content_tag('p', "limelight", :class => ["song", "play"]) # => <p class="song play">limelight</p> Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* Add test ensuring redirect_to uses the given protocol [#2886]Dan Croak2009-08-081-0/+10
| | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* Allow radio buttons to work with booleans.José Valim2009-08-081-0/+10
| | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* Add :include_blank option for select_tag [#1987 status:resolved]rizwanreza2009-08-081-0/+12
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* Polymorphic routes generates collection URL from model class [#1089 ↵Niklas Holmgren2009-08-081-0/+31
| | | | | | | state:resolved] Signed-off-by: Dan Pickett <dpickett@enlightsolutions.com> Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* Merge commit 'jose/responder'Yehuda Katz2009-08-081-5/+5
|\
| * Renamed ActionController::Renderer to ActionController::Responder and ↵José Valim2009-08-081-5/+5
| | | | | | | | ActionController::MimeResponds::Responder to ActionController::MimeResponds::Collector.
* | Fixes "Cached fragment hit" written to log even if fragment is not cached ↵Yehuda Katz2009-08-081-0/+15
|/ | | | (Erik Andrejko) [#2917 state:resolved]
* Fix number_to_precision rounding error [#2071 state:resolved]wmoxam2009-08-081-0/+1
| | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* Ruby 1.9 compat: fix route recognition encoding testJeremy Kemper2009-08-071-1/+1
|
* Rename find_by_parts and find_by_parts? to find and exists?Yehuda Katz2009-08-072-3/+3
|
* Renamed presenter to renderer, added some documentation and defined its API.José Valim2009-08-074-10/+24
|
* Encapsulate respond_with behavior in a presenter.José Valim2009-08-071-22/+18
|
* Add destroyed? to ActiveRecord, include tests for polymorphic urls for ↵José Valim2009-08-075-76/+78
| | | | destroyed objects and refactor mime responds tests and documentation.
* Add nagivational behavior to respond_with.José Valim2009-08-076-17/+91
|
* Merge branch 'master' of git://github.com/rails/rails into oldJosé Valim2009-08-0710-78/+32
|\
| * Replace _render_template_with_layout with _render_template since the layout ↵Yehuda Katz2009-08-072-2/+4
| | | | | | | | is optional
| * Clean up render @object a bit more.Yehuda Katz2009-08-071-57/+0
| |
| * Move AbstractController to a top-level componentYehuda Katz2009-08-062-2/+1
| |
| * Replace _action_view with view_context to reflect that it is public and that ↵Yehuda Katz2009-08-061-1/+1
| | | | | | | | it does not need to be an ActionView instance
| * Make sure javascript_include_tag/stylesheet_link_tag does not append ".js" ↵Matthew Rudy Jacobs2009-08-051-2/+6
| | | | | | | | | | | | or ".css" onto external urls [#1664 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
| * Remove legacy processing and content_lengthYehuda Katz2009-08-023-9/+2
| | | | | | | | | | | | | | | | | | | | | | * convert_content_type! is handled by assign_default_content_type_and_charset! * set_content_length! should be handled by the endpoint server. Otherwise each middleware that modifies the body has to do the expensive work of recalculating content_length. * convert_language! appears to be legacy. There are no tests for this * convert_cookies! should be handled by the new HeaderHash in Rack * Use an integer for .status's internal representation to avoid needing to do String manipulation just to find out the status
| * Update cache_control to be a Hash of options that is used to build the header.Yehuda Katz2009-08-023-4/+4
| | | | | | | | * Significantly simplifies setting and modifying cache control in other areas
generated by cgit v1.2.3 (git 2.25.1) at 2025-01-04 02:07:56 +0000