aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/test
Commit message (Collapse)AuthorAgeFilesLines
* add test_scoped_root_as_nameSam Ruby2013-09-241-0/+13
| | | | test for regression introduced by https://github.com/rails/rails/pull/9155
* Fix incorrect assert_redirected_to failure messageDerek Prior2013-09-191-0/+18
| | | | | | | | | | | | | | | In some instances, `assert_redirected_to` assertion was returning an incorrect and misleading failure message when the assertion failed. This was due to a disconnect in how the assertion computes the redirect string for the failure message and how `redirect_to` computes the string that is actually used for redirection. I made the `_compute_redirect_to_loaction` method used by `redirect_to` public and call that from the method `assert_redirect_to` uses to calculate the URL. The reveals a new test failure due to the regex used by `_compute_redirect_to_location` allow `_` in the URL scheme.
* NullSessionHash#destroy should be a no-opJonathan Baudanza2013-09-181-0/+10
| | | | Previously it was raising a NilException
* Fix an issue where router can't recognize downcased url encoding path.kennyj2013-09-191-0/+4
|
* Custom flash should be defined only for the class that defines it and it's ↵Ricardo de Cillo2013-09-131-0/+12
| | | | subclasses.
* Merge pull request #12159 from nashby/issue-12149Rafael Mendonça França2013-09-121-0/+9
|\ | | | | do not break params filtering on nil values
| * do not break params filtering on nil valuesVasiliy Ermolovich2013-09-071-0/+9
| | | | | | | | closes #12149
* | Removed semicolon and added spaceAnupam Choudhury2013-09-131-2/+2
| |
* | Reset ActionView::Base.logger instead of AC::Base.loggerAkira Matsuda2013-09-101-1/+1
| | | | | | | | see: 9b0ac0bc74569db460f87ea6888b3847be0ff5be
* | Make AC standalone rendering workSantiago Pastorino2013-09-101-0/+15
| |
* | Remove helper fixtures not used in any testclaudiob2013-09-091-2/+0
|/ | | | | | The fixture for module AbcHelper defines three functions bare_a, bare_b and bare_c, but only bare_a is used in the code that tests helper functions.
* Revert "Port all remaining self.protected_instance_variables to class methods"Łukasz Strzałkowski2013-09-021-1/+1
| | | | This reverts commit 7de994fa215e9f4c2856d85034bc4dd7b65d0c01.
* Merge pull request #11912 from jonkessler/respond-to-signature-fixesRafael Mendonça França2013-08-311-0/+5
|\ | | | | Update Rails::Railtie::Configuration and ActionDispatch::Response#respond_to? to accept include_private argument
| * update Rails::Railtie::Configuration and ↵Jon Kessler2013-08-161-0/+5
| | | | | | | | ActionDispatch::Response#respond_to? to accept include_private argument
* | Port all remaining self.protected_instance_variables to class methodsŁukasz Strzałkowski2013-08-291-1/+1
| |
* | Move abstract's controller tests to AVŁukasz Strzałkowski2013-08-2515-891/+0
| | | | | | | | The ones that were actually testing AV functionality and should belong in there
* | Extend basic rendering, test it in railtiesŁukasz Strzałkowski2013-08-251-19/+0
| |
* | Basic rendering testŁukasz Strzałkowski2013-08-251-0/+19
| |
* | Move AP's capture tests to AVŁukasz Strzałkowski2013-08-251-79/+0
| |
* | Move remaining layouts tests to AVŁukasz Strzałkowski2013-08-2510-270/+0
| |
* | Remove unused fixtures and models from AP testsŁukasz Strzałkowski2013-08-257-12/+0
| |
* | Move render_test to AVŁukasz Strzałkowski2013-08-251-1298/+106
| |
* | Load AV::Layout to AM::Base in railtiesŁukasz Strzałkowski2013-08-251-0/+3
| |
* | Remove RenderERBUtils from AP (only AV use it)Łukasz Strzałkowski2013-08-251-22/+0
| |
* | Remove AV::TestCase from APŁukasz Strzałkowski2013-08-251-8/+0
| |
* | Load AV::Layouts dynamicly via railtiesŁukasz Strzałkowski2013-08-251-0/+2
| |
* | Create AbstractController::Rendering interfaceŁukasz Strzałkowski2013-08-257-2/+9
| | | | | | | | This interface should be use when implementing renderers.
* | Fix AP test suite after moving stuff to AVŁukasz Strzałkowski2013-08-255-6/+7
| |
* | Move view_paths from AP to AVŁukasz Strzałkowski2013-08-253-176/+0
| |
* | Display exceptions in text format for xhr requestKir Shatrov2013-08-221-0/+41
| |
* | Merge pull request #11443 from wangjohn/sse_reloader_classSantiago Pastorino2013-08-191-0/+88
|\ \ | | | | | | SSE class for ActionController::Live
| * | Creating an SSE class to be used with ActionController::Live.wangjohn2013-07-301-0/+88
| | |
* | | Fail informatively in #respond_with when no appropriate #api_behavior ↵Ben Woosley2013-08-171-0/+31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | renderer is available. Currently if a user calls #respond_with(csvable), but has not csv renderer available, Responder will just run through the default render behavior twice, raising ActionView::MissingTemplate both times. This changes ActionController::Metal::Responder#api_behavior to check in advance whether there is a renderer available, and raise ActionController::MissingRenderer if not.
* | | Split the 1200+ line mime_responds_test into 3 more focused and manageable ↵Ben Woosley2013-08-173-587/+587
| | | | | | | | | | | | test files.
* | | Merge branch 'master' of github.com:rails/docrailsVijay Dev2013-08-173-6/+1
|\ \ \ | |_|/ |/| | | | | | | | | | | | | | | | | Conflicts: actionview/README.rdoc activerecord/lib/active_record/migration.rb guides/source/development_dependencies_install.md guides/source/getting_started.md
| * | Revert "Merge branch 'master' of github.com:rails/docrails"Vijay Dev2013-08-173-6/+1
| |/ | | | | | | | | | | | | This reverts commit 70d6e16fbad75b89dd1798ed697e7732b8606fa3, reversing changes made to ea4db3bc078fb3093ecdddffdf4f2f4ff3e1e8f9. Seems to be a code merge done by mistake.
* | Execute conditional procs on controller filters only for current action.Nicholas Jakobsen2013-08-101-0/+9
| | | | | | | | | | | | :only and :except options for controller filters are now added before :if and :unless. This prevents running :if and :unless procs when not on the specified. Closes #11786.
* | Add timeout to test_async_streamGaurish Sharma2013-08-021-1/+1
|/ | | | | | | | | | Without timeout: this test executed infinitely on JRuby Passes on MRI With Timeout: this test gracefully fails on JRuby Passes on MRI, tested on v2.0 & v1.9.3
* Reset ActionView::Base.logger instead of AC::Base.loggerAkira Matsuda2013-07-261-1/+1
| | | | see: 9b0ac0bc74569db460f87ea6888b3847be0ff5be
* Fix order dependent testsAkira Matsuda2013-07-261-0/+4
| | | | Reset ActionView::Base.logger after tests
* Fix order dependent AP testAkira Matsuda2013-07-261-0/+1
| | | | | | | | | | | | | | | | | | | | | | any_instance.stubs + unstub with Mocha doesn't restore the original status in the following case, so we need to undef Customer#to_json before every test require 'test/unit' require 'mocha/setup' module M def foo() :foo; end end class C include M undef_method :foo end C.any_instance.stubs(:foo).returns(:mocha) C.any_instance.unstub(:foo)
* Allow overriding of all headers from passed environment hashAndrew White2013-07-251-0/+30
| | | | | | | Allow REMOTE_ADDR, HTTP_HOST and HTTP_USER_AGENT to be overridden from the environment passed into `ActionDispatch::TestRequest.new`. Fixes #11590
* Fix failing test missed for the past year :(Andrew White2013-07-171-1/+1
| | | | | | | | | When optimized path helpers were re-introduced in d7014bc the test added in a328f2f broke but no-one noticed because it wasn't being run by the test suite. Fix the test by checking for nil values or empty strings after the args have been parameterized.
* Skip Rack applications and redirects when generating urlsAndrew White2013-07-163-12/+69
| | | | | | | | | | When generating an unnamed url (i.e. using `url_for` with an options hash) we should skip anything other than standard Rails routes otherwise it will match the first mounted application or redirect and generate a url with query parameters rather than raising an error if the options hash doesn't match any defined routes. Fixes #8018
* Removed unused file! Moved to actionviewArun Agrawal2013-07-131-91/+0
| | | | Removed unused file as this has been moved to actionview
* add test-case to verify `error.path` when a helper was not found.Yves Senn2013-07-121-0/+5
| | | | | This verifies the code added with: https://github.com/rails/rails/commit/99c9d18601539c7e7e87f26bb047add1f93072af
* move `MissingHelperError` out of the `ClassMethods` module.Yves Senn2013-07-121-1/+1
|
* Remove accidentally committed vi .swp file.Marc Schütz2013-07-101-0/+0
|
* Show real LoadError on helpers requirePiotr Niełacny2013-07-103-0/+25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | When helper try to require missing file rails will throw exception about missing helper. # app/helpers/my_helper.rb require 'missing' module MyHelper end And when we try do load helper class ApplicationController helper :my end Rails will throw exception. This is wrong because there is a helper file. Missing helper file helpers/my_helper.rb Now when helper try to require non-existed file rails will throw proper exception. No such file to load -- missing
* Use Request#raw_post instead Request#bodyPaul Nikitochkin2013-07-081-0/+7
| | | | | | | | In order to get raw_post to be not empty after ParamsParser#parse_formatted_parameters, added rewinding of body stream input on parsing json params. Closes #11345