aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/test
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | Add with_default_charset helper.Zuhao Wan2014-05-281-12/+20
|/ / /
* | | Deprecate all *_filter callbacks in favor of *_action callbacksRafael Mendonça França2014-05-273-194/+196
| | | | | | | | | | | | | | | This is the continuation of the work started at 9d62e04838f01f5589fa50b0baa480d60c815e2c
* | | PARAMETERS_KEY is only used in the request, so move the constant thereAaron Patterson2014-05-271-5/+5
| | |
* | | Merge branch 'constraints'Aaron Patterson2014-05-271-2/+6
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * constraints: rm reset_parameters because we automatically do it from 9ca4839a move path_parameter encoding check to the request object dispatcher doesn't need `call` anymore call `serve` with the request on dispatchers constraints class does not need the request class anymore give all endpoints a superclass skip the build business if the stack is empty stop hardcoding path_parameters and get it from the request we do not need to cache rack_app a redirect is not a dispatcher by definition, so eliminate test push is_a check up to where the Constraints object is allocated pass the request object to the application pass a request to `matches?` so we can avoid creating excess requests nothing is passed to `rack_app` anymore, so rm the params one fewer is_a check Constraints#app should never return another Constraints object, so switch to if statement eliminate dispatcher is_a checks push is_a?(Dispatcher) check in to one place Always construct route objects with Constraint objects Conflicts: actionpack/lib/action_controller/metal.rb
| * | | rm reset_parameters because we automatically do it from 9ca4839aAaron Patterson2014-05-271-3/+0
| | | |
| * | | pass the request object to the applicationAaron Patterson2014-05-251-2/+5
| | | |
| * | | push is_a?(Dispatcher) check in to one placeAaron Patterson2014-05-241-0/+1
| | | |
| * | | Always construct route objects with Constraint objectsAaron Patterson2014-05-241-0/+3
| | | |
* | | | Skip individual tests upon Dalli::RingErrorMatthew Draper2014-05-271-0/+18
| |_|/ |/| | | | | | | | | | | | | | | | | Unlike the outer `rescue`, this one is much more precise about what we want to handle: a connection failure (`Dalli::RingError`) is not relevant to what we're testing here. But other Dalli errors may well be indicating an actual problem.
* | | The correct status to test should be :switching_protocols.Zuhao Wan2014-05-251-2/+2
|/ /
* | Merge pull request #14986 from dlangevin/trailing-slash-url-generationRafael Mendonça França2014-05-241-0/+18
|\ \ | | | | | | | | | | | | | | | | | | Fixes URL generation with trailing_slash: true Conflicts: actionpack/lib/action_dispatch/http/url.rb
| * | Fixes URL generation with trailing_slash: trueDan Langevin2014-05-221-0/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | URL generation with trailing_slash: true was adding a trailing slash after .:format Routes.draw do resources :bars end bars_url(trailing_slash: true, format: 'json') # => /bars.json/ This commit removes that extra trailing slash
* | | glob_param is never used, so rmAaron Patterson2014-05-231-1/+5
| | | | | | | | | | | | | | | | | | this also changes the constructor. We don't need to pass more options than "defaults" (whatever defaults are, ugh. probably another hash of stupid stuff).
* | | decouple the router object from the request classAaron Patterson2014-05-231-14/+6
| | |
* | | pass the correct custom request to the recognize methodAaron Patterson2014-05-231-13/+10
| | |
* | | switch to the `serve` method so we can remove the request class (eventually)Aaron Patterson2014-05-231-2/+6
| | |
* | | extract request allocation from the main app serving routineAaron Patterson2014-05-231-0/+1
| | |
* | | remove NullRequest and just always pass a request classAaron Patterson2014-05-231-3/+7
| | |
* | | use the request object since we have itAaron Patterson2014-05-232-6/+6
| | | | | | | | | | | | | | | stop hardcoding hash keys and use the accessors provided on the request object.
* | | stop using PARAMETERS_KEY, and use the accessor on the request objectAaron Patterson2014-05-221-0/+3
| | | | | | | | | | | | this decouples our code from the env hash a bit.
* | | use symbol keys for path_parametersAaron Patterson2014-05-221-5/+5
| | |
* | | Form full URI as string to be parsed in Rack::Test.Guo Xiang Tan2014-05-211-6/+6
| | | | | | | | | | | | There are performance gains to be made by avoiding URI setter methods.
* | | middle variable is never used, so rmAaron Patterson2014-05-211-14/+14
| | |
* | | we don't use this parameter for anything, so rmAaron Patterson2014-05-201-20/+19
| | |
* | | Merge pull request #11346 from tomykaira/fix_10257Rafael Mendonça França2014-05-201-0/+7
|\ \ \ | | | | | | | | Check authentication scheme in Basic auth
| * | | Check authentication scheme in Basic authtomykaira2013-07-071-0/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `authenticate_with_http_basic` and its families should check the authentication schema is "Basic". Different schema, such as OAuth2 Bearer should be rejected by basic auth, but it was passing as the test shows. This fixes #10257.
* | | | Merge pull request #15182 from zuhao/refactor_actionpack_respond_with_test_2Yves Senn2014-05-201-4/+10
|\ \ \ \ | | | | | | | | | | Un-define :to_json for Customer class after stubbing.
| * | | | Add using_resouce_with_json to controller.Zuhao Wan2014-05-201-4/+10
| | | | |
* | | | | Merge pull request #15178 from zuhao/refactor_actionpack_respond_with_testYves Senn2014-05-201-0/+19
|\ \ \ \ \ | | | | | | | | | | | | Deregister csv renderer after test to prevent leak.
| * | | | | Add ActionController::Renderers.remove.Zuhao Wan2014-05-201-0/+19
| |/ / / /
* / / / / Revert "Rewrite journey routes formatter for performance"Aaron Patterson2014-05-191-0/+20
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 5c224de9e110763ec7a0f01f5b604bcf81f40bfb. Conflicts: actionpack/lib/action_dispatch/journey/visitors.rb 5c224de9e110763ec7a0f01f5b604bcf81f40bfb introduced a bug in the formatter. This commit includes a regression test.
* | | | Ensure :js is defined regardless of the outcome of the test.Zuhao Wan2014-05-171-5/+11
| | | |
* | | | fixes stack level too deep exception on action named 'status' returning ↵Christiaan Van den Poel2014-05-151-0/+31
| | | | | | | | | | | | | | | | 'head :ok'
* | | | Add RFC4791 MKCALENDAR methodkasper2014-05-151-2/+3
| | | |
* | | | Remove unused method in RouteSet test.Guo Xiang Tan2014-05-151-4/+0
| | | |
* | | | Merge pull request #14137 from dasch/better-fragment-cache-instrumentationRafael Mendonça França2014-05-141-0/+16
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add controller and action name to the fragment caching instrumentation payload Conflicts: actionpack/CHANGELOG.md
| * | | | Add controller and action name to the instrumentation payloadDaniel Schierbeck2014-05-101-0/+16
| | | | |
* | | | | Merge pull request #15070 from ayamomiji/sse-patchAaron Patterson2014-05-141-0/+16
|\ \ \ \ \ | | | | | | | | | | | | Add multiple lines message support for SSE module
| * | | | | Add multiple lines message support for SSE moduleayaya2014-05-121-0/+16
| | | | | |
* | | | | | _recall should be set to a hash or not setAaron Patterson2014-05-131-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | Then we can avoid nil checks
* | | | | | Fix regression on `assert_redirected_to`.Arthur Neves2014-05-131-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `assert_redirected_to` would fail if there is no controller set on a `ActionDispatch::IntegrationTest`, as _compute_redirect_to_location would be called on the controller to build the url. This regression was introduced after 1dacfbabf3bb1e0a9057dd2a016b1804e7fa38c0. [fixes #14691]
* | | | | | this class is a model, so it should act like oneAaron Patterson2014-05-121-0/+3
|/ / / / /
* | | | / Remove redundant tests method.Guo Xiang Tan2014-05-111-2/+0
| |_|_|/ |/| | |
* | | | Always use the provided port for protocol relative urlsAndrew White2014-05-111-0/+12
| | | | | | | | | | | | | | | | | | | | There may be situations where you need to tunnel SSL connections over port 80 so we shouldn't remove it if it has been explicitly provided.
* | | | ActionDispatch::Http::URL.normalize_port should not strip port for protocol ↵Guilherme Cavalcanti2014-05-111-0/+12
| | | | | | | | | | | | | | | | relative URL.
* | | | just call the method and assert the return valueAaron Patterson2014-05-091-8/+1
| | | | | | | | | | | | | | | | do not test internals
* | | | HTTP::Headers#key? correctly convertsschneems2014-05-071-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously if you were looking for a given key, the header may incorrectly tell you that it did not exist even though it would return a valid value: ```ruby env = { "CONTENT_TYPE" => "text/plain" } headers = ActionDispatch::Http::Headers.new(env) headers["Content-Type"] # => "text/plain" headers.key?("Content-Type") # => false ``` This PR fixes that behavior by converting the key before checking for presence
* | | | Merge pull request #14945 from tomkadwill/form_authenticity_param_refactorRafael Mendonça França2014-05-061-5/+26
|\ \ \ \ | | | | | | | | | | Moved 'params[request_forgery_protection_token]' into its own method and...
| * | | | Moved 'params[request_forgery_protection_token]' into its own method and ↵Tom Kadwill2014-05-061-5/+26
| | |_|/ | |/| | | | | | | | | | improved tests.
* / | | Only accept actions without File::SEPARATOR in the name.Rafael Mendonça França2014-05-061-1/+16
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | This will avoid directory traversal in implicit render. Fixes: CVE-2014-0130 Conflicts: actionpack/lib/abstract_controller/base.rb
generated by cgit v1.2.3 (git 2.25.1) at 2024-08-17 20:32:50 +0000