aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/test
Commit message (Collapse)AuthorAgeFilesLines
...
| | * | Remove redundant test.Guo Xiang Tan2014-07-181-11/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since we're stubbing the request, the test is actually just asserting that `@method = env['REQUEST_METHOD']`. In order to the test against the methodoverride middleware, we should test it against an actual request. However, Rack is already covering this scenario so we can remove this test.
| | * | Fix duplicated test.Guo Xiang Tan2014-07-181-2/+6
| | | | | | | | | | | | | | | | | | | | There is already another test covering Request#request_method. This test should cover Request#method.
| | * | Update test to clearly reflect what it is testing for.Guo Xiang Tan2014-07-181-5/+7
| | | |
| | * | Update outdated test.Guo Xiang Tan2014-07-181-6/+3
| | |/ | | | | | | | | | | | | The current test is asserting against an outdated version of Request#method where HEAD requests are treated as GET requests.
| * | Add CHANGELOG for #14886Arthur Neves2014-07-181-1/+1
| | | | | | | | | | | | | | | | | | | | | Also cleanup test a bit [related #14886] [related #14743]
| * | LOCALHOST definition should match any 127.0.0.0/8 addressEarl J St Sauver2014-07-182-1/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The entire 127.0.0.0/8 range is assigned to the loopback address, not only 127.0.0.0/24. This patch allows ActionDispatch::Request::LOCALHOST to match any IPv4 127.0.0.0/8 loopback address. The only place that the #local? method was previously under test was in the show_expectations_test.rb file. I don't particularly like that that's implicitly where this code is under test, and I feel like I should move some of that testing code into the test/dispatch/request_test.rb file, but I wanted some feedback first. Credit goes to @sriedel for discovering the issue and adding the patch.
| * | reporting is only done in one thread, so we can safely remove the lockAaron Patterson2014-07-171-1/+1
| | | | | | | | | | | | (I think)
| * | pass the test reporter by referenceAaron Patterson2014-07-171-1/+4
| | | | | | | | | | | | | | | | | | this prevents the array from being dumped as a DRbObject so we can reduce communication with the server. the reporter should always exist on the server side, so we don't have to worry about GC
| * | fix filesystem race conditionAaron Patterson2014-07-171-1/+1
| | |
| * | do not restart the service, just stop itAaron Patterson2014-07-171-1/+0
| | |
| * | only parallelize on forking systemsAaron Patterson2014-07-171-1/+1
| | |
| * | [EXPERIMENTAL] run actionpack tests in parallelAaron Patterson2014-07-171-0/+57
| | | | | | | | | | | | | | | only on forking systems though. Feel free to revert this if it causes problems.
| * | pass the route name to define_url_helperAaron Patterson2014-07-171-1/+2
| | | | | | | | | | | | | | | this allows us to avoid 2 hash allocations per named helper definition, also we can avoid a `merge` and `delete`.
| * | helper methods are public, so we can just call themAaron Patterson2014-07-171-4/+4
| | | | | | | | | | | | | | | also if you want a path from a named helper, you should call helper_path, not helper_url(:only_path => true).
| * | Rails-ish apps should descend from Rails::RailtieAaron Patterson2014-07-163-6/+14
| | | | | | | | | | | | | | | Use an is_a check to ensure it's a Railsish app so we can avoid respond_to calls everywhere.
| * | always transcode the file to utf-8Aaron Patterson2014-07-161-0/+6
| | | | | | | | | | | | | | | | | | people may be passing filenames to the constructor that are not utf-8, but they will assome that calling `original_filename` returns utf-8 (because that's what it used to do).
| * | Remove unused fixturesRafael Mendonça França2014-07-1660-98/+0
| | | | | | | | | | | | These fixtures are not used in actionpack tests.
| * | Don't accept parameters as argument for redirect to [via @homakov]Santiago Pastorino2014-07-161-0/+10
| | | | | | | | | | | | Closes #16170
| * | Fix 1.9. uggghhhhhh get it together @tenderlove :bomb:Aaron Patterson2014-07-151-2/+2
| | |
| * | fix for 1.9 kwargs syntaxAaron Patterson2014-07-151-1/+2
| | |
| * | stop passing recall to url_forAaron Patterson2014-07-152-37/+48
| | |
| * | fix warningsAaron Patterson2014-07-151-1/+1
| | |
| * | stop calling url_for with recall parameters and actually use a requestAaron Patterson2014-07-152-85/+197
| | |
| * | execute a request and check the path_parametersAaron Patterson2014-07-151-17/+59
| | | | | | | | | | | | | | | | | | | | | | | | This actually runs a request through the system, using the actual routing methods as we would use in production, then tests the path_parameters set on the request object. The `recognize_path` method isn't actually used in production, so testing what it returns isn't useful.
| * | set `set` in the setup methodAaron Patterson2014-07-151-2/+5
| | |
| * | remove useless ivar setAaron Patterson2014-07-151-1/+0
| | |
| * | RouteSet should be in charge of constructing the dispatherAaron Patterson2014-07-151-2/+2
| | | | | | | | | | | | Now we can override how requests are dispatched in the routeset object
| * | Merge pull request #16168 from greysteil/stash-path-infoMatthew Draper2014-07-141-1/+2
| |\ \ | | | | | | | | Stash original path in `ShowExceptions` middleware
| | * | Stash original path in `ShowExceptions` middlewareGrey Baker2014-07-141-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `ActionDispatch::ShowExceptions` overwrites `PATH_INFO` with the status code for the exception defined in `ExceptionWrapper`, so the path the user was visiting when an exception occurred was not previously available to any custom exceptions_app. The original `PATH_INFO` is now stashed in `env["action_dispatch.original_path"]`.
| * | | Fix typos like `a html` to `an html` and 'an mail' to 'an email'. [ci skip]Santosh Wadghule2014-07-141-2/+2
| |/ /
| * | Removed single space padding from empty response body.Godfrey Chan2014-07-104-16/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `render nothing: true` or rendering a `nil` body no longer add a single space to the response body. The old behavior was added as a workaround for a bug in an early version of Safari, where the HTTP headers are not returned correctly if the response body has a 0-length. This is been fixed since and the workaround is no longer necessary. Use `render body: ' '` if the old behavior is desired.
* | | Remove more unneeded includeRafael Mendonça França2014-07-151-3/+0
| | |
* | | We don't need loofah for the assertionsRafael Mendonça França2014-07-151-3/+3
| | | | | | | | | | | | We can just use nokogiri
* | | Merge pull request #11218 from kaspth/loofah-integrationRafael Mendonça França2014-07-107-1175/+8
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | Loofah-integration Conflicts: actionpack/CHANGELOG.md actionview/CHANGELOG.md
| * | Remove unneeded comment in test.Timm2014-06-161-1/+1
| | |
| * | Exchanged requiring of action view assertions with rails dom testing assertions.Timm2014-06-161-2/+3
| | |
| * | Moved ActionView::Assertions dependency from Action Pack's lib to ↵Timm2014-06-161-0/+2
| | | | | | | | | | | | abstract_unit.rb.
| * | Nokogiri leaves '<' unescaped, so the assert_select looking for '&lt;' will ↵Timm2014-06-161-2/+3
| | | | | | | | | | | | never work. Switched to assert_matching the reponse body.
| * | Removed require's for html-scanner.Timm2014-06-162-2/+0
| | |
| * | Moved Dom and Selector assertions from ActionDispatch to ActionView.Timm2014-06-161-350/+0
| | |
| * | Fixed: assert_select_encoded finds the right content. No longer uses a ↵Timm2014-06-161-9/+2
| | | | | | | | | | | | <encoded> wrapper. Updated tests to reflect this.
| * | Fixed: test_nested_assert_select selects from elements instead of ↵Timm2014-06-161-2/+2
| | | | | | | | | | | | elements[0] and elements[1].
| * | Changed xml_namespace test to correct syntax. However, Nokogiri won't ↵Timm2014-06-161-2/+3
| | | | | | | | | | | | recognize the namespace.
| * | Changed test methods to use new substitution syntax more in line with css ↵Timm2014-06-161-3/+3
| | | | | | | | | | | | selectors.
| * | Fixed typo in method name. Fixed Nokogiri::CSS::SyntaxError.Timm2014-06-151-2/+2
| | |
| * | Changed tests to assert_kind_of Loofah::HTML::Document.Timm2014-06-151-3/+3
| | |
| * | Removed selector_test.rb since HTML::Selector will be removed. Soon.Timm2014-06-151-629/+0
| | |
| * | Fixed Nokogiri::CSS::SyntaxErrors.Timm2014-06-151-2/+2
| | | | | | | | | | | | Fixed a Nokogiri::CSS::SyntaxError by using its expected format for unicode characters.
| * | Removed tag.rb since it has been deprecated.Timm2014-06-152-184/+0
| | |
* | | Merge branch 'rosetta_flash' of https://github.com/gcampbell/rails into ↵Aaron Patterson2014-07-102-2/+2
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | gcampbell-rosetta_flash * 'rosetta_flash' of https://github.com/gcampbell/rails: Address CVE-2014-4671 (JSONP Flash exploit) Conflicts: actionpack/CHANGELOG.md