| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
If two different environments are configured to use the pipeline, but
one has an extra step (such as compression) then without taking the
environment into account you may end up serving wrong assets
|
|\
| |
| | |
Simple_format should not edit it in place. (Fixes https://github.com/rails/rails/issues/1980)
|
| |
| |
| |
| | |
place. Now it duplicates it.
|
|\ \
| |/
|/| |
fix stringify_keys destructive behavior for most FormTagHelper functions
|
| |
| |
| |
| | |
add four new tests to verify that the other three methods that called stringify_keys! are fixed. verified that the tests break in master without the code patch. Closes #2355
|
| |
| |
| |
| |
| |
| | |
Closes #1872. Closes #2031.
Signed-off-by: José Valim <jose.valim@gmail.com>
|
| |
| |
| |
| | |
File#to_path and similar.
|
|\ \
| | |
| | | |
Removing extra requires from the test. Already loaded in abstract_unit.
|
| |/ |
|
|/
|
|
| |
abstract_unit.rb
|
|
|
|
| |
warnings because of a missing instance variable
|
|\
| |
| | |
Inline resources router fix
|
| |
| |
| |
| | |
This fixes a bug that is caused by Resource/SingletonResource mangling resource options when using inline "multi"-resource declarations.
|
|\ \
| | |
| | | |
Allow ActiveModel-compatible instances to define their own partial paths
|
| | |
| | |
| | |
| | |
| | |
| | | |
Deprecate ActiveModel::Name#partial_path. Now you
should call #to_path directly on ActiveModel
instances.
|
| | | |
|
|\ \ \
| | | |
| | | | |
Fixes overriding of options[:html][:remote] in form_for() (Issue #2094)
|
| | | | |
|
| | | | |
|
| |/ /
|/| |
| | |
| | |
| | |
| | | |
When format is true, it is mandatory (as opposed to :format => false).
This is currently not possible with resource routes, which automatically
make format optional by default.
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
davidtrogers/constraints_block_passed_to_following_routes_in_same_scope
Memoizing @blocks & disposing of constraints options properly
|
| | |/
| |/|
| | |
| | |
| | | |
addresses issue #1907 - any routes that follow a route with a constraints
block are inheriting the previous route's constraints.
|
| | | |
|
|\ \ \
| | | |
| | | | |
Use shorter class-level File methods instead of going through File.stat
|
| |/ / |
|
|/ /
| |
| |
| | |
This brings back the ability to overwrite/extend url generating methods in application heleprs.
|
|\ \ |
|
| | |
| | |
| | |
| | |
| | |
| | | |
English to
American English(according to Weber)
|
|\ \ \
| | | |
| | | | |
Fix issue 1951 master Namespaced model partial_path is wrong in namespaced controllers
|
| | | |
| | | |
| | | |
| | | | |
fix issues/1951
|
| | | |
| | | |
| | | |
| | | |
| | | | |
https://github.com/rails/rails/issues/1951
Namespaced model partial_path is wrong in namespaced controllers
|
|/ / / |
|
|/ /
| |
| | |
Unfortunately #respond_to?(:controller) won't work as suggested, nor will respond_to?(:params), as #controller is present and #params is delegated to #controller. #delegate makes respond_to? return true regardless whether the target responds to it.
|
| |
| |
| |
| |
| |
| | |
requests. Closes #2119
An xhr request must have an "Accept" or "Content-type" header in order to be considered a request with valid_accept_header.
|
| |
| |
| |
| |
| |
| | |
Needed to move AC::Metal::Instrumentation before AM::Metal::Rescue
so that status codes rendered from rescue_from blocks are logged
properly.
|
|\ \
| | |
| | | |
Fix a wrong assertion on url_helper_test, and add missing `#html_safe?` a
|
| |/
| |
| |
| | |
be in its method
|
|\ \
| |/
|/| |
Render partial invalid check
|
| | |
|
|/ |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I have found that Rails will take an invalid session ID specified by the
client and materialize a session based on that session ID. This means
that it is possible, among other things, for a client to use an
arbitrarily weak session ID or for a client to resurrect a previous used
session ID. In other words, we cannot guarantee that all session IDs are
generated by the server and that they are (statistically) unique through
time.
The fix is to always generate a new session ID in #get_session if an
existing session cannot be found under the incoming session ID.
Also added new tests that make sure that an invalid session ID is never
materialized into a new session, regardless of whether it comes in via a
cookie or a URL parameter (when :cookie_only => false).
|
|
|
|
| |
FormBuilder#select now works with a nested data structure.
|
| |
|
|
|
|
|
|
| |
That integer is rather irrelevant, the only thing that matters is that
it is consistent and with no apparent bias. Zlib.crc32 is 8-10 times
faster than bytes.sum, so use that.
|
| |
|
|
|
|
| |
wildcard of the assets path because in ruby 1.9 is not consistent
|
|
|
|
|
|
| |
This is because only template rendering works with streaming.
Setting it at the class level was also changing the behavior
of JSON and XML responses, closes #1337.
|
|\
| |
| | |
Refactor sprockets asset paths to allow for alternate asset environments
|
| | |
|
| |
| |
| | |
This fixes the problem of having a non-explicit message when the :location option is not provided in respond_with.
|