Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | remove useless rescue | Damien Mathieu | 2011-08-24 | 1 | -1/+5 |
| | | | | | params is a method, defined in every controller, which always returns a hash. If it raises a NoMethodError, it means there's a bug somewhere else, which we want to know about. | ||||
* | Merge pull request #2411 from ai/debug_assets_by_config | Santiago Pastorino | 2011-08-22 | 1 | -14/+6 |
|\ | | | | | Debug assets by config | ||||
| * | Allow to debug assets by config.assets.debug | Andrey A.I. Sitnik | 2011-08-22 | 1 | -14/+6 |
| | | |||||
* | | fix escape_javascript for unicode character \u2028. | Teng Siong Ong | 2011-08-21 | 1 | -0/+1 |
|/ | |||||
* | Debug assets by default in development and test environments | Guillermo Iguaran | 2011-08-18 | 1 | -6/+22 |
| | |||||
* | Properly escape glob characters. | Aaron Patterson | 2011-08-16 | 2 | -0/+15 |
| | |||||
* | Tags with invalid names should also be stripped in order to prevent | Aaron Patterson | 2011-08-16 | 1 | -0/+7 |
| | | | | XSS attacks. Thanks Sascha Depold for the report. | ||||
* | Use lazy load hooks to set parameter wrapping configuration. This means that ↵ | Jon Leighton | 2011-08-16 | 1 | -7/+0 |
| | | | | it doesn't force Action Controller / Active Record to load, but it doesn't fail if they have already loaded. Thanks @josevalim for the hint. | ||||
* | Don't refer to ActionController::Base in the wrap_parameters initializer - ↵ | Jon Leighton | 2011-08-16 | 1 | -0/+7 |
| | | | | use config object instead. Cuts about 15% off the load time. (#734) | ||||
* | Unused variable removed. | Arun Agrawal | 2011-08-15 | 1 | -4/+4 |
| | |||||
* | Methods like status and location are interfering with redirect_to [Closes #2511] | Franck Verrot | 2011-08-14 | 1 | -0/+5 |
| | |||||
* | moving test_generate to an integration test with one assert per test | Aaron Patterson | 2011-08-12 | 2 | -108/+183 |
| | |||||
* | when calling url_for with a hash, additional (likely unwanted) values (such ↵ | Andrew Kaspick | 2011-08-11 | 1 | -0/+12 |
| | | | | as :host) would be returned in the hash... calling #dup on the hash prevents this | ||||
* | deprecating process_view_paths | Aaron Patterson | 2011-08-09 | 2 | -2/+2 |
| | |||||
* | generate environment dependent asset digests | Ilya Grigorik | 2011-08-04 | 1 | -0/+13 |
| | | | | | | If two different environments are configured to use the pipeline, but one has an extra step (such as compression) then without taking the environment into account you may end up serving wrong assets | ||||
* | Merge pull request #2421 from pivotal-casebook/master | Santiago Pastorino | 2011-08-04 | 1 | -2/+2 |
|\ | | | | | Simple_format should not edit it in place. (Fixes https://github.com/rails/rails/issues/1980) | ||||
| * | ActionView::Helpers::TextHelper#simple_format should not change the text in ↵ | Casebook Developer | 2011-08-04 | 1 | -2/+2 |
| | | | | | | | | place. Now it duplicates it. | ||||
* | | Merge pull request #2356 from waynn/fix_symbol | Santiago Pastorino | 2011-08-04 | 1 | -0/+24 |
|\ \ | |/ |/| | fix stringify_keys destructive behavior for most FormTagHelper functions | ||||
| * | fix stringify_keys destructive behavior for most FormTagHelper functions | Waynn Lue | 2011-08-03 | 1 | -0/+24 |
| | | | | | | | | add four new tests to verify that the other three methods that called stringify_keys! are fixed. verified that the tests break in master without the code patch. Closes #2355 | ||||
* | | Fix the issue where default_url_options is being cached on test cases. ↵ | thoefer | 2011-08-01 | 1 | -0/+29 |
| | | | | | | | | | | | | Closes #1872. Closes #2031. Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | | Rename new method to_path to to_partial_path to avoid conflicts with ↵ | José Valim | 2011-08-01 | 2 | -3/+3 |
| | | | | | | | | File#to_path and similar. | ||||
* | | Merge pull request #2379 from arunagw/extra_require_removal | Santiago Pastorino | 2011-07-31 | 1 | -1/+0 |
|\ \ | | | | | | | Removing extra requires from the test. Already loaded in abstract_unit. | ||||
| * | | Removing extra requires from the test. Already loaded in abstract_unit. | Arun Agrawal | 2011-07-31 | 1 | -1/+0 |
| |/ | |||||
* / | remove extra require for 'active_support/dependencies' as it is required in ↵ | Vishnu Atrai | 2011-07-31 | 1 | -1/+0 |
|/ | | | | abstract_unit.rb | ||||
* | Instead of removing the instance variable just set it to nil, resolves the ↵ | Brian Cardarella | 2011-07-29 | 1 | -2/+2 |
| | | | | warnings because of a missing instance variable | ||||
* | Merge pull request #2330 from thedarkone/resources-router-fix | José Valim | 2011-07-28 | 1 | -0/+9 |
|\ | | | | | Inline resources router fix | ||||
| * | There is no need to be destructive with the passed-in options. | thedarkone | 2011-07-28 | 1 | -0/+9 |
| | | | | | | | | This fixes a bug that is caused by Resource/SingletonResource mangling resource options when using inline "multi"-resource declarations. | ||||
* | | Merge pull request #2034 from Casecommons/to_path | José Valim | 2011-07-28 | 2 | -0/+41 |
|\ \ | | | | | | | Allow ActiveModel-compatible instances to define their own partial paths | ||||
| * | | Let ActiveModel instances define partial paths. | Grant Hutchins & Peter Jaros | 2011-07-25 | 2 | -0/+41 |
| | | | | | | | | | | | | | | | | | | Deprecate ActiveModel::Name#partial_path. Now you should call #to_path directly on ActiveModel instances. | ||||
* | | | fixing wildcard path matching when wildcard is inside parenthesis | Aaron Patterson | 2011-07-26 | 1 | -0/+7 |
| | | | |||||
* | | | Merge pull request #2095 from dgeb/issue-2094 | Aaron Patterson | 2011-07-26 | 1 | -0/+17 |
|\ \ \ | | | | | | | | | Fixes overriding of options[:html][:remote] in form_for() (Issue #2094) | ||||
| * | | | added test case for fix to issue #2094 | Dan Gebhardt | 2011-07-16 | 1 | -0/+17 |
| | | | | |||||
* | | | | use sprocket's append_path and assert_match | Damien Mathieu | 2011-07-26 | 1 | -26/+26 |
| | | | | |||||
* | | | | Allow a route to have :format => true | Erik Michaels-Ober | 2011-07-25 | 1 | -0/+7 |
| |/ / |/| | | | | | | | | | | | | | | When format is true, it is mandatory (as opposed to :format => false). This is currently not possible with resource routes, which automatically make format optional by default. | ||||
* | | | Merge pull request #2245 from ↵ | Santiago Pastorino | 2011-07-25 | 1 | -0/+20 |
|\ \ \ | | | | | | | | | | | | | | | | | davidtrogers/constraints_block_passed_to_following_routes_in_same_scope Memoizing @blocks & disposing of constraints options properly | ||||
| * | | | Ensure the constraints block is only applied to the correct route | Dave Rogers | 2011-07-25 | 1 | -0/+20 |
| | |/ | |/| | | | | | | | | | | addresses issue #1907 - any routes that follow a route with a constraints block are inheriting the previous route's constraints. | ||||
* | | | no need for an anonymous class on every setup call | Aaron Patterson | 2011-07-25 | 1 | -10/+9 |
| | | | |||||
* | | | Merge pull request #2258 from thedarkone/no-file-stat | José Valim | 2011-07-25 | 1 | -2/+2 |
|\ \ \ | | | | | | | | | Use shorter class-level File methods instead of going through File.stat | ||||
| * | | | Use shorter class-level File methods instead of going through File.stat. | thedarkone | 2011-07-25 | 1 | -2/+2 |
| |/ / | |||||
* / / | Make polymorphic_url calls go through application helpers again. | thedarkone | 2011-07-25 | 2 | -1/+13 |
|/ / | | | | | | | This brings back the ability to overwrite/extend url generating methods in application heleprs. | ||||
* | | Merge branch 'master' of git://github.com/lifo/docrails | Xavier Noria | 2011-07-24 | 1 | -1/+1 |
|\ \ | |||||
| * | | Changed a few instances of of words in the API docs written in British ↵ | Oemuer Oezkir | 2011-07-24 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | | | English to American English(according to Weber) | ||||
* | | | Merge pull request #2233 from gramos/fix-issue-1951-master | Aaron Patterson | 2011-07-23 | 1 | -0/+14 |
|\ \ \ | | | | | | | | | Fix issue 1951 master Namespaced model partial_path is wrong in namespaced controllers | ||||
| * | | | - added ActionView::PartialRenderer#merge_path_into_partial(path, partial) | Gaston Ramos | 2011-07-24 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | fix issues/1951 | ||||
| * | | | - added test case for issue: | Gaston Ramos | 2011-07-24 | 1 | -0/+14 |
| | | | | | | | | | | | | | | | | | | | | https://github.com/rails/rails/issues/1951 Namespaced model partial_path is wrong in namespaced controllers | ||||
* | | | | just use normal ruby for stubbing | Aaron Patterson | 2011-07-23 | 1 | -5/+3 |
|/ / / | |||||
* / / | Simple fix to the NoMethodError noted in #2177. | Ben Woosley | 2011-07-23 | 1 | -1/+0 |
|/ / | | | | | Unfortunately #respond_to?(:controller) won't work as suggested, nor will respond_to?(:params), as #controller is present and #params is delegated to #controller. #delegate makes respond_to? return true regardless whether the target responds to it. | ||||
* | | Check Accept and Content-Type headers before evaluating them in xhr ↵ | ogeidix | 2011-07-19 | 1 | -0/+6 |
| | | | | | | | | | | | | requests. Closes #2119 An xhr request must have an "Accept" or "Content-type" header in order to be considered a request with valid_accept_header. | ||||
* | | Ensure that status codes are logged properly | Jesse Storimer | 2011-07-18 | 1 | -0/+19 |
| | | | | | | | | | | | | Needed to move AC::Metal::Instrumentation before AM::Metal::Rescue so that status codes rendered from rescue_from blocks are logged properly. | ||||
* | | Merge pull request #2046 from sikachu/master-test_fix | Santiago Pastorino | 2011-07-17 | 1 | -2/+6 |
|\ \ | | | | | | | Fix a wrong assertion on url_helper_test, and add missing `#html_safe?` a |