Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | fields_for should treat ActiveRecord::Relation as an array | Neeraj Singh | 2010-11-11 | 1 | -0/+21 |
| | | | | | | [#5795 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Fix render partial with layout and no block | Carlos Antonio da Silva | 2010-11-11 | 1 | -0/+10 |
| | | | | | | | | When using a render :partial with :layout call, without giving a block, if the given :partial had another render :partial call, the layout was not being rendered. This commit fixes this context by storing variables before rendering the partial, so they are not overrided in any successive call to render partials down the path. All ActionPack tests are ok. | ||||
* | Fix issue with rendering partials and then yielding inside a render layout call | Carlos Antonio da Silva | 2010-11-11 | 1 | -0/+20 |
| | | | | | | | The given block was never being executed when another render :partial call existed before the yield call, due to the block being overriden. This commit also adds some more tests to render with :layout option. | ||||
* | patching to ensure separator is printed with order [#5816 state:resolved] | Aditya Sanghi | 2010-11-11 | 1 | -0/+41 |
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Added :negative_format option to number_to_currency function [#5894 ↵ | Don Wilson | 2010-11-02 | 2 | -1/+8 |
| | | | | | | state:resolved] Signed-off-by: Andrew White <andyw@pixeltrix.co.uk> | ||||
* | Test that capture doesn't escape twice | Santiago Pastorino | 2010-11-02 | 1 | -2/+7 |
| | |||||
* | Make sure capture's output gets html_escaped [#5545 state:resolved] | Jeff Kreeftmeijer | 2010-11-02 | 2 | -6/+6 |
| | | | | | | | Also remove a duplicate test_link_to_unless assertion and add .html_safe to the remaining one. Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Allow generated url helpers to be overriden [#5243 state:resolved] | Andrew White | 2010-10-26 | 1 | -0/+18 |
| | |||||
* | number_to_phone always return safe | Santiago Pastorino | 2010-10-17 | 1 | -1/+2 |
| | |||||
* | HTML5 data attribute helpers [#5825 state:resolved]. | Stephen Celis | 2010-10-18 | 1 | -0/+7 |
| | |||||
* | Fix for ActionView::Template#refresh in rails 3.1.0.beta | André Camargo | 2010-10-15 | 1 | -2/+2 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Remove :cache => true on lookup templates initialization. | José Valim | 2010-10-14 | 2 | -12/+0 |
| | |||||
* | render :once should consider the current controller prefix. | José Valim | 2010-10-14 | 1 | -3/+3 |
| | |||||
* | Fix test helpers to ensure get method forms are properly tested [#5753 ↵ | Aditya Sanghi | 2010-10-12 | 2 | -9/+16 |
| | | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | data-disable-with in button_to helper | Paco Guzman | 2010-10-11 | 1 | -0/+21 |
| | | | | | | [#4993 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Revert "Make InstanceTagMethods#value_before_type_cast raise if the model ↵ | Santiago Pastorino | 2010-10-10 | 1 | -30/+0 |
| | | | | | | | | don't respond to attr_before_type_cast or attr method" And "Makes form_helper use overriden model accessors" This reverts commit 3ba8e3100548f10fce0c9784981a4589531476dd and fb0bd8c1092db51888ec4bb72af6c595e13c31fa. | ||||
* | Do not allow templates coming from Fallback resolvers to store a virtual path. | José Valim | 2010-10-10 | 2 | -3/+14 |
| | |||||
* | Use identifiers for template equality. | José Valim | 2010-10-10 | 1 | -0/+8 |
| | |||||
* | Clean up unused methods from AV::Base and pass in the template object on ↵ | José Valim | 2010-10-10 | 3 | -11/+13 |
| | | | | rendering. | ||||
* | Add expire! and rerender to the template API. This will be used by SASS ↵ | José Valim | 2010-10-10 | 1 | -2/+47 |
| | | | | template handler. | ||||
* | Add some unit tests to Template#refresh. | José Valim | 2010-10-10 | 1 | -4/+28 |
| | |||||
* | Resolvers now consider timestamps. | José Valim | 2010-10-10 | 1 | -0/+45 |
| | | | | | | | | | | | Before this patch, every request in development caused the template to be compiled, regardless if it was updated in the filesystem or not. This patch now checks the timestamp and only compiles it again if any change was done. While this probably won't show any difference for current setups, but it will be useful for asset template handlers (like SASS), as compiling their templates is slower than ERb, Haml, etc. | ||||
* | Deprecate old template handler API. Remove old handlers. | José Valim | 2010-10-10 | 1 | -2/+2 |
| | |||||
* | Add more docs and tests to templates. | José Valim | 2010-10-09 | 1 | -0/+12 |
| | |||||
* | Fix 1.9.2 failures. | José Valim | 2010-10-08 | 1 | -4/+4 |
| | |||||
* | fix rendering a partial with an array as its :object [#5746 state:resolved] | Michael Koziarski | 2010-10-08 | 1 | -0/+4 |
| | | | | | | | | Signed-off-by: Michael Koziarski <michael@koziarski.com> Conflicts: actionpack/lib/action_view/render/partials.rb | ||||
* | Allow cache to be temporarily disabled through lookup_context. | José Valim | 2010-10-07 | 1 | -0/+21 |
| | |||||
* | Remove locals dependency from template. | José Valim | 2010-10-07 | 1 | -0/+1 |
| | | | | | | This means that templates does not need to store its source anymore, allowing us to reduce the ammount of memory taken by our Rails processes. Naively speaking, if your app/views contains 2MB of files, each of your processes (after being hit by a bunch of requests) will take 2MB less of memory after this commit. This is extremely important for the upcoming features. Since Rails will also render CSS and JS files, their source won't be stored as well allowing us to decrease the ammount of memory taken. | ||||
* | Rename _assigns to view_assigns in AV::TC | David Chelimsky | 2010-10-03 | 1 | -0/+31 |
| | | | | | | | | | - also add tests - also deprecate _assigns [#5751 state:resolved] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | added test for form_for with search_field | Aditya Sanghi | 2010-10-02 | 1 | -0/+15 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | delete repeated code | Aaron Patterson | 2010-10-01 | 1 | -18/+0 |
| | |||||
* | Fix test that wasn't running at all. | Emilio Tagua | 2010-09-28 | 1 | -1/+1 |
| | |||||
* | Redefine duplicated test name. | Emilio Tagua | 2010-09-28 | 1 | -1/+1 |
| | |||||
* | Use helper method here. | Emilio Tagua | 2010-09-28 | 1 | -6/+5 |
| | |||||
* | Silence warnings here, only setting Encoding.default_external for testing. | Emilio Tagua | 2010-09-28 | 1 | -2/+3 |
| | |||||
* | Silence warnings here, only setting Encoding.default_external for testing. | Emilio Tagua | 2010-09-28 | 1 | -2/+3 |
| | |||||
* | Add parenthesis to avoid syntax warnings. | Emilio Tagua | 2010-09-28 | 2 | -2/+2 |
| | |||||
* | Remove duplicated method. | Emilio Tagua | 2010-09-28 | 1 | -2/+0 |
| | |||||
* | Initialize @_virtual_path path ivar. | Emilio Tagua | 2010-09-28 | 1 | -0/+1 |
| | |||||
* | Rename tests to avoid name collisions and warnings when running rake task. | Emilio Tagua | 2010-09-28 | 1 | -5/+5 |
| | |||||
* | Rename duplicated test, and give it a correct name. Remove nonsense line. | Emilio Tagua | 2010-09-28 | 1 | -2/+1 |
| | |||||
* | Remove duplicated test. | Emilio Tagua | 2010-09-28 | 1 | -20/+0 |
| | |||||
* | Remove more warnings shadowing outer local variable. | Emilio Tagua | 2010-09-27 | 1 | -1/+1 |
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Remove more warnings shadowing outer local variable. | Emilio Tagua | 2010-09-27 | 1 | -1/+1 |
| | |||||
* | Use parentheses when using assert_match followed by a regexp to avoid warnings. | Emilio Tagua | 2010-09-27 | 5 | -16/+16 |
| | |||||
* | Remove last tests with deprecated form_for and cleanup form_for helper | Carlos Antonio da Silva | 2010-09-26 | 1 | -63/+49 |
| | | | | | | | This cleans up the last bits of deprecation stuff from form_for helper. However there is still a bug when using :as => foo[], with index. The classes and ids are being generated using [], such as foo[]_edit. This bug already existed but it was not detected before. | ||||
* | Select tags with array options are deprecated, removing | Carlos Antonio da Silva | 2010-09-26 | 1 | -6/+0 |
| | |||||
* | Review most of the form_for deprecated tests, missing tests with index like [] | Carlos Antonio da Silva | 2010-09-26 | 1 | -405/+321 |
| | |||||
* | Remove duplicate helper method | Krekoten' Marjan | 2010-09-25 | 1 | -3/+0 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | These tests shouldn't depend on local time to pass or fail, we can use utc here. | Emilio Tagua | 2010-09-24 | 2 | -2/+2 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> |