Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | Merge pull request #6074 from mark-rushakoff/unused-variables | Jeremy Kemper | 2012-04-29 | 1 | -1/+1 | |
|\ \ | | | | | | | Remove some unused variable assignments | |||||
| * | | Remove unused assignment in actionpack date helper test | Mark Rushakoff | 2012-04-29 | 1 | -1/+1 | |
| | | | ||||||
* | | | Merge pull request #6059 from rafaelfranca/check_box_inverted | José Valim | 2012-04-29 | 1 | -2/+98 | |
|\ \ \ | | | | | | | | | Change check_box to work inverting the checked and unchecked value | |||||
| * | | | Change check_box to work inverting the checked and unchecked value | Rafael Mendonça França | 2012-04-29 | 1 | -2/+98 | |
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes: * Boolean with inverted logic * Integer with inverted logic * BigDecimal with inverted logic Fixes #3995 | |||||
* | | | Allow access to current object_counter variable from layout when rendering ↵ | Carlos Antonio da Silva | 2012-04-29 | 1 | -4/+11 | |
| | | | | | | | | | | | | with partial + collection | |||||
* | | | Allow layout to access current object being rendered when using render ↵ | Carlos Antonio da Silva | 2012-04-29 | 1 | -0/+4 | |
| | | | | | | | | | | | | partial + object | |||||
* | | | Allow layout rendering to access current object being rendered when using ↵ | Carlos Antonio da Silva | 2012-04-29 | 1 | -2/+6 | |
|/ / | | | | | | | partial + collection | |||||
* | | Lazy load `default_form_builder` if it's passed as a string | Piotr Sarnacki | 2012-04-28 | 1 | -0/+17 | |
| | | | | | | | | closes #3341 | |||||
* | | Remove default match without specified method | Jose and Yehuda | 2012-04-24 | 3 | -11/+11 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In the current router DSL, using the +match+ DSL method will match all verbs for the path to the specified endpoint. In the vast majority of cases, people are currently using +match+ when they actually mean +get+. This introduces security implications. This commit disallows calling +match+ without an HTTP verb constraint by default. To explicitly match all verbs, this commit also adds a :via => :all option to +match+. Closes #5964 | |||||
* | | Use leap years trick in distance_of_time_in_words only for distances between ↵ | Alexey Vakhov | 2012-04-24 | 1 | -0/+2 | |
| | | | | | | | | real date points | |||||
* | | fixed non matching documentation behaviour with method semantics on ↵ | Marcelo Casiraghi | 2012-04-24 | 1 | -2/+19 | |
| | | | | | | | | distance_of_time_in_words | |||||
* | | Distance of time in words should work correct if from time > to_time | Alexey Vakhov | 2012-04-24 | 1 | -0/+1 | |
| | | ||||||
* | | converting some tests to assert_raises, and DRY'ing retrieve_variable changes | Tieg Zaharia | 2012-04-16 | 1 | -39/+17 | |
| | | ||||||
* | | catch nil.to_sym errors in partial_renderer, and raise ArgumentError instead | Tieg Zaharia | 2012-04-16 | 1 | -0/+9 | |
| | | ||||||
* | | Merge pull request #5746 from jmbejar/index_method_form_builder | Santiago Pastorino | 2012-04-11 | 1 | -0/+50 | |
|\ \ | | | | | | | Add method FormBuilder#index | |||||
| * | | Add index method to FormBuilder. Useful when you use field_for and need to ↵ | Jorge Bejar | 2012-04-11 | 1 | -0/+50 | |
| | | | | | | | | | | | | know the index number into the iteration. | |||||
* | | | Adding itemscope to list of boolean attributes. | Frankie Roberto | 2012-04-09 | 1 | -2/+2 | |
| | | | | | | | | | | | | | | | | | | 'itemscope' is defined within HTML5 for use in microdata markup. See http://www.whatwg.org/specs/web-apps/current-work/multipage/microdata.ht ml#attr-itemscope | |||||
* | | | default_url_options does not receive one argument anymore | Rafael Mendonça França | 2012-04-08 | 1 | -1/+1 | |
| | | | ||||||
* | | | Remove unnecessary in HTML 5 type attribute with default value | Andrey A.I. Sitnik | 2012-04-05 | 4 | -102/+102 | |
|/ / | ||||||
* | | add type option to atom feed entry builder | Sergey Nartimov | 2012-04-01 | 1 | -0/+31 | |
| | | | | | | | | closes #5672 | |||||
* | | Block version of label should wrapped in field_with_errors in case of error | Alexey Vakhov | 2012-04-01 | 1 | -0/+14 | |
| | | ||||||
* | | datetime_select should work with -/+ infinity dates | Joe Van Dyk | 2012-03-28 | 1 | -0/+12 | |
| | | ||||||
* | | Merge pull request #5621 from rafaelfranca/fix-2492-master | Jeremy Kemper | 2012-03-27 | 1 | -0/+34 | |
|\ \ | | | | | | | Fix label_tag to merge the options hash with the object hash | |||||
| * | | Check if the options hash already exists and merge it with the another | Rafael Mendonça França | 2012-03-27 | 1 | -6/+18 | |
| | | | | | | | | | | | | | | | | | | hash. Closes #2492 and #5615 | |||||
| * | | Fixing issue #2492 for master branch. ActionView::Base.field_error_proc ↵ | Andrey Samsonov | 2012-03-27 | 1 | -0/+22 | |
| | | | | | | | | | | | | | | | | | | | | | | | | doesn't call for label. objectify_options method should be applied to the proper options arg. See explanation and example of the bug - https://github.com/kryzhovnik/rails_field_error_proc_bug_example | |||||
* | | | Don't break Haml with textarea newline fix. | James Coleman | 2012-03-27 | 1 | -6/+6 | |
|/ / | | | | | | | | | | | See issue #393, issue #4000, issue #5190, and issue #5191. Adds a newline after the textarea opening tag based on @codykrieger's original patch so that we don't cause regressions in Haml-using apps. The regression caused textarea tags to add newlines to the field unintentionally (each update/save added an extra newline.) Also fix 6 more tests that didn't yet have the newline expectation. | |||||
* | | change number_with_precision to not return negative zeros | Tim McEwan | 2012-03-27 | 1 | -0/+1 | |
| | | ||||||
* | | Don't ignore non Enumerable values passed to sanitize (closes #5585) | Piotr Sarnacki | 2012-03-27 | 1 | -0/+18 | |
| | | | | | | | | | | | | | | | | | | When someone accidentally passes a string to sanitize like: sanitize("<span>foo</span>", :tags => "b") there is no indication that it's the wrong way and span will not be removed. | |||||
* | | Remove warning added by my own commit :fire: | Carlos Antonio da Silva | 2012-03-26 | 1 | -1/+1 | |
| | | | | | | | | Commit: 7a0cf2f5294e8bcef547642435636b394340a3e4 | |||||
* | | Merge pull request #5561 from carlosantoniodasilva/form-builder-block-arg | Aaron Patterson | 2012-03-26 | 1 | -0/+12 | |
|\ \ | | | | | | | Properly deprecate the block argument in AV FormBuilder | |||||
| * | | Properly deprecate the block argument in AV FormBuilder | Carlos Antonio da Silva | 2012-03-23 | 1 | -0/+12 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Commit 56089ca986c767763f29159c8de0aa1ebabfd4d2 introduced a backward incompatible change by changing the method signature of the FormBuilder. This brings back the same method signature warning in case someone gives a block to the builder. More info: https://github.com/rails/rails/commit/56089ca986c767763f29159c8de0aa1ebabfd4d2#commitcomment-1116166 | |||||
* | | | apply form_for namespace option to date_select | Sergey Nartimov | 2012-03-26 | 1 | -0/+8 | |
|/ / | ||||||
* | | Fixes issue #5222: DateTimeSelector builds invalid dates on leap day when ↵ | Jey Balachandran | 2012-03-18 | 2 | -7/+21 | |
| | | | | | | | | discarding both day and month. | |||||
* | | time_tag support for blocks | Antonio Tapiador del Dujo | 2012-03-18 | 1 | -0/+4 | |
| | | ||||||
* | | Remove remaining sprockets tests | Guillermo Iguaran | 2012-03-13 | 1 | -28/+0 | |
| | | ||||||
* | | Remove tests and fixtures for Sprockets on ActionPack | Guillermo Iguaran | 2012-03-13 | 2 | -406/+0 | |
| | | ||||||
* | | add include_hidden option to checkbox tag | Sergey Nartimov | 2012-03-13 | 1 | -0/+5 | |
| | | ||||||
* | | add 'include_hidden' option to select tag, closes #5402 | Vasiliy Ermolovich | 2012-03-13 | 1 | -0/+8 | |
| | | ||||||
* | | Merge pull request #5375 from nertzy/assert_template_with_regexp | Aaron Patterson | 2012-03-12 | 1 | -0/+6 | |
|\ \ | | | | | | | assert_template matches against Regexp | |||||
| * | | assert_template matches against Regexp | Grant Hutchins | 2012-03-10 | 1 | -0/+6 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This allows for more strict template assertions, while maintaining backward compatibility. For example, if you use assert_template("foo/bar") and "foo/bar/baz" was rendered, the test passes. But if you use assert_template(%r{\Afoo/bar\Z}), you will catch that a different template was rendered. Also, if you passed an unsupported argument to assert_template() in the past, it would silently succeed. Now it raises an ArgumentError. | |||||
* | | | Merge pull request #5380 from benmmurphy/escape_unicode_paragraph_separator | Aaron Patterson | 2012-03-12 | 1 | -0/+2 | |
|\ \ \ | | | | | | | | | ensure u2029 is escaped in escape_javascript helper | |||||
| * | | | ensure u2029 is escaped in escape_javascript helper | benmmurphy | 2012-03-11 | 1 | -0/+2 | |
| |/ / | ||||||
* / / | Fixes #5324 by removing default size options from input:text and default ↵ | Philip Arndt | 2012-03-10 | 2 | -165/+165 | |
|/ / | | | | | | | cols and rows options from textarea. | |||||
* | | Merge pull request #5310 from Serabe/layout_for_partials_with_collections | José Valim | 2012-03-06 | 1 | -0/+4 | |
|\ \ | | | | | | | Adds :layout option to render :partial when a collection is given. | |||||
| * | | Adds :layout option to render :partial when a collection is given. | Sergio Arbeo | 2012-03-06 | 1 | -0/+4 | |
| | | | ||||||
* | | | Compute asset paths from the request if ENV["RAILS_RELATIVE_URL_ROOT"] is ↵ | Dwayne Litzenberger | 2012-03-05 | 2 | -0/+103 | |
|/ / | | | | | | | | | | | | | | | | | not set. This should fix the following issue: "Rails is not a Rack Application (SCRIPT_NAME vs. relative_url_root ?)" https://github.com/rails/rails/issues/910 | |||||
* | | Merge pull request #5242 from rails/opt_routes | José Valim | 2012-03-02 | 1 | -2/+2 | |
|\ \ | | | | | | | | | | | | | | | | | | | | | | Optimize routes generation in simple cases. If you pass to the route helper the same amount of arguments as the required segments, route generation will be optimized as a string interpolation. After this commit, `post_path(post)` is about 6.5 times faster, `post_url(post)` is about 5 times. | |||||
| * | | Optimize url helpers. | Sergey Nartimov + José Valim | 2012-03-02 | 1 | -2/+2 | |
| | | | ||||||
* | | | Allow fieldsets to be created without a block. | Ben Pickles | 2012-03-01 | 1 | -0/+10 | |
|/ / | ||||||
* | | Merge branch 'master-security' | Aaron Patterson | 2012-03-01 | 1 | -1/+8 | |
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * master-security: Ensure [] respects the status of the buffer. delete vulnerable AS::SafeBuffer#[] use AS::SafeBuffer#clone_empty for flushing the output_buffer add AS::SafeBuffer#clone_empty fix output safety issue with select options Conflicts: actionpack/lib/action_view/helpers/tags/base.rb |