Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Stylistic pass at form_helper_test | Rafael Mendonça França | 2013-01-21 | 1 | -286/+362 |
| | |||||
* | Capture block so content won't leak. | José Mota | 2013-01-21 | 1 | -0/+57 |
| | | | | | | | | | | | | | | The [following pull request](https://github.com/rails/rails/pull/8916) fixed the block being passed to the appropriate helper method. However, the content being passed into the block is generating repeated markup on the page due to some weird ERb evaluation. This commit tries to capture the block's generated output so the page isn't flooded with markup. [Rafael França + José Mota] Closes #8936 | ||||
* | Remove i18n symbol dependency | Chris McGrath | 2013-01-17 | 1 | -3/+8 |
| | | | | | | | | | date.order is the only key in rails i18n that is required to be a symbol. This patch allows for symbols or strings which means: * No requirement for symbol type in .yml files. A future YAML.safe_load wouldn't need to load symbols * Rails could actually use json rather than yml as the backend | ||||
* | Fix date_select :selected option so you can pass it nil | Colin Burn-Murdoch | 2013-01-16 | 1 | -1/+64 |
| | |||||
* | Merge pull request #8938 from colinbm/date_select_value | Steve Klabnik | 2013-01-14 | 1 | -2/+50 |
|\ | | | | | Rename :value to :selected for date_select, and add missing tests/docs | ||||
| * | Rename :value option to :selected, in line with other select helpers | Colin Burn-Murdoch | 2013-01-14 | 1 | -2/+50 |
| | | | | | | | | | | Add tests for time & datetime. Add documentation. | ||||
* | | Revert benchmark helper regression. Use a #capture within a #benchmark | Jeremy Kemper | 2013-01-14 | 1 | -24/+0 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | block. Breaks benchmark calls that return non-String values otherwise. Revert "add benchmark helper that works in erb" This reverts commit 904e544cc8f5846de7c31827bb5556c6a238c0de. Conflicts: actionpack/lib/action_view/helpers.rb actionpack/lib/action_view/helpers/benchmark_helper.rb actionpack/test/template/benchmark_helper_test.rb | ||||
* | | Merge pull request #8916 from josemota/collection-with-block | Rafael Mendonça França | 2013-01-13 | 1 | -0/+49 |
|\ \ | |/ |/| | | | | | Collection radio buttons and collection check boxes through FormBuilder render the provided block. Closes #8897 | ||||
| * | Collection radio buttons and collection check boxes through FormBuilder render | José Mota | 2013-01-12 | 1 | -0/+49 |
| | | | | | | | | | | | | | | | | the provided block. In the case of having a form_for method being called, the block for each collection would not be passed and thus the result expected was always the same. This patch passes the block to the original method like it would be assumed. | ||||
* | | Allow value to be set on date_select | Colin Burn-Murdoch | 2013-01-13 | 1 | -0/+21 |
| | | |||||
* | | Associaton -> Association | Steve Klabnik | 2013-01-13 | 1 | -2/+2 |
|/ | |||||
* | Merge pull request #8623 from virusman/form_helpers_collectionproxy_fix | Jon Leighton | 2013-01-11 | 1 | -0/+23 |
|\ | | | | | Fixed nested fields bug when called with AssociationProxy | ||||
| * | Test nested fields with AssociationProxy mockup & fix AssociationProxy ↵ | virusman | 2012-12-27 | 1 | -0/+23 |
| | | | | | | | | support in form helper | ||||
* | | view_cache_dependency API | Jamis Buck | 2013-01-08 | 1 | -2/+16 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | A declarative API for specifying dependencies that affect template cache digest computation. In your controller, specify any of said dependencies: view_cache_dependency { "phone" if using_phone? } When the block is evaluated, the resulting value is included in the cache digest calculation, allowing you to generate different digests for effectively the same template. (Mostly useful if you're mucking with template load paths.) | ||||
* | | set 'alt' attribute for image_submit_tag | Nihad Abbasov | 2013-01-08 | 1 | -2/+2 |
| | | |||||
* | | Do not generate local vars for partials without object or collection | Carlos Antonio da Silva | 2013-01-08 | 1 | -0/+7 |
| | | | | | | | | | | | | | | | | | | Previously rendering a partial without giving :object or :collection would generate a local variable with the partial name by default. This was noticed due to warnings in Ruby 2.0 of not used variables, which turned out to be the generation of not used variables inside partials that do not contain objects related to them. | ||||
* | | Do not call fields_for from form_for, to avoid instantiating two builders | Carlos Antonio da Silva | 2013-01-06 | 1 | -1/+13 |
| | | |||||
* | | deprecate `assert_blank` and `assert_present`. | Yves Senn | 2013-01-05 | 1 | -1/+1 |
| | | | | | | | | | | They don't add any benefits over `assert object.blank?` and `assert object.present?` | ||||
* | | No need to pass a empty block to content_tag_for anymore | Rafael Mendonça França | 2013-01-02 | 1 | -11/+11 |
| | | |||||
* | | Make content_tag_for work without block | Rafael Mendonça França | 2013-01-02 | 1 | -0/+8 |
| | | | | | | | | This is version of #8640 for master | ||||
* | | Remove unneeded tests | Rafael Mendonça França | 2012-12-31 | 2 | -95/+0 |
| | | | | | | | | These tests are needed only if we are using MiniTest::Spec | ||||
* | | Fix collection_radio_buttons with the option `:checked` with value of | Rafael Mendonça França | 2012-12-26 | 1 | -0/+6 |
|/ | | | | `false` | ||||
* | Digestor explicit dependency should not contain trailing whitespace | Brian Alexander | 2012-12-21 | 1 | -0/+6 |
| | | | | test for rails/rails#8586 | ||||
* | Remove obfuscation support from mail_to helper | Nick Reed | 2012-12-18 | 1 | -56/+0 |
| | | | | | | Removes support for :encode, :replace_at, and :replace_dot options from the mail_to helper. Support for these options has been extracted to the 'actionview-encoded_mail_to' gem. | ||||
* | handle protocol option in stylesheet_link_tag and javascript_include_tag | Vasiliy Ermolovich | 2012-12-18 | 1 | -1/+23 |
| | | | | closes #8388 | ||||
* | Override <%== to always behave as literal text rather than toggling based on ↵ | Jeremy Kemper | 2012-12-03 | 1 | -2/+2 |
| | | | | whether escaping is enabled. Fixes that existing plaintext email templates using <%== unexpectedly flipped to *escaping* HTML when #8235 was merged. | ||||
* | More descriptive error when rendering a partial with `:layout => true` | Yves Senn | 2012-12-02 | 1 | -0/+5 |
| | |||||
* | No sort Hash options in #grouped_options_for_select | Sergey Kojin | 2012-11-27 | 1 | -1/+1 |
| | |||||
* | Fix failing template tests | Carlos Antonio da Silva | 2012-11-16 | 1 | -2/+2 |
| | | | | Introduced in 4a4de567b45ff28035419bc2d92f9b206e3c0a66. | ||||
* | Introduce `ActionView::Template::Handlers::ERB.escape_whitelist`. | Joost Baaij | 2012-11-16 | 1 | -1/+15 |
| | | | | | | | | | | | This is a list of mime types where template text is not html escaped by default. It prevents `Jack & Joe` from rendering as `Jack & Joe` for the whitelisted mime types. The default whitelist contains text/plain. This follows a whitelist approach where plain text templates are not escaped, and all the others (json, xml) are. The mime type is assumed to be set by the abstract controller. | ||||
* | Merge pull request #8222 from marcandre/avoid_slash | Rafael Mendonça França | 2012-11-14 | 1 | -0/+5 |
|\ | | | | | Avoid using Integer#/, as it is redefined by the 'mathn' stdlib | ||||
| * | Avoid using Integer#/, as it is redefined by the 'mathn' stdlib | Marc-Andre Lafortune | 2012-11-14 | 1 | -0/+5 |
| | | |||||
* | | Ruby 2.0.0 defaults source encoding to utf-8 so we need to specifically tag ↵ | Aaron Patterson | 2012-11-12 | 1 | -0/+1 |
|/ | | | | this file with us-ascii | ||||
* | Support :multiple option on input tags with :index | Daniel Fox, Grant Hutchins & Trace Wax | 2012-11-02 | 1 | -0/+13 |
| | | | | | When you have an explicit index set, then when you build an input tag with :multiple => true, it doesn't add [] to the end of its name, although it should. | ||||
* | Add test to ensure data attributes are properly escaped with tag helpers | Carlos Antonio da Silva | 2012-11-01 | 1 | -2/+7 |
| | | | | Closes #8091 | ||||
* | Fix failing tests and use new hash style in deprecation messages | Carlos Antonio da Silva | 2012-10-29 | 2 | -12/+12 |
| | |||||
* | Improve the deprecation message of link_to_function and | Rafael Mendonça França | 2012-10-27 | 1 | -6/+6 |
| | | | | | | button_to_function Point the the Unobtrusive JavaScript secion in the JavaScript guide | ||||
* | cleanup, remove trailing whitespace within actionpack | Yves Senn | 2012-10-27 | 2 | -3/+3 |
| | |||||
* | check_box value can be not only an object of Array class | Vasiliy Ermolovich | 2012-10-20 | 1 | -0/+6 |
| | | | | there is a chance that `value` is a Set or an object that reponses to `include?` method so let's handle this case | ||||
* | Add i18n scope to disance_of_time_in_words. | Steve Klabnik | 2012-10-19 | 1 | -10/+19 |
| | | | | This fixes #733. | ||||
* | Merge pull request #7975 from butcher/extend_date_select_helper_functionality | Rafael Mendonça França | 2012-10-18 | 1 | -0/+16 |
|\ | | | | | | | | | | | | | Extend date_select helper functionality. Conflicts: actionpack/CHANGELOG.md | ||||
| * | Extend date_select helper functionality. | Pavel Nikitin | 2012-10-18 | 1 | -0/+16 |
| | | |||||
* | | use the tmp filesystem rather than our own thing. | Aaron Patterson | 2012-10-17 | 1 | -5/+9 |
|/ | |||||
* | Ignore asset url query string or anchor when appending extensions and ↵ | Joshua Peek | 2012-10-15 | 1 | -1/+18 |
| | | | | computing public path | ||||
* | Extract compute_asset_extname and allow extname to be disabled | Joshua Peek | 2012-10-15 | 1 | -6/+15 |
| | |||||
* | Merge branch 'master' into asset-path-helper | Joshua Peek | 2012-10-15 | 1 | -5/+1 |
|\ | | | | | | | | | Conflicts: railties/test/application/configuration_test.rb | ||||
| * | Minor cleanup, helper method was only used once | Ayrton De Craene | 2012-10-15 | 1 | -5/+1 |
| | | |||||
* | | :fire: Rails asset id support | Joshua Peek | 2012-10-15 | 1 | -80/+1 |
| | | |||||
* | | Allow asset url config to be undefined | Joshua Peek | 2012-10-13 | 1 | -0/+41 |
| | | |||||
* | | Add a few more compute_asset_path tests | Joshua Peek | 2012-10-13 | 1 | -0/+8 |
| | |